23877 2009-02-10 13:35:00 -0800 Allow port to disable progress events from media elements 2009-02-12 06:36:54 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 eric.carlson webkit-unassigned oldest_to_newest 109177 0 eric.carlson 2009-02-10 13:35:00 -0800 Not all media engines provide enough information about a file to be able to support progress events, so a port should be able to disable them completely instead of emitting invalid events. 109193 1 27541 eric.carlson 2009-02-10 14:42:04 -0800 Created attachment 27541 Proposed patch 109204 2 27541 simon.fraser 2009-02-10 15:24:10 -0800 Comment on attachment 27541 Proposed patch > Index: WebCore/html/HTMLMediaElement.h > =================================================================== > --- WebCore/html/HTMLMediaElement.h (revision 40828) > +++ WebCore/html/HTMLMediaElement.h (working copy) > @@ -221,6 +221,8 @@ protected: > OwnPtr<MediaPlayer> m_player; > > LoadRestrictions m_loadRestrictions; > + > + bool m_supportProgressEvents; Rename to something like 'm_sendProgressEvents' and add a comment about why you need the switch, and r=me. 109465 3 eric.carlson 2009-02-12 06:36:54 -0800 Committed as r40857 27541 2009-02-10 14:42:04 -0800 2009-02-10 15:24:10 -0800 Proposed patch patch.txt text/plain 3695 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDgzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDItMTAgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODc3CisgICAgICAg IEFsbG93IHBvcnQgdG8gZGlzYWJsZSBwcm9ncmVzcyBldmVudHMgZnJvbSA8dmlkZW8+IGFuZCA8 YXVkaW8+IGVsZW1lbnRzCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOiBJ bml0aWFsaXplIG1fc3VwcG9ydFByb2dyZXNzRXZlbnRzLgorICAgICAgICAoV2ViQ29yZTo6SFRN TE1lZGlhRWxlbWVudDo6SFRNTE1lZGlhRWxlbWVudCk6IERvbid0IHBvc3QgcHJvZ3Jlc3MgZXZl bnRzIGlmIG1fc3VwcG9ydFByb2dyZXNzRXZlbnRzIGlzIGZhbHNlLgorICAgICAgICAoV2ViQ29y ZTo6SFRNTE1lZGlhRWxlbWVudDo6aW5pdEFuZERpc3BhdGNoUHJvZ3Jlc3NFdmVudCk6IERpdHRv LgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6bG9hZCk6IERpdHRvLgorICAg ICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOiBBZGQgbV9zdXBwb3J0UHJvZ3Jlc3NFdmVu dHMvCisKIDIwMDktMDItMTAgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCBCdWcgMjM4NzE6IEFzc2VydGlvbiBmYWlsdXJlIGJlbmVhdGggV2ViQ29yZTo6b3Bl bkZ1bmMgd2hlbgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gNDA4 MjgpCisrKyBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTg1LDYgKzg1LDcgQEAgSFRNTE1lZGlhRWxlbWVudDo6SFRNTE1lZGlhRWxlbWVudChjb25z dAogICAgICwgbV9pbkFjdGl2ZURvY3VtZW50KHRydWUpCiAgICAgLCBtX3BsYXllcigwKQogICAg ICwgbV9sb2FkUmVzdHJpY3Rpb25zKE5vTG9hZFJlc3RyaWN0aW9uKQorICAgICwgbV9zdXBwb3J0 UHJvZ3Jlc3NFdmVudHModHJ1ZSkKIHsKICAgICBkb2N1bWVudCgpLT5yZWdpc3RlckZvckRvY3Vt ZW50QWN0aXZhdGlvbkNhbGxiYWNrcyh0aGlzKTsKICAgICBkb2N1bWVudCgpLT5yZWdpc3RlckZv ck1lZGlhVm9sdW1lQ2FsbGJhY2tzKHRoaXMpOwpAQCAtMTcyLDYgKzE3Myw5IEBAIHZvaWQgSFRN TE1lZGlhRWxlbWVudDo6c2NoZWR1bGVMb2FkKCkKIAogdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpp bml0QW5kRGlzcGF0Y2hQcm9ncmVzc0V2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnROYW1l KQogeworICAgIGlmICghbV9zdXBwb3J0UHJvZ3Jlc3NFdmVudHMpCisgICAgICAgIHJldHVybjsK KwogICAgIGJvb2wgdG90YWxLbm93biA9IG1fcGxheWVyICYmIG1fcGxheWVyLT50b3RhbEJ5dGVz S25vd24oKTsKICAgICB1bnNpZ25lZCBsb2FkZWQgPSBtX3BsYXllciA/IG1fcGxheWVyLT5ieXRl c0xvYWRlZCgpIDogMDsKICAgICB1bnNpZ25lZCB0b3RhbCA9IG1fcGxheWVyID8gbV9wbGF5ZXIt PnRvdGFsQnl0ZXMoKSA6IDA7CkBAIC0yOTYsNyArMzAwLDggQEAgdm9pZCBIVE1MTWVkaWFFbGVt ZW50Ojpsb2FkKEV4Y2VwdGlvbkNvZAogICAgIGlmIChtX2JlZ3VuKSB7CiAgICAgICAgIG1fYmVn dW4gPSBmYWxzZTsKICAgICAgICAgbV9lcnJvciA9IE1lZGlhRXJyb3I6OmNyZWF0ZShNZWRpYUVy cm9yOjpNRURJQV9FUlJfQUJPUlRFRCk7Ci0gICAgICAgIGluaXRBbmREaXNwYXRjaFByb2dyZXNz RXZlbnQoZXZlbnROYW1lcygpLmFib3J0RXZlbnQpOworICAgICAgICBpZiAobV9zdXBwb3J0UHJv Z3Jlc3NFdmVudHMpCisgICAgICAgICAgICBpbml0QW5kRGlzcGF0Y2hQcm9ncmVzc0V2ZW50KGV2 ZW50TmFtZXMoKS5hYm9ydEV2ZW50KTsKICAgICAgICAgaWYgKG1fbG9hZE5lc3RpbmdMZXZlbCA8 IG1fdGVybWluYXRlTG9hZEJlbG93TmVzdGluZ0xldmVsKQogICAgICAgICAgICAgZ290byBlbmQ7 CiAgICAgfQpAQCAtMzQwLDcgKzM0NSw4IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bG9hZChF eGNlcHRpb25Db2QKIAogICAgIC8vIDkKICAgICBtX2JlZ3VuID0gdHJ1ZTsgICAgICAgIAotICAg IGRpc3BhdGNoUHJvZ3Jlc3NFdmVudChldmVudE5hbWVzKCkubG9hZHN0YXJ0RXZlbnQsIGZhbHNl LCAwLCAwKTsKKyAgICBpZiAobV9zdXBwb3J0UHJvZ3Jlc3NFdmVudHMpCisgICAgICAgIGRpc3Bh dGNoUHJvZ3Jlc3NFdmVudChldmVudE5hbWVzKCkubG9hZHN0YXJ0RXZlbnQsIGZhbHNlLCAwLCAw KTsKICAgICBpZiAobV9sb2FkTmVzdGluZ0xldmVsIDwgbV90ZXJtaW5hdGVMb2FkQmVsb3dOZXN0 aW5nTGV2ZWwpCiAgICAgICAgIGdvdG8gZW5kOwogICAgIApAQCAtMzU2LDExICszNjIsMTQgQEAg dm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpsb2FkKEV4Y2VwdGlvbkNvZAogICAgICAgICByZW5kZXJl cigpLT51cGRhdGVGcm9tRWxlbWVudCgpOwogICAgIAogICAgIC8vIDE0Ci0gICAgbV9wcmV2aW91 c1Byb2dyZXNzVGltZSA9IFdURjo6Y3VycmVudFRpbWUoKTsKLSAgICBtX3ByZXZpb3VzUHJvZ3Jl c3MgPSAwOwotICAgIGlmIChtX2JlZ3VuKQotICAgICAgICAvLyAzNTBtcyBpcyBub3QgbWFnaWMs IGl0IGlzIGluIHRoZSBzcGVjIQotICAgICAgICBtX3Byb2dyZXNzRXZlbnRUaW1lci5zdGFydFJl cGVhdGluZygwLjM1MCk7CisgICAgaWYgKG1fc3VwcG9ydFByb2dyZXNzRXZlbnRzKSB7CisgICAg ICAgIG1fcHJldmlvdXNQcm9ncmVzc1RpbWUgPSBXVEY6OmN1cnJlbnRUaW1lKCk7CisgICAgICAg IG1fcHJldmlvdXNQcm9ncmVzcyA9IDA7CisgICAgICAgIGlmIChtX2JlZ3VuKQorICAgICAgICAg ICAgLy8gMzUwbXMgaXMgbm90IG1hZ2ljLCBpdCBpcyBpbiB0aGUgc3BlYyEKKyAgICAgICAgICAg IG1fcHJvZ3Jlc3NFdmVudFRpbWVyLnN0YXJ0UmVwZWF0aW5nKDAuMzUwKTsKKyAgICB9CisKIGVu ZDoKICAgICBBU1NFUlQobV9sb2FkTmVzdGluZ0xldmVsKTsKICAgICBtX2xvYWROZXN0aW5nTGV2 ZWwtLTsKSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAkocmV2aXNpb24gNDA4MjgpCisrKyBX ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjEsNiAr MjIxLDggQEAgcHJvdGVjdGVkOgogICAgIE93blB0cjxNZWRpYVBsYXllcj4gbV9wbGF5ZXI7CiAK ICAgICBMb2FkUmVzdHJpY3Rpb25zIG1fbG9hZFJlc3RyaWN0aW9uczsKKyAgICAKKyAgICBib29s IG1fc3VwcG9ydFByb2dyZXNzRXZlbnRzOwogfTsKIAogfSAvL25hbWVzcGFjZQo=