238762 2022-04-04 13:55:42 -0700 Remove the 'general_directory_for_storage' system feature flag 2022-04-04 16:07:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ggaren sihui_liu webkit-bug-importer oldest_to_newest 1858043 0 thorton 2022-04-04 13:55:42 -0700 Remove the 'general_directory_for_storage' system feature flag 1858044 1 456624 thorton 2022-04-04 13:55:57 -0700 Created attachment 456624 Patch 1858046 2 thorton 2022-04-04 13:56:55 -0700 If you need a for-debugging-only way to disable this, perhaps a user default, or WebPreferencesDebug preference? (both suggestions are only valid if you're OK with apps having the power to turn this flag on and off themselves). 1858108 3 thorton 2022-04-04 15:18:19 -0700 Sihui points out that `internalFeatureEnabled` somewhat-questionably already reads from defaults, so this should be OK as it stands. 1858125 4 456624 sihui_liu 2022-04-04 15:53:55 -0700 Comment on attachment 456624 Patch r=me, given that we should still be able to turn it off with NSUserDefaults. 1858128 5 thorton 2022-04-04 16:06:38 -0700 Committed r292355 (249220@trunk): <https://commits.webkit.org/249220@trunk> 1858129 6 webkit-bug-importer 2022-04-04 16:07:15 -0700 <rdar://problem/91266474> 456624 2022-04-04 13:55:57 -0700 2022-04-04 15:54:05 -0700 Patch bug-238762-20220404135556.patch text/plain 3819 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA0NWVjMmQyMmIyYjcyODRi MThlYzY3ZjUwOGM2NTAzNmYxODA3OTMuLjkxN2ZmOWZhM2U4M2Q3ZGZmYzlhYjRhOTljMjRjMTMx YjNlYWNiOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDQtMDQgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHRoZSAnZ2Vu ZXJhbF9kaXJlY3RvcnlfZm9yX3N0b3JhZ2UnIHN5c3RlbSBmZWF0dXJlIGZsYWcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODc2MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRmVhdHVyZUZsYWdzL1dl YktpdC1hcHBsZXR2b3MucGxpc3Q6CisgICAgICAgICogRmVhdHVyZUZsYWdzL1dlYktpdC1pb3Mu cGxpc3Q6CisgICAgICAgICogRmVhdHVyZUZsYWdzL1dlYktpdC1tYWNvcy5wbGlzdDoKKyAgICAg ICAgKiBGZWF0dXJlRmxhZ3MvV2ViS2l0LXdhdGNob3MucGxpc3Q6CisgICAgICAgICogVUlQcm9j ZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5tbToKKyAgICAgICAg KFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdFNob3VsZFVzZUN1c3RvbVN0b3JhZ2VQ YXRocyk6CisKIDIwMjItMDQtMDQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgog CiAgICAgICAgIFNlcnZpY2UtV29ya2VyLU5hdmlnYXRpb24tUHJlbG9hZCBoZWFkZXIgbm90IGJl aW5nIHNlbnQgd2hlbiBOYXZpZ2F0aW9uIFByZWxvYWQgaXMgZW5hYmxlZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvRmVhdHVyZUZsYWdzL1dlYktpdC1hcHBsZXR2b3MucGxpc3QgYi9Tb3Vy Y2UvV2ViS2l0L0ZlYXR1cmVGbGFncy9XZWJLaXQtYXBwbGV0dm9zLnBsaXN0CmluZGV4IGQ0OWY1 NmVjYmE4N2U0ZTcxZmI5MGI0YWU0MzMyZWM2YjE0ZGZjMzIuLmQxOTI4ZTgwMWMxNjhlMmQwZDhi YTY5MzBlZDU3YjM3NWUxMjNkZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvRmVhdHVyZUZs YWdzL1dlYktpdC1hcHBsZXR2b3MucGxpc3QKKysrIGIvU291cmNlL1dlYktpdC9GZWF0dXJlRmxh Z3MvV2ViS2l0LWFwcGxldHZvcy5wbGlzdApAQCAtOTIsMTAgKzkyLDUgQEAKIAkJPGtleT5FbmFi bGVkPC9rZXk+CiAJCTx0cnVlLz4KIAk8L2RpY3Q+Ci0JPGtleT5nZW5lcmFsX2RpcmVjdG9yeV9m b3Jfc3RvcmFnZTwva2V5PgotCTxkaWN0PgotCQk8a2V5PkVuYWJsZWQ8L2tleT4KLQkJPHRydWUv PgotCTwvZGljdD4KIDwvZGljdD4KIDwvcGxpc3Q+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L0ZlYXR1cmVGbGFncy9XZWJLaXQtaW9zLnBsaXN0IGIvU291cmNlL1dlYktpdC9GZWF0dXJlRmxh Z3MvV2ViS2l0LWlvcy5wbGlzdAppbmRleCAxOTkwZTUxMDk2MDdiODBjODU4YTk3M2Y5ODVkOGQx OGIxYWU3NjY4Li42M2M3MzM2NmQzMDM3NDhmOWU1ODIzMWE1ODU4Y2ZlOWNiZjMwNmQ5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0ZlYXR1cmVGbGFncy9XZWJLaXQtaW9zLnBsaXN0CisrKyBi L1NvdXJjZS9XZWJLaXQvRmVhdHVyZUZsYWdzL1dlYktpdC1pb3MucGxpc3QKQEAgLTkyLDEwICs5 Miw1IEBACiAJCTxrZXk+RW5hYmxlZDwva2V5PgogCQk8dHJ1ZS8+CiAJPC9kaWN0PgotCTxrZXk+ Z2VuZXJhbF9kaXJlY3RvcnlfZm9yX3N0b3JhZ2U8L2tleT4KLQk8ZGljdD4KLQkJPGtleT5FbmFi bGVkPC9rZXk+Ci0JCTx0cnVlLz4KLQk8L2RpY3Q+CiA8L2RpY3Q+CiA8L3BsaXN0PgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9GZWF0dXJlRmxhZ3MvV2ViS2l0LW1hY29zLnBsaXN0IGIvU291 cmNlL1dlYktpdC9GZWF0dXJlRmxhZ3MvV2ViS2l0LW1hY29zLnBsaXN0CmluZGV4IGJkMTIxZGRh YWU4MGUyMjI3NGMzZjQ5M2RhYmQyNjQ3MWEzZGUyODAuLmI0ZjcxMTBhMmMwOTJhMTk0NWE4MTNl YzY0NmI5MzIxNWNlZDYyMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvRmVhdHVyZUZsYWdz L1dlYktpdC1tYWNvcy5wbGlzdAorKysgYi9Tb3VyY2UvV2ViS2l0L0ZlYXR1cmVGbGFncy9XZWJL aXQtbWFjb3MucGxpc3QKQEAgLTk3LDEwICs5Nyw1IEBACiAJCTxrZXk+RW5hYmxlZDwva2V5Pgog CQk8dHJ1ZS8+CiAJPC9kaWN0PgotCTxrZXk+Z2VuZXJhbF9kaXJlY3RvcnlfZm9yX3N0b3JhZ2U8 L2tleT4KLQk8ZGljdD4KLQkJPGtleT5FbmFibGVkPC9rZXk+Ci0JCTx0cnVlLz4KLQk8L2RpY3Q+ CiA8L2RpY3Q+CiA8L3BsaXN0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9GZWF0dXJlRmxh Z3MvV2ViS2l0LXdhdGNob3MucGxpc3QgYi9Tb3VyY2UvV2ViS2l0L0ZlYXR1cmVGbGFncy9XZWJL aXQtd2F0Y2hvcy5wbGlzdAppbmRleCBkNDlmNTZlY2JhODdlNGU3MWZiOTBiNGFlNDMzMmVjNmIx NGRmYzMyLi5kMTkyOGU4MDFjMTY4ZTJkMGQ4YmE2OTMwZWQ1N2IzNzVlMTIzZGZkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L0ZlYXR1cmVGbGFncy9XZWJLaXQtd2F0Y2hvcy5wbGlzdAorKysg Yi9Tb3VyY2UvV2ViS2l0L0ZlYXR1cmVGbGFncy9XZWJLaXQtd2F0Y2hvcy5wbGlzdApAQCAtOTIs MTAgKzkyLDUgQEAKIAkJPGtleT5FbmFibGVkPC9rZXk+CiAJCTx0cnVlLz4KIAk8L2RpY3Q+Ci0J PGtleT5nZW5lcmFsX2RpcmVjdG9yeV9mb3Jfc3RvcmFnZTwva2V5PgotCTxkaWN0PgotCQk8a2V5 PkVuYWJsZWQ8L2tleT4KLQkJPHRydWUvPgotCTwvZGljdD4KIDwvZGljdD4KIDwvcGxpc3Q+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2NvYS9XZWJz aXRlRGF0YVN0b3JlQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0 YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0KaW5kZXggMTA2YWI5ZGRjM2M1YWVjMjdi MDMzYTg0YzZmMzRjYTI4ODgxNTZiOS4uMDBjYTBlNGM1NmFmNjk0ZTQ0OTM3MmEyYWM3NGUxOWE4 ZGU3ZjI0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEv Q29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5tbQpAQCAtNjI2LDgg KzYyNiw3IEBAIGJvb2wgV2Vic2l0ZURhdGFTdG9yZTo6bmV0d29ya1Byb2Nlc3NIYXNFbnRpdGxl bWVudEZvclRlc3RpbmcoY29uc3QgU3RyaW5nJiBlbnRpCiAKIGJvb2wgV2Vic2l0ZURhdGFTdG9y ZTo6ZGVmYXVsdFNob3VsZFVzZUN1c3RvbVN0b3JhZ2VQYXRocygpCiB7Ci0gICAgYm9vbCB1c2VH ZW5lcmFsRGlyZWN0b3J5Rm9yU3RvcmFnZUZlYXR1cmVGbGFnID0gaXNGZWF0dXJlRmxhZ0VuYWJs ZWQoImdlbmVyYWxfZGlyZWN0b3J5X2Zvcl9zdG9yYWdlIl9zLCB0cnVlKTsKLSAgICByZXR1cm4g IWludGVybmFsRmVhdHVyZUVuYWJsZWQoV2ViUHJlZmVyZW5jZXNLZXk6OnVzZUdlbmVyYWxEaXJl Y3RvcnlGb3JTdG9yYWdlS2V5KCksIHVzZUdlbmVyYWxEaXJlY3RvcnlGb3JTdG9yYWdlRmVhdHVy ZUZsYWcpOworICAgIHJldHVybiAhaW50ZXJuYWxGZWF0dXJlRW5hYmxlZChXZWJQcmVmZXJlbmNl c0tleTo6dXNlR2VuZXJhbERpcmVjdG9yeUZvclN0b3JhZ2VLZXkoKSwgdHJ1ZSk7CiB9CiAKIH0K