238742 2022-04-04 09:59:09 -0700 Only check isPagedOut() under memory pressure 2022-04-04 13:56:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren ews-watchlist heycam keith_miller mark.lam msaboff nham saam tzagallo webkit-bug-importer oldest_to_newest 1857899 0 ggaren 2022-04-04 09:59:09 -0700 Only check isPagedOut() under memory pressure 1857902 1 456581 ggaren 2022-04-04 10:05:53 -0700 Created attachment 456581 Patch 1857913 2 nham 2022-04-04 10:11:29 -0700 One issue here is that isUnderMemoryPressure() doesn't actually tell you if the system is under memory pressure. Instead it just tells you if your process has received a critical memory pressure notification. They're not the same thing. Maybe we need a new method isSystemUnderMemoryPressure() that checks the system-wide kern.memorystatus_vm_pressure_level sysctl on a timer or something. I guess we can implement that in another patch. 1857943 3 ggaren 2022-04-04 11:03:00 -0700 I could change to kern.memorystatus_vm_pressure_level here. Worth it? 1857944 4 nham 2022-04-04 11:04:29 -0700 (In reply to Geoffrey Garen from comment #3) > I could change to kern.memorystatus_vm_pressure_level here. Worth it? I can probably write another patch that tries to do something sensible. My guess is the patch would also require a small sandbox change. Let's go with the speedo win here for now and we can test that change separately. 1858042 5 ews-feeder 2022-04-04 13:55:12 -0700 Committed r292315 (249208@main): <https://commits.webkit.org/249208@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456581. 1858045 6 webkit-bug-importer 2022-04-04 13:56:16 -0700 <rdar://problem/91259682> 456581 2022-04-04 10:05:53 -0700 2022-04-04 13:55:14 -0700 Patch bug-238742-20220404100552.patch text/plain 1946 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjkyMjkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDIyLTA0LTA0ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgT25seSBjaGVjayBpc1BhZ2VkT3V0KCkgdW5kZXIgbWVtb3J5IHByZXNzdXJlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzg3NDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXb3J0aCBhYm91dCAwLjQl IG9uIFNwZWVkb21ldGVyLgorCisgICAgICAgIEluIHRoZW9yeSwgaWYgd2UncmUgbm90IHVuZGVy IG1lbW9yeSBwcmVzc3VyZSwgd2UncmUgZWl0aGVyIChhKSBub3QKKyAgICAgICAgcGFnZWQgb3V0 IGJlY2F1c2Ugd2Ugd2VyZSBub3QgcmVjZW50bHkgdW5kZXIgbWVtb3J5IHByZXNzdXJlIG9yIChi KQorICAgICAgICBwYWdlZCBvdXQgYnV0IE9LIHRvIHBhZ2UgaW4gYWdhaW4gYmVjYXVzZSBtZW1v cnkgaXMgYXZhaWxhYmxlLgorCisgICAgICAgIFRoaXMgY291bGQgaW5jcmVhc2Ugc3dhcCBpZiBh IHN5c3RlbSBmcmVxdWVudGx5IG9zY2lsbGF0ZWQgYmV0d2VlbgorICAgICAgICB5ZXMtbWVtb3J5 LXByZXNzdXJlIGFuZCBuby1tZW1vcnktcHJlc3N1cmU7IGJ1dCBpbiBwcmFjdGljZSB0aGUgc3lz dGVtcworICAgICAgICB3ZSBzZWUgdW5kZXIgc2lnbmlmaWNhbnQgbWVtb3J5IHByZXNzdXJlIHRl bmQgdG8gc3RheSB0aGF0IHdheS4KKworICAgICAgICAqIGhlYXAvRnVsbEdDQWN0aXZpdHlDYWxs YmFjay5jcHA6CisgICAgICAgIChKU0M6OkZ1bGxHQ0FjdGl2aXR5Q2FsbGJhY2s6OmRvQ29sbGVj dGlvbik6CisKIDIwMjItMDQtMDIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgZGVmYXVsdCBjb25zdHJ1Y3RvciB0byBBU0NJSUxpdGVyYWwKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Z1bGxHQ0FjdGl2aXR5Q2FsbGJhY2suY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Z1bGxHQ0FjdGl2aXR5Q2FsbGJh Y2suY3BwCShyZXZpc2lvbiAyOTIyOTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9G dWxsR0NBY3Rpdml0eUNhbGxiYWNrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUsNiArMjUsNyBA QAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiRnVsbEdDQWN0aXZpdHlDYWxsYmFj ay5oIgorI2luY2x1ZGUgPHd0Zi9NZW1vcnlQcmVzc3VyZUhhbmRsZXIuaD4KIAogI2luY2x1ZGUg IlZNLmgiCiAKQEAgLTQyLDcgKzQzLDcgQEAgdm9pZCBGdWxsR0NBY3Rpdml0eUNhbGxiYWNrOjpk b0NvbGxlY3RpbwogCiAjaWYgIVBMQVRGT1JNKElPU19GQU1JTFkpIHx8IFBMQVRGT1JNKE1BQ0NB VEFMWVNUKQogICAgIE1vbm90b25pY1RpbWUgc3RhcnRUaW1lID0gTW9ub3RvbmljVGltZTo6bm93 KCk7Ci0gICAgaWYgKGhlYXAuaXNQYWdlZE91dCgpKSB7CisgICAgaWYgKE1lbW9yeVByZXNzdXJl SGFuZGxlcjo6c2luZ2xldG9uKCkuaXNVbmRlck1lbW9yeVByZXNzdXJlKCkgJiYgaGVhcC5pc1Bh Z2VkT3V0KCkpIHsKICAgICAgICAgY2FuY2VsKCk7CiAgICAgICAgIGhlYXAuaW5jcmVhc2VMYXN0 RnVsbEdDTGVuZ3RoKE1vbm90b25pY1RpbWU6Om5vdygpIC0gc3RhcnRUaW1lKTsKICAgICAgICAg cmV0dXJuOwo=