238737 2022-04-04 07:24:30 -0700 webkitpy.w3c.test_exporter assumes all exceptions are HTTPError 2022-04-11 15:58:03 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=238735 InRadar P2 Normal --- 1 gsnedders gsnedders ews-watchlist glenn jbedard koivisto webkit-bug-importer oldest_to_newest 1857845 0 gsnedders 2022-04-04 07:24:30 -0700 This is the second exception in bug 238735: During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/Users/antti/webkit/OpenSource/Tools/Scripts//webkit-patch", line 80, in <module> main() File "/Users/antti/webkit/OpenSource/Tools/Scripts//webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/wptchangeexport.py", line 53, in run test_exporter.do_export() File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 397, in do_export self.make_pull_request() File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 336, in make_pull_request pr_number = self.create_wpt_pull_request(self._wpt_fork_remote + ':' + self._public_branch_name, self._commit_message, description) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 352, in create_wpt_pull_request if e.code == 422: AttributeError: 'TypeError' object has no attribute 'code' Essentially, we seem to be assuming we always have a code attribute (which urllib.error.HTTPError has), but catching every exception. 1857849 1 456569 gsnedders 2022-04-04 07:42:22 -0700 Created attachment 456569 Patch This I think would fix it, but there's no easy way to test this currently, short of exporting something. 1860279 2 webkit-bug-importer 2022-04-11 07:25:15 -0700 <rdar://problem/91563799> 1860417 3 456569 gsnedders 2022-04-11 14:44:01 -0700 Comment on attachment 456569 Patch Let's just land this because from a basic review it's obvious that it shouldn't make anything worse. 1860447 4 ews-feeder 2022-04-11 15:57:59 -0700 Committed r292731 (249516@main): <https://commits.webkit.org/249516@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456569. 456569 2022-04-04 07:42:22 -0700 2022-04-11 15:58:01 -0700 Patch bug-238737-20220404154220.patch text/plain 2087 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjg3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWMyNjc1Yzc0YmM0NjQxMjc3NDdlOGJlZmM5MjY5ODJm YTY2NWQzNC4uZTkzOGVmZDYzMDY3MThmNjdkN2YzZjBlYjFlODZjMGYyZmIxNzUyNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIyLTA0LTA0ICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAg ICAgICAgd2Via2l0cHkudzNjLnRlc3RfZXhwb3J0ZXIgYXNzdW1lcyBhbGwgZXhjZXB0aW9ucyBh cmUgSFRUUEVycm9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzg3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGN1cnJlbnRseSBpc24ndCBhdCBhbGwgZWFzeSB0byB0ZXN0LCBhcyBvdXIgZXhp c3RpbmcgbW9ja3MgZm9yIG11Y2gKKyAgICAgICAgb2YgdGhpcyBkb24ndCBtYWtlIGl0IGVhc3kg dG8gdGhyb3cgYXJiaXRyYXJ5IGV4Y2VwdGlvbnMgZnJvbSBnaXZlbgorICAgICAgICBmdW5jdGlv bnMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2V4cG9ydGVyLnB5Ogor ICAgICAgICAoV2ViUGxhdGZvcm1UZXN0RXhwb3J0ZXIuY3JlYXRlX3dwdF9wdWxsX3JlcXVlc3Qp OgorCiAyMDIyLTA0LTA0ICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CiAKICAg ICAgICAgV1BUIGV4cG9ydCBicm9rZW4gdW5kZXIgUHl0aG9uIDMKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3czYy90ZXN0X2V4cG9ydGVyLnB5CmluZGV4IDY2YzU3OTJhZWI2M2NmNjNiZWRmMzFi MmVmZmU1YmQyNWJjNzkyNmIuLjUxMDMwZGI5MWNlOWMyZjZmZTgwNzgxYTJlODUwMWQ5M2E5Mjgz YTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0ZXIu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9leHBvcnRlci5weQpAQCAt MzQ4LDEyICszNDgsMTUgQEAgY2xhc3MgV2ViUGxhdGZvcm1UZXN0RXhwb3J0ZXIob2JqZWN0KToK ICAgICAgICAgcHJfbnVtYmVyID0gTm9uZQogICAgICAgICB0cnk6CiAgICAgICAgICAgICBwcl9u dW1iZXIgPSBzZWxmLl9naXRodWIuY3JlYXRlX3ByKHJlbW90ZV9icmFuY2hfbmFtZSwgdGl0bGUs IGJvZHkpCi0gICAgICAgIGV4Y2VwdCBFeGNlcHRpb24gYXMgZToKKyAgICAgICAgZXhjZXB0IEhU VFBFcnJvciBhcyBlOgogICAgICAgICAgICAgaWYgZS5jb2RlID09IDQyMjoKICAgICAgICAgICAg ICAgICBfbG9nLmluZm8oJ1VuYWJsZSB0byBjcmVhdGUgYSBuZXcgcHVsbCByZXF1ZXN0IGZvciBi cmFuY2ggIiVzIiBiZWNhdXNlIGEgcHVsbCByZXF1ZXN0IGFscmVhZHkgZXhpc3RzLiBUaGUgYnJh bmNoIGhhcyBiZWVuIHVwZGF0ZWQgYW5kIHRoZXJlIGlzIG5vIGZ1cnRoZXIgYWN0aW9uIG5lZWRl ZC4nICUgKHJlbW90ZV9icmFuY2hfbmFtZSkpCiAgICAgICAgICAgICBlbHNlOgogICAgICAgICAg ICAgICAgIF9sb2cud2FybmluZyhlKQogICAgICAgICAgICAgICAgIF9sb2cuaW5mbygnRXJyb3Ig Y3JlYXRpbmcgYSBwdWxsIHJlcXVlc3Qgb24gZ2l0aHViLiBQbGVhc2UgZW5zdXJlIHRoYXQgdGhl IHByb3ZpZGVkIGdpdGh1YiB0b2tlbiBoYXMgdGhlICJwdWJsaWNfcmVwbyIgc2NvcGUuJykKKyAg ICAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgorICAgICAgICAgICAgX2xvZy53YXJuaW5nKGUp CisgICAgICAgICAgICBfbG9nLmluZm8oJ0Vycm9yIGNyZWF0aW5nIGEgcHVsbCByZXF1ZXN0IG9u IGdpdGh1Yi4gUGxlYXNlIGVuc3VyZSB0aGF0IHRoZSBwcm92aWRlZCBnaXRodWIgdG9rZW4gaGFz IHRoZSAicHVibGljX3JlcG8iIHNjb3BlLicpCiAgICAgICAgIHJldHVybiBwcl9udW1iZXIKIAog ICAgIGRlZiBkZWxldGVfbG9jYWxfYnJhbmNoKHNlbGYpOgo=