238736 2022-04-04 07:18:12 -0700 Simplify / Optimize the whitespace cache implementation 2022-04-08 15:07:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez changseok darin esprehn+autocc ews-watchlist ggaren gyuyoung.kim heycam sam webkit-bug-importer oldest_to_newest 1857841 0 cdumez 2022-04-04 07:18:12 -0700 Simplify / Optimize the whitespace cache implementation. 1857844 1 456568 cdumez 2022-04-04 07:23:35 -0700 Created attachment 456568 Patch 1857890 2 456568 sam 2022-04-04 09:43:13 -0700 Comment on attachment 456568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456568&action=review > Source/WebCore/html/parser/HTMLConstructionSite.h:245 > + WhitespaceCache() : > + m_atoms(maximumCachedStringLength) > + { } Unconventional style. Probably this: WhitespaceCache() : m_atoms(maximumCachedStringLength) { } 1857895 3 cdumez 2022-04-04 09:49:45 -0700 (In reply to Sam Weinig from comment #2) > Comment on attachment 456568 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456568&action=review > > > Source/WebCore/html/parser/HTMLConstructionSite.h:245 > > + WhitespaceCache() : > > + m_atoms(maximumCachedStringLength) > > + { } > > Unconventional style. Probably this: > > WhitespaceCache() > : m_atoms(maximumCachedStringLength) > { > } Ooops, my bad, not sure what happened there. 1857910 4 456584 cdumez 2022-04-04 10:10:17 -0700 Created attachment 456584 Patch 1857994 5 ews-feeder 2022-04-04 12:26:21 -0700 Committed r292310 (249203@main): <https://commits.webkit.org/249203@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456584. 1857995 6 webkit-bug-importer 2022-04-04 12:27:18 -0700 <rdar://problem/91255370> 1859898 7 456584 darin 2022-04-08 14:47:45 -0700 Comment on attachment 456584 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456584&action=review > Source/WebCore/html/parser/HTMLConstructionSite.h:52 > +namespace WebCore { > struct HTMLConstructionSiteTask { Missing space here. 1859900 8 456584 cdumez 2022-04-08 14:48:46 -0700 Comment on attachment 456584 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456584&action=review >> Source/WebCore/html/parser/HTMLConstructionSite.h:52 >> struct HTMLConstructionSiteTask { > > Missing space here. I can add a blank line between the namespace and the struct, assuming that's what you mean. 1859902 9 cdumez 2022-04-08 14:51:33 -0700 Reopening to attach new patch. 1859903 10 457121 cdumez 2022-04-08 14:51:54 -0700 Created attachment 457121 Follow-up to fix style 1859907 11 457121 darin 2022-04-08 15:02:29 -0700 Comment on attachment 457121 Follow-up to fix style View in context: https://bugs.webkit.org/attachment.cgi?id=457121&action=review > Source/WebCore/html/parser/HTMLConstructionSite.h:52 > namespace WTF { > + > template<> struct VectorTraits<WebCore::AtomStringWithCode> : SimpleClassVectorTraits { }; > + > } Not sure we needed these, but the others do seem important to look right. 1859909 12 cdumez 2022-04-08 15:07:49 -0700 Committed r292638 (249458@trunk): <https://commits.webkit.org/249458@trunk> 456568 2022-04-04 07:23:35 -0700 2022-04-04 10:10:15 -0700 Patch bug-238736-20220404072334.patch text/plain 5465 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVmZjI5ZTdlMmY0YTM0 MWY4ZjU2ZjdjNDI5NTkwMDMyNzRhZDU4ZS4uOTQwMmVmNzQ0ZDUyZWU2ZGQ3YWVjMTI1MjliZWQw YjZmODg2ZjQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIyLTA0LTA0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgLyBPcHRpbWl6 ZSB0aGUgd2hpdGVzcGFjZSBjYWNoZSBpbXBsZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4NzM2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiB1c2luZyAyIEMgYXJyYXlz IG9mIHNpemUgbWF4aW11bUNhY2hlZFN0cmluZ0xlbmd0aCArIDEgVmVjdG9yIHdpdGggYW4gaW5s aW5lCisgICAgICAgIGJ1ZmZlciBvZiBzaXplIG1heGltdW1DYWNoZWRTdHJpbmdMZW5ndGgsIHdl IG5vdyB1c2VkIGEgc2luZ2xlIEZpeGVkVmVjdG9yIG9mIHNpemUKKyAgICAgICAgbWF4aW11bUNh Y2hlZFN0cmluZ0xlbmd0aC4KKworICAgICAgICBCZWNhdXNlIHRoZSBWZWN0b3IgaGFzIGFuIGlu bGluZSBidWZmZXIgd2hvc2Ugc2l6ZSBpcyB0aGUgbWF4IHNpemUgb2YgdGhlIGNhY2hlLCB1c2lu ZworICAgICAgICBhIEZpeGVkVmVjdG9yIGlzIGp1c3QgbW9yZSBlZmZpY2llbnQuIEl0IGFsc28g bWVhbnMgd2UgZG9uJ3QgbmVlZCB0byBzdG9yZSBpbmRleGVzIGluCisgICAgICAgIHRoYXQgVmVj dG9yIGluIGEgc2VwYXJhdGUgQyBhcnJheS4gRmluYWxseSwgSSB1c2VkIGEgc3RydWN0IG5hbWVk IEF0b21TdHJpbmdXaXRoQ29kZSB0bworICAgICAgICBzdG9yZSB7IEF0b21TdHJpbmcsIHVpbnQ2 NCBjb2RlIH0gc28gd2UgZG9uJ3QgbmVlZCBzZXBhcmF0ZSBjb250YWluZXJzIGZvciB0aGUgQXRv bVN0cmluZworICAgICAgICBhbmQgdGhlIGNvZGUuCisKKyAgICAgICAgTm90ZSB0aGF0IEkgYWRk ZWQgVmVjdG9yVHJhaXRzIGZvciB0aGUgbmV3IEF0b21TdHJpbmdXaXRoQ29kZSBzdHJ1Y3QgdG8g bWFrZSBzdXJlIGl0IGNhbgorICAgICAgICBnZXQgaW5pdGlhbGl6ZWQgdmlhIGEgc2ltcGxlIG1l bXNldC4KKworICAgICAgICBUaGlzIGlzIGEgMC4yNS0wLjMlIHByb2dyZXNzaW9uIG9uIFNwZWVk b21ldGVyIGFjY29yZGluZyB0byBBL0IgYm90cy4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hU TUxDb25zdHJ1Y3Rpb25TaXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldoaXRlc3BhY2VDYWNo ZTo6bG9va3VwKToKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5o OgorICAgICAgICAoV2ViQ29yZTo6V2hpdGVzcGFjZUNhY2hlOjpXaGl0ZXNwYWNlQ2FjaGUpOgor CiAyMDIyLTAzLTI4ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgogCiAgICAg ICAgIE1ha2UgaXQgaGFyZCB0byBhZGQgYSBuZXcgQ1NTIHByb3BlcnR5IHRvIFdlYktpdCB3aWh0 b3V0IGFkZGluZyBhbmltYXRpb24gc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCmluZGV4IDU0ZGQ5YjA3MDE0NTFmMDVj MDFkMzNkZmI0MDgzODMwMzM3YjkwMWEuLjE1ZGNmZmI4MmYxODk0OTAyMjFhOWNmODI1Njk1YmNk YTNmODZiNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25z dHJ1Y3Rpb25TaXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29u c3RydWN0aW9uU2l0ZS5jcHAKQEAgLTg4NywzNSArODg3LDI2IEBAIEF0b21TdHJpbmcgV2hpdGVz cGFjZUNhY2hlOjpsb29rdXAoY29uc3QgU3RyaW5nJiBzdHJpbmcsIFdoaXRlc3BhY2VNb2RlIHdo aXRlc3BhCiAgICAgICAgIHJldHVybiB3aGl0ZXNwYWNlTW9kZSA9PSBBbGxXaGl0ZXNwYWNlIHx8 IGlzQWxsV2hpdGVzcGFjZShzdHJpbmcpID8gQXRvbVN0cmluZyhzdHJpbmcpIDogQXRvbVN0cmlu ZygpOwogCiAgICAgdWludDY0X3QgY29kZTsKLSAgICBpZiAod2hpdGVzcGFjZU1vZGUgPT0gQWxs V2hpdGVzcGFjZSkKKyAgICBpZiAod2hpdGVzcGFjZU1vZGUgPT0gQWxsV2hpdGVzcGFjZSkgewog ICAgICAgICBjb2RlID0gY29kZUZvclN0cmluZzxBbGxXaGl0ZXNwYWNlPihzdHJpbmcpOwotICAg IGVsc2UKKyAgICAgICAgQVNTRVJUKGNvZGUpOworICAgIH0gZWxzZSB7CiAgICAgICAgIGNvZGUg PSBjb2RlRm9yU3RyaW5nPFdoaXRlc3BhY2VVbmtub3duPihzdHJpbmcpOworICAgICAgICBpZiAo IWNvZGUpCisgICAgICAgICAgICByZXR1cm4gQXRvbVN0cmluZygpOworICAgIH0KIAotICAgIGlm ICghY29kZSkKLSAgICAgICAgcmV0dXJuIEF0b21TdHJpbmcoKTsKLQotICAgIHNpemVfdCBsZW5n dGhJbmRleCA9IGxlbmd0aCAtIDE7Ci0gICAgaWYgKG1fY29kZXNbbGVuZ3RoSW5kZXhdID09IGNv ZGUpIHsKLSAgICAgICAgQVNTRVJUKG1fYXRvbXNbbV9pbmRleGVzW2xlbmd0aEluZGV4XV0gPT0g c3RyaW5nKTsKLSAgICAgICAgcmV0dXJuIG1fYXRvbXNbbV9pbmRleGVzW2xlbmd0aEluZGV4XV07 CisgICAgYXV0byYgZXhpc3RpbmdBdG9tID0gbV9hdG9tc1tsZW5ndGggLSAxXTsKKyAgICBpZiAo ZXhpc3RpbmdBdG9tLmNvZGUgPT0gY29kZSkgeworICAgICAgICBBU1NFUlQoZXhpc3RpbmdBdG9t LnN0cmluZyA9PSBzdHJpbmcpOworICAgICAgICByZXR1cm4gZXhpc3RpbmdBdG9tLnN0cmluZzsK ICAgICB9CiAKICAgICBpZiAoY29kZSA9PSBvdmVyZmxvd1doaXRlc3BhY2VDb2RlKQogICAgICAg ICByZXR1cm4gQXRvbVN0cmluZyhzdHJpbmcpOwogCi0gICAgaWYgKG1fY29kZXNbbGVuZ3RoSW5k ZXhdKSB7Ci0gICAgICAgIEF0b21TdHJpbmcgd2hpdGVzcGFjZUF0b20oc3RyaW5nKTsKLSAgICAg ICAgbV9jb2Rlc1tsZW5ndGhJbmRleF0gPSBjb2RlOwotICAgICAgICBtX2F0b21zW21faW5kZXhl c1tsZW5ndGhJbmRleF1dID0gd2hpdGVzcGFjZUF0b207Ci0gICAgICAgIHJldHVybiB3aGl0ZXNw YWNlQXRvbTsKLSAgICB9Ci0KLSAgICBBdG9tU3RyaW5nIHdoaXRlc3BhY2VBdG9tKHN0cmluZyk7 Ci0gICAgbV9jb2Rlc1tsZW5ndGhJbmRleF0gPSBjb2RlOwotICAgIG1faW5kZXhlc1tsZW5ndGhJ bmRleF0gPSBtX2F0b21zLnNpemUoKTsKLSAgICBtX2F0b21zLmFwcGVuZCh3aGl0ZXNwYWNlQXRv bSk7Ci0gICAgcmV0dXJuIHdoaXRlc3BhY2VBdG9tOworICAgIGV4aXN0aW5nQXRvbSA9IHsgQXRv bVN0cmluZyB7IHN0cmluZyB9LCBjb2RlIH07CisgICAgcmV0dXJuIGV4aXN0aW5nQXRvbS5zdHJp bmc7CiB9CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxD b25zdHJ1Y3Rpb25TaXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3Ry dWN0aW9uU2l0ZS5oCmluZGV4IDUwNTEyNWNjZDJmMTUzNWQyNzY4MTVjNjMwNWI4NzkyNjI3ZGVj NTUuLmZjMTM3Zjc1YzA5YTc2N2Y2OTdiNzAxYzk3MTkyODAxN2YxMGYyMGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmgKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuaApAQCAtMzAs NiArMzAsNyBAQAogI2luY2x1ZGUgIkZyYWdtZW50U2NyaXB0aW5nUGVybWlzc2lvbi5oIgogI2lu Y2x1ZGUgIkhUTUxFbGVtZW50U3RhY2suaCIKICNpbmNsdWRlICJIVE1MRm9ybWF0dGluZ0VsZW1l bnRMaXN0LmgiCisjaW5jbHVkZSA8d3RmL0ZpeGVkVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL05v bmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9TZXRG b3JTY29wZS5oPgpAQCAtMzcsNiArMzgsMTcgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitz dHJ1Y3QgQXRvbVN0cmluZ1dpdGhDb2RlIHsKKyAgICBBdG9tU3RyaW5nIHN0cmluZzsKKyAgICB1 aW50NjRfdCBjb2RlIHsgMCB9OworfTsKK30KKworbmFtZXNwYWNlIFdURiB7Cit0ZW1wbGF0ZTw+ IHN0cnVjdCBWZWN0b3JUcmFpdHM8V2ViQ29yZTo6QXRvbVN0cmluZ1dpdGhDb2RlPiA6IFNpbXBs ZUNsYXNzVmVjdG9yVHJhaXRzIHsgfTsKK30KKworbmFtZXNwYWNlIFdlYkNvcmUgewogc3RydWN0 IEhUTUxDb25zdHJ1Y3Rpb25TaXRlVGFzayB7CiAgICAgZW51bSBPcGVyYXRpb24gewogICAgICAg ICBJbnNlcnQsCkBAIC0yMjgsNyArMjQwLDkgQEAgcHJpdmF0ZToKIGNsYXNzIFdoaXRlc3BhY2VD YWNoZSB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6Ci0gICAgV2hpdGVz cGFjZUNhY2hlKCkgPSBkZWZhdWx0OworICAgIFdoaXRlc3BhY2VDYWNoZSgpIDoKKyAgICAgICAg bV9hdG9tcyhtYXhpbXVtQ2FjaGVkU3RyaW5nTGVuZ3RoKQorICAgIHsgfQogCiAgICAgQXRvbVN0 cmluZyBsb29rdXAoY29uc3QgU3RyaW5nJiwgV2hpdGVzcGFjZU1vZGUpOwogCkBAIC0yMzgsMTQg KzI1Miw3IEBAIHByaXZhdGU6CiAgICAgY29uc3RleHByIHN0YXRpYyB1aW50NjRfdCBvdmVyZmxv d1doaXRlc3BhY2VDb2RlID0gc3RhdGljX2Nhc3Q8dWludDY0X3Q+KC0xKTsKICAgICBjb25zdGV4 cHIgc3RhdGljIHNpemVfdCBtYXhpbXVtQ2FjaGVkU3RyaW5nTGVuZ3RoID0gMTI4OwogCi0gICAg Ly8gUGFyYWxsZWwgYXJyYXlzIHN0b3JpbmcgYSA2NCBiaXQgY29kZSBhbmQgYW4gaW5kZXggaW50 byBtX2F0b21zIGZvciB0aGUKLSAgICAvLyBtb3N0IHJlY2VudGx5IGF0b21pemVkIHdoaXRlc3Bh Y2Utb25seSBzdHJpbmcgb2YgYSBnaXZlbiBsZW5ndGguIFRoZQotICAgIC8vIGluZGljZXMgaW50 byB0aGVzZSB0d28gYXJyYXlzIGFyZSB0aGUgc3RyaW5nIGxlbmd0aCBtaW51cyAxLCBzbyB0aGUg Y29kZQotICAgIC8vIGZvciBhIHdoaXRlc3BhY2Utb25seSBzdHJpbmcgb2YgbGVuZ3RoIDIgaXMg c3RvcmVkIGF0IG1fY29kZXNbMV0sIGV0Yy4KLSAgICB1aW50NjRfdCBtX2NvZGVzW21heGltdW1D YWNoZWRTdHJpbmdMZW5ndGhdIHsgMCB9OwotICAgIHVpbnQ4X3QgbV9pbmRleGVzW21heGltdW1D YWNoZWRTdHJpbmdMZW5ndGhdIHsgMCB9OwotCi0gICAgVmVjdG9yPEF0b21TdHJpbmcsIG1heGlt dW1DYWNoZWRTdHJpbmdMZW5ndGg+IG1fYXRvbXM7CisgICAgRml4ZWRWZWN0b3I8QXRvbVN0cmlu Z1dpdGhDb2RlPiBtX2F0b21zOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 456584 2022-04-04 10:10:17 -0700 2022-04-04 12:26:23 -0700 Patch bug-238736-20220404101016.patch text/plain 5446 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTE2ZjJhZGNiMDIzNjk4 ZjhmNTM3YzU4OTEzYTM4Yjg0NTQ4OGQ1MC4uYTM2MDQ3MWIzMDNlMzZkOGZjYWRjYWViMzkyM2Vj MmFlNDRkZDMwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIyLTA0LTA0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgLyBPcHRpbWl6 ZSB0aGUgd2hpdGVzcGFjZSBjYWNoZSBpbXBsZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4NzM2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgU2FtIFdlaW5pZy4KKworICAgICAgICBJbnN0ZWFkIG9mIHVzaW5nIDIgQyBhcnJheXMgb2Yg c2l6ZSBtYXhpbXVtQ2FjaGVkU3RyaW5nTGVuZ3RoICsgMSBWZWN0b3Igd2l0aCBhbiBpbmxpbmUK KyAgICAgICAgYnVmZmVyIG9mIHNpemUgbWF4aW11bUNhY2hlZFN0cmluZ0xlbmd0aCwgd2Ugbm93 IHVzZWQgYSBzaW5nbGUgRml4ZWRWZWN0b3Igb2Ygc2l6ZQorICAgICAgICBtYXhpbXVtQ2FjaGVk U3RyaW5nTGVuZ3RoLgorCisgICAgICAgIEJlY2F1c2UgdGhlIFZlY3RvciBoYXMgYW4gaW5saW5l IGJ1ZmZlciB3aG9zZSBzaXplIGlzIHRoZSBtYXggc2l6ZSBvZiB0aGUgY2FjaGUsIHVzaW5nCisg ICAgICAgIGEgRml4ZWRWZWN0b3IgaXMganVzdCBtb3JlIGVmZmljaWVudC4gSXQgYWxzbyBtZWFu cyB3ZSBkb24ndCBuZWVkIHRvIHN0b3JlIGluZGV4ZXMgaW4KKyAgICAgICAgdGhhdCBWZWN0b3Ig aW4gYSBzZXBhcmF0ZSBDIGFycmF5LiBGaW5hbGx5LCBJIHVzZWQgYSBzdHJ1Y3QgbmFtZWQgQXRv bVN0cmluZ1dpdGhDb2RlIHRvCisgICAgICAgIHN0b3JlIHsgQXRvbVN0cmluZywgdWludDY0IGNv ZGUgfSBzbyB3ZSBkb24ndCBuZWVkIHNlcGFyYXRlIGNvbnRhaW5lcnMgZm9yIHRoZSBBdG9tU3Ry aW5nCisgICAgICAgIGFuZCB0aGUgY29kZS4KKworICAgICAgICBOb3RlIHRoYXQgSSBhZGRlZCBW ZWN0b3JUcmFpdHMgZm9yIHRoZSBuZXcgQXRvbVN0cmluZ1dpdGhDb2RlIHN0cnVjdCB0byBtYWtl IHN1cmUgaXQgY2FuCisgICAgICAgIGdldCBpbml0aWFsaXplZCB2aWEgYSBzaW1wbGUgbWVtc2V0 LgorCisgICAgICAgIFRoaXMgaXMgYSAwLjI1LTAuMyUgcHJvZ3Jlc3Npb24gb24gU3BlZWRvbWV0 ZXIgYWNjb3JkaW5nIHRvIEEvQiBib3RzLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTENv bnN0cnVjdGlvblNpdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2hpdGVzcGFjZUNhY2hlOjps b29rdXApOgorICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmg6Cisg ICAgICAgIChXZWJDb3JlOjpXaGl0ZXNwYWNlQ2FjaGU6OldoaXRlc3BhY2VDYWNoZSk6CisKIDIw MjItMDQtMDQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIENP UlM6IEFsbG93IHBhcnRpY3VsYXIgUmFuZ2UgaGVhZGVyIHZhbHVlcyB3aXRob3V0IGEgcHJlZmxp Z2h0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0 aW9uU2l0ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9u U2l0ZS5jcHAKaW5kZXggNTRkZDliMDcwMTQ1MWYwNWMwMWQzM2RmYjQwODM4MzAzMzdiOTAxYS4u MTVkY2ZmYjgyZjE4OTQ5MDIyMWE5Y2Y4MjU2OTViY2RhM2Y4NmI0OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcApAQCAtODg3 LDM1ICs4ODcsMjYgQEAgQXRvbVN0cmluZyBXaGl0ZXNwYWNlQ2FjaGU6Omxvb2t1cChjb25zdCBT dHJpbmcmIHN0cmluZywgV2hpdGVzcGFjZU1vZGUgd2hpdGVzcGEKICAgICAgICAgcmV0dXJuIHdo aXRlc3BhY2VNb2RlID09IEFsbFdoaXRlc3BhY2UgfHwgaXNBbGxXaGl0ZXNwYWNlKHN0cmluZykg PyBBdG9tU3RyaW5nKHN0cmluZykgOiBBdG9tU3RyaW5nKCk7CiAKICAgICB1aW50NjRfdCBjb2Rl OwotICAgIGlmICh3aGl0ZXNwYWNlTW9kZSA9PSBBbGxXaGl0ZXNwYWNlKQorICAgIGlmICh3aGl0 ZXNwYWNlTW9kZSA9PSBBbGxXaGl0ZXNwYWNlKSB7CiAgICAgICAgIGNvZGUgPSBjb2RlRm9yU3Ry aW5nPEFsbFdoaXRlc3BhY2U+KHN0cmluZyk7Ci0gICAgZWxzZQorICAgICAgICBBU1NFUlQoY29k ZSk7CisgICAgfSBlbHNlIHsKICAgICAgICAgY29kZSA9IGNvZGVGb3JTdHJpbmc8V2hpdGVzcGFj ZVVua25vd24+KHN0cmluZyk7CisgICAgICAgIGlmICghY29kZSkKKyAgICAgICAgICAgIHJldHVy biBBdG9tU3RyaW5nKCk7CisgICAgfQogCi0gICAgaWYgKCFjb2RlKQotICAgICAgICByZXR1cm4g QXRvbVN0cmluZygpOwotCi0gICAgc2l6ZV90IGxlbmd0aEluZGV4ID0gbGVuZ3RoIC0gMTsKLSAg ICBpZiAobV9jb2Rlc1tsZW5ndGhJbmRleF0gPT0gY29kZSkgewotICAgICAgICBBU1NFUlQobV9h dG9tc1ttX2luZGV4ZXNbbGVuZ3RoSW5kZXhdXSA9PSBzdHJpbmcpOwotICAgICAgICByZXR1cm4g bV9hdG9tc1ttX2luZGV4ZXNbbGVuZ3RoSW5kZXhdXTsKKyAgICBhdXRvJiBleGlzdGluZ0F0b20g PSBtX2F0b21zW2xlbmd0aCAtIDFdOworICAgIGlmIChleGlzdGluZ0F0b20uY29kZSA9PSBjb2Rl KSB7CisgICAgICAgIEFTU0VSVChleGlzdGluZ0F0b20uc3RyaW5nID09IHN0cmluZyk7CisgICAg ICAgIHJldHVybiBleGlzdGluZ0F0b20uc3RyaW5nOwogICAgIH0KIAogICAgIGlmIChjb2RlID09 IG92ZXJmbG93V2hpdGVzcGFjZUNvZGUpCiAgICAgICAgIHJldHVybiBBdG9tU3RyaW5nKHN0cmlu Zyk7CiAKLSAgICBpZiAobV9jb2Rlc1tsZW5ndGhJbmRleF0pIHsKLSAgICAgICAgQXRvbVN0cmlu ZyB3aGl0ZXNwYWNlQXRvbShzdHJpbmcpOwotICAgICAgICBtX2NvZGVzW2xlbmd0aEluZGV4XSA9 IGNvZGU7Ci0gICAgICAgIG1fYXRvbXNbbV9pbmRleGVzW2xlbmd0aEluZGV4XV0gPSB3aGl0ZXNw YWNlQXRvbTsKLSAgICAgICAgcmV0dXJuIHdoaXRlc3BhY2VBdG9tOwotICAgIH0KLQotICAgIEF0 b21TdHJpbmcgd2hpdGVzcGFjZUF0b20oc3RyaW5nKTsKLSAgICBtX2NvZGVzW2xlbmd0aEluZGV4 XSA9IGNvZGU7Ci0gICAgbV9pbmRleGVzW2xlbmd0aEluZGV4XSA9IG1fYXRvbXMuc2l6ZSgpOwot ICAgIG1fYXRvbXMuYXBwZW5kKHdoaXRlc3BhY2VBdG9tKTsKLSAgICByZXR1cm4gd2hpdGVzcGFj ZUF0b207CisgICAgZXhpc3RpbmdBdG9tID0geyBBdG9tU3RyaW5nIHsgc3RyaW5nIH0sIGNvZGUg fTsKKyAgICByZXR1cm4gZXhpc3RpbmdBdG9tLnN0cmluZzsKIH0KIAogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuaCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmgKaW5kZXggNTA1MTI1 Y2NkMmYxNTM1ZDI3NjgxNWM2MzA1Yjg3OTI2MjdkZWM1NS4uMjMwODIxNmQ0ZjE3YzMzODlkMWNj ZGU0ZDgzYTg2MTE5MGQ2MmNiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNl ci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5oCkBAIC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSAiRnJh Z21lbnRTY3JpcHRpbmdQZXJtaXNzaW9uLmgiCiAjaW5jbHVkZSAiSFRNTEVsZW1lbnRTdGFjay5o IgogI2luY2x1ZGUgIkhUTUxGb3JtYXR0aW5nRWxlbWVudExpc3QuaCIKKyNpbmNsdWRlIDx3dGYv Rml4ZWRWZWN0b3IuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KICNpbmNsdWRlIDx3 dGYvUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1NldEZvclNjb3BlLmg+CkBAIC0zNyw2ICszOCwx NyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK3N0cnVjdCBBdG9tU3RyaW5nV2l0aENvZGUg eworICAgIEF0b21TdHJpbmcgc3RyaW5nOworICAgIHVpbnQ2NF90IGNvZGUgeyAwIH07Cit9Owor fQorCituYW1lc3BhY2UgV1RGIHsKK3RlbXBsYXRlPD4gc3RydWN0IFZlY3RvclRyYWl0czxXZWJD b3JlOjpBdG9tU3RyaW5nV2l0aENvZGU+IDogU2ltcGxlQ2xhc3NWZWN0b3JUcmFpdHMgeyB9Owor fQorCituYW1lc3BhY2UgV2ViQ29yZSB7CiBzdHJ1Y3QgSFRNTENvbnN0cnVjdGlvblNpdGVUYXNr IHsKICAgICBlbnVtIE9wZXJhdGlvbiB7CiAgICAgICAgIEluc2VydCwKQEAgLTIyOCw3ICsyNDAs MTAgQEAgcHJpdmF0ZToKIGNsYXNzIFdoaXRlc3BhY2VDYWNoZSB7CiAgICAgV1RGX01BS0VfRkFT VF9BTExPQ0FURUQ7CiBwdWJsaWM6Ci0gICAgV2hpdGVzcGFjZUNhY2hlKCkgPSBkZWZhdWx0Owor ICAgIFdoaXRlc3BhY2VDYWNoZSgpCisgICAgICAgIDogbV9hdG9tcyhtYXhpbXVtQ2FjaGVkU3Ry aW5nTGVuZ3RoKQorICAgIHsKKyAgICB9CiAKICAgICBBdG9tU3RyaW5nIGxvb2t1cChjb25zdCBT dHJpbmcmLCBXaGl0ZXNwYWNlTW9kZSk7CiAKQEAgLTIzOCwxNCArMjUzLDcgQEAgcHJpdmF0ZToK ICAgICBjb25zdGV4cHIgc3RhdGljIHVpbnQ2NF90IG92ZXJmbG93V2hpdGVzcGFjZUNvZGUgPSBz dGF0aWNfY2FzdDx1aW50NjRfdD4oLTEpOwogICAgIGNvbnN0ZXhwciBzdGF0aWMgc2l6ZV90IG1h eGltdW1DYWNoZWRTdHJpbmdMZW5ndGggPSAxMjg7CiAKLSAgICAvLyBQYXJhbGxlbCBhcnJheXMg c3RvcmluZyBhIDY0IGJpdCBjb2RlIGFuZCBhbiBpbmRleCBpbnRvIG1fYXRvbXMgZm9yIHRoZQot ICAgIC8vIG1vc3QgcmVjZW50bHkgYXRvbWl6ZWQgd2hpdGVzcGFjZS1vbmx5IHN0cmluZyBvZiBh IGdpdmVuIGxlbmd0aC4gVGhlCi0gICAgLy8gaW5kaWNlcyBpbnRvIHRoZXNlIHR3byBhcnJheXMg YXJlIHRoZSBzdHJpbmcgbGVuZ3RoIG1pbnVzIDEsIHNvIHRoZSBjb2RlCi0gICAgLy8gZm9yIGEg d2hpdGVzcGFjZS1vbmx5IHN0cmluZyBvZiBsZW5ndGggMiBpcyBzdG9yZWQgYXQgbV9jb2Rlc1sx XSwgZXRjLgotICAgIHVpbnQ2NF90IG1fY29kZXNbbWF4aW11bUNhY2hlZFN0cmluZ0xlbmd0aF0g eyAwIH07Ci0gICAgdWludDhfdCBtX2luZGV4ZXNbbWF4aW11bUNhY2hlZFN0cmluZ0xlbmd0aF0g eyAwIH07Ci0KLSAgICBWZWN0b3I8QXRvbVN0cmluZywgbWF4aW11bUNhY2hlZFN0cmluZ0xlbmd0 aD4gbV9hdG9tczsKKyAgICBGaXhlZFZlY3RvcjxBdG9tU3RyaW5nV2l0aENvZGU+IG1fYXRvbXM7 CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 457121 2022-04-08 14:51:54 -0700 2022-04-08 15:02:29 -0700 Follow-up to fix style 238736_blank_lines.patch text/plain 1268 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkY2M5NTNiNzdjYzMuLmUwMGU5ZjJiYmVmZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIyLTA0LTA4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CisKKyAgICAgICAgU2ltcGxpZnkgLyBPcHRpbWl6ZSB0aGUgd2hpdGVzcGFjZSBjYWNoZSBpbXBs ZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM4NzM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85MTI1NTM3MD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb2xsb3ctdXAgdG8gcjI5MjMx MCB0byBhZGQgbWlzc2luZyBibGFuayBsaW5lcy4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hU TUxDb25zdHJ1Y3Rpb25TaXRlLmg6CisKIDIwMjItMDQtMDggIE9yaW9sIEJydWZhdSAgPG9icnVm YXVAaWdhbGlhLmNvbT4KIAogICAgICAgICBbY3NzLWNhc2NhZGVdIE1lcmdlIGdldFJlbGF0ZWRQ cm9wZXJ0eUlkKCkgYW5kIHNob3VsZEFwcGx5UHJvcGVydHlJblBhcnNlT3JkZXIoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuaCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmgKaW5kZXgg MjMwODIxNmQ0ZjE3Li40ZDI5MjY2ZTg3NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuaApAQCAtNDIsMTMgKzQyLDE3IEBAIHN0cnVj dCBBdG9tU3RyaW5nV2l0aENvZGUgewogICAgIEF0b21TdHJpbmcgc3RyaW5nOwogICAgIHVpbnQ2 NF90IGNvZGUgeyAwIH07CiB9OworCiB9CiAKIG5hbWVzcGFjZSBXVEYgeworCiB0ZW1wbGF0ZTw+ IHN0cnVjdCBWZWN0b3JUcmFpdHM8V2ViQ29yZTo6QXRvbVN0cmluZ1dpdGhDb2RlPiA6IFNpbXBs ZUNsYXNzVmVjdG9yVHJhaXRzIHsgfTsKKwogfQogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CisKIHN0 cnVjdCBIVE1MQ29uc3RydWN0aW9uU2l0ZVRhc2sgewogICAgIGVudW0gT3BlcmF0aW9uIHsKICAg ICAgICAgSW5zZXJ0LAo=