238735 2022-04-04 07:17:59 -0700 WPT export broken under Python 3 2022-04-04 08:42:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=238737 InRadar P2 Normal --- 1 gsnedders gsnedders ews-watchlist glenn jbedard koivisto ntim webkit-bug-importer oldest_to_newest 1857840 0 gsnedders 2022-04-04 07:17:59 -0700 Via Antti: > I’m getting: Fetching: https://bugs.webkit.org/show_bug.cgi?id=238542&ctype=xml&excludefield=attachmentdata Removing local branch wpt-export-for-webkit-238542 Finished Cleaning web-platform-tests master branch Traceback (most recent call last): File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 350, in create_wpt_pull_request pr_number = self._github.create_pr(remote_branch_name, title, body) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/wpt_github.py", line 152, in create_pr response = self.request(path, method='POST', body=body) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/wpt_github.py", line 95, in request response = self.host.web.request( File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/web.py", line 51, in request return opener.open(request) File ".../Python.framework/Versions/3.8/lib/python3.8/urllib/request.py", line 522, in open req = meth(req) File ".../Python.framework/Versions/3.8/lib/python3.8/urllib/request.py", line 1285, in do_request_ raise TypeError(msg) TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str. During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/Users/antti/webkit/OpenSource/Tools/Scripts//webkit-patch", line 80, in <module> main() File "/Users/antti/webkit/OpenSource/Tools/Scripts//webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/wptchangeexport.py", line 53, in run test_exporter.do_export() File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 397, in do_export self.make_pull_request() File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 336, in make_pull_request pr_number = self.create_wpt_pull_request(self._wpt_fork_remote + ':' + self._public_branch_name, self._commit_message, description) File "/Users/antti/webkit/OpenSource/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 352, in create_wpt_pull_request if e.code == 422: AttributeError: 'TypeError' object has no attribute 'code' 1857843 1 456567 gsnedders 2022-04-04 07:22:03 -0700 Created attachment 456567 Patch 1857862 2 ews-feeder 2022-04-04 08:41:33 -0700 Committed r292288 (249186@main): <https://commits.webkit.org/249186@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456567. 1857863 3 webkit-bug-importer 2022-04-04 08:42:16 -0700 <rdar://problem/91241469> 456567 2022-04-04 07:22:03 -0700 2022-04-04 08:41:34 -0700 Patch bug-238735-20220404152202.patch text/plain 1205 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjg3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODFiYzMzYmE3YzM1NTE5OTY2NGQ1MGJhMDUyOWNmNDY4 YTM4ZGY0YS4uYWMyNjc1Yzc0YmM0NjQxMjc3NDdlOGJlZmM5MjY5ODJmYTY2NWQzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIyLTA0LTA0ICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAg ICAgICAgV1BUIGV4cG9ydCBicm9rZW4gdW5kZXIgUHl0aG9uIDMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODczNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS93M2Mvd3B0 X2dpdGh1Yi5weToKKyAgICAgICAgKFdQVEdpdEh1Yi5yZXF1ZXN0KTogRW5zdXJlIHdlIGhhdmUg Ynl0ZXMsIG5vdCBzdHIuCisKIDIwMjItMDQtMDQgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxh cGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtHVEtdIFJFR1JFU1NJT04ocjI5MjI2 Myk6IENhbm5vdCBtYWtlIHJlbGVhc2UgdGFyYmFsbHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdzNjL3dwdF9naXRodWIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3cz Yy93cHRfZ2l0aHViLnB5CmluZGV4IDBmNzFkYWRmYTQwNzY4MGM3ZTNkNzcxMTUwYTYxNzFiZWVl MDAxYmQuLjM5Mzc0MjlmNTdjYWJkMTZiYzE2ZmEyM2M3ZjY0NGY5NWVkZWY5NDkgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3dwdF9naXRodWIucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS93M2Mvd3B0X2dpdGh1Yi5weQpAQCAtODUsNyArODUsNyBAQCBjbGFz cyBXUFRHaXRIdWIob2JqZWN0KToKICAgICAgICAgYXNzZXJ0IHBhdGguc3RhcnRzd2l0aCgnLycp CiAKICAgICAgICAgaWYgYm9keToKLSAgICAgICAgICAgIGJvZHkgPSBqc29uLmR1bXBzKGJvZHkp CisgICAgICAgICAgICBib2R5ID0ganNvbi5kdW1wcyhib2R5KS5lbmNvZGUoJ3V0Zi04JykKIAog ICAgICAgICBoZWFkZXJzID0geydBY2NlcHQnOiAnYXBwbGljYXRpb24vdm5kLmdpdGh1Yi52Mytq c29uJ30KIAo=