238729 2022-04-04 02:18:21 -0700 [CMake] Provide better messages when gi-docgen cannot be found 2022-04-04 04:20:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226662 InRadar P2 Normal --- 1 aperez aperez annulen cgarcia ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio webkit-bug-importer oldest_to_newest 1857785 0 aperez 2022-04-04 02:18:21 -0700 In bug #226662 we switched to gi-docgen, but the errors when gi-docgen is not installed or does not run correctly can be quite cryptic. We would like to also hint to people that gi-docgen can be easily installed at the gi-docgen/ subdirectory of the source tree. 1857786 1 456550 aperez 2022-04-04 02:21:46 -0700 Created attachment 456550 Patch 1857809 2 ews-feeder 2022-04-04 04:19:01 -0700 Committed r292286 (249184@main): <https://commits.webkit.org/249184@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456550. 1857810 3 webkit-bug-importer 2022-04-04 04:20:19 -0700 <rdar://problem/91233482> 456550 2022-04-04 02:21:46 -0700 2022-04-04 04:19:02 -0700 Patch bug-238729-20220404122145.patch text/plain 3082 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEdJRG9jZ2VuLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHSURvY2dlbi5jbWFrZQppbmRleCA5 ZTI5ZmM0OGEwMGM5Y2U1MDcwODczNGIzYWMzOGQzODkwZDQ4NGUzLi4xZjkwNWUzYzI4MmFmNWZj MDVlNTVjOGVlMGMyMTgwY2Y0NjJiNTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEdJ RG9jZ2VuLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR0lEb2NnZW4uY21ha2UKQEAgLTY5 LDIxICs2OSw0NyBAQCBmaW5kX3Byb2dyYW0oR0lEb2NnZW5fRVhFCiAgICAgSElOVFMgIiR7Q01B S0VfU09VUkNFX0RJUn0vZ2ktZG9jZ2VuL2JpbiIKICAgICAgICAgICAiJHtDTUFLRV9TT1VSQ0Vf RElSfS9naS1kb2NnZW4iCiAgICAgRE9DICJQYXRoIHRvIHRoZSBnaS1kb2NnZW4gcHJvZ3JhbSIK LSAgICBSRVFVSVJFRAogKQogCi1leGVjdXRlX3Byb2Nlc3MoCi0gICAgQ09NTUFORCAke0dJRG9j Z2VuX0VYRX0gLS12ZXJzaW9uCi0gICAgT1VUUFVUX1ZBUklBQkxFIEdJRG9jZ2VuX1ZFUlNJT04K LSAgICBPVVRQVVRfU1RSSVBfVFJBSUxJTkdfV0hJVEVTUEFDRQotICAgIENPTU1BTkRfRVJST1Jf SVNfRkFUQUwgQU5ZCi0gICAgRVJST1JfUVVJRVQKLSkKKworaWYgKEdJRG9jZ2VuX0ZJTkRfUkVR VUlSRUQpCisgICAgc2V0KF9HSURvY2dlbl9NU0dMRVZFTCBGQVRBTF9FUlJPUikKK2Vsc2UgKCkK KyAgICBzZXQoX0dJRG9jZ2VuX01TR0xFVkVMIFdBUk5JTkcpCitlbmRpZiAoKQorCitpZiAoTk9U IEdJRG9jZ2VuX0VYRSkKKyAgICBtZXNzYWdlKCR7X0dJRG9jZ2VuX01TR0xFVkVMfQorICAgICAg ICAiQ291bGQgbm90IGZpbmQgZ2ktZG9jZ2VuLiBJZiB5b3VyIHN5c3RlbSBkb2VzIG5vdCBwcm92 aWRlIGEgcGFja2FnZSAiCisgICAgICAgICJ0aGUgZm9sbG93aW5nIGNvbW1hbmRzIGNhbiBiZSB1 c2VkIHRvIGluc3RhbGwgaXQgaW5zaWRlIHRoZSBXZWJLaXQgIgorICAgICAgICAic291cmNlIHRy ZWUsIHdoZXJlIGl0IHdpbGwgYmUgZm91bmQgYXV0b21hdGljYWxseTpcbiIKKyAgICAgICAgIiAg dmlydHVhbGVudiBnaS1kb2NnZW4gJHtDTUFLRV9TT1VSQ0VfRElSfS9naS1kb2NnZW5cbiIKKyAg ICAgICAgIiAgJHtDTUFLRV9TT1VSQ0VfRElSfS9naS1kb2NnZW4vYmluL3BpcCBpbnN0YWxsIGdp LWRvY2dlblxuIgorICAgICAgICAiQW5vdGhlciBvcHRpb24gaXMgdW5wYWNraW5nIGEgZ2ktZG9j Z2VuIHJlbGVhc2UgYXQgdGhlIHNhbWUgbG9jYXRpb24gIgorICAgICAgICAiYnV0IGluIHRoaXMg Y2FzZSBkZXBlbmRlbmNpZXMgd2lsbCBub3QgYmUgYXV0b21hdGljYWxseSBpbnN0YWxsZWQuXG4i CisgICAgKQorZWxzZWlmIChHSURvY2dlbl9FWEUpCisgICAgZXhlY3V0ZV9wcm9jZXNzKAorICAg ICAgICBDT01NQU5EICR7R0lEb2NnZW5fRVhFfSAtLXZlcnNpb24KKyAgICAgICAgT1VUUFVUX1ZB UklBQkxFIEdJRG9jZ2VuX1ZFUlNJT04KKyAgICAgICAgT1VUUFVUX1NUUklQX1RSQUlMSU5HX1dI SVRFU1BBQ0UKKyAgICAgICAgUkVTVUxUX1ZBUklBQkxFIF9HSURvY2dlbl9DTURTVEFUVVMKKyAg ICAgICAgRVJST1JfUVVJRVQKKyAgICApCisgICAgc2V0KEdJRG9jZ2VuX1ZFUlNJT04gIiR7R0lE b2NnZW5fVkVSU0lPTn0iIENBQ0hFIElOVEVSTkFMICIiKQorICAgIGlmIChOT1QgJHtfR0lEb2Nn ZW5fQ01EU1RBVFVTfSBFUVVBTCAwKQorICAgICAgICBtZXNzYWdlKCR7X0dJRG9jZ2VuX01TR0xF VkVMfQorICAgICAgICAgICAgIkNvdWxkIG5vdCBleGVjdXRlICR7R0lEb2NnZW5fRVhFfS4gVGhp cyB0eXBpY2FsbHkgc2lnbmFscyBhbiAiCisgICAgICAgICAgICAiaW5jb3JyZWN0IGluc3RhbGxh dGlvbi4gWW91IG1heSB3YW50IHRvIHJ1biBpdCBieSBoYW5kIGZvciAiCisgICAgICAgICAgICAi dHJvdWJsZXNob290aW5nLCB0aGUgcmUtcnVuIENNYWtlIGFnYWluLlxuIgorICAgICAgICApCisg ICAgZW5kaWYgKCkKK2VuZGlmICgpCiAKIGluY2x1ZGUoRmluZFBhY2thZ2VIYW5kbGVTdGFuZGFy ZEFyZ3MpCiBmaW5kX3BhY2thZ2VfaGFuZGxlX3N0YW5kYXJkX2FyZ3MoR0lEb2NnZW4KICAgICBG T1VORF9WQVIgR0lEb2NnZW5fRk9VTkQKLSAgICBSRVFVSVJFRF9WQVJTIEdJRG9jZ2VuX0VYRQor ICAgIFJFUVVJUkVEX1ZBUlMgR0lEb2NnZW5fRVhFIEdJRG9jZ2VuX1ZFUlNJT04KICAgICBWRVJT SU9OX1ZBUiBHSURvY2dlbl9WRVJTSU9OCiApCiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0No YW5nZUxvZwppbmRleCBiODgxMGMyZjU4ZWRiNmY4NDg0MTc5OWU1MTE5Zjc2MTdlYmQxM2MxLi5l NmU5ZTc4ZTJiNDEwYTRhNGRlMDc0Yzg3NjQ0MWVjOThjNmE1NmE1IDEwMDY0NAotLS0gYS9DaGFu Z2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDQtMDQgIEFkcmlh biBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2Vd IFByb3ZpZGUgYmV0dGVyIG1lc3NhZ2VzIHdoZW4gZ2ktZG9jZ2VuIGNhbm5vdCBiZSBmb3VuZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4NzI5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBnaS1k b2NnZW4gY2Fubm90IGJlIGZvdW5kLCBvciBjYW5ub3QgYmUgZXhlY3V0ZWQsIHByb3ZpZGUgYmV0 dGVyIGVycm9yIG1lc3NhZ2VzCisgICAgICAgIHRoYW4gdGhvc2UgcHJvdmlkZWQgYnkgQ01ha2Uu IFdoaWxlIGF0IGl0LCBtYWtlIHRoZSBtZXNzYWdlcyBtZW50aW9uIGhvdyBnaS1kb2NnZW4KKyAg ICAgICAgY2FuIGJlIGluc3RhbGxlZCBpbnNpZGUgdGhlIFdlYktpdCBzb3VyY2UgdHJlZSB0byBi ZSB1c2VkIGZvciB0aGUgYnVpbGQuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZEdJRG9j Z2VuLmNtYWtlOgorCiAyMDIyLTA0LTAyICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVwbGFjZSBndGstZG9jIHdpdGggZ2ktZG9j Z2VuCg==