238669 2022-04-01 10:00:52 -0700 GTK doesn't compile with ENABLE_ACCESSIBILITY=0 2022-04-28 08:17:07 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yurys yurys bugs-noreply clopez dennisn dpino mcatanzaro oldest_to_newest 1857290 0 yurys 2022-04-01 10:00:52 -0700 GTK doesn't compile with ENABLE_ACCESSIBILITY=0 1857291 1 456369 yurys 2022-04-01 10:02:27 -0700 Created attachment 456369 Patch 1857294 2 yurys 2022-04-01 10:05:14 -0700 The error it is fixing is: ../../../Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:697:43: error: use of undeclared identifier 'WEBKIT_WEB_VIEW_ACCESSIBLE' webkitWebViewAccessibleSetWebView(WEBKIT_WEB_VIEW_ACCESSIBLE(webView->priv->accessible.get()), nullptr); ^ ../../../Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1694:49: error: use of undeclared identifier 'webkitWebViewAccessibleNew' priv->accessible = adoptGRef(ATK_OBJECT(webkitWebViewAccessibleNew(widget))); ^ 2 errors generated. 1857579 3 ews-feeder 2022-04-02 09:00:16 -0700 Committed r292265 (249163@main): <https://commits.webkit.org/249163@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456369. 1865143 4 mcatanzaro 2022-04-28 08:17:07 -0700 *** Bug 239837 has been marked as a duplicate of this bug. *** 456369 2022-04-01 10:02:27 -0700 2022-04-02 09:00:18 -0700 Patch bug-238669-20220401100226.patch text/plain 2427 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRjYzBkODIyMmFlYzM2ZDA3 ODdlOWY0YTg0ZjgxYWJlOGZkMGJhMTAuLjcxMmJiZGM5MWY1NWExMjliMjA0MTA1MDlhYjM0ODk3 MjUwMGM5MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjItMDQtMDEgIFl1cnkgU2Vt aWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgR1RLIGRvZXNuJ3QgY29t cGlsZSB3aXRoIEVOQUJMRV9BQ0NFU1NJQklMSVRZPTAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODY2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBHVEsgY29tcGlsYXRpb24gd2l0aCBFTkFCTEVf QUNDRVNTSUJJTElUWT0wCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2Vi Vmlld0Jhc2VEaXNwb3NlKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19iYXNlX2NsYXNzX2lu aXQpOgorCiAyMDIyLTA0LTAxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uLmdldE5vdGlmaWNhdGlvbnMgc2hvdWxk IGxpc3QgYWxsIHBlcnNpc3RlbnQgbm90aWZpY2F0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCAyNzY1Yjg2 MDU1OWJiMjE1ZDEyMzc3MGZlZjVhNGIwN2IyYjFlZDM2Li40M2Y4YThkOWJlNjAyM2VmNDNiYzcw NTljN2U3Y2YzZGVjZGFjZWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtNjk0LDggKzY5NCwxMCBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZURpc3Bvc2UoR09iamVjdCogZ29iamVjdCkKICNlbHNl CiAgICAgZ19jbGVhcl9wb2ludGVyKCZ3ZWJWaWV3LT5wcml2LT5kaWFsb2csIGd0a193aWRnZXRf ZGVzdHJveSk7CiAgICAgd2Via2l0V2ViVmlld0Jhc2VTZXRUb3BsZXZlbE9uU2NyZWVuV2luZG93 KHdlYlZpZXcsIG51bGxwdHIpOworI2lmIEVOQUJMRShBQ0NFU1NJQklMSVRZKQogICAgIGlmICh3 ZWJWaWV3LT5wcml2LT5hY2Nlc3NpYmxlKQogICAgICAgICB3ZWJraXRXZWJWaWV3QWNjZXNzaWJs ZVNldFdlYlZpZXcoV0VCS0lUX1dFQl9WSUVXX0FDQ0VTU0lCTEUod2ViVmlldy0+cHJpdi0+YWNj ZXNzaWJsZS5nZXQoKSksIG51bGxwdHIpOworI2VuZGlmIC8vIEVOQUJMRShBQ0NFU1NJQklMSVRZ KQogI2VuZGlmCiAjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMywgMjQsIDApCiAgICAgd2Via2l0V2Vi Vmlld0Jhc2VDb21wbGV0ZUVtb2ppQ2hvb3NlclJlcXVlc3Qod2ViVmlldywgZW1wdHlTdHJpbmco KSk7CkBAIC0xNjg3LDcgKzE2ODksNyBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0V2ViVmlld0Jh c2VRdWVyeVRvb2x0aXAoR3RrV2lkZ2V0KiB3aWRnZXQsIGdpbnQgLyogeCAqLywgZwogICAgIHJl dHVybiBUUlVFOwogfQogCi0jaWYgIVVTRShHVEs0KQorI2lmICFVU0UoR1RLNCkgJiYgRU5BQkxF KEFDQ0VTU0lCSUxJVFkpCiBzdGF0aWMgQXRrT2JqZWN0KiB3ZWJraXRXZWJWaWV3QmFzZUdldEFj Y2Vzc2libGUoR3RrV2lkZ2V0KiB3aWRnZXQpCiB7CiAgICAgV2ViS2l0V2ViVmlld0Jhc2VQcml2 YXRlKiBwcml2ID0gV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2lkZ2V0KS0+cHJpdjsKQEAgLTIyMjEs NyArMjIyMyw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19iYXNlX2NsYXNzX2luaXQo V2ViS2l0V2ViVmlld0Jhc2VDbGFzcyogd2Via2l0V2ViVmllCiAgICAgd2lkZ2V0Q2xhc3MtPnRv dWNoX2V2ZW50ID0gd2Via2l0V2ViVmlld0Jhc2VUb3VjaEV2ZW50OwogI2VuZGlmCiAgICAgd2lk Z2V0Q2xhc3MtPnF1ZXJ5X3Rvb2x0aXAgPSB3ZWJraXRXZWJWaWV3QmFzZVF1ZXJ5VG9vbHRpcDsK LSNpZiAhVVNFKEdUSzQpCisjaWYgIVVTRShHVEs0KSAmJiBFTkFCTEUoQUNDRVNTSUJJTElUWSkK ICAgICB3aWRnZXRDbGFzcy0+Z2V0X2FjY2Vzc2libGUgPSB3ZWJraXRXZWJWaWV3QmFzZUdldEFj Y2Vzc2libGU7CiAjZW5kaWYKICNpZiBVU0UoR1RLNCkK