238648 2022-03-31 19:49:40 -0700 intersectsWithAncestor doesn't take fragmented boxes into account 2022-04-04 15:05:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mattwoodrow mattwoodrow bfulgham changseok dino esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1857110 0 mattwoodrow 2022-03-31 19:49:40 -0700 intersectsWithAncestor uses overlapBounds(), which doesn't take into account the boxes of other fragments, and can incorrectly determine that we don't intersect if only the first fragment intersects. <rdar://90589355> 1857114 1 456311 mattwoodrow 2022-03-31 19:53:14 -0700 Created attachment 456311 Patch 1857116 2 456311 simon.fraser 2022-03-31 20:07:06 -0700 Comment on attachment 456311 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456311&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2813 > - auto overlap = child.overlapBounds(); > - overlap.moveBy(offset); > + auto overlap = child.boundingBox(&ancestor, child.offsetFromAncestor(&ancestor), RenderLayer::UseFragmentBoxesExcludingCompositing); Is child.overlapBounds() just wrong in this case? That implies there are other cases where overlap is broken? 1857691 3 456311 mattwoodrow 2022-04-03 13:26:17 -0700 Comment on attachment 456311 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456311&action=review >> Source/WebCore/rendering/RenderLayerBacking.cpp:2813 >> + auto overlap = child.boundingBox(&ancestor, child.offsetFromAncestor(&ancestor), RenderLayer::UseFragmentBoxesExcludingCompositing); > > Is child.overlapBounds() just wrong in this case? That implies there are other cases where overlap is broken? It looks like the only other caller overlapBounds is within RenderLayerCompositor, and RenderLayerCompositor::canBeComposited returns false for RenderFragmentedFlow, so I think it shouldn't ever be called for this case. 1858101 4 ews-feeder 2022-04-04 15:05:37 -0700 Committed r292350 (249215@main): <https://commits.webkit.org/249215@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456311. 456311 2022-03-31 19:53:14 -0700 2022-04-04 15:05:39 -0700 Patch bug-238648-20220401155312.patch text/plain 5532 mattwoodrow U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU4YjNiNGQ0M2RlZTM3 NDQ4MDZhMWNhZjg3OTU4ODUwNzNiYjdiZS4uZGJkODk4ZjMzNWI4N2Y1ZWY4MDkxNzNlYzMzZGJk NmUwMjM3ODc5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTMxICBNYXR0 IFdvb2Ryb3cgIDxtYXR0d29vZHJvd0BhcHBsZS5jb20+CisKKyAgICAgICAgaW50ZXJzZWN0c1dp dGhBbmNlc3RvciBzaG91bGQgdGFrZSBmcmFnbWVudGVkIGJveGVzIGludG8gYWNjb3VudC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODY0OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGNvbXBv c2l0aW5nL2JhY2tpbmcvYmFja2luZy1zdG9yZS1jb2x1bW5zLWluc2lkZS1wb3NpdGlvbi1maXhl ZC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmludGVyc2VjdHNXaXRoQW5jZXN0b3IpOgorCisgICAgICAgIFVzZSBi b3VuZGluZ0JveCgpIGZvciBpbnRlcnNlY3RzV2l0aEFuY2VzdG9yLCBzbyB0aGF0IHdlIGNhbiBl eHBsaWNpdGx5IHJlcXVlc3QgdGhlIGJveCB0aGF0IGNvbnRhaW5zCisgICAgICAgIGFsbCBmcmFn bWVudCBib3hlcy4KKwogMjAyMi0wMy0zMSAgTWF0dCBXb29kcm93ICA8bWF0dHdvb2Ryb3dAYXBw bGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBzdXBwb3J0IGZvciBhbGlnbmluZyBiYXNlbGlu ZXMgdGhyb3VnaCBzdWJncmlkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmNwcAppbmRleCAyMzQ1NTI1YjJjODBmYTIyY2ViNjIwZDVkYWY3MDEwMDIx OTg1MmY0Li5lNGU2NjUzYjhjODc0ODM0MGMxNTBkZjcyNGE5NjFkNzQyN2E4YWFjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApAQCAtMjgx MCw5ICsyODEwLDcgQEAgc3RhdGljIHN0ZDo6b3B0aW9uYWw8Ym9vbD4gaW50ZXJzZWN0c1dpdGhB bmNlc3Rvcihjb25zdCBSZW5kZXJMYXllciYgY2hpbGQsIGNvbnMKICAgICAgICAgICAgIHJldHVy biBzdGQ6Om51bGxvcHQ7CiAgICAgfQogCi0gICAgYXV0byBvZmZzZXQgPSBjaGlsZC5jb252ZXJ0 VG9MYXllckNvb3JkcygmYW5jZXN0b3IsIHsgfSwgUmVuZGVyTGF5ZXI6OkFkanVzdEZvckNvbHVt bnMpOwotICAgIGF1dG8gb3ZlcmxhcCA9IGNoaWxkLm92ZXJsYXBCb3VuZHMoKTsKLSAgICBvdmVy bGFwLm1vdmVCeShvZmZzZXQpOworICAgIGF1dG8gb3ZlcmxhcCA9IGNoaWxkLmJvdW5kaW5nQm94 KCZhbmNlc3RvciwgY2hpbGQub2Zmc2V0RnJvbUFuY2VzdG9yKCZhbmNlc3RvciksIFJlbmRlckxh eWVyOjpVc2VGcmFnbWVudEJveGVzRXhjbHVkaW5nQ29tcG9zaXRpbmcpOwogICAgIHJldHVybiBv dmVybGFwLmludGVyc2VjdHMoYW5jZXN0b3JDb21wb3NpdGVkQm91bmRzKTsKIH0KIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGIxOWJjZDBhZjUyODIxZmFmMDQyM2Y5MmU1ZmUwMzRiM2NhMzhhZGMuLmRjMjk2NzYxOTAzZGM2 ZjM1NTYwMzlkZWJkNjBkODQzM2QwZWRkYjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMi0w My0zMSAgTWF0dCBXb29kcm93ICA8bWF0dHdvb2Ryb3dAYXBwbGUuY29tPgorCisgICAgICAgIGlu dGVyc2VjdHNXaXRoQW5jZXN0b3Igc2hvdWxkIHRha2UgZnJhZ21lbnRlZCBib3hlcyBpbnRvIGFj Y291bnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Mzg2NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGNvbXBvc2l0aW5nL2JhY2tpbmcvYmFja2luZy1zdG9yZS1jb2x1bW5zLWluc2lkZS1wb3NpdGlv bi1maXhlZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGNvbXBvc2l0aW5nL2JhY2tp bmcvYmFja2luZy1zdG9yZS1jb2x1bW5zLWluc2lkZS1wb3NpdGlvbi1maXhlZC5odG1sOiBBZGRl ZC4KKworICAgICAgICBBZGRzIG5ldyB0ZXN0IHRoYXQgc2Nyb2xscyBjb250ZW50IHNwbGl0IGlu dG8gY29sdW1ucyB1bnRpbCB0aGUgZmlyc3QgY29sdW1uIGlzIG9mZnNjcmVlbiwgdG8gY29uZmly bQorICAgICAgICB0aGF0IHdlIHN0aWxsIGhhdmUgYSBiYWNraW5nIHN0b3JlLgorCiAyMDIyLTAz LTI4ICBNYXR0IFdvb2Ryb3cgIDxtYXR0d29vZHJvd0BhcHBsZS5jb20+CiAKICAgICAgICAgRG9u J3QgbXV0YXRlIGNoaWxkcmVuIGR1cmluZyBSZW5kZXJHcmlkOjpjb21wdXRlSW50cmluc2ljTG9n aWNhbFdpZHRocyB1bmxlc3Mgd2UncmUgYWJvdXQgdG8gcmUtbGF5b3V0LgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvYmFja2luZy9iYWNraW5nLXN0b3JlLWNvbHVtbnMtaW5z aWRlLXBvc2l0aW9uLWZpeGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5n L2JhY2tpbmcvYmFja2luZy1zdG9yZS1jb2x1bW5zLWluc2lkZS1wb3NpdGlvbi1maXhlZC1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNmFkNDg2ODA3M2RiNzBhNjM0OGRiNDQ5NDA3MmExNWYwNjdh YTY3MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2JhY2tpbmcv YmFja2luZy1zdG9yZS1jb2x1bW5zLWluc2lkZS1wb3NpdGlvbi1maXhlZC1leHBlY3RlZC50eHQK QEAgLTAsMCArMSwyMSBAQAorKEdyYXBoaWNzTGF5ZXIKKyAgKGFuY2hvciAwLjAwIDAuMDApCisg IChib3VuZHMgODAwLjAwIDYwMC4wMCkKKyAgKGJhY2tpbmdTdG9yZUF0dGFjaGVkIDEpCisgIChj aGlsZHJlbiAxCisgICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAgIChib3VuZHMgODAwLjAwIDYwMC4w MCkKKyAgICAgIChjb250ZW50c09wYXF1ZSAxKQorICAgICAgKGJhY2tpbmdTdG9yZUF0dGFjaGVk IDEpCisgICAgICAoY2hpbGRyZW4gMQorICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAg IChwb3NpdGlvbiA4LjAwIDAuMDApCisgICAgICAgICAgKGJvdW5kcyA2MDAuMDAgNjAwLjAwKQor ICAgICAgICAgIChkcmF3c0NvbnRlbnQgMSkKKyAgICAgICAgICAoYmFja2luZ1N0b3JlQXR0YWNo ZWQgMSkKKyAgICAgICAgKQorICAgICAgKQorICAgICkKKyAgKQorKQorCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9jb21wb3NpdGluZy9iYWNraW5nL2JhY2tpbmctc3RvcmUtY29sdW1ucy1pbnNp ZGUtcG9zaXRpb24tZml4ZWQuaHRtbCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2JhY2tpbmcv YmFja2luZy1zdG9yZS1jb2x1bW5zLWluc2lkZS1wb3NpdGlvbi1maXhlZC5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLmU2ZjFhZTFhN2EwNzNhMmU1MGRlMTEwNDY3ZGZkMWU5NzRiYWU2NjMKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9iYWNraW5nL2JhY2tpbmctc3RvcmUtY29s dW1ucy1pbnNpZGUtcG9zaXRpb24tZml4ZWQuaHRtbApAQCAtMCwwICsxLDcxIEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+Cisjb3V0IHsKKyAgICBwb3NpdGlvbjog YWJzb2x1dGU7Cit9CisKKy5maXhlZCB7CisgICAgcG9zaXRpb246IGZpeGVkOworICAgIHRvcDog MHB4OworICAgIGJvdHRvbTowcHg7CisgICAgb3ZlcmZsb3cteDogc2Nyb2xsOworfQorLnNjcm9s bGVkIHsKKyAgICBjb2x1bW4td2lkdGg6IDIwMHB4OworICAgIGNvbHVtbi1maWxsOiBhdXRvOwor ICAgIGhlaWdodDogMjAwcHg7CisgICAgd2lkdGg6IDYwMHB4OworfQorLmZpbGxlciB7CisgICAg d2lkdGg6IDIwMHB4OworICAgIGhlaWdodDogMjAwcHg7CisgICAgYmFja2dyb3VuZC1jb2xvcjpi bHVlOworfQorPC9zdHlsZT4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAg ICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUo KTsKK30KKword2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgeworICAgIGlmICghd2luZG93LnRl c3RSdW5uZXIpCisgICAgICAgIHJldHVybjsKKworICAgIHJlcXVlc3RBbmltYXRpb25GcmFtZSgo KSA9PiB7CisKKyAgICAgICAgbGV0IHNjcm9sbGVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2ZpeGVkJyk7CisgICAgICAgIHNjcm9sbGVyLnNjcm9sbFRvKDQwMCwgMCk7CisKKyAgICAgICAg bGV0IHVpU2NyaXB0ID0gYChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHVpQ29udHJvbGxlci5k b0FmdGVyTmV4dFN0YWJsZVByZXNlbnRhdGlvblVwZGF0ZShmdW5jdGlvbigpIHsKKyAgICAgICAg ICAgICAgICB1aUNvbnRyb2xsZXIudWlTY3JpcHRDb21wbGV0ZSgpOworICAgICAgICAgICAgfSk7 CisgICAgICAgIH0pKClgCisKKyAgICAgICAgdGVzdFJ1bm5lci5ydW5VSVNjcmlwdCh1aVNjcmlw dCwgKCkgPT4geworICAgICAgICAgICAgbGV0IGFmdGVyTGF5ZXJzID0gaW50ZXJuYWxzLmxheWVy VHJlZUFzVGV4dChkb2N1bWVudCwgaW50ZXJuYWxzLkxBWUVSX1RSRUVfSU5DTFVERVNfQkFDS0lO R19TVE9SRV9BVFRBQ0hFRCk7CisgICAgICAgICAgICBsZXQgb3V0ID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ291dCcpOworICAgICAgICAgICAgb3V0LnRleHRDb250ZW50ID0gYCR7YWZ0ZXJM YXllcnN9YAorICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAgIH0p OworICAgIH0pOworfTsKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cHJlIGlkPSJvdXQi PjwvcHJlPgorCis8ZGl2IGlkPSJmaXhlZCIgY2xhc3M9ImZpeGVkIj4KKyAgICA8ZGl2IGNsYXNz PSJzY3JvbGxlZCI+CisgICAgICAgIDxkaXYgY2xhc3M9ImZpbGxlciI+PC9kaXY+CisgICAgICAg IDxkaXYgY2xhc3M9ImZpbGxlciI+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9ImZpbGxlciI+ PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9ImZpbGxlciI+PC9kaXY+CisgICAgICAgIDxkaXYg Y2xhc3M9ImZpbGxlciI+PC9kaXY+CisgICAgPC9kaXY+Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRt bD4K