238609 2022-03-31 08:11:31 -0700 Expand adattributiond sandbox slightly to avoid sandbox crashes 2022-03-31 13:55:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen pvollan webkit-bug-importer oldest_to_newest 1856807 0 achristensen 2022-03-31 08:11:31 -0700 Expand adattributiond sandbox slightly to avoid sandbox crashes 1856808 1 456238 achristensen 2022-03-31 08:12:17 -0700 Created attachment 456238 Patch 1856809 2 achristensen 2022-03-31 08:12:21 -0700 <rdar://problem/91073280> 1856810 3 456239 achristensen 2022-03-31 08:14:43 -0700 Created attachment 456239 Patch 1856817 4 456239 pvollan 2022-03-31 08:45:20 -0700 Comment on attachment 456239 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456239&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in:151 > +;; Note this does not allow subpaths of "/" > +(allow file-read* > + (literal "/")) > + Is there a way to make this more specific? Would allowing file-read-metadata be sufficient? 1856822 5 achristensen 2022-03-31 08:55:48 -0700 No. file-read-metadata is insufficient. It needs at least file-read-data and at that point may as well allow file-read* 1856832 6 achristensen 2022-03-31 09:36:53 -0700 We also need file-test-existence 1856836 7 456249 achristensen 2022-03-31 09:42:09 -0700 Created attachment 456249 Patch 1856857 8 456249 pvollan 2022-03-31 10:33:07 -0700 Comment on attachment 456249 Patch R=me. 1856957 9 achristensen 2022-03-31 13:55:20 -0700 r292171 456238 2022-03-31 08:12:17 -0700 2022-03-31 08:14:41 -0700 Patch bug-238609-20220331081216.patch text/plain 2325 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMTQxCndhcm5pbmc6IHVuYWJsZSB0byBhY2Nlc3MgJy9V c2Vycy9hbGV4Y2hyaXN0ZW5zZW4vLmNvbmZpZy9naXQvYXR0cmlidXRlcyc6IFBlcm1pc3Npb24g ZGVuaWVkCndhcm5pbmc6IHVuYWJsZSB0byBhY2Nlc3MgJy9Vc2Vycy9hbGV4Y2hyaXN0ZW5zZW4v LmNvbmZpZy9naXQvYXR0cmlidXRlcyc6IFBlcm1pc3Npb24gZGVuaWVkCndhcm5pbmc6IHVuYWJs ZSB0byBhY2Nlc3MgJy9Vc2Vycy9hbGV4Y2hyaXN0ZW5zZW4vLmNvbmZpZy9naXQvYXR0cmlidXRl cyc6IFBlcm1pc3Npb24gZGVuaWVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRhNzI4ZjBjNmMyMjQ2MzIyODI1NzA1 YjZiYWEyYTliNzY3MmRmZjIuLjNjYmQxZTEzNjlmODljZjAxNzhjODNhMGU1OTk0ZjljYzE3MmJl MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDMtMzEgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBFeHBhbmQgYWRhdHRyaWJ1 dGlvbmQgc2FuZGJveCBzbGlnaHRseSB0byBhdm9pZCBzYW5kYm94IGNyYXNoZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODYwOQorICAgICAgICA8 cmRhcjovLzkxMDczMjgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5hZGF0dHJpYnV0aW9uZC5zYi5pbjoKKwogMjAyMi0wMy0zMCAgU2lodWkgTGl1ICA8c2lodWlf bGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uOiBXZWJzaXRlRGF0YVN0b3JlIGZh aWxzIHRvIHJlYWQgZXhwZXJpbWVudGFsIGZlYXR1cmUgdmFsdWVzIGZyb20gTlNVc2VyRGVmYXVs dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5hZGF0dHJpYnV0aW9uZC5zYi5pbiBiL1NvdXJjZS9XZWJLaXQv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5hZGF0dHJpYnV0 aW9uZC5zYi5pbgppbmRleCAzYzRmZDcyOGVlNzE1Njk2NmY1MGVjYTBjYWZiODViYWI1ZWJhY2Uy Li5lYjMwNzQ0NGIzYWY3ZjBhZjE3NmRiZDNhZDYxMzk1NmM0NzQwZjA1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJL aXQuYWRhdHRyaWJ1dGlvbmQuc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2Fu ZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LmFkYXR0cmlidXRpb25kLnNiLmluCkBA IC05MSw2ICs5MSw4IEBACiAoYWxsb3cgc3lzY3RsLXJlYWQKICAgICAoc3lzY3RsLW5hbWUKICAg ICAgICAgImh3LmFjdGl2ZWNwdSIKKyAgICAgICAgImh3Lm9zZW52aXJvbm1lbnQiCisgICAgICAg ICJody50YXJnZXQiCiAgICAgICAgICJody5tYWNoaW5lIgogICAgICAgICAiaHcubWVtc2l6ZSIK ICAgICAgICAgImh3Lm5jcHUiCkBAIC0xMDksNiArMTExLDE0IEBACiAgICAgKHN5c2N0bC1uYW1l LXByZWZpeCAia2Vybi5wcm9jLnBpZC4iKQogKQogCisod2l0aC1maWx0ZXIgKHN5c3RlbS1hdHRy aWJ1dGUgYXBwbGUtaW50ZXJuYWwpCisgICAgKGFsbG93IHN5c2N0bC1yZWFkIHN5c2N0bC13cml0 ZQorICAgICAgICAoc3lzY3RsLW5hbWUKKyAgICAgICAgICAgICJ2bS5mb290cHJpbnRfc3VzcGVu ZCIKKyAgICAgICAgKQorICAgICkKKykKKwogKGFsbG93LXJlYWQtd3JpdGUtZGlyZWN0b3J5LWNv bnRlbnRzIChwYXJhbSAiREFSV0lOX1VTRVJfQ0FDSEVfRElSIikpCiAoYWxsb3ctcmVhZC13cml0 ZS1kaXJlY3RvcnktY29udGVudHMgKHBhcmFtICJEQVJXSU5fVVNFUl9URU1QX0RJUiIpKQogCkBA IC0xMzUsNiArMTQ1LDkgQEAKIChhbGxvdyBmaWxlLXJlYWQqCiAgICAgICAgKGxpdGVyYWwgIi9w cml2YXRlL3Zhci9wcmVmZXJlbmNlcy9jb20uYXBwbGUubmV0d29ya2QucGxpc3QiKSkKIAorKGFs bG93IGZpbGUtcmVhZCoKKyAgICAgICAobGl0ZXJhbCAiLyIpKQorCiAoYWxsb3cgZmlsZS1yZWFk LWRhdGEKICAgICAobGl0ZXJhbCAiL1N5c3RlbS9MaWJyYXJ5L0NvcmVTZXJ2aWNlcy9TeXN0ZW1W ZXJzaW9uLnBsaXN0IikKICAgICAobGl0ZXJhbCAiL3Vzci9saWIvbG9nIikK 456239 2022-03-31 08:14:43 -0700 2022-03-31 09:42:07 -0700 Patch bug-238609-20220331081442.patch text/plain 2371 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMTQxCndhcm5pbmc6IHVuYWJsZSB0byBhY2Nlc3MgJy9V c2Vycy9hbGV4Y2hyaXN0ZW5zZW4vLmNvbmZpZy9naXQvYXR0cmlidXRlcyc6IFBlcm1pc3Npb24g ZGVuaWVkCndhcm5pbmc6IHVuYWJsZSB0byBhY2Nlc3MgJy9Vc2Vycy9hbGV4Y2hyaXN0ZW5zZW4v LmNvbmZpZy9naXQvYXR0cmlidXRlcyc6IFBlcm1pc3Npb24gZGVuaWVkCndhcm5pbmc6IHVuYWJs ZSB0byBhY2Nlc3MgJy9Vc2Vycy9hbGV4Y2hyaXN0ZW5zZW4vLmNvbmZpZy9naXQvYXR0cmlidXRl cyc6IFBlcm1pc3Npb24gZGVuaWVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRhNzI4ZjBjNmMyMjQ2MzIyODI1NzA1 YjZiYWEyYTliNzY3MmRmZjIuLjNjYmQxZTEzNjlmODljZjAxNzhjODNhMGU1OTk0ZjljYzE3MmJl MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDMtMzEgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBFeHBhbmQgYWRhdHRyaWJ1 dGlvbmQgc2FuZGJveCBzbGlnaHRseSB0byBhdm9pZCBzYW5kYm94IGNyYXNoZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODYwOQorICAgICAgICA8 cmRhcjovLzkxMDczMjgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5hZGF0dHJpYnV0aW9uZC5zYi5pbjoKKwogMjAyMi0wMy0zMCAgU2lodWkgTGl1ICA8c2lodWlf bGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uOiBXZWJzaXRlRGF0YVN0b3JlIGZh aWxzIHRvIHJlYWQgZXhwZXJpbWVudGFsIGZlYXR1cmUgdmFsdWVzIGZyb20gTlNVc2VyRGVmYXVs dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5hZGF0dHJpYnV0aW9uZC5zYi5pbiBiL1NvdXJjZS9XZWJLaXQv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5hZGF0dHJpYnV0 aW9uZC5zYi5pbgppbmRleCAzYzRmZDcyOGVlNzE1Njk2NmY1MGVjYTBjYWZiODViYWI1ZWJhY2Uy Li5kZjU0NTczZGVmNGQxNzQxMmE3OTIyODlhMTc5ZTQyYjE0NWRjNWJjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJL aXQuYWRhdHRyaWJ1dGlvbmQuc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2Fu ZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LmFkYXR0cmlidXRpb25kLnNiLmluCkBA IC05MSw2ICs5MSw4IEBACiAoYWxsb3cgc3lzY3RsLXJlYWQKICAgICAoc3lzY3RsLW5hbWUKICAg ICAgICAgImh3LmFjdGl2ZWNwdSIKKyAgICAgICAgImh3Lm9zZW52aXJvbm1lbnQiCisgICAgICAg ICJody50YXJnZXQiCiAgICAgICAgICJody5tYWNoaW5lIgogICAgICAgICAiaHcubWVtc2l6ZSIK ICAgICAgICAgImh3Lm5jcHUiCkBAIC0xMDksNiArMTExLDE0IEBACiAgICAgKHN5c2N0bC1uYW1l LXByZWZpeCAia2Vybi5wcm9jLnBpZC4iKQogKQogCisod2l0aC1maWx0ZXIgKHN5c3RlbS1hdHRy aWJ1dGUgYXBwbGUtaW50ZXJuYWwpCisgICAgKGFsbG93IHN5c2N0bC1yZWFkIHN5c2N0bC13cml0 ZQorICAgICAgICAoc3lzY3RsLW5hbWUKKyAgICAgICAgICAgICJ2bS5mb290cHJpbnRfc3VzcGVu ZCIKKyAgICAgICAgKQorICAgICkKKykKKwogKGFsbG93LXJlYWQtd3JpdGUtZGlyZWN0b3J5LWNv bnRlbnRzIChwYXJhbSAiREFSV0lOX1VTRVJfQ0FDSEVfRElSIikpCiAoYWxsb3ctcmVhZC13cml0 ZS1kaXJlY3RvcnktY29udGVudHMgKHBhcmFtICJEQVJXSU5fVVNFUl9URU1QX0RJUiIpKQogCkBA IC0xMzUsNiArMTQ1LDEwIEBACiAoYWxsb3cgZmlsZS1yZWFkKgogICAgICAgIChsaXRlcmFsICIv cHJpdmF0ZS92YXIvcHJlZmVyZW5jZXMvY29tLmFwcGxlLm5ldHdvcmtkLnBsaXN0IikpCiAKKzs7 IE5vdGUgdGhpcyBkb2VzIG5vdCBhbGxvdyBzdWJwYXRocyBvZiAiLyIKKyhhbGxvdyBmaWxlLXJl YWQqCisgICAgICAgKGxpdGVyYWwgIi8iKSkKKwogKGFsbG93IGZpbGUtcmVhZC1kYXRhCiAgICAg KGxpdGVyYWwgIi9TeXN0ZW0vTGlicmFyeS9Db3JlU2VydmljZXMvU3lzdGVtVmVyc2lvbi5wbGlz dCIpCiAgICAgKGxpdGVyYWwgIi91c3IvbGliL2xvZyIpCg== 456249 2022-03-31 09:42:09 -0700 2022-03-31 13:55:26 -0700 Patch bug-238609-20220331094209.patch text/plain 2068 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ3MmNmMTgxNjA0ODZjNzk2 OTA0ZWUwYTRiYTVlZTI1NjY4M2NhMjMuLjVjNjU1YmMzM2JkNjM1YTcyMWEyM2FjZDdlNDUxMTNk N2NkMWZkN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDMtMzEgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBFeHBhbmQgYWRh dHRyaWJ1dGlvbmQgc2FuZGJveCBzbGlnaHRseSB0byBhdm9pZCBzYW5kYm94IGNyYXNoZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODYwOQorICAg ICAgICA8cmRhcjovLzkxMDczMjgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxl LldlYktpdC5hZGF0dHJpYnV0aW9uZC5zYi5pbjoKKwogMjAyMi0wMy0zMSAgQmVuIE5oYW0gIDxu aGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgcHVzaCBzdWJzY3JpcHRpb25zIHdoZW4g cGVybWlzc2lvbnMgYXJlIHJlc2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNl cy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuYWRhdHRyaWJ1dGlvbmQuc2Iu aW4gYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBs ZS5XZWJLaXQuYWRhdHRyaWJ1dGlvbmQuc2IuaW4KaW5kZXggM2M0ZmQ3MjhlZTcxNTY5NjZmNTBl Y2EwY2FmYjg1YmFiNWViYWNlMi4uMTg5OTM5ZjJkZjMyYTBmOWI2MmQzNzc5NzU2M2IzMzg5ZTMz MGIwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0LmFkYXR0cmlidXRpb25kLnNiLmluCisrKyBiL1NvdXJjZS9X ZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5hZGF0 dHJpYnV0aW9uZC5zYi5pbgpAQCAtOTEsNiArOTEsOCBAQAogKGFsbG93IHN5c2N0bC1yZWFkCiAg ICAgKHN5c2N0bC1uYW1lCiAgICAgICAgICJody5hY3RpdmVjcHUiCisgICAgICAgICJody5vc2Vu dmlyb25tZW50IgorICAgICAgICAiaHcudGFyZ2V0IgogICAgICAgICAiaHcubWFjaGluZSIKICAg ICAgICAgImh3Lm1lbXNpemUiCiAgICAgICAgICJody5uY3B1IgpAQCAtMTA5LDYgKzExMSwxNCBA QAogICAgIChzeXNjdGwtbmFtZS1wcmVmaXggImtlcm4ucHJvYy5waWQuIikKICkKIAorKHdpdGgt ZmlsdGVyIChzeXN0ZW0tYXR0cmlidXRlIGFwcGxlLWludGVybmFsKQorICAgIChhbGxvdyBzeXNj dGwtcmVhZCBzeXNjdGwtd3JpdGUKKyAgICAgICAgKHN5c2N0bC1uYW1lCisgICAgICAgICAgICAi dm0uZm9vdHByaW50X3N1c3BlbmQiCisgICAgICAgICkKKyAgICApCispCisKIChhbGxvdy1yZWFk LXdyaXRlLWRpcmVjdG9yeS1jb250ZW50cyAocGFyYW0gIkRBUldJTl9VU0VSX0NBQ0hFX0RJUiIp KQogKGFsbG93LXJlYWQtd3JpdGUtZGlyZWN0b3J5LWNvbnRlbnRzIChwYXJhbSAiREFSV0lOX1VT RVJfVEVNUF9ESVIiKSkKIApAQCAtMTM1LDYgKzE0NSwxMCBAQAogKGFsbG93IGZpbGUtcmVhZCoK ICAgICAgICAobGl0ZXJhbCAiL3ByaXZhdGUvdmFyL3ByZWZlcmVuY2VzL2NvbS5hcHBsZS5uZXR3 b3JrZC5wbGlzdCIpKQogCis7OyBOb3RlIHRoaXMgZG9lcyBub3QgYWxsb3cgc3VicGF0aHMgb2Yg Ii8iCisoYWxsb3cgZmlsZS1yZWFkKiBmaWxlLXRlc3QtZXhpc3RlbmNlCisgICAgICAgKGxpdGVy YWwgIi8iKSkKKwogKGFsbG93IGZpbGUtcmVhZC1kYXRhCiAgICAgKGxpdGVyYWwgIi9TeXN0ZW0v TGlicmFyeS9Db3JlU2VydmljZXMvU3lzdGVtVmVyc2lvbi5wbGlzdCIpCiAgICAgKGxpdGVyYWwg Ii91c3IvbGliL2xvZyIpCg==