238583 2022-03-30 17:58:01 -0700 Drop bad adoptNS() in NetworkProcess.LaunchOnlyWhenNecessary 2022-03-31 01:10:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen andersca darin sihui_liu webkit-bug-importer oldest_to_newest 1856627 0 cdumez 2022-03-30 17:58:01 -0700 Drop bad adoptNS() in NetworkProcess.LaunchOnlyWhenNecessary. It is incorrect as the WKWebViewConfiguration.websiteDataStore getter is not ref'ing the store for us. 1856629 1 456190 cdumez 2022-03-30 17:59:20 -0700 Created attachment 456190 Patch 1856654 2 achristensen 2022-03-30 20:25:06 -0700 If only there were some kind of language feature we could use that would do all this for us... 1856657 3 darin 2022-03-30 20:29:27 -0700 A sort of automatic release counting system? 1856658 4 cdumez 2022-03-30 20:30:25 -0700 (In reply to Darin Adler from comment #3) > A sort of automatic release counting system? Do we have ARC enabled in the API tests? 1856664 5 darin 2022-03-30 20:40:52 -0700 I don’t think we do, but I think we could. Thinking about it, it seems to me that calls to adoptNS should fail to compile under ARC; not important to be able to write it. Should be easy enough to make that change to RetainPtr.h if it’s not already done. Then the question wouldn’t need to be asked. If this was under ARC then it would fail to compile. A while back, once WebKit had a new enough minimum supported version of iOS and macOS, I tried to start converting everything to ARC and it was hard to get it all done. My patches introduced storage leaks because presumably I created a reference cycle somewhere by accident. But probably it wasn’t as hard as I made it. It seems safer for the future if we could get over that hump and convert all our code. Should be easy to switch over all our tests, though, and less risky than doing it in the framework code. So maybe we should do that really soon. 1856719 6 ews-feeder 2022-03-31 01:08:42 -0700 Committed r292144 (249051@main): <https://commits.webkit.org/249051@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456190. 1856721 7 webkit-bug-importer 2022-03-31 01:10:18 -0700 <rdar://problem/91091275> 456190 2022-03-30 17:59:20 -0700 2022-03-31 01:09:05 -0700 Patch bug-238583-20220330175919.patch text/plain 1719 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMTI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTVmYTMwZTczODVjMWY0YzQ2ZjEyNTA1NGM4OTA2ODFk YmYzNTYwYS4uOWU1ZWRlMjMwNjA2YmM2YTAzNDhiYTA3OGZhODRmYTNmYTI3YzczZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIyLTAzLTMwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgRHJvcCBiYWQgYWRvcHROUygpIGluIE5ldHdvcmtQcm9jZXNzLkxhdW5jaE9ubHlXaGVuTmVj ZXNzYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Mzg1ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE cm9wIGJhZCBhZG9wdE5TKCkgaW4gTmV0d29ya1Byb2Nlc3MuTGF1bmNoT25seVdoZW5OZWNlc3Nh cnkuIEl0IGlzIGluY29ycmVjdCBhcyB0aGUKKyAgICAgICAgV0tXZWJWaWV3Q29uZmlndXJhdGlv bi53ZWJzaXRlRGF0YVN0b3JlIGdldHRlciBpcyBub3QgcmVmJ2luZyB0aGUgc3RvcmUgZm9yIHVz LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9OZXR3b3JrUHJv Y2Vzcy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIyLTAzLTMwICBTaWh1aSBMaXUgIDxzaWh1 aV9saXVAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSAtW1dLV2Vic2l0ZURhdGFTdG9yZSBf aW5kZXhlZERCRGF0YWJhc2VEaXJlY3RvcnldCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL05ldHdvcmtQcm9jZXNzLm1tIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9OZXR3b3JrUHJvY2Vzcy5tbQppbmRleCAxYzVlZjFiNzZl NWUwMTY0NTQzZjRmMTQ5YmRjYmQ4YTBlNWU2NzhhLi40NTVlY2U5NWMyNjQyNmI5ZjVlZjA2ZDE4 NzFhZmUzNzY4NjQ1OTlhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL05ldHdvcmtQcm9jZXNzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Q29jb2EvTmV0d29ya1Byb2Nlc3MubW0KQEAgLTkzLDcgKzkzLDcgQEAgVEVTVChO ZXR3b3JrUHJvY2VzcywgTGF1bmNoT25seVdoZW5OZWNlc3NhcnkpCiAKICAgICBAYXV0b3JlbGVh c2Vwb29sIHsKICAgICAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbV0tXZWJWaWV3IG5ld10p OwotICAgICAgICB3ZWJzaXRlRGF0YVN0b3JlID0gYWRvcHROUyhbd2ViVmlldyBjb25maWd1cmF0 aW9uXS53ZWJzaXRlRGF0YVN0b3JlKTsKKyAgICAgICAgd2Vic2l0ZURhdGFTdG9yZSA9IFt3ZWJW aWV3IGNvbmZpZ3VyYXRpb25dLndlYnNpdGVEYXRhU3RvcmU7CiAgICAgICAgIFt3ZWJzaXRlRGF0 YVN0b3JlIF9zZXRSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRW5hYmxlZDpZRVNdOwogICAgICAgICBb W3dlYlZpZXcgY29uZmlndXJhdGlvbl0ucHJvY2Vzc1Bvb2wgX3JlZ2lzdGVyVVJMU2NoZW1lQXNT ZWN1cmU6QCJ0ZXN0Il07CiAgICAgICAgIFtbd2ViVmlldyBjb25maWd1cmF0aW9uXS5wcm9jZXNz UG9vbCBfcmVnaXN0ZXJVUkxTY2hlbWVBc0J5cGFzc2luZ0NvbnRlbnRTZWN1cml0eVBvbGljeTpA InRlc3QiXTsK