238559 2022-03-30 10:37:23 -0700 Use dispatch_source_create(DISPATCH_SOURCE_TYPE_SIGNAL, SIGTERM) in setOSTransaction() 2022-03-30 16:35:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin kkinnunen webkit-bug-importer oldest_to_newest 1856451 0 cdumez 2022-03-30 10:37:23 -0700 Use dispatch_source_create(DISPATCH_SOURCE_TYPE_SIGNAL, SIGTERM) in setOSTransaction() instead of a low-level signal(SIGTERM) handler, as recommended by the XPC team. This is better becomes it has less limitations about what you can do in the handler. It is also possible to set several handlers this way, in different parts of the code (i.e. also not worry about some other code overriding our handler). 1856453 1 456145 cdumez 2022-03-30 10:38:42 -0700 Created attachment 456145 Patch 1856608 2 ews-feeder 2022-03-30 16:34:24 -0700 Committed r292128 (249038@main): <https://commits.webkit.org/249038@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456145. 1856609 3 webkit-bug-importer 2022-03-30 16:35:17 -0700 <rdar://problem/91073577> 456145 2022-03-30 10:38:42 -0700 2022-03-30 16:34:26 -0700 Patch bug-238559-20220330103841.patch text/plain 2926 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA5ZDVjYzkxNDg1N2U5NWJh NTYxM2U3MTg3NDIyNDI1ODUyMmRlZGMuLjlhOWVjY2Q2YTdlMjIwZjEyNGU0MTM3ODJkNDExMDQ5 ZDY1NTg1ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjItMDMtMzAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgZGlzcGF0Y2hfc291cmNlX2Ny ZWF0ZShESVNQQVRDSF9TT1VSQ0VfVFlQRV9TSUdOQUwsIFNJR1RFUk0pIGluIHNldE9TVHJhbnNh Y3Rpb24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjM4NTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIGRpc3BhdGNoX3NvdXJjZV9jcmVhdGUoRElTUEFUQ0hfU09VUkNFX1RZUEVfU0lHTkFMLCBT SUdURVJNKSBpbiBzZXRPU1RyYW5zYWN0aW9uKCkgaW5zdGVhZCBvZiBhCisgICAgICAgIGxvdy1s ZXZlbCBzaWduYWwoU0lHVEVSTSkgaGFuZGxlciwgYXMgcmVjb21tZW5kZWQgYnkgdGhlIFhQQyB0 ZWFtLgorCisgICAgICAgIFRoaXMgaXMgYmV0dGVyIGJlY29tZXMgaXQgaGFzIGxlc3MgbGltaXRh dGlvbnMgYWJvdXQgd2hhdCB5b3UgY2FuIGRvIGluIHRoZSBoYW5kbGVyLiBJdCBpcyBhbHNvCisg ICAgICAgIHBvc3NpYmxlIHRvIHNldCBzZXZlcmFsIGhhbmRsZXJzIHRoaXMgd2F5LCBpbiBkaWZm ZXJlbnQgcGFydHMgb2YgdGhlIGNvZGUgKGkuZS4gYWxzbyBub3Qgd29ycnkgYWJvdXQKKyAgICAg ICAgc29tZSBvdGhlciBjb2RlIG92ZXJyaWRpbmcgb3VyIGhhbmRsZXIpLgorCisgICAgICAgICog U2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNlRW50 cnlQb2ludC5tbToKKyAgICAgICAgKFdlYktpdDo6c2V0T1NUcmFuc2FjdGlvbik6CisKIDIwMjIt MDMtMzAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgSGFz aFRyYW5zbGF0b3IgZm9yIEFTQ0lJTGl0ZXJhbCBmb3IgZmFzdGVyIGxvb2t1cCBpbiBIYXNoTWFw cyAvIEhhc2hTZXRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50 VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZUVudHJ5UG9pbnQubW0gYi9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBD U2VydmljZUVudHJ5UG9pbnQubW0KaW5kZXggYTNkYjRhZjRjMTIzYjZlNmE5MWVhMWVjZGMxM2Ri ODJhMWJjOGIyNC4uZjllZjU4ZDQwMGVhY2U0YTE4Njc1M2JjNjlkOTM1NTlkMWZlNWJjOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9Y UENTZXJ2aWNlL1hQQ1NlcnZpY2VFbnRyeVBvaW50Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hh cmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNlRW50cnlQ b2ludC5tbQpAQCAtMTY4LDEzICsxNjgsMTUgQEAgdm9pZCBzZXRPU1RyYW5zYWN0aW9uKE9TT2Jq ZWN0UHRyPG9zX3RyYW5zYWN0aW9uX3Q+JiYgdHJhbnNhY3Rpb24pCiAgICAgLy8gc2VydmljZXMg b3Vyc2VsdmVzLiBIb3dldmVyLCBvbmUgb2YgdGhlIHNpZGUgZWZmZWN0cyBvZiBsZWFraW5nIHRo aXMgdHJhbnNhY3Rpb24gaXMgdGhhdCB0aGUgZGVmYXVsdCBTSUdURVJNCiAgICAgLy8gaGFuZGxl ciBkb2Vzbid0IGNsZWFubHkgZXhpdCBvdXIgWFBDIHNlcnZpY2VzIHdoZW4gbG9nZ2luZyBvdXQg b3IgcmVib290aW5nLiBUaGlzIGxlZCB0byBjcmFzaGVzIHdpdGgKICAgICAvLyBYUENfRVhJVF9S RUFTT05fU0lHVEVSTV9USU1FT1VUIGFzIHRlcm1pbmF0aW9uIHJlYXNvbiAocmRhcjovLzg4OTQw MjI5KS4gVG8gYWRkcmVzcyB0aGUgaXNzdWUsIHdlIG5vdyBzZXQgb3VyCi0gICAgLy8gb3duIFNJ R1RFUk0gaGFuZGxlciB0aGF0IGNhbGxzIF9leGl0KDApLiBJbiB0aGUgZnV0dXJlLCB3ZSBzaG91 bGQgbGlrZWx5IGFkb3B0IFJ1bm5pbmdCb2FyZCBvbiBtYWNPUyBhbmQKKyAgICAvLyBvd24gU0lH VEVSTSBoYW5kbGVyIHRoYXQgY2FsbHMgZXhpdCgwKS4gSW4gdGhlIGZ1dHVyZSwgd2Ugc2hvdWxk IGxpa2VseSBhZG9wdCBSdW5uaW5nQm9hcmQgb24gbWFjT1MgYW5kCiAgICAgLy8gY29udHJvbCBv dXIgbGlmZXRpbWUgdmlhIHByb2Nlc3MgYXNzZXJ0aW9ucyBpbnN0ZWFkIG9mIGxlYWtpbmcgdGhp cyBPUyB0cmFuc2FjdGlvbi4KLSAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgb25jZUtleTsKLSAg ICBzdGQ6OmNhbGxfb25jZShvbmNlS2V5LCBbXSB7Ci0gICAgICAgIHNpZ25hbChTSUdURVJNLCBb XShpbnQpIHsKLSAgICAgICAgICAgIF9leGl0KDApOworICAgIHN0YXRpYyBkaXNwYXRjaF9vbmNl X3QgZmxhZzsKKyAgICBkaXNwYXRjaF9vbmNlKCZmbGFnLCBeeworICAgICAgICBhdXRvIHNpZ1Rl cm1Tb3VyY2UgPSBkaXNwYXRjaF9zb3VyY2VfY3JlYXRlKERJU1BBVENIX1NPVVJDRV9UWVBFX1NJ R05BTCwgU0lHVEVSTSwgMCwgZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSk7CisgICAgICAgIGRp c3BhdGNoX3NvdXJjZV9zZXRfZXZlbnRfaGFuZGxlcihzaWdUZXJtU291cmNlLCBeeworICAgICAg ICAgICAgZXhpdCgwKTsKICAgICAgICAgfSk7CisgICAgICAgIGRpc3BhdGNoX3Jlc3VtZShzaWdU ZXJtU291cmNlKTsKICAgICB9KTsKIAogICAgIGdsb2JhbFRyYW5zYWN0aW9uLmdldCgpID0gV1RG TW92ZSh0cmFuc2FjdGlvbik7Cg==