238556 2022-03-30 10:07:28 -0700 Turn DEVELOPER_MODE ON for all non-Apple ports in build-webkit 2022-03-30 19:38:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead achristensen annulen bfulgham ews-watchlist gyuyoung.kim jbedard pvollan ryuan.choi sergio webkit-bug-importer oldest_to_newest 1856428 0 don.olmstead 2022-03-30 10:07:28 -0700 PlayStation isn't building with it. 1856460 1 456146 don.olmstead 2022-03-30 10:49:44 -0700 Created attachment 456146 Patch 1856462 2 456146 don.olmstead 2022-03-30 10:51:06 -0700 Comment on attachment 456146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456146&action=review > Tools/Scripts/webkitdirs.pm:2565 > # Some ports have production mode, but build-webkit should always use developer mode. > - push @args, "-DDEVELOPER_MODE=ON" if isGtk() || isJSCOnly() || isWPE() || isWin64(); > + push @args, "-DDEVELOPER_MODE=ON" unless isAppleWebKit(); Originally this seemed to want to be turned ON for non-AppleWin ports. I'm really not sure if this should still be the case. I'm leaning towards it being on for all CMake ports but wanted to get an opinion from Apple before modifying it. 1856469 3 456146 achristensen 2022-03-30 10:55:04 -0700 Comment on attachment 456146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456146&action=review >> Tools/Scripts/webkitdirs.pm:2565 >> + push @args, "-DDEVELOPER_MODE=ON" unless isAppleWebKit(); > > Originally this seemed to want to be turned ON for non-AppleWin ports. I'm really not sure if this should still be the case. I'm leaning towards it being on for all CMake ports but wanted to get an opinion from Apple before modifying it. No strong opinion here. This seems fine. I wonder if we could work to remove DEVELOPER_MODE 1856479 4 456146 don.olmstead 2022-03-30 11:03:01 -0700 Comment on attachment 456146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456146&action=review >>> Tools/Scripts/webkitdirs.pm:2565 >>> + push @args, "-DDEVELOPER_MODE=ON" unless isAppleWebKit(); >> >> Originally this seemed to want to be turned ON for non-AppleWin ports. I'm really not sure if this should still be the case. I'm leaning towards it being on for all CMake ports but wanted to get an opinion from Apple before modifying it. > > No strong opinion here. This seems fine. I wonder if we could work to remove DEVELOPER_MODE If there's no historical reason for not turning `DEVELOPER_MODE` `ON` for AppleWin then I think we should just turn it `ON` for all here so the above comment is actually true. We could possibly roll `DEVELOPER_MODE` and `ENABLE_EXPERIMENTAL_FEATURES` together. For Igalia ports `DEVELOPER_MODE=OFF` seems to signal a production build for them. I'm not sure if you'd ever want to do `DEVELOPER_MODE=OFF` and `ENABLE_EXPERIMENTAL_FEATURES=ON`. I would guess there would need to be a transition period with that though. 1856480 5 achristensen 2022-03-30 11:04:04 -0700 I think we should be working towards removing DEVELOPER_MODE and ENABLE_EXPERIMENTAL_FEATURES and having development be more like production. 1856493 6 don.olmstead 2022-03-30 11:28:12 -0700 (In reply to Alex Christensen from comment #5) > I think we should be working towards removing DEVELOPER_MODE and > ENABLE_EXPERIMENTAL_FEATURES and having development be more like production. My understanding is the Igalia releases use DEVELOPER_MODE=OFF. In those cases it doesn't build any testing bits or the MiniBrowser. Then they make their browser off of that. So I'll propose we add in the DEVELOPER_MODE=ON for all ports. Then get the PlayStation port on that, which is my main concern. Then we can talk to Igalians about their release and hopefully merge ENABLE_EXPERIMENTAL_FEATURES into DEVELOPER_MODE. Then we can figure out if there's a way to get us off DEVELOPER_MDOE completely. I'm not sure everyone's requirements for a production build so it might need to stick around completely. For our builds I'd like to minimize the number of functions exported and do a full LTO. 1856497 7 don.olmstead 2022-03-30 11:36:59 -0700 Also from grepping the code I do see uses of ENABLE(DEVELOPER_MODE) and ENABLE(EXPERIMENTAL_FEATURES). ENABLE(DEVELOPER_MODE) appears in a number of .h/.cpp files. ENABLE(EXPERIMENTAL_FEATURES) only appears in a single .cpp file BUT is used in two WebPrefences yaml files. 1856501 8 achristensen 2022-03-30 11:39:22 -0700 EXPERIMENTAL_FEATURES is on in SafariTechnologyPreview and off everywhere else in Apple's ecosystem. We discussed it a few months ago and decided it is better to have SafariTechnologyPreview more similar to everything else. The more differences between DEVELOPER_MODE=ON and DEVELOPER_MODE=OFF there are, the more likely it is that a bug in some obscure configuration will go unfixed because no developers noticed it. 1856509 9 456159 don.olmstead 2022-03-30 11:54:55 -0700 Created attachment 456159 Patch enabling all 1856510 10 mcatanzaro 2022-03-30 11:56:17 -0700 We'll never be able to get rid of DEVELOPER_MODE because some things just need to be different for developer builds vs. real builds. E.g. if you're a developer you want to load the injected bundle from your build directory instead of the install prefix, otherwise there's no way it will work. But in releases we need to load the installed injected bundle. Another example: in developer builds we need to mount the build directory in the sandbox. For a more recent example, in bug #237107 where clopez needs to run a suboptimal codepath for WPT tests that we don't want to run in production. Some cases look suspicious, though. E.g. I see we have Xvfb-related code guarded by DEVELOPER_MODE. I doubt those guards are truly needed. Removing EXPERIMENTAL_FEATURES is probably possible: that's just a matter of replacing build guards with runtime guards. 1856512 11 achristensen 2022-03-30 12:04:09 -0700 Apple developers use DYLD_FRAMEWORK_PATH so habitually and it works so well that I think we don't want ENABLE(DEVELOPER_MODE) on Apple platforms. I understand if it might be useful for linux developers, but we should keep it minimal. 1856515 12 achristensen 2022-03-30 12:11:37 -0700 I'm removing EXPERIMENTAL_FEATURES in https://bugs.webkit.org/show_bug.cgi?id=238565 and would appreciate some input from Linux devs because I'm not familiar with its use on Linux. 1856538 13 don.olmstead 2022-03-30 12:57:58 -0700 (In reply to Alex Christensen from comment #12) > I'm removing EXPERIMENTAL_FEATURES in > https://bugs.webkit.org/show_bug.cgi?id=238565 and would appreciate some > input from Linux devs because I'm not familiar with its use on Linux. Ok if that's the plan can we get a review on this? 1856645 14 ews-feeder 2022-03-30 19:37:37 -0700 Committed r292137 (249044@main): <https://commits.webkit.org/249044@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456146. 1856646 15 webkit-bug-importer 2022-03-30 19:38:17 -0700 <rdar://problem/91080551> 456146 2022-03-30 10:49:44 -0700 2022-03-30 19:37:40 -0700 Patch bug-238556.diff text/plain 3529 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjNjQ0MDg5MmNiNjcuLjQz YjUyNTJjZDY2YyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIyLTAzLTMwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5j b20+CisKKyAgICAgICAgVHVybiBERVZFTE9QRVJfTU9ERSBPTiBmb3IgYWxsIG5vbi1BcHBsZSBw b3J0cyBpbiBidWlsZC13ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzODU1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVzZSBERVZFTE9QRVJfTU9ERSB0byBkZXRlcm1pbmUgd2hhdCB0aGUgZGVm YXVsdHMgb2YgRU5BQkxFX0FQSV9URVNUUyBhbmQKKyAgICAgICAgRU5BQkxFX01JTklCUk9XU0VS IHNob3VsZCBiZS4gTWFrZSBFTkFCTEVfV0VCS0lUIHRoZSBkZWZhdWx0IG9mIEVOQUJMRV9NSU5J QlJPV1NFUi4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zUGxheVN0YXRpb24uY21h a2U6CisKIDIwMjItMDMtMjkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQWRkIGRlc2NyaXB0aW9ucyBvbiBob3cgdG8gc3RhcnQgV1BUIGFuZCBodHRwIHRlc3Qg c2VydmVycyB0byBJbnRyb2R1Y3Rpb24ubWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRp b25zUGxheVN0YXRpb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1BsYXlTdGF0aW9uLmNt YWtlCmluZGV4IGUxYzk5YzhhYThkOS4uNDIyMjQ4ZjkyOWRjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv Y21ha2UvT3B0aW9uc1BsYXlTdGF0aW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25z UGxheVN0YXRpb24uY21ha2UKQEAgLTE2LDEyICsxNiwxOCBAQCBhZGRfZGVmaW5pdGlvbnMoLURT Q0VfTElCQ19ESVNBQkxFX0NQUDE0X0hFQURFUl9XQVJOSU5HPSAtRFNDRV9MSUJDX0RJU0FCTEVf Q1BQMQogIyBidWctMjI0NDYyCiBXRUJLSVRfUFJFUEVORF9HTE9CQUxfQ09NUElMRVJfRkxBR1Mo LVduby1kbGwtYXR0cmlidXRlLW9uLXJlZGVjbGFyYXRpb24pCiAKLXNldChFTkFCTEVfQVBJX1RF U1RTIE9OIENBQ0hFIEJPT0wgIkJ1aWxkIEFQSSBUZXN0cyIpCiBzZXQoRU5BQkxFX1dFQktJVF9M RUdBQ1kgT0ZGKQogc2V0KEVOQUJMRV9XRUJJTlNQRUNUT1JVSSBPRkYpCiAKIFdFQktJVF9PUFRJ T05fQkVHSU4oKQogCisjIERldmVsb3BlciBtb2RlIG9wdGlvbnMKK1NFVF9BTkRfRVhQT1NFX1RP X0JVSUxEKEVOQUJMRV9ERVZFTE9QRVJfTU9ERSAke0RFVkVMT1BFUl9NT0RFfSkKK2lmIChFTkFC TEVfREVWRUxPUEVSX01PREUpCisgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUo RU5BQkxFX0FQSV9URVNUUyBQUklWQVRFIE9OKQorICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9NSU5JQlJPV1NFUiBQVUJMSUMgJHtFTkFCTEVfV0VCS0lUfSkKK2Vu ZGlmICgpCisKICMgUGxheVN0YXRpb24gU3BlY2lmaWMgT3B0aW9ucwogV0VCS0lUX09QVElPTl9E RUZJTkUoRU5BQkxFX1NUQVRJQ19KU0MgIkNvbnRyb2wgd2hldGhlciB0byBidWlsZCBhIG5vbi1z aGFyZWQgSlNDIiBQVUJMSUMgT04pCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCA3MTc5ZTkzN2MzZDAuLjEwMjAwOWFlNWZiZCAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDIyLTAzLTMwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAg ICAgICAgVHVybiBERVZFTE9QRVJfTU9ERSBPTiBmb3IgYWxsIG5vbi1BcHBsZSBwb3J0cyBpbiBi dWlsZC13ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzODU1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBERVZFTE9QRVJfTU9ERT1PTiB0byB0aGUgQ01ha2UgYXJndW1lbnQgbGlzdCBmb3Ig YWxsIG5vbi1BcHBsZSBwb3J0cyBpbiBidWlsZC13ZWJraXQuCisgICAgICAgIFVzZSBFTkFCTEVf TUlOSUJST1dTRVIgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgdG8gYnVpbGQgdGhlIGV4ZWN1dGFibGUg b24gUGxheVN0YXRpb24uCisKKyAgICAgICAgKiBQbGF0Zm9ybVBsYXlTdGF0aW9uLmNtYWtlOgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGdlbmVyYXRlQnVpbGRT eXN0ZW1Gcm9tQ01ha2VQcm9qZWN0KToKKwogMjAyMi0wMy0yOSAgQWxleCBDaHJpc3RlbnNlbiAg PGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIERvbid0IGNyZWF0ZSBkaXJlY3Rv cmllcyBvbiBpT1MgaWYgd2UgYXJlIG9ubHkgdXNpbmcgZXBoZW1lcmFsIHN0b3JhZ2VzCmRpZmYg LS1naXQgYS9Ub29scy9QbGF0Zm9ybVBsYXlTdGF0aW9uLmNtYWtlIGIvVG9vbHMvUGxhdGZvcm1Q bGF5U3RhdGlvbi5jbWFrZQppbmRleCBhNTM1YjlhYmE4YTguLjcyNTQ3MmE5YjViOSAxMDA2NDQK LS0tIGEvVG9vbHMvUGxhdGZvcm1QbGF5U3RhdGlvbi5jbWFrZQorKysgYi9Ub29scy9QbGF0Zm9y bVBsYXlTdGF0aW9uLmNtYWtlCkBAIC0xLDMgKzEsMyBAQAotaWYgKEVOQUJMRV9XRUJLSVQpCitp ZiAoRU5BQkxFX01JTklCUk9XU0VSKQogICAgIGFkZF9zdWJkaXJlY3RvcnkoTWluaUJyb3dzZXIv cGxheXN0YXRpb24pCiBlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRk aXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDYyMzRiYTE4NDJkNi4u OTNmOTVkMzk4MDQ5IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yNTYyLDcgKzI1NjIsNyBAQCBzdWIg Z2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QKICAgICBwdXNoIEBhcmdzLCAnLURT SE9XX0JJTkRJTkdTX0dFTkVSQVRJT05fUFJPR1JFU1M9MScgdW5sZXNzICgkd2lsbFVzZU5pbmph ICYmIC10IFNURE9VVCk7CiAKICAgICAjIFNvbWUgcG9ydHMgaGF2ZSBwcm9kdWN0aW9uIG1vZGUs IGJ1dCBidWlsZC13ZWJraXQgc2hvdWxkIGFsd2F5cyB1c2UgZGV2ZWxvcGVyIG1vZGUuCi0gICAg cHVzaCBAYXJncywgIi1EREVWRUxPUEVSX01PREU9T04iIGlmIGlzR3RrKCkgfHwgaXNKU0NPbmx5 KCkgfHwgaXNXUEUoKSB8fCBpc1dpbjY0KCk7CisgICAgcHVzaCBAYXJncywgIi1EREVWRUxPUEVS X01PREU9T04iIHVubGVzcyBpc0FwcGxlV2ViS2l0KCk7CiAKICAgICBpZiAoYXJjaGl0ZWN0dXJl KCkgZXEgIng4Nl82NCIgJiYgc2hvdWxkQnVpbGQzMkJpdCgpKSB7CiAgICAgICAgICMgQ01BS0Vf TElCUkFSWV9BUkNISVRFQ1RVUkUgaXMgbmVlZGVkIHRvIGdldCB0aGUgcmlnaHQgLnBjCg== 456159 2022-03-30 11:54:55 -0700 2022-03-30 13:12:19 -0700 Patch enabling all bug-238556.diff text/plain 5479 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjNjQ0MDg5MmNiNjcuLjRm NjliYjEwMmZlOCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIyIEBACisyMDIyLTAzLTMwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5j b20+CisKKyAgICAgICAgVHVybiBERVZFTE9QRVJfTU9ERSBPTiBmb3IgYWxsIENNYWtlIHBvcnRz IGluIGJ1aWxkLXdlYmtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjM4NTU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIERFVkVMT1BFUl9NT0RFIGFzIGFuIG9wdGlvbiBmb3IgYWxsIENNYWtlIHBv cnRzLiBFeHBvc2UgRU5BQkxFX0RFVkVMT1BFUl9NT0RFIHRvIHRoZQorICAgICAgICBidWlsZCBi YXNlZCBvbiB0aGlzIHZhbHVlLiBGb3IgdGhlIFBsYXlTdGF0aW9uIHBvcnQgdXNlIERFVkVMT1BF Ul9NT0RFIHRvIGhlbHAgZGV0ZXJtaW5lCisgICAgICAgIHdoYXQgdGhlIGRlZmF1bHRzIG9mIEVO QUJMRV9BUElfVEVTVFMgYW5kIEVOQUJMRV9NSU5JQlJPV1NFUiBzaG91bGQgYmUuCisKKyAgICAg ICAgWENvZGUgYnVpbGRzIGhhdmUgYSBEZWJ1ZywgUmVsZWFzZSBhbmQgUHJvZHVjdGlvbiBidWls ZCBzbyB1c2UgREVWRUxPUEVSX01PREU9T0ZGIHRvCisgICAgICAgIHNpZ25pZnkgYSBQcm9kdWN0 aW9uIGJ1aWxkIHZhcmlhbnQuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1BsYXlT dGF0aW9uLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOgor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luQ2Fpcm8uY21ha2U6CisgICAgICAgICog U291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOgorCiAyMDIyLTAzLTI5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBkZXNjcmlwdGlvbnMgb24g aG93IHRvIHN0YXJ0IFdQVCBhbmQgaHR0cCB0ZXN0IHNlcnZlcnMgdG8gSW50cm9kdWN0aW9uLm1k CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1BsYXlTdGF0aW9uLmNtYWtlIGIvU291 cmNlL2NtYWtlL09wdGlvbnNQbGF5U3RhdGlvbi5jbWFrZQppbmRleCBlMWM5OWM4YWE4ZDkuLjU2 OGMxOTRiZDhmZiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNQbGF5U3RhdGlvbi5j bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1BsYXlTdGF0aW9uLmNtYWtlCkBAIC0xNiwx MiArMTYsMTcgQEAgYWRkX2RlZmluaXRpb25zKC1EU0NFX0xJQkNfRElTQUJMRV9DUFAxNF9IRUFE RVJfV0FSTklORz0gLURTQ0VfTElCQ19ESVNBQkxFX0NQUDEKICMgYnVnLTIyNDQ2MgogV0VCS0lU X1BSRVBFTkRfR0xPQkFMX0NPTVBJTEVSX0ZMQUdTKC1Xbm8tZGxsLWF0dHJpYnV0ZS1vbi1yZWRl Y2xhcmF0aW9uKQogCi1zZXQoRU5BQkxFX0FQSV9URVNUUyBPTiBDQUNIRSBCT09MICJCdWlsZCBB UEkgVGVzdHMiKQogc2V0KEVOQUJMRV9XRUJLSVRfTEVHQUNZIE9GRikKIHNldChFTkFCTEVfV0VC SU5TUEVDVE9SVUkgT0ZGKQogCiBXRUJLSVRfT1BUSU9OX0JFR0lOKCkKIAorIyBEZXZlbG9wZXIg bW9kZSBvcHRpb25zCitpZiAoRU5BQkxFX0RFVkVMT1BFUl9NT0RFKQorICAgIFdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BUElfVEVTVFMgUFJJVkFURSBPTikKKyAgICBX RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUlOSUJST1dTRVIgUFVCTElD ICR7RU5BQkxFX1dFQktJVH0pCitlbmRpZiAoKQorCiAjIFBsYXlTdGF0aW9uIFNwZWNpZmljIE9w dGlvbnMKIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9TVEFUSUNfSlNDICJDb250cm9sIHdo ZXRoZXIgdG8gYnVpbGQgYSBub24tc2hhcmVkIEpTQyIgUFVCTElDIE9OKQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCmluZGV4IGQxZmQyZjAxZThhNi4uNmUxNDg5MDViOGY3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5j bWFrZQpAQCAtMjYsOCArMjYsNiBAQCBmaW5kX3BhY2thZ2UoWkxJQiBSRVFVSVJFRCkKIAogV0VC S0lUX09QVElPTl9CRUdJTigpCiAKLVNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEVOQUJMRV9ERVZF TE9QRVJfTU9ERSAke0RFVkVMT1BFUl9NT0RFfSkKLQogaW5jbHVkZShHU3RyZWFtZXJEZWZpbml0 aW9ucykKIAogIyBQdWJsaWMgb3B0aW9ucyBzaGFyZWQgd2l0aCBvdGhlciBXZWJLaXQgcG9ydHMu IERvIG5vdCBhZGQgYW55IG9wdGlvbnMgaGVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09w dGlvbnNXaW5DYWlyby5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luQ2Fpcm8uY21ha2UK aW5kZXggNjJiNGJjNmU5MWIxLi5jNTFiYmFiY2IyYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFr ZS9PcHRpb25zV2luQ2Fpcm8uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWly by5jbWFrZQpAQCAtNjMsOCArNjMsNiBAQCBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfVEVY VFVSRV9NQVBQRVJfR0wgT04pCiBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfTUVESUFfRk9V TkRBVElPTiBPTikKIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9JTlNQRUNUT1JfU09DS0VU X1NFUlZFUiAke0VOQUJMRV9SRU1PVEVfSU5TUEVDVE9SfSkKIAotU0VUX0FORF9FWFBPU0VfVE9f QlVJTEQoRU5BQkxFX0RFVkVMT1BFUl9NT0RFICR7REVWRUxPUEVSX01PREV9KQotCiBTRVRfQU5E X0VYUE9TRV9UT19CVUlMRChIQVZFX09TX0RBUktfTU9ERV9TVVBQT1JUIDEpCiAKICMgQ29yZUZv dW5kYXRpb24gaXMgcmVxdWlyZWQgd2hlbiBidWlsZGluZyBXZWJLaXRMZWdhY3kKZGlmZiAtLWdp dCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJL aXRGZWF0dXJlcy5jbWFrZQppbmRleCA5YTA4ZGE0ZjJlZDMuLmZmMzU0NmUwZGEwNiAxMDA2NDQK LS0tIGEvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFr ZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQpAQCAtNDI5LDUgKzQyOSw4IEBAIG1hY3JvKFdFQktJVF9D SEVDS19TT1VSQ0VfQ09NUElMRVMgX3ZhcmlhYmxlIF9zb3VyY2UpCiAgICAgU0VUX0FORF9FWFBP U0VfVE9fQlVJTEQoJHtfdmFyaWFibGV9ICR7JHtfdmFyaWFibGV9X3ZhbHVlfSkKIGVuZG1hY3Jv KCkKIAorb3B0aW9uKERFVkVMT1BFUl9NT0RFICJFbmFibGUgZGV2ZWxvcGVyIG1vZGUiIE9GRikK K1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEVOQUJMRV9ERVZFTE9QRVJfTU9ERSAke0RFVkVMT1BF Ul9NT0RFfSkKKwogb3B0aW9uKEVOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVMgIkVuYWJsZSBl eHBlcmltZW50YWwgZmVhdHVyZXMiIE9GRikKIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEVOQUJM RV9FWFBFUklNRU5UQUxfRkVBVFVSRVMgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkK ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3MTc5 ZTkzN2MzZDAuLmYwYTgxN2Q1OTRiNSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTMwICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgVHVybiBERVZFTE9QRVJfTU9E RSBPTiBmb3IgYWxsIENNYWtlIHBvcnRzIGluIGJ1aWxkLXdlYmtpdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4NTU2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIERFVkVMT1BFUl9NT0RFPU9OIHRv IHRoZSBDTWFrZSBhcmd1bWVudCBsaXN0IGZvciBhbGwgQ01ha2UgcG9ydHMgaW4gYnVpbGQtd2Vi a2l0LgorICAgICAgICAKKyAgICAgICAgVXNlIEVOQUJMRV9NSU5JQlJPV1NFUiB0byBkZXRlcm1p bmUgd2hldGhlciB0byBidWlsZCB0aGUgZXhlY3V0YWJsZSBvbiBQbGF5U3RhdGlvbi4KKworICAg ICAgICAqIFBsYXRmb3JtUGxheVN0YXRpb24uY21ha2U6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRkaXJzLnBtOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3Qp OgorCiAyMDIyLTAzLTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5v cmc+CiAKICAgICAgICAgRG9uJ3QgY3JlYXRlIGRpcmVjdG9yaWVzIG9uIGlPUyBpZiB3ZSBhcmUg b25seSB1c2luZyBlcGhlbWVyYWwgc3RvcmFnZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1BsYXRmb3Jt UGxheVN0YXRpb24uY21ha2UgYi9Ub29scy9QbGF0Zm9ybVBsYXlTdGF0aW9uLmNtYWtlCmluZGV4 IGE1MzViOWFiYThhOC4uNzI1NDcyYTliNWI5IDEwMDY0NAotLS0gYS9Ub29scy9QbGF0Zm9ybVBs YXlTdGF0aW9uLmNtYWtlCisrKyBiL1Rvb2xzL1BsYXRmb3JtUGxheVN0YXRpb24uY21ha2UKQEAg LTEsMyArMSwzIEBACi1pZiAoRU5BQkxFX1dFQktJVCkKK2lmIChFTkFCTEVfTUlOSUJST1dTRVIp CiAgICAgYWRkX3N1YmRpcmVjdG9yeShNaW5pQnJvd3Nlci9wbGF5c3RhdGlvbikKIGVuZGlmICgp CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0KaW5kZXggNjIzNGJhMTg0MmQ2Li5mZjM1ODE2YWU4NzggMTAwNzU1Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0KQEAgLTI1NjIsNyArMjU2Miw3IEBAIHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJv bUNNYWtlUHJvamVjdAogICAgIHB1c2ggQGFyZ3MsICctRFNIT1dfQklORElOR1NfR0VORVJBVElP Tl9QUk9HUkVTUz0xJyB1bmxlc3MgKCR3aWxsVXNlTmluamEgJiYgLXQgU1RET1VUKTsKIAogICAg ICMgU29tZSBwb3J0cyBoYXZlIHByb2R1Y3Rpb24gbW9kZSwgYnV0IGJ1aWxkLXdlYmtpdCBzaG91 bGQgYWx3YXlzIHVzZSBkZXZlbG9wZXIgbW9kZS4KLSAgICBwdXNoIEBhcmdzLCAiLURERVZFTE9Q RVJfTU9ERT1PTiIgaWYgaXNHdGsoKSB8fCBpc0pTQ09ubHkoKSB8fCBpc1dQRSgpIHx8IGlzV2lu NjQoKTsKKyAgICBwdXNoIEBhcmdzLCAiLURERVZFTE9QRVJfTU9ERT1PTiI7CiAKICAgICBpZiAo YXJjaGl0ZWN0dXJlKCkgZXEgIng4Nl82NCIgJiYgc2hvdWxkQnVpbGQzMkJpdCgpKSB7CiAgICAg ICAgICMgQ01BS0VfTElCUkFSWV9BUkNISVRFQ1RVUkUgaXMgbmVlZGVkIHRvIGdldCB0aGUgcmln aHQgLnBjCg==