238520 2022-03-29 13:38:55 -0700 [Playstation] Fix build break after r292041 when ENABLE_SERVICE_WORKER is off 2022-03-29 17:00:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jigen.zhou jigen.zhou darin webkit-bug-importer oldest_to_newest 1856172 0 jigen.zhou 2022-03-29 13:38:55 -0700 There was 2 additional build errors occur after r292041 (the fix to r291979) ( if NOTIFICATIONS is also off: C:\Working\neko_dir\neko-ps\Source\WebKit\WebProcess/Notifications/WebNotificationManager.cpp(153,93): error : member access into incomplete type 'WebCore::Notif ication' [C:\Working\neko_dir\neko-ps\WebKitBuild\Debug-PS5\Source\WebKit\WebKit.vcxproj] LOG(Notifications, "WebProcess %i going to show notification %s", getpid(), notification.identifier().toString().utf8().data()); ^ C:\Working\neko_dir\neko-ps\WebKitBuild\Debug-PS5\WebCore\PrivateHeaders\WebCore/NotificationClient.h(39,7): note: forward declaration of 'WebCore::Notificatio n' class Notification; ^ 1 error generated. :\Working\neko_dir\neko-ps\Source\WebKit\UIProcess/WebsiteData/WebsiteDataStore.cpp(2114,18): error : no member named 'setServiceWorkerOpenWindowCompletionCallb ack' in 'WebKit::WebPageProxy' [C:\Working\neko_dir\neko-ps\WebKitBuild\Debug-PS5\Source\WebKit\WebKit.vcxproj] newPage->setServiceWorkerOpenWindowCompletionCallback(WTFMove(innerCallback)); ~~~~~~~ ^ 1 error generated. 1856175 1 jigen.zhou 2022-03-29 13:54:06 -0700 The error for NOTIFICATIONS has been fixed by r291994. 1856190 2 456059 jigen.zhou 2022-03-29 14:29:52 -0700 Created attachment 456059 Patch 1856226 3 456059 darin 2022-03-29 16:03:35 -0700 Comment on attachment 456059 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456059&action=review > Source/WebKit/ChangeLog:3 > + [Playstation] Fix build break after r292041 when ENABLE_SERVICE_WORKER is off This bug name does not need a platform prefix, and should not have one. 1856250 4 ews-feeder 2022-03-29 16:59:34 -0700 Committed r292081 (249008@main): <https://commits.webkit.org/249008@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456059. 1856251 5 webkit-bug-importer 2022-03-29 17:00:17 -0700 <rdar://problem/91013132> 456059 2022-03-29 14:29:52 -0700 2022-03-29 16:59:37 -0700 Patch Patch text/plain 1365 jigen.zhou ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMmFlMDc4Mzk2NWZjLi42MzVkMGUxOWZkODcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMjItMDMtMjkgIEppZ2VuIFpob3UgIDxqaWdlbi56aG91QHNvbnkuY29tPgor CisgICAgICAgIFtQbGF5c3RhdGlvbl0gRml4IGJ1aWxkIGJyZWFrIGFmdGVyIHIyOTIwNDEgd2hl biBFTkFCTEVfU0VSVklDRV9XT1JLRVIgaXMgb2ZmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzg1MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMjkyMDQx IC8gcjI5MTk3OSBmb3IgUGxheXNhdGlvbiBwbGF0Zm9ybSBidWlsZHMuIAorCisgICAgICAgICog VUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwOgorCiAyMDIyLTAzLTI5 ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0xpYldQ RV0gR3VhcmQgbGlieGtiY29tbW9uIGNvZGUgd2l0aCBXUEVfRU5BQkxFX1hLQgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3Jl LmNwcAppbmRleCAyY2Q3Y2MzZjgzNjQuLjI3MTljMGQ3NTZhNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAK QEAgLTIxMTEsNyArMjExMSw5IEBAIHZvaWQgV2Vic2l0ZURhdGFTdG9yZTo6b3BlbldpbmRvd0Zy b21TZXJ2aWNlV29ya2VyKGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zCiAgICAgICAgICAg ICBjYWxsYmFjayhuZXdQYWdlLT53ZWJQYWdlSUQoKSk7CiAgICAgICAgIH07CiAKKyNpZiBFTkFC TEUoU0VSVklDRV9XT1JLRVIpCiAgICAgICAgIG5ld1BhZ2UtPnNldFNlcnZpY2VXb3JrZXJPcGVu V2luZG93Q29tcGxldGlvbkNhbGxiYWNrKFdURk1vdmUoaW5uZXJDYWxsYmFjaykpOworI2VuZGlm CiAgICAgfTsKIAogICAgIG1fY2xpZW50LT5vcGVuV2luZG93RnJvbVNlcnZpY2VXb3JrZXIodXJs U3RyaW5nLCBzZXJ2aWNlV29ya2VyT3JpZ2luLCBXVEZNb3ZlKGlubmVyQ2FsbGJhY2spKTsK