238490 2022-03-28 22:46:04 -0700 Handle pkg_config and declare_args statements in gni-to-cmake.py 2022-03-29 12:10:19 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kbr kbr annulen dino ews-watchlist gyuyoung.kim kbr kkinnunen kondapallykalyan kpiddington ryuan.choi sergio webkit-bug-importer oldest_to_newest 1855917 0 kbr 2022-03-28 22:46:04 -0700 The Source/ThirdParty/ANGLE/gni-to-cmake.py script doesn't currently handle GN's pkg_config and declare_args statements. They don't need to be fully parsed; simply removing them will eliminate some of the manual fixups needed during each ANGLE roll. 1855925 1 455999 kbr 2022-03-28 22:57:10 -0700 Created attachment 455999 Patch 1855926 2 ews-watchlist 2022-03-28 22:58:49 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1856125 3 ews-feeder 2022-03-29 12:09:19 -0700 Committed r292053 (248990@main): <https://commits.webkit.org/248990@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455999. 1856126 4 webkit-bug-importer 2022-03-29 12:10:19 -0700 <rdar://problem/90997571> 455999 2022-03-28 22:57:10 -0700 2022-03-29 12:09:22 -0700 Patch bug-238490-20220328225709.patch text/plain 2420 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNzUwNzk0NzE5YzdmMmUyYWI3YjQxMDgwM2VlZTI2MGJmZTAyNjZiNy4uMWI1NDU0MzZiYzYw ZWNmMWQxM2JjZWQ5NzYxZDUwYzllZjcyYmM1MiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAzLTI4ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIEhhbmRsZSBwa2dfY29uZmlnIGFuZCBkZWNsYXJlX2FyZ3Mg c3RhdGVtZW50cyBpbiBnbmktdG8tY21ha2UucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODQ5MAorCisgICAgICAgIFJlbW92ZSB0aGVzZSBzdGF0 ZW1lbnRzLCBzaW5jZSB0aGV5IGN1cnJlbnRseSBtdXN0IGJlIGRlbGV0ZWQgZnJvbQorICAgICAg ICB0aGUgcmVzdWx0aW5nIENNYWtlIGZpbGVzIGJ5IGhhbmQuCisKKyAgICAgICAgUmVnZW5lcmF0 ZSB0aGUgQ01ha2UgZmlsZXMgZnJvbSBjdXJyZW50IEFOR0xFIHNvdXJjZXMsIHRvIG1pbmltaXpl CisgICAgICAgIGNoYW5nZXMgZHVyaW5nIHRoZSBuZXh0IHJvbGwuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHTC5jbWFrZToKKyAgICAgICAgKiBn bmktdG8tY21ha2UucHk6CisKIDIwMjItMDMtMjMgIEtlbm5ldGggUnVzc2VsbCAgPGtickBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUm9sbCBBTkdMRSB0byAyMDIyLTAzLTIyIChlN2YyOTQ0MGYw MjUxNDEyNmYzMDM1MGRjZDcxMzJiNjhmNzk1NGQ3KQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvR0wuY21ha2UgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9HTC5jbWFrZQpp bmRleCBlMGMzOWM1ODgyZDIzNWZjNWEyYzJkMWUzMjRmNDc5M2RmMjA0MDI0Li42OWUyNGEwZDRi MjU0NjJlY2MzYzdmOWQwNWExYWE0ZGM5MzQ0NWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9HTC5jbWFrZQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9HTC5jbWFr ZQpAQCAtMTAsNiArMTAsMTIgQEAKIAogCiAKK2lmKGFuZ2xlX2hhc19idWlsZCBBTkQgb3pvbmVf cGxhdGZvcm1fZ2JtKQorCisKK2VuZGlmKCkKKworCiAKIAogc2V0KF9nbF9iYWNrZW5kX3NvdXJj ZXMKQEAgLTE2Myw2ICsxNjksOCBAQCBpZihvem9uZV9wbGF0Zm9ybV9nYm0pCiAgICAgICAgICJz cmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvZWdsL2dibS9TdXJmYWNlR2JtLmNwcCIKICAgICAgICAg InNyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9lZ2wvZ2JtL1N1cmZhY2VHYm0uaCIKICAgICApCisK KwogZW5kaWYoKQogCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2duaS10 by1jbWFrZS5weSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2duaS10by1jbWFrZS5weQppbmRl eCAyMGQ5MzAzZGYxYjUxNGYyYzQ2ZDViMDI2ZDM1OWIxMDg4ZDkwZTFkLi4yNzA2MmQ4OTBjYzJl MTgxZDk1MzAxZGJkZTNjYzMwZDQ0YjVmYmI4IDEwMDc1NQotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9nbmktdG8tY21ha2UucHkKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvZ25p LXRvLWNtYWtlLnB5CkBAIC0zNiw2ICszNiwxNSBAQCB3aXRoIG9wZW4oYXJncy5nbmksICdyJywg ZW5jb2Rpbmc9InV0Zi04IikgYXMgZ25pOgogICAgICAgICBmaWxlLAogICAgICAgICBmbGFncz1y ZS5NVUxUSUxJTkUgfCByZS5ET1RBTEwpCiAKKyAgICAjIFJlbW92ZSBwa2dfY29uZmlnIGFuZCBk ZWNsYXJlX2FyZ3Mgc3RhdGVtZW50cyBhZnRlciByZW1vdmluZyBpbXBvcnQgc3RhdGVtZW50cy4K KyAgICAjIEltcG9ydCBzdGF0ZW1lbnRzIGNhbiByZWZlciB0byBwa2dfY29uZmlnLCBuZWNlc3Nh dGluZyBoYW5kbGluZyB0aGlzIHNlcGFyYXRlbHksCisgICAgIyBhbmQgdGhlIHJlZ2V4cHMgYXJl IHNsaWdodGx5IGRpZmZlcmVudC4KKyAgICBmaWxlID0gcmUuc3ViKAorICAgICAgICByJyheXHMq KHBrZ19jb25maWd8ZGVjbGFyZV9hcmdzKVwoW14pXSpcKVxzK3suKj99JCkqJywKKyAgICAgICAg cicnLAorICAgICAgICBmaWxlLAorICAgICAgICBmbGFncz1yZS5NVUxUSUxJTkUgfCByZS5ET1RB TEwpCisKICAgICAjIFRyYW5zbGF0ZSBnbiBzaW5nbGUgbGluZSBsaXN0IGRlY2xhcmF0aW9uOgog ICAgIGZpbGUgPSByZS5zdWIocidcWyAoKD86IlteIl0qIiw/ICkqKVxdJCcsIHInIFwxKScsIGZp bGUsIGZsYWdzPXJlLk1VTFRJTElORSkKIAo=