238482 2022-03-28 19:48:45 -0700 Build failure with g++ 12: DMIs before end of enclosing class 2022-04-01 12:07:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build All Linux RESOLVED WONTFIX P2 Normal --- 1 mgorse webkit-unassigned achristensen bugs-noreply darin ews-watchlist keith_miller mark.lam mcatanzaro mgorse mliska msaboff saam tzagallo zilla oldest_to_newest 1855888 0 mgorse 2022-03-28 19:48:45 -0700 The build fails (again) with the most recent git revision of gcc 12: /home/mgorse/src/WebKit/Source/JavaScriptCore/runtime/SamplingProfiler.h:135:60: required from here /usr/include/c++/12/type_traits:971:30: error: default member initializer for ‘JSC::SamplingProfiler::StackFrame::CodeLocation::lineNumber’ required by ‘std::is_constructible’ before the end of its enclosing class This is not the only error of this type; WebCore/platform/graphics/ColorInterpolationMethod.h gives a similar error. It is Related to this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96645 1856358 1 mliska 2022-03-30 04:44:24 -0700 The simplest fix would be providing a default constructor as seen here: https://paste.centos.org/view/80fc6f3c 1856475 2 456150 mgorse 2022-03-30 11:01:44 -0700 Created attachment 456150 Patch. 1856481 3 456150 mcatanzaro 2022-03-30 11:05:33 -0700 Comment on attachment 456150 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=456150&action=review > Source/WebCore/platform/graphics/ColorInterpolationMethod.h:64 > + HSL(HueInterpolationMethod method) explicit HSL(HueInterpolationMethod method) 1856482 4 mcatanzaro 2022-03-30 11:06:14 -0700 Complaints from style bot: ERROR: Source/JavaScriptCore/runtime/SamplingProfiler.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/runtime/SamplingProfiler.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/runtime/SamplingProfiler.h:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/ColorInterpolationMethod.h:61: Missing space before }. [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ColorInterpolationMethod.h:65: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] 1856537 5 456169 mgorse 2022-03-30 12:54:10 -0700 Created attachment 456169 Patch. 1856567 6 456169 achristensen 2022-03-30 14:14:54 -0700 Comment on attachment 456169 Patch. Comma location and indentation is not WebKit style even though style bot can't figure that out. I'm not a big fan of this fix (removing initializer lists and adding more explicit constructors is a step in the wrong direction in my opinion). Is there an alternative fix at the instantiation site? 1856727 7 zilla 2022-03-31 01:27:49 -0700 (In reply to Martin Liška from comment #1) > The simplest fix would be providing a default constructor as seen here: > https://paste.centos.org/view/80fc6f3c That paste of mine is about to expire. For posterity, the content is what Mike Gorse attached in comment 2. 1856728 8 zilla 2022-03-31 01:29:32 -0700 (In reply to Alex Christensen from comment #6) > I'm not a big fan of this fix (removing initializer lists and adding more > explicit constructors is a step in the wrong direction in my opinion). Is > there an alternative fix at the instantiation site? No. The problem is that the implicit default ctor needs to check if it should be defined as deleted or not, which means checking the initializers for the non-static data members. What you can do is just add a default ctor and let the default member initializers still do the initialization: --- webkit11.ii 2022-03-30 12:38:21.928429136 +0100 +++ webkit11.ii~ 2022-03-30 12:39:46.985998048 +0100 @@ -240201,6 +240201,8 @@ BytecodeIndex wasmOffset; struct CodeLocation { + CodeLocation() { } + bool hasCodeBlockHash() const { return codeBlockHash.isSet(); Now the default ctor is not implicitly-declared, so the compiler doesn't need to check if it would be well-formed or should be deleted. It's default constructible, period. The actual initialization of the members will still be done by the default initializers defined later in the class. 1856735 9 zilla 2022-03-31 01:38:28 -0700 Yet another option would be to replace the initializers with simpler ones. G++ just got a change to process some initializers immediately, instead of after the class is complete. So: --- webkit11.ii 2022-03-30 12:38:21.928429136 +0100 +++ webkit11.ii~ 2022-03-30 12:39:46.985998048 +0100 @@ -240218,11 +240218,11 @@ } - unsigned lineNumber { std::numeric_limits<unsigned>::max() }; - unsigned columnNumber { std::numeric_limits<unsigned>::max() }; + unsigned lineNumber { UINT_MAX }; + unsigned columnNumber { UINT_MAX }; BytecodeIndex bytecodeIndex; CodeBlockHash codeBlockHash; - JITType jitType { JITType::None }; + JITType jitType { }; bool isRegExp { false }; }; Using the UINT_MAX macro doesn't need to do name lookup, so can be parsed immediately. But yes, it means using a macro not numeric_limits, sorry :-( Alternatively, use { ~0u } to get the all-ones unsigned value. The JITType init works because value-init with {} will init to zero, which happens to be the value of JITType::None. That's a bit fragile if you ever wanted to change the value of None, or wanted to init to a different value. My preference would be the empty default ctor in comment 8. 1856738 10 zilla 2022-03-31 01:39:47 -0700 (In reply to Jonathan Wakely from comment #9) > Alternatively, use { ~0u } to get the all-ones unsigned value. Or { -1u } 1857028 11 456293 mgorse 2022-03-31 15:41:00 -0700 Created attachment 456293 Patch. I think I've fixed the indentation. Also removed the changes to the initializers. 1857034 12 456293 achristensen 2022-03-31 16:13:39 -0700 Comment on attachment 456293 Patch. This now puts redundant information into the header. I like the suggestion in comment 8 better if that works. While I would be fine making a reasonable change, why not just change g++12? 1857251 13 mliska 2022-04-01 07:12:48 -0700 So the GCC 12 change was actually reverted and will be discussed in CWG issue 2335. However, it's likely the change may land again in GCC 13.*: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96645#c24 1857275 14 achristensen 2022-04-01 09:20:26 -0700 Ok. We do often make adjustments to make our code compile on the currently released or previously released and still supported gcc, clang, and msvc, though we try to make those adjustments as elegant as possible. However, if someone wants to support a source-breaking change in a future version of a compiler, the developers of that compiler should probably consider if that's a good idea. 1857276 15 zilla 2022-04-01 09:21:20 -0700 Even if the source being broken is ill-formed or undefined according to the C++ standard? 1857277 16 achristensen 2022-04-01 09:23:36 -0700 If gcc, clang, and msvc all successfully compile a piece of code and have for years, then we should consider changing the C++ standard. I'd be happy to write a proposal if this is the case. In this case, I don't oppose fixing our code. I just would like to do that in a way that doesn't add redundant information. 1857282 17 456367 mgorse 2022-04-01 09:37:46 -0700 Created attachment 456367 Patch. Sorry--I'd misunderstood what Jonathan was suggesting there. I've tweaked the patch a bit. It does not build if I don't also add the implicit constructor. But I'm not strongly opposed to marking this wontfix, given that the gcc change has been reverted, although it may come up again in the future. 1857292 18 456367 darin 2022-04-01 10:02:32 -0700 Comment on attachment 456367 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=456367&action=review > Source/JavaScriptCore/ChangeLog:3 > + Build failure with g++ 12: DMIs before end of enclosing class Is this a feature in gcc, or a bug? I am not happy with these changes! 1857303 19 achristensen 2022-04-01 10:28:25 -0700 This is the most acceptable version of these changes yet, but let's plan to not fix this with the possibility of revisiting if GCC13 insists that they really want to break this code. 1857319 20 mgorse 2022-04-01 11:04:33 -0700 The comment on the revert does suggest that the standard needs a fix. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96645#c24 1857354 21 mcatanzaro 2022-04-01 12:07:33 -0700 Well the patch is appreciated anyway, in case other distros wind up needing it. Nice that you caught this and let the GCC developers know, even before GCC 12 was released! 456150 2022-03-30 11:01:44 -0700 2022-03-30 12:54:10 -0700 Patch. build.patch text/plain 3730 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDczNGRhZDczNWNhMi4uYzU1ZTJhZjc1YjkxIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMy0zMCAgTWlr ZSBHb3JzZSAgPG1nb3JzZUBzdXNlLmNvbT4KKworICAgICAgICBCdWlsZCBmYWlsdXJlIHdpdGgg ZysrIDEyOiBETUlzIGJlZm9yZSBlbmQgb2YgZW5jbG9zaW5nIGNsYXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzg0ODIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvU2FtcGxpbmdQcm9m aWxlci5oOgorICAgICAgICAoSlNDOjpTYW1wbGluZ1Byb2ZpbGVyOjpTdGFja0ZyYW1lOjpDb2Rl TG9jYXRpb246OkNvZGVMb2NhdGlvbik6CisgICAgICAgIEFkZCBkZWZhdWx0IGNvbnN0cnVjdG9y LgorCiAyMDIyLTAzLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmUgb2Jzb2xldGUgLS11c2VQcm9iZU9TUkV4aXQgb3B0aW9uLgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oCmluZGV4IDY0NDE1OTY3 YWI3Zi4uODdlY2JiNGU3YmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TYW1wbGluZ1Byb2ZpbGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU2FtcGxpbmdQcm9maWxlci5oCkBAIC0xMDYsNiArMTA2LDEzIEBAIHB1YmxpYzoKICAgICAg ICAgQnl0ZWNvZGVJbmRleCB3YXNtT2Zmc2V0OwogCiAgICAgICAgIHN0cnVjdCBDb2RlTG9jYXRp b24geworICAgICAgICAgICAgQ29kZUxvY2F0aW9uKCkKKyAgICAgICAgICAgIDogbGluZU51bWJl ciB7IHN0ZDo6bnVtZXJpY19saW1pdHM8dW5zaWduZWQ+OjptYXgoKSB9LAorICAgICAgICAgICAg ICBjb2x1bW5OdW1iZXIgeyBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4KCkgfSwK KyAgICAgICAgICAgICAgaml0VHlwZSB7IEpJVFR5cGU6Ok5vbmUgfSwKKyAgICAgICAgICAgICAg aXNSZWdFeHAgeyBmYWxzZSB9CisgICAgICAgICAgICB7IH0KKwogICAgICAgICAgICAgYm9vbCBo YXNDb2RlQmxvY2tIYXNoKCkgY29uc3QKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICBy ZXR1cm4gY29kZUJsb2NrSGFzaC5pc1NldCgpOwpAQCAtMTIzLDEyICsxMzAsMTIgQEAgcHVibGlj OgogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAvLyBUaGVzZSBhdHRlbXB0IHRvIGJlIGV4 cHJlc3Npb24tbGV2ZWwgbGluZSBhbmQgY29sdW1uIG51bWJlci4KLSAgICAgICAgICAgIHVuc2ln bmVkIGxpbmVOdW1iZXIgeyBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4KCkgfTsK LSAgICAgICAgICAgIHVuc2lnbmVkIGNvbHVtbk51bWJlciB7IHN0ZDo6bnVtZXJpY19saW1pdHM8 dW5zaWduZWQ+OjptYXgoKSB9OworICAgICAgICAgICAgdW5zaWduZWQgbGluZU51bWJlcjsKKyAg ICAgICAgICAgIHVuc2lnbmVkIGNvbHVtbk51bWJlcjsKICAgICAgICAgICAgIEJ5dGVjb2RlSW5k ZXggYnl0ZWNvZGVJbmRleDsKICAgICAgICAgICAgIENvZGVCbG9ja0hhc2ggY29kZUJsb2NrSGFz aDsKLSAgICAgICAgICAgIEpJVFR5cGUgaml0VHlwZSB7IEpJVFR5cGU6Ok5vbmUgfTsKLSAgICAg ICAgICAgIGJvb2wgaXNSZWdFeHAgeyBmYWxzZSB9OworICAgICAgICAgICAgSklUVHlwZSBqaXRU eXBlOworICAgICAgICAgICAgYm9vbCBpc1JlZ0V4cDsKICAgICAgICAgfTsKIAogICAgICAgICBD b2RlTG9jYXRpb24gc2VtYW50aWNMb2NhdGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiZWJhMzI1NmY4Yjcu LjU2YzdmYzcwMDlhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIyLTAzLTMwICBN aWtlIEdvcnNlICA8bWdvcnNlQHN1c2UuY29tPgorCisgICAgICAgIEJ1aWxkIGZhaWx1cmUgd2l0 aCBnKysgMTI6IERNSXMgYmVmb3JlIGVuZCBvZiBlbmNsb3NpbmcgY2xhc3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODQ4MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Q29sb3JJbnRlcnBvbGF0aW9uTWV0aG9kLmg6CisgICAgICAgIChXZWJDb3JlOjpDb2xvckludGVy cG9sYXRpb25NZXRob2Q6OkhTTDo6SFNMKTogQWRkIGNvbnN0cnVjdG9ycy4KKwogMjAyMi0wMy0z MCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBIYXNoVHJh bnNsYXRvciBmb3IgQVNDSUlMaXRlcmFsIGZvciBmYXN0ZXIgbG9va3VwIGluIEhhc2hNYXBzIC8g SGFzaFNldHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Nv bG9ySW50ZXJwb2xhdGlvbk1ldGhvZC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvQ29sb3JJbnRlcnBvbGF0aW9uTWV0aG9kLmgKaW5kZXggZWU2Y2JhMGQxZDNhLi45OTAyNTFk ODJhMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9y SW50ZXJwb2xhdGlvbk1ldGhvZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0NvbG9ySW50ZXJwb2xhdGlvbk1ldGhvZC5oCkBAIC01Nyw5ICs1NywxNyBAQCBlbnVtIGNs YXNzIENvbG9ySW50ZXJwb2xhdGlvbkNvbG9yU3BhY2UgOiB1aW50OF90IHsKICAgICAKIHN0cnVj dCBDb2xvckludGVycG9sYXRpb25NZXRob2QgewogICAgIHN0cnVjdCBIU0wgeworICAgICAgICBI U0woKQorICAgICAgICA6IGh1ZUludGVycG9sYXRpb25NZXRob2QgeyBIdWVJbnRlcnBvbGF0aW9u TWV0aG9kOjpTaG9ydGVyfQorICAgICAgICB7IH0KKworICAgICAgICBIU0woSHVlSW50ZXJwb2xh dGlvbk1ldGhvZCBtZXRob2QpCisgICAgICAgIDogaHVlSW50ZXJwb2xhdGlvbk1ldGhvZChtZXRo b2QpCisgICAgICAgIHsgfQorCiAgICAgICAgIHN0YXRpYyBjb25zdGV4cHIgYXV0byBpbnRlcnBv bGF0aW9uQ29sb3JTcGFjZSA9IENvbG9ySW50ZXJwb2xhdGlvbkNvbG9yU3BhY2U6OkhTTDsKICAg ICAgICAgdXNpbmcgQ29sb3JUeXBlID0gV2ViQ29yZTo6SFNMQTxmbG9hdD47Ci0gICAgICAgIEh1 ZUludGVycG9sYXRpb25NZXRob2QgaHVlSW50ZXJwb2xhdGlvbk1ldGhvZCA9IEh1ZUludGVycG9s YXRpb25NZXRob2Q6OlNob3J0ZXI7CisgICAgICAgIEh1ZUludGVycG9sYXRpb25NZXRob2QgaHVl SW50ZXJwb2xhdGlvbk1ldGhvZDsKICAgICB9OwogICAgIHN0cnVjdCBIV0IgewogICAgICAgICBz dGF0aWMgY29uc3RleHByIGF1dG8gaW50ZXJwb2xhdGlvbkNvbG9yU3BhY2UgPSBDb2xvckludGVy cG9sYXRpb25Db2xvclNwYWNlOjpIV0I7Cg== 456169 2022-03-30 12:54:10 -0700 2022-03-31 15:41:00 -0700 Patch. build.patch text/plain 3738 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDczNGRhZDczNWNhMi4uYzU1ZTJhZjc1YjkxIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMy0zMCAgTWlr ZSBHb3JzZSAgPG1nb3JzZUBzdXNlLmNvbT4KKworICAgICAgICBCdWlsZCBmYWlsdXJlIHdpdGgg ZysrIDEyOiBETUlzIGJlZm9yZSBlbmQgb2YgZW5jbG9zaW5nIGNsYXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzg0ODIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvU2FtcGxpbmdQcm9m aWxlci5oOgorICAgICAgICAoSlNDOjpTYW1wbGluZ1Byb2ZpbGVyOjpTdGFja0ZyYW1lOjpDb2Rl TG9jYXRpb246OkNvZGVMb2NhdGlvbik6CisgICAgICAgIEFkZCBkZWZhdWx0IGNvbnN0cnVjdG9y LgorCiAyMDIyLTAzLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmUgb2Jzb2xldGUgLS11c2VQcm9iZU9TUkV4aXQgb3B0aW9uLgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oCmluZGV4IDY0NDE1OTY3 YWI3Zi4uNzcxMjAwNjg1NzU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TYW1wbGluZ1Byb2ZpbGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU2FtcGxpbmdQcm9maWxlci5oCkBAIC0xMDYsNiArMTA2LDEzIEBAIHB1YmxpYzoKICAgICAg ICAgQnl0ZWNvZGVJbmRleCB3YXNtT2Zmc2V0OwogCiAgICAgICAgIHN0cnVjdCBDb2RlTG9jYXRp b24geworICAgICAgICAgICAgQ29kZUxvY2F0aW9uKCkKKyAgICAgICAgICAgIDogbGluZU51bWJl ciB7IHN0ZDo6bnVtZXJpY19saW1pdHM8dW5zaWduZWQ+OjptYXgoKSB9LAorICAgICAgICAgICAg Y29sdW1uTnVtYmVyIHsgc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpIH0sCisg ICAgICAgICAgICBqaXRUeXBlIHsgSklUVHlwZTo6Tm9uZSB9LAorICAgICAgICAgICAgaXNSZWdF eHAgeyBmYWxzZSB9CisgICAgICAgICAgICB7IH0KKwogICAgICAgICAgICAgYm9vbCBoYXNDb2Rl QmxvY2tIYXNoKCkgY29uc3QKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICByZXR1cm4g Y29kZUJsb2NrSGFzaC5pc1NldCgpOwpAQCAtMTIzLDEyICsxMzAsMTIgQEAgcHVibGljOgogICAg ICAgICAgICAgfQogCiAgICAgICAgICAgICAvLyBUaGVzZSBhdHRlbXB0IHRvIGJlIGV4cHJlc3Np b24tbGV2ZWwgbGluZSBhbmQgY29sdW1uIG51bWJlci4KLSAgICAgICAgICAgIHVuc2lnbmVkIGxp bmVOdW1iZXIgeyBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4KCkgfTsKLSAgICAg ICAgICAgIHVuc2lnbmVkIGNvbHVtbk51bWJlciB7IHN0ZDo6bnVtZXJpY19saW1pdHM8dW5zaWdu ZWQ+OjptYXgoKSB9OworICAgICAgICAgICAgdW5zaWduZWQgbGluZU51bWJlcjsKKyAgICAgICAg ICAgIHVuc2lnbmVkIGNvbHVtbk51bWJlcjsKICAgICAgICAgICAgIEJ5dGVjb2RlSW5kZXggYnl0 ZWNvZGVJbmRleDsKICAgICAgICAgICAgIENvZGVCbG9ja0hhc2ggY29kZUJsb2NrSGFzaDsKLSAg ICAgICAgICAgIEpJVFR5cGUgaml0VHlwZSB7IEpJVFR5cGU6Ok5vbmUgfTsKLSAgICAgICAgICAg IGJvb2wgaXNSZWdFeHAgeyBmYWxzZSB9OworICAgICAgICAgICAgSklUVHlwZSBqaXRUeXBlOwor ICAgICAgICAgICAgYm9vbCBpc1JlZ0V4cDsKICAgICAgICAgfTsKIAogICAgICAgICBDb2RlTG9j YXRpb24gc2VtYW50aWNMb2NhdGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiZWJhMzI1NmY4YjcuLjU2Yzdm YzcwMDlhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIyLTAzLTMwICBNaWtlIEdv cnNlICA8bWdvcnNlQHN1c2UuY29tPgorCisgICAgICAgIEJ1aWxkIGZhaWx1cmUgd2l0aCBnKysg MTI6IERNSXMgYmVmb3JlIGVuZCBvZiBlbmNsb3NpbmcgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODQ4MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JJ bnRlcnBvbGF0aW9uTWV0aG9kLmg6CisgICAgICAgIChXZWJDb3JlOjpDb2xvckludGVycG9sYXRp b25NZXRob2Q6OkhTTDo6SFNMKTogQWRkIGNvbnN0cnVjdG9ycy4KKwogMjAyMi0wMy0zMCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBIYXNoVHJhbnNsYXRv ciBmb3IgQVNDSUlMaXRlcmFsIGZvciBmYXN0ZXIgbG9va3VwIGluIEhhc2hNYXBzIC8gSGFzaFNl dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9ySW50 ZXJwb2xhdGlvbk1ldGhvZC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29s b3JJbnRlcnBvbGF0aW9uTWV0aG9kLmgKaW5kZXggZWU2Y2JhMGQxZDNhLi4yODliMzdkZjc5ZDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9ySW50ZXJw b2xhdGlvbk1ldGhvZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Nv bG9ySW50ZXJwb2xhdGlvbk1ldGhvZC5oCkBAIC01Nyw5ICs1NywxNyBAQCBlbnVtIGNsYXNzIENv bG9ySW50ZXJwb2xhdGlvbkNvbG9yU3BhY2UgOiB1aW50OF90IHsKICAgICAKIHN0cnVjdCBDb2xv ckludGVycG9sYXRpb25NZXRob2QgewogICAgIHN0cnVjdCBIU0wgeworICAgICAgICBIU0woKQor ICAgICAgICA6IGh1ZUludGVycG9sYXRpb25NZXRob2QgeyBIdWVJbnRlcnBvbGF0aW9uTWV0aG9k OjpTaG9ydGVyIH0KKyAgICAgICAgeyB9CisKKyAgICAgICAgZXhwbGljaXQgSFNMKEh1ZUludGVy cG9sYXRpb25NZXRob2QgbWV0aG9kKQorICAgICAgICAgICAgOiBodWVJbnRlcnBvbGF0aW9uTWV0 aG9kKG1ldGhvZCkKKyAgICAgICAgeyB9CisKICAgICAgICAgc3RhdGljIGNvbnN0ZXhwciBhdXRv IGludGVycG9sYXRpb25Db2xvclNwYWNlID0gQ29sb3JJbnRlcnBvbGF0aW9uQ29sb3JTcGFjZTo6 SFNMOwogICAgICAgICB1c2luZyBDb2xvclR5cGUgPSBXZWJDb3JlOjpIU0xBPGZsb2F0PjsKLSAg ICAgICAgSHVlSW50ZXJwb2xhdGlvbk1ldGhvZCBodWVJbnRlcnBvbGF0aW9uTWV0aG9kID0gSHVl SW50ZXJwb2xhdGlvbk1ldGhvZDo6U2hvcnRlcjsKKyAgICAgICAgSHVlSW50ZXJwb2xhdGlvbk1l dGhvZCBodWVJbnRlcnBvbGF0aW9uTWV0aG9kOwogICAgIH07CiAgICAgc3RydWN0IEhXQiB7CiAg ICAgICAgIHN0YXRpYyBjb25zdGV4cHIgYXV0byBpbnRlcnBvbGF0aW9uQ29sb3JTcGFjZSA9IENv bG9ySW50ZXJwb2xhdGlvbkNvbG9yU3BhY2U6OkhXQjsK 456293 2022-03-31 15:41:00 -0700 2022-04-01 09:37:46 -0700 Patch. build.patch text/plain 2991 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDczNGRhZDczNWNhMi4uYzU1ZTJhZjc1YjkxIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMy0zMCAgTWlr ZSBHb3JzZSAgPG1nb3JzZUBzdXNlLmNvbT4KKworICAgICAgICBCdWlsZCBmYWlsdXJlIHdpdGgg ZysrIDEyOiBETUlzIGJlZm9yZSBlbmQgb2YgZW5jbG9zaW5nIGNsYXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzg0ODIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvU2FtcGxpbmdQcm9m aWxlci5oOgorICAgICAgICAoSlNDOjpTYW1wbGluZ1Byb2ZpbGVyOjpTdGFja0ZyYW1lOjpDb2Rl TG9jYXRpb246OkNvZGVMb2NhdGlvbik6CisgICAgICAgIEFkZCBkZWZhdWx0IGNvbnN0cnVjdG9y LgorCiAyMDIyLTAzLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmUgb2Jzb2xldGUgLS11c2VQcm9iZU9TUkV4aXQgb3B0aW9uLgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oCmluZGV4IDY0NDE1OTY3 YWI3Zi4uNGQzMmI0Mjk1MWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TYW1wbGluZ1Byb2ZpbGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU2FtcGxpbmdQcm9maWxlci5oCkBAIC0xMDYsNiArMTA2LDE0IEBAIHB1YmxpYzoKICAgICAg ICAgQnl0ZWNvZGVJbmRleCB3YXNtT2Zmc2V0OwogCiAgICAgICAgIHN0cnVjdCBDb2RlTG9jYXRp b24geworICAgICAgICAgICAgQ29kZUxvY2F0aW9uKCkKKyAgICAgICAgICAgICAgICA6IGxpbmVO dW1iZXIgeyBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4KCkgfQorICAgICAgICAg ICAgICAgICwgY29sdW1uTnVtYmVyIHsgc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1h eCgpIH0KKyAgICAgICAgICAgICAgICAsIGppdFR5cGUgeyBKSVRUeXBlOjpOb25lIH0KKyAgICAg ICAgICAgICAgICAsIGlzUmVnRXhwIHsgZmFsc2UgfQorICAgICAgICAgICAgeyAKKyAgICAgICAg ICAgIH0KKwogICAgICAgICAgICAgYm9vbCBoYXNDb2RlQmxvY2tIYXNoKCkgY29uc3QKICAgICAg ICAgICAgIHsKICAgICAgICAgICAgICAgICByZXR1cm4gY29kZUJsb2NrSGFzaC5pc1NldCgpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IGJlYmEzMjU2ZjhiNy4uNTZjN2ZjNzAwOWE4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMjItMDMtMzAgIE1pa2UgR29yc2UgIDxtZ29yc2VAc3VzZS5jb20+CisK KyAgICAgICAgQnVpbGQgZmFpbHVyZSB3aXRoIGcrKyAxMjogRE1JcyBiZWZvcmUgZW5kIG9mIGVu Y2xvc2luZyBjbGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM4NDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Db2xvckludGVycG9sYXRpb25NZXRob2QuaDoKKyAg ICAgICAgKFdlYkNvcmU6OkNvbG9ySW50ZXJwb2xhdGlvbk1ldGhvZDo6SFNMOjpIU0wpOiBBZGQg Y29uc3RydWN0b3JzLgorCiAyMDIyLTAzLTMwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkIEhhc2hUcmFuc2xhdG9yIGZvciBBU0NJSUxpdGVyYWwgZm9yIGZh c3RlciBsb29rdXAgaW4gSGFzaE1hcHMgLyBIYXNoU2V0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JJbnRlcnBvbGF0aW9uTWV0aG9kLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvckludGVycG9sYXRpb25NZXRob2QuaApp bmRleCBlZTZjYmEwZDFkM2EuLjQ2YWEzODVjODkyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JJbnRlcnBvbGF0aW9uTWV0aG9kLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JJbnRlcnBvbGF0aW9uTWV0aG9kLmgK QEAgLTU3LDYgKzU3LDE2IEBAIGVudW0gY2xhc3MgQ29sb3JJbnRlcnBvbGF0aW9uQ29sb3JTcGFj ZSA6IHVpbnQ4X3QgewogICAgIAogc3RydWN0IENvbG9ySW50ZXJwb2xhdGlvbk1ldGhvZCB7CiAg ICAgc3RydWN0IEhTTCB7CisgICAgICAgIEhTTCgpCisgICAgICAgICAgICA6IGh1ZUludGVycG9s YXRpb25NZXRob2QgeyBIdWVJbnRlcnBvbGF0aW9uTWV0aG9kOjpTaG9ydGVyIH0KKyAgICAgICAg eworICAgICAgICB9CisKKyAgICAgICAgZXhwbGljaXQgSFNMKEh1ZUludGVycG9sYXRpb25NZXRo b2QgbWV0aG9kKQorICAgICAgICAgICAgOiBodWVJbnRlcnBvbGF0aW9uTWV0aG9kKG1ldGhvZCkK KyAgICAgICAgeworICAgICAgICB9CisKICAgICAgICAgc3RhdGljIGNvbnN0ZXhwciBhdXRvIGlu dGVycG9sYXRpb25Db2xvclNwYWNlID0gQ29sb3JJbnRlcnBvbGF0aW9uQ29sb3JTcGFjZTo6SFNM OwogICAgICAgICB1c2luZyBDb2xvclR5cGUgPSBXZWJDb3JlOjpIU0xBPGZsb2F0PjsKICAgICAg ICAgSHVlSW50ZXJwb2xhdGlvbk1ldGhvZCBodWVJbnRlcnBvbGF0aW9uTWV0aG9kID0gSHVlSW50 ZXJwb2xhdGlvbk1ldGhvZDo6U2hvcnRlcjsK 456367 2022-04-01 09:37:46 -0700 2022-04-01 10:28:34 -0700 Patch. build.patch text/plain 2690 mgorse ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDczNGRhZDczNWNhMi4uYzU1ZTJhZjc1YjkxIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMy0zMCAgTWlr ZSBHb3JzZSAgPG1nb3JzZUBzdXNlLmNvbT4KKworICAgICAgICBCdWlsZCBmYWlsdXJlIHdpdGgg ZysrIDEyOiBETUlzIGJlZm9yZSBlbmQgb2YgZW5jbG9zaW5nIGNsYXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzg0ODIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvU2FtcGxpbmdQcm9m aWxlci5oOgorICAgICAgICAoSlNDOjpTYW1wbGluZ1Byb2ZpbGVyOjpTdGFja0ZyYW1lOjpDb2Rl TG9jYXRpb246OkNvZGVMb2NhdGlvbik6CisgICAgICAgIEFkZCBkZWZhdWx0IGNvbnN0cnVjdG9y LgorCiAyMDIyLTAzLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmUgb2Jzb2xldGUgLS11c2VQcm9iZU9TUkV4aXQgb3B0aW9uLgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5oCmluZGV4IDY0NDE1OTY3 YWI3Zi4uMjQ2MDEwZjdlMDUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TYW1wbGluZ1Byb2ZpbGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU2FtcGxpbmdQcm9maWxlci5oCkBAIC0xMDYsNiArMTA2LDEwIEBAIHB1YmxpYzoKICAgICAg ICAgQnl0ZWNvZGVJbmRleCB3YXNtT2Zmc2V0OwogCiAgICAgICAgIHN0cnVjdCBDb2RlTG9jYXRp b24geworICAgICAgICAgICAgQ29kZUxvY2F0aW9uKCkKKyAgICAgICAgICAgIHsgCisgICAgICAg ICAgICB9CisKICAgICAgICAgICAgIGJvb2wgaGFzQ29kZUJsb2NrSGFzaCgpIGNvbnN0CiAgICAg ICAgICAgICB7CiAgICAgICAgICAgICAgICAgcmV0dXJuIGNvZGVCbG9ja0hhc2guaXNTZXQoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZWJhMzI1NmY4YjcuLjU2YzdmYzcwMDlhOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDIyLTAzLTMwICBNaWtlIEdvcnNlICA8bWdvcnNlQHN1c2UuY29tPgor CisgICAgICAgIEJ1aWxkIGZhaWx1cmUgd2l0aCBnKysgMTI6IERNSXMgYmVmb3JlIGVuZCBvZiBl bmNsb3NpbmcgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzODQ4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JJbnRlcnBvbGF0aW9uTWV0aG9kLmg6Cisg ICAgICAgIChXZWJDb3JlOjpDb2xvckludGVycG9sYXRpb25NZXRob2Q6OkhTTDo6SFNMKTogQWRk IGNvbnN0cnVjdG9ycy4KKwogMjAyMi0wMy0zMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCBIYXNoVHJhbnNsYXRvciBmb3IgQVNDSUlMaXRlcmFsIGZvciBm YXN0ZXIgbG9va3VwIGluIEhhc2hNYXBzIC8gSGFzaFNldHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9ySW50ZXJwb2xhdGlvbk1ldGhvZC5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JJbnRlcnBvbGF0aW9uTWV0aG9kLmgK aW5kZXggZWU2Y2JhMGQxZDNhLi4wMTgzNGMxMWI2ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9ySW50ZXJwb2xhdGlvbk1ldGhvZC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9ySW50ZXJwb2xhdGlvbk1ldGhvZC5o CkBAIC01Nyw2ICs1NywxNSBAQCBlbnVtIGNsYXNzIENvbG9ySW50ZXJwb2xhdGlvbkNvbG9yU3Bh Y2UgOiB1aW50OF90IHsKICAgICAKIHN0cnVjdCBDb2xvckludGVycG9sYXRpb25NZXRob2Qgewog ICAgIHN0cnVjdCBIU0wgeworICAgICAgICBIU0woKQorICAgICAgICB7CisgICAgICAgIH0KKwor ICAgICAgICBleHBsaWNpdCBIU0woSHVlSW50ZXJwb2xhdGlvbk1ldGhvZCBtZXRob2QpCisgICAg ICAgICAgICA6IGh1ZUludGVycG9sYXRpb25NZXRob2QobWV0aG9kKQorICAgICAgICB7CisgICAg ICAgIH0KKwogICAgICAgICBzdGF0aWMgY29uc3RleHByIGF1dG8gaW50ZXJwb2xhdGlvbkNvbG9y U3BhY2UgPSBDb2xvckludGVycG9sYXRpb25Db2xvclNwYWNlOjpIU0w7CiAgICAgICAgIHVzaW5n IENvbG9yVHlwZSA9IFdlYkNvcmU6OkhTTEE8ZmxvYXQ+OwogICAgICAgICBIdWVJbnRlcnBvbGF0 aW9uTWV0aG9kIGh1ZUludGVycG9sYXRpb25NZXRob2QgPSBIdWVJbnRlcnBvbGF0aW9uTWV0aG9k OjpTaG9ydGVyOwo=