238481 2022-03-28 19:29:09 -0700 [GLIB] Ubuntu LTS build broken after r291956 2022-03-29 18:59:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino changseok darin esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan mattwoodrow pdr rego svillar webkit-bug-importer oldest_to_newest 1855884 0 dpino 2022-03-28 19:29:09 -0700 [GLIB] Ubuntu LTS build broken after r291956 1855886 1 455982 dpino 2022-03-28 19:40:47 -0700 Created attachment 455982 Patch 1855887 2 dpino 2022-03-28 19:43:42 -0700 Ubuntu LTS build bot error: ``` ../../Source/WebCore/rendering/style/StyleGridData.h:47:59: error: ‘bool WebCore::GridTrackEntrySubgrid::operator==(const WebCore::GridTrackEntrySubgrid&) const’ cannot be defaulted 47 | bool operator==(const GridTrackEntrySubgrid&) const = default; | ^~~~~~~ ../../Source/WebCore/rendering/style/StyleGridData.h:50:58: error: ‘bool WebCore::GridTrackEntryRepeat::operator==(const WebCore::GridTrackEntryRepeat&) const’ cannot be defaulted 50 | bool operator==(const GridTrackEntryRepeat&) const = default; | ^~~~~~~ ../../Source/WebCore/rendering/style/StyleGridData.h:56:62: error: ‘bool WebCore::GridTrackEntryAutoRepeat::operator==(const WebCore::GridTrackEntryAutoRepeat&) const’ cannot be defaulted 56 | bool operator==(const GridTrackEntryAutoRepeat&) const = default; | ^~~~~~~ ``` https://build.webkit.org/#/builders/68/builds/12315/steps/8/logs/stdio 1855923 3 455998 dpino 2022-03-28 22:55:27 -0700 Created attachment 455998 Patch 1856218 4 455998 darin 2022-03-29 15:34:13 -0700 Comment on attachment 455998 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455998&action=review > Source/WebCore/ChangeLog:3 > + [GLIB] Ubuntu LTS build broken after r291956 There should not be a "[GLIB]" prefix on a bug like this. I know our rule might be confusing. A "you used a non-portable feature that GCC doesn’t support yet" bug doesn’t need a platform prefix. Or if it did have one, it would be "[GCC]". 1856258 5 ews-feeder 2022-03-29 17:22:03 -0700 /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 1856261 6 456082 dpino 2022-03-29 17:33:43 -0700 Created attachment 456082 [fast-cq] Patch 1856270 7 ews-feeder 2022-03-29 18:58:14 -0700 Committed r292094 (249014@main): <https://commits.webkit.org/249014@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456082. 1856271 8 webkit-bug-importer 2022-03-29 18:59:17 -0700 <rdar://problem/91018313> 455982 2022-03-28 19:40:47 -0700 2022-03-28 22:55:23 -0700 Patch bug-238481-20220329104045.patch text/plain 2166 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTljZTc0OWZlNjM3MGFm MmE1NTUwNGMwM2ZmMzAwMDg0NjdmNGIyZC4uZTg0ODhkMGYzMDZkYTE2ZjMxZGU3YWMzYWJmYmNl ZTczOGMxNGVjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAzLTI4ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIFVidW50 dSBMVFMgYnVpbGQgYnJva2VuIGFmdGVyIHIyOTE5NTYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODQ4MQorCisgICAgICAgIERlZmF1bHQgY29tcGFy aXNvbnMgYnkgdmFsdWUgKFAxOTQ2UjApIGlzIG9ubHkgc3VwcG9ydGVkIHNpbmNlIEdDQzEwLgor ICAgICAgICBodHRwczovL2VuLmNwcHJlZmVyZW5jZS5jb20vdy9jcHAvY29tcGlsZXJfc3VwcG9y dC8yMAorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0eWxlR3JpZERhdGEuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkdyaWRUcmFja0VudHJ5U3ViZ3JpZDo6b3BlcmF0b3I9PSBjb25zdCk6Cisg ICAgICAgIChXZWJDb3JlOjpHcmlkVHJhY2tFbnRyeVJlcGVhdDo6b3BlcmF0b3I9PSBjb25zdCk6 CisgICAgICAgIChXZWJDb3JlOjpHcmlkVHJhY2tFbnRyeUF1dG9SZXBlYXQ6Om9wZXJhdG9yPT0g Y29uc3QpOgorCiAyMDIyLTAzLTI4ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIG5vbi11bmlmaWVkIGJ1aWxkZml4IGFmdGVyIDI0ODkzOEBt YWluCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVHcmlk RGF0YS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlR3JpZERhdGEuaApp bmRleCAyY2RjYzBlMTVjMTQwZDc3ZmJjZWYyNTg2ZTg1YmNkZjE1MWU5YTEwLi5mMGNhNGQwZWY3 MTg5MTY4NDliZDdkZDE2NWIwNDY4YjRhMWI0MDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVHcmlkRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9TdHlsZUdyaWREYXRhLmgKQEAgLTQ0LDE2ICs0NCwyNSBAQCB0eXBlZGVm IHN0ZDo6dmFyaWFudDxHcmlkVHJhY2tTaXplLCBWZWN0b3I8U3RyaW5nPj4gUmVwZWF0RW50cnk7 CiB0eXBlZGVmIFZlY3RvcjxSZXBlYXRFbnRyeT4gUmVwZWF0VHJhY2tMaXN0OwogCiBzdHJ1Y3Qg R3JpZFRyYWNrRW50cnlTdWJncmlkIHsKLSAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgR3JpZFRy YWNrRW50cnlTdWJncmlkJikgY29uc3QgPSBkZWZhdWx0OworICAgIGJvb2wgb3BlcmF0b3I9PShj b25zdCBHcmlkVHJhY2tFbnRyeVN1YmdyaWQmIG90aGVyKSBjb25zdAorICAgIHsKKyAgICAgICAg cmV0dXJuICp0aGlzID09IG90aGVyOworICAgIH0KIH07CiBzdHJ1Y3QgR3JpZFRyYWNrRW50cnlS ZXBlYXQgewotICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBHcmlkVHJhY2tFbnRyeVJlcGVhdCYp IGNvbnN0ID0gZGVmYXVsdDsKKyAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgR3JpZFRyYWNrRW50 cnlSZXBlYXQmIG90aGVyKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIHJlcGVhdHMgPT0g b3RoZXIucmVwZWF0cyAmJiBsaXN0ID09IG90aGVyLmxpc3Q7CisgICAgfQogCiAgICAgdW5zaWdu ZWQgcmVwZWF0czsKICAgICBSZXBlYXRUcmFja0xpc3QgbGlzdDsKIH07CiBzdHJ1Y3QgR3JpZFRy YWNrRW50cnlBdXRvUmVwZWF0IHsKLSAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgR3JpZFRyYWNr RW50cnlBdXRvUmVwZWF0JikgY29uc3QgPSBkZWZhdWx0OworICAgIGJvb2wgb3BlcmF0b3I9PShj b25zdCBHcmlkVHJhY2tFbnRyeUF1dG9SZXBlYXQmIG90aGVyKSBjb25zdAorICAgIHsKKyAgICAg ICAgcmV0dXJuIHR5cGUgPT0gb3RoZXIudHlwZSAmJiBsaXN0ID09IG90aGVyLmxpc3Q7CisgICAg fQogCiAgICAgQXV0b1JlcGVhdFR5cGUgdHlwZTsKICAgICBSZXBlYXRUcmFja0xpc3QgbGlzdDsK 455998 2022-03-28 22:55:27 -0700 2022-03-29 17:33:38 -0700 Patch bug-238481-20220329135526.patch text/plain 2150 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTljZTc0OWZlNjM3MGFm MmE1NTUwNGMwM2ZmMzAwMDg0NjdmNGIyZC4uZTg0ODhkMGYzMDZkYTE2ZjMxZGU3YWMzYWJmYmNl ZTczOGMxNGVjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAzLTI4ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIFVidW50 dSBMVFMgYnVpbGQgYnJva2VuIGFmdGVyIHIyOTE5NTYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODQ4MQorCisgICAgICAgIERlZmF1bHQgY29tcGFy aXNvbnMgYnkgdmFsdWUgKFAxOTQ2UjApIGlzIG9ubHkgc3VwcG9ydGVkIHNpbmNlIEdDQzEwLgor ICAgICAgICBodHRwczovL2VuLmNwcHJlZmVyZW5jZS5jb20vdy9jcHAvY29tcGlsZXJfc3VwcG9y dC8yMAorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0eWxlR3JpZERhdGEuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkdyaWRUcmFja0VudHJ5U3ViZ3JpZDo6b3BlcmF0b3I9PSBjb25zdCk6Cisg ICAgICAgIChXZWJDb3JlOjpHcmlkVHJhY2tFbnRyeVJlcGVhdDo6b3BlcmF0b3I9PSBjb25zdCk6 CisgICAgICAgIChXZWJDb3JlOjpHcmlkVHJhY2tFbnRyeUF1dG9SZXBlYXQ6Om9wZXJhdG9yPT0g Y29uc3QpOgorCiAyMDIyLTAzLTI4ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIG5vbi11bmlmaWVkIGJ1aWxkZml4IGFmdGVyIDI0ODkzOEBt YWluCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVHcmlk RGF0YS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlR3JpZERhdGEuaApp bmRleCAyY2RjYzBlMTVjMTQwZDc3ZmJjZWYyNTg2ZTg1YmNkZjE1MWU5YTEwLi42ZjNkYjVmODgw MmExYTdhYjg5NmQ5OGQ5OGUyMGRmMGNjZWI4M2E2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVHcmlkRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9TdHlsZUdyaWREYXRhLmgKQEAgLTQ0LDE2ICs0NCwyNSBAQCB0eXBlZGVm IHN0ZDo6dmFyaWFudDxHcmlkVHJhY2tTaXplLCBWZWN0b3I8U3RyaW5nPj4gUmVwZWF0RW50cnk7 CiB0eXBlZGVmIFZlY3RvcjxSZXBlYXRFbnRyeT4gUmVwZWF0VHJhY2tMaXN0OwogCiBzdHJ1Y3Qg R3JpZFRyYWNrRW50cnlTdWJncmlkIHsKLSAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgR3JpZFRy YWNrRW50cnlTdWJncmlkJikgY29uc3QgPSBkZWZhdWx0OworICAgIGJvb2wgb3BlcmF0b3I9PShj b25zdCBHcmlkVHJhY2tFbnRyeVN1YmdyaWQmKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJu IHRydWU7CisgICAgfQogfTsKIHN0cnVjdCBHcmlkVHJhY2tFbnRyeVJlcGVhdCB7Ci0gICAgYm9v bCBvcGVyYXRvcj09KGNvbnN0IEdyaWRUcmFja0VudHJ5UmVwZWF0JikgY29uc3QgPSBkZWZhdWx0 OworICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBHcmlkVHJhY2tFbnRyeVJlcGVhdCYgb3RoZXIp IGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gcmVwZWF0cyA9PSBvdGhlci5yZXBlYXRzICYm IGxpc3QgPT0gb3RoZXIubGlzdDsKKyAgICB9CiAKICAgICB1bnNpZ25lZCByZXBlYXRzOwogICAg IFJlcGVhdFRyYWNrTGlzdCBsaXN0OwogfTsKIHN0cnVjdCBHcmlkVHJhY2tFbnRyeUF1dG9SZXBl YXQgewotICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBHcmlkVHJhY2tFbnRyeUF1dG9SZXBlYXQm KSBjb25zdCA9IGRlZmF1bHQ7CisgICAgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEdyaWRUcmFja0Vu dHJ5QXV0b1JlcGVhdCYgb3RoZXIpIGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gdHlwZSA9 PSBvdGhlci50eXBlICYmIGxpc3QgPT0gb3RoZXIubGlzdDsKKyAgICB9CiAKICAgICBBdXRvUmVw ZWF0VHlwZSB0eXBlOwogICAgIFJlcGVhdFRyYWNrTGlzdCBsaXN0Owo= 456082 2022-03-29 17:33:43 -0700 2022-03-29 18:58:15 -0700 [fast-cq] Patch bug-238481-20220330083341.patch text/plain 2185 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTljZTc0OWZlNjM3MGFm MmE1NTUwNGMwM2ZmMzAwMDg0NjdmNGIyZC4uMDkzOGQyMmUxZWQ2NTY5MTgyZjZlODg5NDg5N2Nj NjlkMmJhMDMwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTI4ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dDQ10gVWJ1bnR1 IExUUyBidWlsZCBicm9rZW4gYWZ0ZXIgcjI5MTk1NgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4NDgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCisKKyAgICAgICAgRGVmYXVsdCBjb21wYXJpc29ucyBieSB2YWx1ZSAoUDE5NDZS MCkgaXMgb25seSBzdXBwb3J0ZWQgc2luY2UgR0NDMTAuCisgICAgICAgIGh0dHBzOi8vZW4uY3Bw cmVmZXJlbmNlLmNvbS93L2NwcC9jb21waWxlcl9zdXBwb3J0LzIwCisKKyAgICAgICAgKiByZW5k ZXJpbmcvc3R5bGUvU3R5bGVHcmlkRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6R3JpZFRyYWNr RW50cnlTdWJncmlkOjpvcGVyYXRvcj09IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkdyaWRU cmFja0VudHJ5UmVwZWF0OjpvcGVyYXRvcj09IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6Okdy aWRUcmFja0VudHJ5QXV0b1JlcGVhdDo6b3BlcmF0b3I9PSBjb25zdCk6CisKIDIwMjItMDMtMjgg IExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg bm9uLXVuaWZpZWQgYnVpbGRmaXggYWZ0ZXIgMjQ4OTM4QG1haW4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZUdyaWREYXRhLmggYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVHcmlkRGF0YS5oCmluZGV4IDJjZGNjMGUxNWMxNDBkNzdm YmNlZjI1ODZlODViY2RmMTUxZTlhMTAuLjZmM2RiNWY4ODAyYTFhN2FiODk2ZDk4ZDk4ZTIwZGYw Y2NlYjgzYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHls ZUdyaWREYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlR3Jp ZERhdGEuaApAQCAtNDQsMTYgKzQ0LDI1IEBAIHR5cGVkZWYgc3RkOjp2YXJpYW50PEdyaWRUcmFj a1NpemUsIFZlY3RvcjxTdHJpbmc+PiBSZXBlYXRFbnRyeTsKIHR5cGVkZWYgVmVjdG9yPFJlcGVh dEVudHJ5PiBSZXBlYXRUcmFja0xpc3Q7CiAKIHN0cnVjdCBHcmlkVHJhY2tFbnRyeVN1YmdyaWQg ewotICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBHcmlkVHJhY2tFbnRyeVN1YmdyaWQmKSBjb25z dCA9IGRlZmF1bHQ7CisgICAgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEdyaWRUcmFja0VudHJ5U3Vi Z3JpZCYpIGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CiB9Owogc3Ry dWN0IEdyaWRUcmFja0VudHJ5UmVwZWF0IHsKLSAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgR3Jp ZFRyYWNrRW50cnlSZXBlYXQmKSBjb25zdCA9IGRlZmF1bHQ7CisgICAgYm9vbCBvcGVyYXRvcj09 KGNvbnN0IEdyaWRUcmFja0VudHJ5UmVwZWF0JiBvdGhlcikgY29uc3QKKyAgICB7CisgICAgICAg IHJldHVybiByZXBlYXRzID09IG90aGVyLnJlcGVhdHMgJiYgbGlzdCA9PSBvdGhlci5saXN0Owor ICAgIH0KIAogICAgIHVuc2lnbmVkIHJlcGVhdHM7CiAgICAgUmVwZWF0VHJhY2tMaXN0IGxpc3Q7 CiB9Owogc3RydWN0IEdyaWRUcmFja0VudHJ5QXV0b1JlcGVhdCB7Ci0gICAgYm9vbCBvcGVyYXRv cj09KGNvbnN0IEdyaWRUcmFja0VudHJ5QXV0b1JlcGVhdCYpIGNvbnN0ID0gZGVmYXVsdDsKKyAg ICBib29sIG9wZXJhdG9yPT0oY29uc3QgR3JpZFRyYWNrRW50cnlBdXRvUmVwZWF0JiBvdGhlcikg Y29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiB0eXBlID09IG90aGVyLnR5cGUgJiYgbGlzdCA9 PSBvdGhlci5saXN0OworICAgIH0KIAogICAgIEF1dG9SZXBlYXRUeXBlIHR5cGU7CiAgICAgUmVw ZWF0VHJhY2tMaXN0IGxpc3Q7Cg==