238475 2022-03-28 16:01:01 -0700 UTF-8 handling in MediaFragmentURIParser::parseFragments() seems wrong 2024-01-14 16:59:31 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=238408 https://www.w3.org/2008/WebVideo/Fragments/WD-media-fragments-spec/#processing-name-value-components InRadar P2 Normal --- 1 cdumez webkit-unassigned ahmad.saleem792 annevk darin eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1855819 0 cdumez 2022-03-28 16:01:01 -0700 UTF-8 handling in MediaFragmentURIParser::parseFragments() seems wrong: ``` // b. Convert name and value to Unicode strings by interpreting them as UTF-8. If either // name or value are not valid UTF-8 strings, then remove the name-value pair from the list. bool validUTF8 = false; if (!name.isEmpty() && !value.isEmpty()) { name = String { name.utf8(StrictConversion).data() }; validUTF8 = !name.isEmpty(); if (validUTF8) { value = String { value.utf8(StrictConversion).data() }; validUTF8 = !value.isEmpty(); } } ``` Note that `String { }` parses the input string as latin1, not UTF-8. So we're converting to UTF-8 and then back as latin1. 1855828 1 cdumez 2022-03-28 16:15:43 -0700 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/media_fragment_seek.html seems to be this only WPT test we have that exercises this logic, but doesn't actually seem to cover UTF-8 cases. 1855830 2 cdumez 2022-03-28 16:23:55 -0700 (In reply to Chris Dumez from comment #1) > imported/w3c/web-platform-tests/html/semantics/embedded-content/media- > elements/media_fragment_seek.html seems to be this only WPT test we have > that exercises this logic, but doesn't actually seem to cover UTF-8 cases. Looks like there are quite a few related tests in media/media-fragments though. 1858127 3 webkit-bug-importer 2022-04-04 16:01:15 -0700 <rdar://problem/91266173>