238471 2022-03-28 14:47:16 -0700 [Playstation] Fix build break after r291979 if ENABLE_SERVICE_WORKER is off 2022-03-29 10:33:14 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jigen.zhou jigen.zhou don.olmstead webkit-bug-importer oldest_to_newest 1855782 0 jigen.zhou 2022-03-28 14:47:16 -0700 After r291979, the following build errors occur when ENABLE_SERVICE_WORKER is off: In file included from WebKit/DerivedSources/unified-sources/UnifiedSource-88d1702b-4.cpp:10: C:/work/webkit/jenkins/neko/Source/WebKit\UIProcess/WebPageProxy.cpp:4915:9: error: use of undeclared identifier 'm_serviceWorkerOpenWindowCompletionCallback' if (m_serviceWorkerOpenWindowCompletionCallback) ^ C:/work/webkit/jenkins/neko/Source/WebKit\UIProcess/WebPageProxy.cpp:4916:9: error: use of undeclared identifier 'm_serviceWorkerOpenWindowCompletionCallback' m_serviceWorkerOpenWindowCompletionCallback(success); ^ 2 errors generated. 1855792 1 455958 jigen.zhou 2022-03-28 15:06:27 -0700 Created attachment 455958 Patch 1856082 2 ews-feeder 2022-03-29 10:32:04 -0700 Committed r292041 (248981@main): <https://commits.webkit.org/248981@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455958. 1856084 3 webkit-bug-importer 2022-03-29 10:33:14 -0700 <rdar://problem/90991068> 455958 2022-03-28 15:06:27 -0700 2022-03-29 10:32:11 -0700 Patch Patch text/plain 1517 jigen.zhou ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNDllYmE5NzVhNzMyLi5kNDk2ZjQ4NTliOWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMjItMDMtMjggIEppZ2VuIFpob3UgIDxqaWdlbi56aG91QHNvbnkuY29tPgor CisgICAgICAgIFtQbGF5c3RhdGlvbl0gRml4IGJ1aWxkIGJyZWFrIGFmdGVyIHIyOTE5NzkgaWYg RU5BQkxFX1NFUlZJQ0VfV09SS0VSIGlzIG9mZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4NDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnVpbGQgZml4IGZvciBwbGF5c3RhdGlvbiBwbGF0Zm9ybSBh ZnRlciByMjkxOTc5IHRvIHN1cHBvcnQgU2VydmljZVdvcmtlckNsaWVudHMub3BlbldpbmRvdy4g CisgICAgICAgIFRoaXMgcGF0Y2ggcmVzb2x2ZXMgY29tcGlsaW5nIGVycm9ycyBvY2N1cnMgaW4g V2ViUGFnZVByb3h5OjpjYWxsTG9hZENvbXBsZXRpb25IYW5kbGVyc0lmTmVjZXNzYXJ5IAorICAg ICAgICBpZiBFTkFCTEVfU0VSVklDRV9XT1JLRVIgaXMgb2ZmLgorCisgICAgICAgICogVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisKIDIwMjItMDMtMjggIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAogICAgICAgICBQcmVwYXJlIFdlYkNvcmUgZm9yIG1ha2luZyB0aGUgU3Ry aW5nKGNvbnN0IGNoYXIqKSBjb25zdHJ1Y3RvciBleHBsaWNpdApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggMjY5NzhhNGQ1MmQyLi44ZmUyMTEwOGRkMTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNDk0OSwxMCArNDk0 OSwxMCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6Y2FsbExvYWRDb21wbGV0aW9uSGFuZGxlcnNJZk5l Y2Vzc2FyeShib29sIHN1Y2Nlc3MpCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQogICAgIGlm IChtX2lzU2VydmljZVdvcmtlclBhZ2UgJiYgbV9zZXJ2aWNlV29ya2VyTGF1bmNoQ29tcGxldGlv bkhhbmRsZXIgJiYgIXN1Y2Nlc3MpCiAgICAgICAgIG1fc2VydmljZVdvcmtlckxhdW5jaENvbXBs ZXRpb25IYW5kbGVyKGZhbHNlKTsKLSNlbmRpZgogCiAgICAgaWYgKG1fc2VydmljZVdvcmtlck9w ZW5XaW5kb3dDb21wbGV0aW9uQ2FsbGJhY2spCiAgICAgICAgIG1fc2VydmljZVdvcmtlck9wZW5X aW5kb3dDb21wbGV0aW9uQ2FsbGJhY2soc3VjY2Vzcyk7CisjZW5kaWYKIH0KIAogI2lmIEVOQUJM RShJTlRFTExJR0VOVF9UUkFDS0lOR19QUkVWRU5USU9OKQo=