238465 2022-03-28 13:00:59 -0700 WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1 2022-03-29 12:11:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan mmaxfield pdr simon.fraser zalan oldest_to_newest 1855738 0 zalan 2022-03-28 13:00:59 -0700 <rdar://80630664> 1855740 1 455947 zalan 2022-03-28 13:04:01 -0700 Created attachment 455947 Patch 1856044 2 455947 koivisto 2022-03-29 09:30:32 -0700 Comment on attachment 455947 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455947&action=review > Source/WebCore/rendering/LegacyRootInlineBox.cpp:363 > - if (!gridLineHeight) > + if (gridLineHeight < 1) could this be if (!roundToInt(gridLineHeight)) ? 1856053 3 zalan 2022-03-29 09:52:57 -0700 (In reply to Antti Koivisto from comment #2) > Comment on attachment 455947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455947&action=review > > > Source/WebCore/rendering/LegacyRootInlineBox.cpp:363 > > - if (!gridLineHeight) > > + if (gridLineHeight < 1) > > could this be > > if (!roundToInt(gridLineHeight)) > > ? yes! 1856088 4 456043 zalan 2022-03-29 10:44:27 -0700 Created attachment 456043 Patch 1856127 5 ews-feeder 2022-03-29 12:11:16 -0700 Committed r292054 (248991@main): <https://commits.webkit.org/248991@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456043. 455947 2022-03-28 13:04:01 -0700 2022-03-29 10:44:24 -0700 Patch bug-238465-20220328130401.patch text/plain 1771 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNlNjFiZDZjZWRlOTUy ODg2YzQ0YWEzNzE5NTQ1MjBjM2JjNjM0OC4uYTFjNjAzNzNlZjMyMjFjYjY4ODZmYTBlNzA2ZDFm YWU3MDIxMGU5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAzLTI4ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpMZWdhY3lSb290 SW5saW5lQm94OjpsaW5lU25hcEFkanVzdG1lbnQgc2hvdWxkIGJhaWwgb3V0IG9uIGdyaWQgbGlu ZSBoZWlnaHQgPCAxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzg0NjUKKyAgICAgICAgPHJkYXI6Ly84MDYzMDY2ND4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgIWdyaWRMaW5lSGVpZ2h0IGNoZWNr IHdhcyBhZGRlZCB0byBhdm9pZCBkaXZpc2lvbiBieSB6ZXJvIGJ1dCB0aGUgaW50ZWdyYWwgcm91 bmRUb0ludCgpIG1heSBhbHNvIHByb2R1Y2UgYSAwIHZhbHVlIGZvcgorICAgICAgICBncmlkTGlu ZUhlaWdodC4KKworICAgICAgICAqIHJlbmRlcmluZy9MZWdhY3lSb290SW5saW5lQm94LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkxlZ2FjeVJvb3RJbmxpbmVCb3g6OmxpbmVTbmFwQWRqdXN0bWVu dCBjb25zdCk6CisKIDIwMjItMDMtMjQgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNv bT4KIAogICAgICAgICBTYWZhcmkgY2FuJ3QgcGxheSB2aWRlbyBjb21wbGV0ZWx5IGF0IGJpbGli aWxpLmNvbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xlZ2FjeVJvb3RJ bmxpbmVCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xlZ2FjeVJvb3RJbmxpbmVC b3guY3BwCmluZGV4IDVlYjI5YTI4NTIwYzUxYTViNjA0YzUzZjZkMjhhMGM4NmJhODgwYzIuLmFh YmNkNWFlMTgzMTRhOGQzMGY2ZDczMTM2NDhhZTgwYzc1NDQ4NWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9MZWdhY3lSb290SW5saW5lQm94LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvTGVnYWN5Um9vdElubGluZUJveC5jcHAKQEAgLTM2MCw3ICszNjAs NyBAQCBMYXlvdXRVbml0IExlZ2FjeVJvb3RJbmxpbmVCb3g6OmxpbmVTbmFwQWRqdXN0bWVudChM YXlvdXRVbml0IGRlbHRhKSBjb25zdAogICAgIC8vIEZJWE1FOiBOZWVkIHRvIGhhbmRsZSBjcmF6 eSBsaW5lLWJveC1jb250YWluIHZhbHVlcyB0aGF0IGNhdXNlIHRoZSByb290IGxpbmUgYm94IHRv IG5vdCBiZSBjb25zaWRlcmVkLiBJIGFzc3VtZQogICAgIC8vIHRoZSBncmlkIHNob3VsZCBob25v ciBsaW5lLWJveC1jb250YWluLgogICAgIExheW91dFVuaXQgZ3JpZExpbmVIZWlnaHQgPSBsaW5l R3JpZEJveC0+bGluZUJveEJvdHRvbSgpIC0gbGluZUdyaWRCb3gtPmxpbmVCb3hUb3AoKTsKLSAg ICBpZiAoIWdyaWRMaW5lSGVpZ2h0KQorICAgIGlmIChncmlkTGluZUhlaWdodCA8IDEpCiAgICAg ICAgIHJldHVybiAwOwogCiAgICAgTGF5b3V0VW5pdCBsaW5lR3JpZEZvbnRBc2NlbnQgPSBsaW5l R3JpZC0+c3R5bGUoKS5tZXRyaWNzT2ZQcmltYXJ5Rm9udCgpLmFzY2VudChiYXNlbGluZVR5cGUo KSk7Cg== 456043 2022-03-29 10:44:27 -0700 2022-03-29 12:11:18 -0700 Patch bug-238465-20220329104426.patch text/plain 1778 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxOTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ExY2UwNmU5YTg5YWZl ODk5M2UwM2U5ZmIyYzZlNThhNzZmMjQ2My4uYzAxYzY1Y2QzZmFiNzkxY2MzZTgzMmEzOTliZGY0 MGY5Y2E5NjVjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAzLTI5ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpMZWdhY3lSb290 SW5saW5lQm94OjpsaW5lU25hcEFkanVzdG1lbnQgc2hvdWxkIGJhaWwgb3V0IG9uIGdyaWQgbGlu ZSBoZWlnaHQgPCAxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzg0NjUKKyAgICAgICAgPHJkYXI6Ly84MDYzMDY2ND4KKworICAgICAgICBSZXZpZXdl ZCBieSBBbnR0aSBLb2l2aXN0by4KKworICAgICAgICBUaGUgIWdyaWRMaW5lSGVpZ2h0IGNoZWNr IHdhcyBhZGRlZCB0byBhdm9pZCBkaXZpc2lvbiBieSB6ZXJvIGJ1dCB0aGUgaW50ZWdyYWwgcm91 bmRUb0ludCgpIG1heSBhbHNvIHByb2R1Y2UgYSAwIHZhbHVlIGZvcgorICAgICAgICBncmlkTGlu ZUhlaWdodC4KKworICAgICAgICAqIHJlbmRlcmluZy9MZWdhY3lSb290SW5saW5lQm94LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkxlZ2FjeVJvb3RJbmxpbmVCb3g6OmxpbmVTbmFwQWRqdXN0bWVu dCBjb25zdCk6CisKIDIwMjItMDMtMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBVc2UgU3RyaW5nVmlldyBmb3IgWWFyciAvIFJlZ3VsYXJFeHByZXNzaW9uIHBh cnNpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MZWdhY3lSb290SW5s aW5lQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MZWdhY3lSb290SW5saW5lQm94 LmNwcAppbmRleCBlODNiNTJmMDkyZWYwNjI2NGRjYzQ3NmQwNDJjMzdmODhkNGU3YzJmLi45MmE4 OGVjNjJiZmM4NDhlYTdhYmQxN2IxNTMyNGJmNDU0NGM1YjFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvTGVnYWN5Um9vdElubGluZUJveC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0xlZ2FjeVJvb3RJbmxpbmVCb3guY3BwCkBAIC0zNjAsNyArMzYwLDcg QEAgTGF5b3V0VW5pdCBMZWdhY3lSb290SW5saW5lQm94OjpsaW5lU25hcEFkanVzdG1lbnQoTGF5 b3V0VW5pdCBkZWx0YSkgY29uc3QKICAgICAvLyBGSVhNRTogTmVlZCB0byBoYW5kbGUgY3Jhenkg bGluZS1ib3gtY29udGFpbiB2YWx1ZXMgdGhhdCBjYXVzZSB0aGUgcm9vdCBsaW5lIGJveCB0byBu b3QgYmUgY29uc2lkZXJlZC4gSSBhc3N1bWUKICAgICAvLyB0aGUgZ3JpZCBzaG91bGQgaG9ub3Ig bGluZS1ib3gtY29udGFpbi4KICAgICBMYXlvdXRVbml0IGdyaWRMaW5lSGVpZ2h0ID0gbGluZUdy aWRCb3gtPmxpbmVCb3hCb3R0b20oKSAtIGxpbmVHcmlkQm94LT5saW5lQm94VG9wKCk7Ci0gICAg aWYgKCFncmlkTGluZUhlaWdodCkKKyAgICBpZiAoIXJvdW5kVG9JbnQoZ3JpZExpbmVIZWlnaHQp KQogICAgICAgICByZXR1cm4gMDsKIAogICAgIExheW91dFVuaXQgbGluZUdyaWRGb250QXNjZW50 ID0gbGluZUdyaWQtPnN0eWxlKCkubWV0cmljc09mUHJpbWFyeUZvbnQoKS5hc2NlbnQoYmFzZWxp bmVUeXBlKCkpOwo=