238446 2022-03-28 04:37:47 -0700 Issues with WPT exporter 2022-03-28 09:29:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 216330 1 noam noam ews-watchlist glenn gsnedders jbedard webkit-bug-importer youennf oldest_to_newest 1855539 0 noam 2022-03-28 04:37:47 -0700 See https://bugs.webkit.org/show_bug.cgi?id=238373 Applying a patch from a bug doesn't do the right thing: - It requires a \n at the end (https://bugs.webkit.org/show_bug.cgi?id=216603) - It sometimes doesn't fetch the correct master branch, rather something from December 2021 - It thinks it needs to add -expected.html Trying to run this command: ./Tools/Scripts/export-w3c-test-changes -b 238373 1855556 1 455906 noam 2022-03-28 05:40:27 -0700 Created attachment 455906 Patch 1855568 2 455906 youennf 2022-03-28 06:24:42 -0700 Comment on attachment 455906 Patch Looks good but some webkitpy tests are failing. Can you double check the tests (hopefully just a rebase). 1855582 3 455912 noam 2022-03-28 06:45:19 -0700 Created attachment 455912 Patch 1855583 4 noam 2022-03-28 06:49:00 -0700 (In reply to youenn fablet from comment #2) > Comment on attachment 455906 [details] > Patch > > Looks good but some webkitpy tests are failing. > Can you double check the tests (hopefully just a rebase). Done, needed to add -3 to the test. 1855620 5 ews-feeder 2022-03-28 08:14:24 -0700 Committed r291966 (248931@main): <https://commits.webkit.org/248931@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455912. 1855621 6 webkit-bug-importer 2022-03-28 08:15:17 -0700 <rdar://problem/90922769> 1855635 7 ntim 2022-03-28 09:29:31 -0700 *** Bug 216603 has been marked as a duplicate of this bug. *** 1855637 8 ntim 2022-03-28 09:29:40 -0700 *** Bug 216330 has been marked as a duplicate of this bug. *** 455906 2022-03-28 05:40:27 -0700 2022-03-28 06:45:14 -0700 Patch bug-238446-20220328154025.patch text/plain 2484 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxOTUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODgzZDMxMmJlNmE4Y2Y2NTdjMWEyMjYyODdhODE2OTc0 MjZmMDFjMS4uYjFlYzUxMTEzZGNlYTU2Zjc1MTg2OWMzOTk3NDllY2IzY2U4NDBhYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIyLTAzLTI4ICBOb2FtIFJvc2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAg ICAgICBJc3N1ZXMgd2l0aCBXUFQgZXhwb3J0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODQ0NgorCisgICAgICAgIEFsc28gYWRkcmVzc2VzIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYzMzAKKyAgICAgICAgYW5k IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY2MDMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaXNzdWVzIHdpdGgg V1BUIGV4cG9ydGVyOgorICAgICAgICAtIElnbm9yZSAqLWV4cGVjdGVkLmh0bWwgZmlsZXMKKyAg ICAgICAgLSBQZXJmb3JtIGEgMy13YXkgbWVyZ2Ugd2hlbiBhcHBseWluZyBwYXRjaAorICAgICAg ICAtIEFkZCBhIG5ld2xpbmUgYXQgdGhlIGVuZCBvZiB0aGUgcGF0Y2gKKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0ZXIucHk6CisgICAgICAgIChXZWJQbGF0Zm9y bVRlc3RFeHBvcnRlci5fc3RyaXBfaWdub3JlZF9maWxlc19mcm9tX2RpZmYpOgorICAgICAgICAo V2ViUGxhdGZvcm1UZXN0RXhwb3J0ZXIuY3JlYXRlX2JyYW5jaF93aXRoX3BhdGNoKToKKwogMjAy Mi0wMy0yNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAg ICAgIFtXZWJHUFVdIEltcG9ydCBXZWJHUFUgQ29uZm9ybWFuY2UgVGVzdCBTdWl0ZQpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9leHBvcnRlci5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0ZXIucHkKaW5kZXggMjFiOGRhY2I4OGMx MTZiZmI1ZDg0OGMyOTA5YmJiOWYwODdkMjY0OS4uNGI5NTY0ZTg4NWQ2OTQyOTc0MTYwNGQyN2Vm Mzc1YTFlYTRlZGNjZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVz dF9leHBvcnRlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2V4cG9y dGVyLnB5CkBAIC01Miw3ICs1Miw3IEBAIFdFQktJVF9XUFRfRElSID0gJ0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMnCiBXUFRfUFJfVVJMID0gIiVzL3B1bGwvIiAl IFdQVF9HSF9VUkwKIFdFQktJVF9FWFBPUlRfUFJfTEFCRUwgPSAnd2Via2l0LWV4cG9ydCcKIAot RVhDTFVERURfRklMRV9TVUZGSVhFUyA9IFsnLWV4cGVjdGVkLnR4dCcsICcud29ya2VyLmh0bWwn LCAnLmFueS5odG1sJywgJy5hbnkud29ya2VyLmh0bWwnLCAndzNjLWltcG9ydC5sb2cnXQorRVhD TFVERURfRklMRV9TVUZGSVhFUyA9IFsnLWV4cGVjdGVkLnR4dCcsICctZXhwZWN0ZWQuaHRtbCcs ICcud29ya2VyLmh0bWwnLCAnLmFueS5odG1sJywgJy5hbnkud29ya2VyLmh0bWwnLCAndzNjLWlt cG9ydC5sb2cnXQogCiAKIGNsYXNzIFdlYlBsYXRmb3JtVGVzdEV4cG9ydGVyKG9iamVjdCk6CkBA IC0xNzksNyArMTc5LDcgQEAgY2xhc3MgV2ViUGxhdGZvcm1UZXN0RXhwb3J0ZXIob2JqZWN0KToK ICAgICAgICAgICAgIGlmIGluY2x1ZGVfZmlsZToKICAgICAgICAgICAgICAgICBuZXdfbGluZXMu YXBwZW5kKGxpbmUpCiAKLSAgICAgICAgcmV0dXJuIGInXG4nLmpvaW4obmV3X2xpbmVzKQorICAg ICAgICByZXR1cm4gYidcbicuam9pbihuZXdfbGluZXMpICsgYidcbicKIAogICAgIGRlZiB3cml0 ZV9naXRfcGF0Y2hfZmlsZShzZWxmKToKICAgICAgICAgXywgcGF0Y2hfZmlsZSA9IHNlbGYuX2Zp bGVzeXN0ZW0ub3Blbl9iaW5hcnlfdGVtcGZpbGUoJ3dwdF9leHBvcnRfcGF0Y2gnKQpAQCAtMzA0 LDcgKzMwNCw3IEBAIGNsYXNzIFdlYlBsYXRmb3JtVGVzdEV4cG9ydGVyKG9iamVjdCk6CiAgICAg ICAgICAgICBzZWxmLl9naXQuZGVsZXRlX2JyYW5jaChzZWxmLl9icmFuY2hfbmFtZSkKICAgICAg ICAgICAgIHNlbGYuX2dpdC5jaGVja291dF9uZXdfYnJhbmNoKHNlbGYuX2JyYW5jaF9uYW1lKQog ICAgICAgICB0cnk6Ci0gICAgICAgICAgICBzZWxmLl9naXQuYXBwbHlfbWFpbF9wYXRjaChbcGF0 Y2hdKQorICAgICAgICAgICAgc2VsZi5fZ2l0LmFwcGx5X21haWxfcGF0Y2goWyctMycsIHBhdGNo XSkKICAgICAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgogICAgICAgICAgICAgX2xvZy53YXJu aW5nKGUpCiAgICAgICAgICAgICByZXR1cm4gRmFsc2UK 455912 2022-03-28 06:45:19 -0700 2022-03-28 08:14:26 -0700 Patch bug-238446-20220328164517.patch text/plain 3768 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxOTUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODgzZDMxMmJlNmE4Y2Y2NTdjMWEyMjYyODdhODE2OTc0 MjZmMDFjMS4uNzc4NzU2NzQzNDZhNjJkZTY3NmM2NzU3YTBhZjJhNGE1ZmIwNDNkMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIyLTAzLTI4ICBOb2FtIFJvc2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAg ICAgICBJc3N1ZXMgd2l0aCBXUFQgZXhwb3J0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODQ0NgorCisgICAgICAgIEFsc28gYWRkcmVzc2VzIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYzMzAKKyAgICAgICAgYW5k IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY2MDMKKworICAgICAg ICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgIEZpeCBpc3N1ZXMgd2l0aCBX UFQgZXhwb3J0ZXI6CisgICAgICAgIC0gSWdub3JlICotZXhwZWN0ZWQuaHRtbCBmaWxlcworICAg ICAgICAtIFBlcmZvcm0gYSAzLXdheSBtZXJnZSB3aGVuIGFwcGx5aW5nIHBhdGNoCisgICAgICAg IC0gQWRkIGEgbmV3bGluZSBhdCB0aGUgZW5kIG9mIHRoZSBwYXRjaAorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS93M2MvdGVzdF9leHBvcnRlci5weToKKyAgICAgICAgKFdlYlBsYXRmb3Jt VGVzdEV4cG9ydGVyLl9zdHJpcF9pZ25vcmVkX2ZpbGVzX2Zyb21fZGlmZik6CisgICAgICAgIChX ZWJQbGF0Zm9ybVRlc3RFeHBvcnRlci5jcmVhdGVfYnJhbmNoX3dpdGhfcGF0Y2gpOgorCiAyMDIy LTAzLTI2ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAg ICAgW1dlYkdQVV0gSW1wb3J0IFdlYkdQVSBDb25mb3JtYW5jZSBUZXN0IFN1aXRlCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2V4cG9ydGVyLnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9leHBvcnRlci5weQppbmRleCAyMWI4ZGFjYjg4YzEx NmJmYjVkODQ4YzI5MDliYmI5ZjA4N2QyNjQ5Li42NmM1NzkyYWViNjNjZjYzYmVkZjMxYjJlZmZl NWJkMjViYzc5MjZiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0 X2V4cG9ydGVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0 ZXIucHkKQEAgLTUyLDcgKzUyLDcgQEAgV0VCS0lUX1dQVF9ESVIgPSAnTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cycKIFdQVF9QUl9VUkwgPSAiJXMvcHVsbC8iICUg V1BUX0dIX1VSTAogV0VCS0lUX0VYUE9SVF9QUl9MQUJFTCA9ICd3ZWJraXQtZXhwb3J0JwogCi1F WENMVURFRF9GSUxFX1NVRkZJWEVTID0gWyctZXhwZWN0ZWQudHh0JywgJy53b3JrZXIuaHRtbCcs ICcuYW55Lmh0bWwnLCAnLmFueS53b3JrZXIuaHRtbCcsICd3M2MtaW1wb3J0LmxvZyddCitFWENM VURFRF9GSUxFX1NVRkZJWEVTID0gWyctZXhwZWN0ZWQudHh0JywgJy1leHBlY3RlZC5odG1sJywg Jy53b3JrZXIuaHRtbCcsICcuYW55Lmh0bWwnLCAnLmFueS53b3JrZXIuaHRtbCcsICd3M2MtaW1w b3J0LmxvZyddCiAKIAogY2xhc3MgV2ViUGxhdGZvcm1UZXN0RXhwb3J0ZXIob2JqZWN0KToKQEAg LTE3OSw3ICsxNzksNyBAQCBjbGFzcyBXZWJQbGF0Zm9ybVRlc3RFeHBvcnRlcihvYmplY3QpOgog ICAgICAgICAgICAgaWYgaW5jbHVkZV9maWxlOgogICAgICAgICAgICAgICAgIG5ld19saW5lcy5h cHBlbmQobGluZSkKIAotICAgICAgICByZXR1cm4gYidcbicuam9pbihuZXdfbGluZXMpCisgICAg ICAgIHJldHVybiBiJ1xuJy5qb2luKG5ld19saW5lcykgKyBiJ1xuJwogCiAgICAgZGVmIHdyaXRl X2dpdF9wYXRjaF9maWxlKHNlbGYpOgogICAgICAgICBfLCBwYXRjaF9maWxlID0gc2VsZi5fZmls ZXN5c3RlbS5vcGVuX2JpbmFyeV90ZW1wZmlsZSgnd3B0X2V4cG9ydF9wYXRjaCcpCkBAIC0zMDQs NyArMzA0LDcgQEAgY2xhc3MgV2ViUGxhdGZvcm1UZXN0RXhwb3J0ZXIob2JqZWN0KToKICAgICAg ICAgICAgIHNlbGYuX2dpdC5kZWxldGVfYnJhbmNoKHNlbGYuX2JyYW5jaF9uYW1lKQogICAgICAg ICAgICAgc2VsZi5fZ2l0LmNoZWNrb3V0X25ld19icmFuY2goc2VsZi5fYnJhbmNoX25hbWUpCiAg ICAgICAgIHRyeToKLSAgICAgICAgICAgIHNlbGYuX2dpdC5hcHBseV9tYWlsX3BhdGNoKFtwYXRj aF0pCisgICAgICAgICAgICBzZWxmLl9naXQuYXBwbHlfbWFpbF9wYXRjaChbcGF0Y2gsICctMydd KQogICAgICAgICBleGNlcHQgRXhjZXB0aW9uIGFzIGU6CiAgICAgICAgICAgICBfbG9nLndhcm5p bmcoZSkKICAgICAgICAgICAgIHJldHVybiBGYWxzZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS93M2MvdGVzdF9leHBvcnRlcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0ZXJfdW5pdHRlc3QucHkKaW5kZXggMDE3ODQ1YzM0Nzkw Y2Y2ZGQ2NWMzZmQ5NDlmZmMxMjM1NTQ1NTE5OC4uY2Y4ZGJhNDQxNTQ4YjYwODVlOTEwYWVlMTFj YjI1ODU1OTg4OWNkNSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVz dF9leHBvcnRlcl91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90 ZXN0X2V4cG9ydGVyX3VuaXR0ZXN0LnB5CkBAIC0xMzgsNyArMTM4LDcgQEAgY2xhc3MgVGVzdEV4 cG9ydGVyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAnY2hlY2tvdXQgbWFz dGVyJywKICAgICAgICAgICAgICdyZXNldCBoYXJkIG9yaWdpbi9tYXN0ZXInLAogICAgICAgICAg ICAgJ2NoZWNrb3V0IG5ldyBicmFuY2ggd3B0LWV4cG9ydC1mb3Itd2Via2l0LTEyMzQnLAotICAg ICAgICAgICAgJ2FwcGx5X21haWxfcGF0Y2ggcGF0Y2gudGVtcCAnLAorICAgICAgICAgICAgJ2Fw cGx5X21haWxfcGF0Y2ggcGF0Y2gudGVtcCAtMycsCiAgICAgICAgICAgICAnY29tbWl0IC1hIC1t IFdlYktpdCBleHBvcnQgb2YgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMzQnLAogICAgICAgICAgICAgJ3JlbW90ZSAnLAogICAgICAgICAgICAgJ3JlbW90ZSBhZGQg VVNFUiBodHRwczovL1VTRVJAZ2l0aHViLmNvbS9VU0VSL3dwdC5naXQnLApAQCAtMTY2LDcgKzE2 Niw3IEBAIGNsYXNzIFRlc3RFeHBvcnRlclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAg ICAgICAgJ2NoZWNrb3V0IG1hc3RlcicsCiAgICAgICAgICAgICAncmVzZXQgaGFyZCBvcmlnaW4v bWFzdGVyJywKICAgICAgICAgICAgICdjaGVja291dCBuZXcgYnJhbmNoIHdwdC1leHBvcnQtZm9y LXdlYmtpdC0xMjM0JywKLSAgICAgICAgICAgICdhcHBseV9tYWlsX3BhdGNoIHBhdGNoLnRlbXAg JywKKyAgICAgICAgICAgICdhcHBseV9tYWlsX3BhdGNoIHBhdGNoLnRlbXAgLTMnLAogICAgICAg ICAgICAgJ2NvbW1pdCAtYSAtbSBXZWJLaXQgZXhwb3J0IG9mIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0JywKICAgICAgICAgICAgICdyZW1vdGUgJywKICAgICAg ICAgICAgICdyZW1vdGUgYWRkIFVTRVIgaHR0cHM6Ly9VU0VSQGdpdGh1Yi5jb20vVVNFUi93cHQu Z2l0JywK