23844 2009-02-09 03:14:32 -0800 Storage panel should show details about parent domains 2009-03-01 08:43:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 rik webkit-unassigned aroben kmccullough mike timothy yael oldest_to_newest 108960 0 rik 2009-02-09 03:14:32 -0800 The new details about sessionStorage and localStorage are really cool. It would be more powerful if it can show the parent domains. The use case is a website with URLs like pseudo.example.org. Storage is done on example.org in order to access it on every subdomains (by changing the document.domain property). When on pseudo.example.org, the web inspector should list storages on pseudo.example.org and example.org. 109058 1 yael 2009-02-09 17:12:00 -0800 (In reply to comment #0) > The new details about sessionStorage and localStorage are really cool. > > It would be more powerful if it can show the parent domains. > > The use case is a website with URLs like pseudo.example.org. Storage is done on > example.org in order to access it on every subdomains (by changing the > document.domain property). When on pseudo.example.org, the web inspector should > list storages on pseudo.example.org and example.org. > Do you have a URL to a test case that I could use? I could not create a test case in which WebKit used the parent url instead of the page url. thanks! 109110 2 27518 rik 2009-02-10 06:53:35 -0800 Created attachment 27518 Testcase Creating the testcase, I've seen a related bug. When you open the inspector, it uses the actual document.domain (that can be modified with JS) to chose which localStorage is viewed. I think the best is to show every subdomain possible. 111438 3 yael 2009-02-27 07:42:31 -0800 According to Anne Van Kesteren (I asked on IRC), localStorage should not be affected by document.domain. It was my mistake to get the host name from the Security Origin instead of the URL. I will fix that shortly. The same should be for databases. 111631 4 28120 yael 2009-02-28 10:35:58 -0800 Created attachment 28120 Use securityOrigin->host() instead of securityOrigin->domain() for display databases, localStorage and sessionStorage are all grouped by databaseIdentifier. And that is based on the host, scheme and port, it is more accurate to display the host, and not the domain. 111712 5 timothy 2009-03-01 08:43:03 -0800 Landed in r41334. 27518 2009-02-10 06:53:35 -0800 2009-02-10 06:53:35 -0800 Testcase demo.html text/html 432 rik PHNjcmlwdD4KbG9jYWxTdG9yYWdlW2RvY3VtZW50LmRvbWFpbiArICcgOiB3ZWJraXQnXSA9ICdy b3hvciBzdWJkb21haW4nOwpkb2N1bWVudC5kb21haW4gPSBkb2N1bWVudC5kb21haW4ubWF0Y2go L14uKj8oW14uL10rWy5dW14uL10rKSQvKVsxXTsKbG9jYWxTdG9yYWdlW2RvY3VtZW50LmRvbWFp biArICcgOiB3ZWJraXQnXSA9ICdyb3hvciBtYWluIGRvbWFpbic7Cjwvc2NyaXB0Pgo8cD5SdW4g dGhpcyBzY3JpcHQgb24gcHNldWRvLmV4YW1wbGUub3JnPC9wPgo8cD5JZiB5b3Ugb3BlbiB0aGUg aW5zcGVjdG9yIGJlZm9yZSBydW5uaW5nLCB5b3UnbGwgc2VlIHRoZSBsb2NhbFN0b3JhZ2Ugb2Yg cHNldWRvLmV4YW1wbGUub3JnIC4gSWYgeW91IG9wZW4gaXQgYWZ0ZXIsIHlvdSdsbCBzZWUgdGhl IGxvY2FsU3RvcmFnZSBvZiBleGFtcGxlLm9yZzwvcD4K 28120 2009-02-28 10:35:58 -0800 2009-02-28 11:06:11 -0800 Use securityOrigin->host() instead of securityOrigin->domain() for display domain.patch text/plain 3140 yael SW5kZXg6IFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9zdG9yYWdlL0RhdGFiYXNlLmNwcAkocmV2aXNpb24gNDEyOTApCisrKyBXZWJDb3JlL3N0b3Jh Z2UvRGF0YWJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTQsNyArMTE0LDcgQEAKICAgICBk b2N1bWVudC0+c2V0SGFzT3BlbkRhdGFiYXNlcygpOwogCiAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBk b2N1bWVudC0+ZnJhbWUoKS0+cGFnZSgpKQotICAgICAgICBwYWdlLT5pbnNwZWN0b3JDb250cm9s bGVyKCktPmRpZE9wZW5EYXRhYmFzZShkYXRhYmFzZS5nZXQoKSwgZG9jdW1lbnQtPmRvbWFpbigp LCBuYW1lLCBleHBlY3RlZFZlcnNpb24pOworICAgICAgICBwYWdlLT5pbnNwZWN0b3JDb250cm9s bGVyKCktPmRpZE9wZW5EYXRhYmFzZShkYXRhYmFzZS5nZXQoKSwgZG9jdW1lbnQtPnNlY3VyaXR5 T3JpZ2luKCktPmhvc3QoKSwgbmFtZSwgZXhwZWN0ZWRWZXJzaW9uKTsKIAogICAgIHJldHVybiBk YXRhYmFzZTsKIH0KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA0MTMxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMDItMjggIFlhZWwgQWhhcm9uICA8eWFl bC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzg0 NAorICAgICAgICBQYXNzIHNlY3VyaXR5T3JpZ2luLT5ob3N0KCkgaW5zdGVhZCBvZiBzZWN1cml0 eU9yaWdpbi0+ZG9tYWluKCkgdG8gV2ViSW5zcGVjdG9yCisgICAgICAgIHdoZW4gY3JlYXRpbmcg ZGF0YWJhc2VzLCBsb2NhbFN0b3JhZ2Ugb3Igc2Vzc2lvblN0b3JhZ2UuCisgICAgICAgIENoYW5n aW5nIGRvY3VtZW50LmRvbWFpbiBzaG91bGQgaGF2ZSBubyBhZmZlY3Qgb24gZGF0YWJhc2VzLCBs b2NhbFN0b3JhZ2UgYW5kCisgICAgICAgIHNlc3Npb25TdG9yYWdlIGRpc3BsYXkgaW4gV2ViIElu c3BlY3Rvci4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmFkZERPTVN0b3JhZ2VTY3Jp cHRSZXNvdXJjZSk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpkaWRV c2VET01TdG9yYWdlKToKKyAgICAgICAgKiBzdG9yYWdlL0RhdGFiYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRhdGFiYXNlOjpvcGVuRGF0YWJhc2UpOgorCiAyMDA5LTAyLTI4ICBBZGFtIEJl cmdrdmlzdCA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNDEyOTApCisrKyBXZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI5NSw3ICsyMjk1LDcg QEAKICAgICAgICAgZG9tU3RvcmFnZSA9IHRvUmVmKEpTSW5zcGVjdGVkT2JqZWN0V3JhcHBlcjo6 d3JhcChleGVjLCB0b0pTKGV4ZWMsIHJlc291cmNlLT5kb21TdG9yYWdlLmdldCgpKSkpOwogICAg IH0KIAotICAgIEpTVmFsdWVSZWYgZG9tYWluVmFsdWUgPSBKU1ZhbHVlTWFrZVN0cmluZyhtX3Nj cmlwdENvbnRleHQsIGpzU3RyaW5nUmVmKHJlc291cmNlLT5mcmFtZS0+ZG9jdW1lbnQoKS0+c2Vj dXJpdHlPcmlnaW4oKS0+ZG9tYWluKCkpLmdldCgpKTsKKyAgICBKU1ZhbHVlUmVmIGRvbWFpblZh bHVlID0gSlNWYWx1ZU1ha2VTdHJpbmcobV9zY3JpcHRDb250ZXh0LCBqc1N0cmluZ1JlZihyZXNv dXJjZS0+ZnJhbWUtPmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2luKCktPmhvc3QoKSkuZ2V0KCkp OwogICAgIEpTVmFsdWVSZWYgaXNMb2NhbFN0b3JhZ2VWYWx1ZSA9IEpTVmFsdWVNYWtlQm9vbGVh bihtX3NjcmlwdENvbnRleHQsIHJlc291cmNlLT5pc0xvY2FsU3RvcmFnZSk7CiAKICAgICBKU1Zh bHVlUmVmIGFyZ3VtZW50c1tdID0geyBkb21TdG9yYWdlLCBkb21haW5WYWx1ZSwgaXNMb2NhbFN0 b3JhZ2VWYWx1ZSB9OwpAQCAtMjczNCw3ICsyNzM0LDcgQEAKICAgICBET01TdG9yYWdlUmVzb3Vy Y2VzU2V0OjppdGVyYXRvciBkb21TdG9yYWdlRW5kID0gbV9kb21TdG9yYWdlUmVzb3VyY2VzLmVu ZCgpOwogICAgIGZvciAoRE9NU3RvcmFnZVJlc291cmNlc1NldDo6aXRlcmF0b3IgaXQgPSBtX2Rv bVN0b3JhZ2VSZXNvdXJjZXMuYmVnaW4oKTsgaXQgIT0gZG9tU3RvcmFnZUVuZDsgKytpdCkgewog ICAgICAgICBJbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2UqIHJlc291cmNlID0gaXQtPmdldCgp OwotICAgICAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UocmVzb3VyY2UtPmZyYW1lLT5kb2N1bWVu dCgpLT5zZWN1cml0eU9yaWdpbigpLT5kb21haW4oKSwgZnJhbWUtPmRvY3VtZW50KCktPnNlY3Vy aXR5T3JpZ2luKCktPmRvbWFpbigpKSAmJiByZXNvdXJjZS0+aXNMb2NhbFN0b3JhZ2UgPT0gaXNM b2NhbFN0b3JhZ2UpCisgICAgICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShyZXNvdXJjZS0+ZnJh bWUtPmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2luKCktPmhvc3QoKSwgZnJhbWUtPmRvY3VtZW50 KCktPnNlY3VyaXR5T3JpZ2luKCktPmhvc3QoKSkgJiYgcmVzb3VyY2UtPmlzTG9jYWxTdG9yYWdl ID09IGlzTG9jYWxTdG9yYWdlKQogICAgICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBSZWZQ dHI8U3RvcmFnZT4gZG9tU3RvcmFnZSA9IFN0b3JhZ2U6OmNyZWF0ZShmcmFtZSwgc3RvcmFnZUFy ZWEpOwo=