238422 2022-03-26 16:26:18 -0700 Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp 2022-03-28 07:15:21 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen cdumez darin ggaren webkit-bug-importer oldest_to_newest 1855426 0 cdumez 2022-03-26 16:26:18 -0700 Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp and inline its implementation in the only caller instead. 1855427 1 455859 cdumez 2022-03-26 16:27:20 -0700 Created attachment 455859 Patch 1855435 2 455859 peng.liu6 2022-03-26 21:01:35 -0700 Comment on attachment 455859 Patch Nice cleanup. 1855437 3 455859 cdumez 2022-03-26 22:04:19 -0700 Comment on attachment 455859 Patch Thanks for reviewing! 1855438 4 ews-feeder 2022-03-26 22:04:43 -0700 peng.liu6@icloud.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 455859 from commit queue. 1855439 5 cdumez 2022-03-26 22:05:37 -0700 (In reply to EWS from comment #4) > peng.liu6@icloud.com does not have reviewer permissions according to > https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors. > json. > > Rejecting attachment 455859 [details] from commit queue. Looks like you will need to update your email in contributors.json Peng. 1855592 6 cdumez 2022-03-28 07:14:17 -0700 Committed r291963 (248928@trunk): <https://commits.webkit.org/248928@trunk> 1855594 7 webkit-bug-importer 2022-03-28 07:15:21 -0700 <rdar://problem/90920497> 455859 2022-03-26 16:27:20 -0700 2022-03-26 22:04:44 -0700 Patch bug-238422-20220326162719.patch text/plain 2885 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxOTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI1MzcyZjE0ZmFhMTQw NjMwZGY0YzYzMzcwZmQ1MTE3YWE4MmVhNi4uZWY3MmJkMmU4YjNkYTZiNTdhNGMzYzY3NDhkNTgx YTAwNGExZmRkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAzLTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCB1bm5lY2Vzc2FyeSBp c1JlYWNoYWJsZUZyb21ET00oKSBmdW5jdGlvbiBpbiBKU05vZGVDdXN0b20uY3BwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzg0MjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIHVubmVjZXNzYXJ5 IGlzUmVhY2hhYmxlRnJvbURPTSgpIGZ1bmN0aW9uIGluIEpTTm9kZUN1c3RvbS5jcHAgYW5kIGlu bGluZSBpdHMgaW1wbGVtZW50YXRpb24gaW4gdGhlIG9ubHkgY2FsbGVyIGluc3RlYWQuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9qcy9KU05vZGVDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SlNOb2RlT3duZXI6OmlzUmVhY2hhYmxlRnJvbU9wYXF1ZVJvb3RzKToKKyAgICAgICAgKFdlYkNv cmU6OmlzUmVhY2hhYmxlRnJvbURPTSk6IERlbGV0ZWQuCisKIDIwMjItMDMtMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBTZXJ2aWNlV29y a2VyV2luZG93Q2xpZW50LmZvY3VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU05vZGVDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNOb2Rl Q3VzdG9tLmNwcAppbmRleCAyYjY1MzExYWY2MzIwMjI4YzRlMzA1MThkNDhjNjkyMmFjZjYwODk3 Li4xMzcwZWZjOTc5NzE2YTkwODQxMmZmYTU2MTYyZTBkZDc0MjUzMjlmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU05vZGVDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9kZUN1c3RvbS5jcHAKQEAgLTY0LDE3ICs2NCwxOCBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiB1c2luZyBuYW1lc3BhY2UgSlNDOwogdXNpbmcgbmFtZXNwYWNl IEhUTUxOYW1lczsKIAotc3RhdGljIGlubGluZSBib29sIGlzUmVhY2hhYmxlRnJvbURPTShOb2Rl KiBub2RlLCBBYnN0cmFjdFNsb3RWaXNpdG9yJiB2aXNpdG9yLCBjb25zdCBjaGFyKiogcmVhc29u KQorYm9vbCBKU05vZGVPd25lcjo6aXNSZWFjaGFibGVGcm9tT3BhcXVlUm9vdHMoSlNDOjpIYW5k bGU8SlNDOjpVbmtub3duPiBoYW5kbGUsIHZvaWQqLCBBYnN0cmFjdFNsb3RWaXNpdG9yJiB2aXNp dG9yLCBjb25zdCBjaGFyKiogcmVhc29uKQogewotICAgIGlmICghbm9kZS0+aXNDb25uZWN0ZWQo KSkgeworICAgIGF1dG8mIG5vZGUgPSBqc0Nhc3Q8SlNOb2RlKj4oaGFuZGxlLnNsb3QoKS0+YXND ZWxsKCkpLT53cmFwcGVkKCk7CisgICAgaWYgKCFub2RlLmlzQ29ubmVjdGVkKCkpIHsKICAgICAg ICAgLy8gSWYgYSBub2RlIGlzIGZpcmluZyBldmVudCBsaXN0ZW5lcnMsIGl0cyB3cmFwcGVyIGlz IG9ic2VydmFibGUgYmVjYXVzZQogICAgICAgICAvLyBpdHMgd3JhcHBlciBpcyByZXNwb25zaWJs ZSBmb3IgbWFya2luZyB0aG9zZSBldmVudCBsaXN0ZW5lcnMuCi0gICAgICAgIGlmIChub2RlLT5p c0ZpcmluZ0V2ZW50TGlzdGVuZXJzKCkpIHsKKyAgICAgICAgaWYgKG5vZGUuaXNGaXJpbmdFdmVu dExpc3RlbmVycygpKSB7CiAgICAgICAgICAgICBpZiAoVU5MSUtFTFkocmVhc29uKSkKICAgICAg ICAgICAgICAgICAqcmVhc29uID0gIk5vZGUgd2hpY2ggaXMgZmlyaW5nIGV2ZW50IGxpc3RlbmVy cyI7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQotICAgICAgICBpZiAoR0NS ZWFjaGFibGVSZWZNYXA6OmNvbnRhaW5zKCpub2RlKSkgeworICAgICAgICBpZiAoR0NSZWFjaGFi bGVSZWZNYXA6OmNvbnRhaW5zKG5vZGUpKSB7CiAgICAgICAgICAgICBpZiAoVU5MSUtFTFkocmVh c29uKSkKICAgICAgICAgICAgICAgICAqcmVhc29uID0gIk5vZGUgaXMgc2NoZWR1bGVkIHRvIGJl IHVzZWQgaW4gYW4gYXN5bmMgc2NyaXB0IGludm9jYXRpb24pIjsKICAgICAgICAgICAgIHJldHVy biB0cnVlOwpAQCAtODcsMTIgKzg4LDYgQEAgc3RhdGljIGlubGluZSBib29sIGlzUmVhY2hhYmxl RnJvbURPTShOb2RlKiBub2RlLCBBYnN0cmFjdFNsb3RWaXNpdG9yJiB2aXNpdG9yLAogICAgIHJl dHVybiB2aXNpdG9yLmNvbnRhaW5zT3BhcXVlUm9vdChyb290KG5vZGUpKTsKIH0KIAotYm9vbCBK U05vZGVPd25lcjo6aXNSZWFjaGFibGVGcm9tT3BhcXVlUm9vdHMoSlNDOjpIYW5kbGU8SlNDOjpV bmtub3duPiBoYW5kbGUsIHZvaWQqLCBBYnN0cmFjdFNsb3RWaXNpdG9yJiB2aXNpdG9yLCBjb25z dCBjaGFyKiogcmVhc29uKQotewotICAgIEpTTm9kZSoganNOb2RlID0ganNDYXN0PEpTTm9kZSo+ KGhhbmRsZS5zbG90KCktPmFzQ2VsbCgpKTsKLSAgICByZXR1cm4gaXNSZWFjaGFibGVGcm9tRE9N KCZqc05vZGUtPndyYXBwZWQoKSwgdmlzaXRvciwgcmVhc29uKTsKLX0KLQogSlNTY29wZSogSlNO b2RlOjpwdXNoRXZlbnRIYW5kbGVyU2NvcGUoSlNHbG9iYWxPYmplY3QqIGxleGljYWxHbG9iYWxP YmplY3QsIEpTU2NvcGUqIG5vZGUpIGNvbnN0CiB7CiAgICAgaWYgKGluaGVyaXRzPEpTSFRNTEVs ZW1lbnQ+KGxleGljYWxHbG9iYWxPYmplY3QtPnZtKCkpKQo=