238376 2022-03-25 08:41:46 -0700 Drop duplicate isFiringEventListeners check in Node wrappers' isReachableFromOpaqueRoots() 2022-03-25 13:34:18 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=238380 InRadar P2 Normal --- 1 cdumez cdumez cdumez darin ggaren sam webkit-bug-importer oldest_to_newest 1855096 0 cdumez 2022-03-25 08:41:46 -0700 Drop duplicate isFiringEventListeners check Node wrapper's isReachableFromOpaqueRoots(). Those wrappers already call JSNodeOwner::isReachableFromOpaqueRoots() which already takes care of checking the isFiringEventListeners flag. 1855097 1 455766 cdumez 2022-03-25 08:44:06 -0700 Created attachment 455766 Patch 1855188 2 455766 ggaren 2022-03-25 12:00:04 -0700 Comment on attachment 455766 Patch r=me 1855222 3 ews-feeder 2022-03-25 13:33:42 -0700 Committed r291883 (248882@main): <https://commits.webkit.org/248882@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455766. 1855223 4 webkit-bug-importer 2022-03-25 13:34:18 -0700 <rdar://problem/90854052> 455766 2022-03-25 08:44:06 -0700 2022-03-25 13:33:44 -0700 Patch bug-238376-20220325084405.patch text/plain 3265 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzdmNjllOTJkNTE0MGM5 YjkyYmEyODAwN2M0NzEyYmFkZTE3M2VlYy4uNzBjMDFiOWM3ZDljN2M4YWE1ZGM0YTI3YzgwMDdm MDQ4MTFlNzNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAzLTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBkdXBsaWNhdGUgaXNG aXJpbmdFdmVudExpc3RlbmVycyBjaGVjayBpbiBOb2RlIHdyYXBwZXJzJyBpc1JlYWNoYWJsZUZy b21PcGFxdWVSb290cygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzgzNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBEcm9wIGR1cGxpY2F0ZSBpc0ZpcmluZ0V2ZW50TGlzdGVuZXJzIGNoZWNrIGluIE5v ZGUgd3JhcHBlcnMnIGlzUmVhY2hhYmxlRnJvbU9wYXF1ZVJvb3RzKCkuCisgICAgICAgIFRob3Nl IHdyYXBwZXJzIGFscmVhZHkgY2FsbCBKU05vZGVPd25lcjo6aXNSZWFjaGFibGVGcm9tT3BhcXVl Um9vdHMoKSB3aGljaCBhbHJlYWR5IHRha2VzIGNhcmUKKyAgICAgICAgb2YgY2hlY2tpbmcgdGhl IGlzRmlyaW5nRXZlbnRMaXN0ZW5lcnMgZmxhZy4KKworICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6 CisKIDIwMjItMDMtMjUgIEZyw6lkw6lyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CiAKICAg ICAgICAgSW1wcm92ZSByZWJ1aWxkaW5nIG9mIHJ1Ynkgc3VidHJlZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggMDczZTE1 OGUzMWE1MzJjMmIzMzg1Nzg3YTk3OTJjNDMyMzA2NGI0NS4uYjQ1Y2JkOWZlMzhhZDc1N2I0ZGE2 MjA3MmM3ZDE3ZGEyZGM0MzBmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTUwMjEsMjQgKzUwMjEsMjMgQEAgc3ViIEdl bmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAg ICAgICByZXR1cm4gdHJ1ZTtcbiIpOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIg ICAgIH1cbiIpOwogICAgICAgICB9Ci0gICAgICAgIGlmICgkY29kZUdlbmVyYXRvci0+SW5oZXJp dHNJbnRlcmZhY2UoJGludGVyZmFjZSwgIkV2ZW50VGFyZ2V0IikpIHsKKyAgICAgICAgaWYgKCRj b2RlR2VuZXJhdG9yLT5Jbmhlcml0c0ludGVyZmFjZSgkaW50ZXJmYWNlLCAiTm9kZSIpKSB7CiAg ICAgICAgICAgICBpZiAoISRlbWl0dGVkSlNDYXN0KSB7CiAgICAgICAgICAgICAgICAgcHVzaChA aW1wbENvbnRlbnQsICIgICAgYXV0byoganMke2ludGVyZmFjZU5hbWV9ID0ganNDYXN0PEpTJHtp bnRlcmZhY2VOYW1lfSo+KGhhbmRsZS5zbG90KCktPmFzQ2VsbCgpKTtcbiIpOwogICAgICAgICAg ICAgICAgICRlbWl0dGVkSlNDYXN0ID0gMTsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHB1 c2goQGltcGxDb250ZW50LCAiICAgIGlmIChqcyR7aW50ZXJmYWNlTmFtZX0tPndyYXBwZWQoKS5p c0ZpcmluZ0V2ZW50TGlzdGVuZXJzKCkpIHtcbiIpOwotICAgICAgICAgICAgcHVzaChAaW1wbENv bnRlbnQsICIgICAgICAgIGlmIChVTkxJS0VMWShyZWFzb24pKVxuIik7Ci0gICAgICAgICAgICBw dXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgICAgICpyZWFzb24gPSBcIkV2ZW50VGFyZ2V0IGZp cmluZyBldmVudCBsaXN0ZW5lcnNcIjtcbiIpOworICAgICAgICAgICAgcHVzaChAaW1wbENvbnRl bnQsICIgICAgaWYgKEpTTm9kZU93bmVyOjppc1JlYWNoYWJsZUZyb21PcGFxdWVSb290cyhoYW5k bGUsIDAsIHZpc2l0b3IsIHJlYXNvbikpXG4iKTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250 ZW50LCAiICAgICAgICByZXR1cm4gdHJ1ZTtcbiIpOwotICAgICAgICAgICAgcHVzaChAaW1wbENv bnRlbnQsICIgICAgfVxuIik7Ci0gICAgICAgIH0KLSAgICAgICAgaWYgKCRjb2RlR2VuZXJhdG9y LT5Jbmhlcml0c0ludGVyZmFjZSgkaW50ZXJmYWNlLCAiTm9kZSIpKSB7CisgICAgICAgIH0gZWxz aWYgKCRjb2RlR2VuZXJhdG9yLT5Jbmhlcml0c0ludGVyZmFjZSgkaW50ZXJmYWNlLCAiRXZlbnRU YXJnZXQiKSkgewogICAgICAgICAgICAgaWYgKCEkZW1pdHRlZEpTQ2FzdCkgewogICAgICAgICAg ICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIGF1dG8qIGpzJHtpbnRlcmZhY2VOYW1lfSA9 IGpzQ2FzdDxKUyR7aW50ZXJmYWNlTmFtZX0qPihoYW5kbGUuc2xvdCgpLT5hc0NlbGwoKSk7XG4i KTsKICAgICAgICAgICAgICAgICAkZW1pdHRlZEpTQ2FzdCA9IDE7CiAgICAgICAgICAgICB9Ci0g ICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICBpZiAoSlNOb2RlT3duZXI6OmlzUmVh Y2hhYmxlRnJvbU9wYXF1ZVJvb3RzKGhhbmRsZSwgMCwgdmlzaXRvciwgcmVhc29uKSlcbiIpOwor ICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgaWYgKGpzJHtpbnRlcmZhY2VOYW1l fS0+d3JhcHBlZCgpLmlzRmlyaW5nRXZlbnRMaXN0ZW5lcnMoKSkge1xuIik7CisgICAgICAgICAg ICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgaWYgKFVOTElLRUxZKHJlYXNvbikpXG4iKTsK KyAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICAgICAgICAgKnJlYXNvbiA9IFwi RXZlbnRUYXJnZXQgZmlyaW5nIGV2ZW50IGxpc3RlbmVyc1wiO1xuIik7CiAgICAgICAgICAgICBw dXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgcmV0dXJuIHRydWU7XG4iKTsKKyAgICAgICAgICAg IHB1c2goQGltcGxDb250ZW50LCAiICAgIH1cbiIpOwogICAgICAgICB9CiAgICAgICAgIGlmIChH ZXRHZW5lcmF0ZUlzUmVhY2hhYmxlKCRpbnRlcmZhY2UpKSB7CiAgICAgICAgICAgICBpZiAoISRl bWl0dGVkSlNDYXN0KSB7Cg==