238348 2022-03-24 13:52:21 -0700 [GLib] Add user directories to WTF::FileSystem 2022-03-24 17:10:17 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead aperez benjamin cdumez cmarcelo ews-watchlist hi joepeck pangle webkit-bug-importer oldest_to_newest 1854839 0 don.olmstead 2022-03-24 13:52:21 -0700 Both g_get_user_cache_dir and g_get_user_data_dir are requested in multiple places so let's move them into FileSystem. 1854841 1 455676 don.olmstead 2022-03-24 14:00:08 -0700 Created attachment 455676 Patch 1854947 2 ews-feeder 2022-03-24 17:09:37 -0700 Committed r291835 (248853@main): <https://commits.webkit.org/248853@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455676. 1854948 3 webkit-bug-importer 2022-03-24 17:10:17 -0700 <rdar://problem/90806138> 455676 2022-03-24 14:00:08 -0700 2022-03-24 17:09:43 -0700 Patch bug-238348.diff text/plain 5531 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOWJjMzBiOGU2ZWNkLi4xNjkzODRhMzMxMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIw MjItMDMtMjQgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KKworICAgICAg ICBbR0xpYl0gQWRkIHVzZXIgZGlyZWN0b3JpZXMgdG8gV1RGOjpGaWxlU3lzdGVtCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzgzNDgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgRmlsZVN5c3RlbTo6 dXNlckNhY2hlRGlyZWN0b3J5IGFuZCBGaWxlU3lzdGVtOjp1c2VyRGF0YURpcmVjdG9yeSB3aGlj aCBjYWxsIGludG8KKyAgICAgICAgZ19nZXRfdXNlcl9jYWNoZV9kaXIgYW5kIGdfZ2V0X3VzZXJf ZGF0YV9kaXIgcmVzcGVjdGl2ZWx5LgorCisgICAgICAgICogd3RmL0ZpbGVTeXN0ZW0uaDoKKyAg ICAgICAgKiB3dGYvZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHA6CisgICAgICAgIChXVEY6OkZpbGVT eXN0ZW1JbXBsOjp1c2VyQ2FjaGVEaXJlY3RvcnkpOgorICAgICAgICAoV1RGOjpGaWxlU3lzdGVt SW1wbDo6dXNlckRhdGFEaXJlY3RvcnkpOgorCiAyMDIyLTAzLTI0ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgU3RyaW5nJ3MgZmluZCgpIC8gcmV2ZXJzZUZpbmQo KSAvIHJlcGxhY2UoKSBzaG91bGQgdGFrZSBpbiBhIFN0cmluZ1ZpZXcgaW5zdGVhZCBvZiBhIFN0 cmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRmlsZVN5c3RlbS5oIGIvU291cmNlL1dU Ri93dGYvRmlsZVN5c3RlbS5oCmluZGV4IDk5NTFhNGIxNGMwYi4uOTU3OGRhMWQ2ZDk5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmgKKysrIGIvU291cmNlL1dURi93dGYv RmlsZVN5c3RlbS5oCkBAIC0xOTIsNiArMTkyLDggQEAgV1RGX0VYUE9SVF9QUklWQVRFIFJldGFp blB0cjxDRlVSTFJlZj4gcGF0aEFzVVJMKGNvbnN0IFN0cmluZyYpOwogV1RGX0VYUE9SVF9QUklW QVRFIFN0cmluZyBmaWxlbmFtZUZvckRpc3BsYXkoY29uc3QgU3RyaW5nJik7CiBXVEZfRVhQT1JU X1BSSVZBVEUgQ1N0cmluZyBjdXJyZW50RXhlY3V0YWJsZVBhdGgoKTsKIFdURl9FWFBPUlRfUFJJ VkFURSBDU3RyaW5nIGN1cnJlbnRFeGVjdXRhYmxlTmFtZSgpOworV1RGX0VYUE9SVF9QUklWQVRF IFN0cmluZyB1c2VyQ2FjaGVEaXJlY3RvcnkoKTsKK1dURl9FWFBPUlRfUFJJVkFURSBTdHJpbmcg dXNlckRhdGFEaXJlY3RvcnkoKTsKICNlbmRpZgogCiAjaWYgT1MoV0lORE9XUykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwIGIvU291cmNlL1dURi93 dGYvZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAKaW5kZXggYTYzODZlNjVhMjMzLi4xMGRlZmVjZjAx ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwCisr KyBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwCkBAIC0zMjgsNSArMzI4 LDE1IEBAIENTdHJpbmcgY3VycmVudEV4ZWN1dGFibGVOYW1lKCkKICAgICByZXR1cm4gZ19nZXRf cHJnbmFtZSgpOwogfQogCitTdHJpbmcgdXNlckNhY2hlRGlyZWN0b3J5KCkKK3sKKyAgICByZXR1 cm4gc3RyaW5nRnJvbUZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihnX2dldF91c2VyX2NhY2hlX2Rp cigpKTsKK30KKworU3RyaW5nIHVzZXJEYXRhRGlyZWN0b3J5KCkKK3sKKyAgICByZXR1cm4gc3Ry aW5nRnJvbUZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihnX2dldF91c2VyX2RhdGFfZGlyKCkpOwor fQorCiB9IC8vIG5hbWVzcGFjZSBGaWxlU3lzdGVtSW1wbAogfSAvLyBuYW1lc3BhY2UgV1RGCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCmluZGV4IDY2NWRjZTBiMGM2YS4uYzdkM2IwNGFhOGU3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDIyLTAzLTI0ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+ CisKKyAgICAgICAgW0dMaWJdIEFkZCB1c2VyIGRpcmVjdG9yaWVzIHRvIFdURjo6RmlsZVN5c3Rl bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4MzQ4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRo ZSBuZXcgRmlsZVN5c3RlbSBBUElzIGluc3RlYWQgb2YgY2FsbGluZyBnbGliIGRpcmVjdGx5Lgor CisgICAgICAgICogVUlQcm9jZXNzL0luc3BlY3Rvci9ndGsvV2ViSW5zcGVjdG9yVUlQcm94eUd0 ay5jcHA6CisgICAgICAgIChXZWJLaXQ6Omluc3BlY3RvcldlYnNpdGVEYXRhU3RvcmUpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9nbGliL1dlYnNpdGVEYXRhU3RvcmVHTGliLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6Y2FjaGVEaXJlY3RvcnlGaWxlU3lzdGVtUmVwcmVz ZW50YXRpb24pOgorICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjp3ZWJzaXRlRGF0 YURpcmVjdG9yeUZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbik6CisKIDIwMjItMDMtMjQgIEZ1amlp IEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJv XSBXQ1RpbGVHcmlkIHNob3VsZCBjcmVhdGUgdGlsZXMgb25seSBmb3IgdGhlIGluc2lkZSBvZiBs YXllciBhcmVhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3Iv Z3RrL1dlYkluc3BlY3RvclVJUHJveHlHdGsuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv SW5zcGVjdG9yL2d0ay9XZWJJbnNwZWN0b3JVSVByb3h5R3RrLmNwcAppbmRleCAzZDVjZjEwODA4 MDIuLjBhNzkzNTBkZGM0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5z cGVjdG9yL2d0ay9XZWJJbnNwZWN0b3JVSVByb3h5R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9JbnNwZWN0b3IvZ3RrL1dlYkluc3BlY3RvclVJUHJveHlHdGsuY3BwCkBAIC0x NDEsOCArMTQxLDggQEAgc3RhdGljIHZvaWQgZ2V0Q29udGV4dE1lbnVGcm9tUHJvcG9zZWRNZW51 KFdLUGFnZVJlZiBwYWdlUmVmLCBXS0FycmF5UmVmIHByb3Bvc2UKIHN0YXRpYyBSZWY8V2Vic2l0 ZURhdGFTdG9yZT4gaW5zcGVjdG9yV2Vic2l0ZURhdGFTdG9yZSgpCiB7CiAgICAgc3RhdGljIGNv bnN0IGNoYXIqIHZlcnNpb25lZERpcmVjdG9yeSA9ICJ3ZWJraXRndGstIiBXRUJLSVRHVEtfQVBJ X1ZFUlNJT05fU1RSSU5HIEdfRElSX1NFUEFSQVRPUl9TICJXZWJJbnNwZWN0b3IiIEdfRElSX1NF UEFSQVRPUl9TOwotICAgIFN0cmluZyBiYXNlQ2FjaGVEaXJlY3RvcnkgPSBGaWxlU3lzdGVtOjpw YXRoQnlBcHBlbmRpbmdDb21wb25lbnQoRmlsZVN5c3RlbTo6c3RyaW5nRnJvbUZpbGVTeXN0ZW1S ZXByZXNlbnRhdGlvbihnX2dldF91c2VyX2NhY2hlX2RpcigpKSwgdmVyc2lvbmVkRGlyZWN0b3J5 KTsKLSAgICBTdHJpbmcgYmFzZURhdGFEaXJlY3RvcnkgPSBGaWxlU3lzdGVtOjpwYXRoQnlBcHBl bmRpbmdDb21wb25lbnQoRmlsZVN5c3RlbTo6c3RyaW5nRnJvbUZpbGVTeXN0ZW1SZXByZXNlbnRh dGlvbihnX2dldF91c2VyX2RhdGFfZGlyKCkpLCB2ZXJzaW9uZWREaXJlY3RvcnkpOworICAgIFN0 cmluZyBiYXNlQ2FjaGVEaXJlY3RvcnkgPSBGaWxlU3lzdGVtOjpwYXRoQnlBcHBlbmRpbmdDb21w b25lbnQoRmlsZVN5c3RlbTo6dXNlckNhY2hlRGlyZWN0b3J5KCksIHZlcnNpb25lZERpcmVjdG9y eSk7CisgICAgU3RyaW5nIGJhc2VEYXRhRGlyZWN0b3J5ID0gRmlsZVN5c3RlbTo6cGF0aEJ5QXBw ZW5kaW5nQ29tcG9uZW50KEZpbGVTeXN0ZW06OnVzZXJEYXRhRGlyZWN0b3J5KCksIHZlcnNpb25l ZERpcmVjdG9yeSk7CiAKICAgICBhdXRvIGNvbmZpZ3VyYXRpb24gPSBXZWJzaXRlRGF0YVN0b3Jl Q29uZmlndXJhdGlvbjo6Y3JlYXRlKElzUGVyc2lzdGVudDo6WWVzLCBXaWxsQ29weVBhdGhzRnJv bUV4aXN0aW5nQ29uZmlndXJhdGlvbjo6WWVzKTsKICAgICBjb25maWd1cmF0aW9uLT5zZXROZXR3 b3JrQ2FjaGVEaXJlY3RvcnkoRmlsZVN5c3RlbTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KGJh c2VDYWNoZURpcmVjdG9yeSwgIldlYktpdENhY2hlIikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvZ2xpYi9XZWJzaXRlRGF0YVN0b3JlR0xpYi5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9nbGliL1dlYnNpdGVEYXRhU3RvcmVHTGliLmNwcAppbmRleCAyZDdkNDY3 OTUxMjcuLjgxMjQwMjgxN2MyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Z2xpYi9XZWJzaXRlRGF0YVN0b3JlR0xpYi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvZ2xpYi9XZWJzaXRlRGF0YVN0b3JlR0xpYi5jcHAKQEAgLTEwMSwxMiArMTAxLDEyIEBAIFdU Rjo6U3RyaW5nIFdlYnNpdGVEYXRhU3RvcmU6OmRlZmF1bHRSZXNvdXJjZUxvYWRTdGF0aXN0aWNz RGlyZWN0b3J5KCkKIAogV1RGOjpTdHJpbmcgV2Vic2l0ZURhdGFTdG9yZTo6Y2FjaGVEaXJlY3Rv cnlGaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oY29uc3QgV1RGOjpTdHJpbmcmIGRpcmVjdG9yeU5h bWUsIFNob3VsZENyZWF0ZURpcmVjdG9yeSkKIHsKLSAgICByZXR1cm4gRmlsZVN5c3RlbTo6cGF0 aEJ5QXBwZW5kaW5nQ29tcG9uZW50KEZpbGVTeXN0ZW06OnN0cmluZ0Zyb21GaWxlU3lzdGVtUmVw cmVzZW50YXRpb24oZ19nZXRfdXNlcl9jYWNoZV9kaXIoKSksIGRpcmVjdG9yeU5hbWUpOworICAg IHJldHVybiBGaWxlU3lzdGVtOjpwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQoRmlsZVN5c3RlbTo6 dXNlckNhY2hlRGlyZWN0b3J5KCksIGRpcmVjdG9yeU5hbWUpOwogfQogCiBXVEY6OlN0cmluZyBX ZWJzaXRlRGF0YVN0b3JlOjp3ZWJzaXRlRGF0YURpcmVjdG9yeUZpbGVTeXN0ZW1SZXByZXNlbnRh dGlvbihjb25zdCBXVEY6OlN0cmluZyYgZGlyZWN0b3J5TmFtZSkKIHsKLSAgICByZXR1cm4gRmls ZVN5c3RlbTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KEZpbGVTeXN0ZW06OnN0cmluZ0Zyb21G aWxlU3lzdGVtUmVwcmVzZW50YXRpb24oZ19nZXRfdXNlcl9kYXRhX2RpcigpKSwgZGlyZWN0b3J5 TmFtZSk7CisgICAgcmV0dXJuIEZpbGVTeXN0ZW06OnBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChG aWxlU3lzdGVtOjp1c2VyRGF0YURpcmVjdG9yeSgpLCBkaXJlY3RvcnlOYW1lKTsKIH0KIAogdm9p ZCBXZWJzaXRlRGF0YVN0b3JlOjpwbGF0Zm9ybVJlbW92ZVJlY2VudFNlYXJjaGVzKFdhbGxUaW1l KQo=