238331 2022-03-24 09:49:50 -0700 Run unifdef more uniformly on all WebKit.framework headers 2022-03-24 11:36:30 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=238213 InRadar P2 Normal --- 1 emw emw ap webkit-bug-importer oldest_to_newest 1854716 0 emw 2022-03-24 09:49:50 -0700 We run unifdef on some special-cased headers in WebKit’s `postprocess-header-rule` script. There doesn’t seem to be a good reason to _only_ run it on those headers. We could run it more broadly and clean up dead code in the product headers. 1854717 1 emw 2022-03-24 09:50:06 -0700 rdar://90704735 1854786 2 455659 emw 2022-03-24 11:36:30 -0700 Created attachment 455659 wip: Run unifdef on all WebKit headers 455659 2022-03-24 11:36:30 -0700 2022-03-24 11:36:30 -0700 wip: Run unifdef on all WebKit headers bug-238331-20220324113629.patch text/plain 5511 emw U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM4YWZlYWJlODZlNDhiYmY2 MjY5M2FjMTA4MmE4OGUxOThkNDFiNzAuLjc3OTJiNzFlNTY3YjYwNmE0M2U2NDI4NDRlNzY5YjFi NDBmZDZlZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjItMDMtMjQgIEVsbGlvdHQg V2lsbGlhbXMgIDxlbXdAYXBwbGUuY29tPgorCisgICAgICAgIFJ1biB1bmlmZGVmIG1vcmUgdW5p Zm9ybWx5IG9uIGFsbCBXZWJLaXQuZnJhbWV3b3JrIGhlYWRlcnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODMzMQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3MgdGhlIHNhbWUgdW5pZmRlZiBmbGFn cyB0byBldmVyeSBwcm9kdWN0IGhlYWRlciwgd2hpY2ggY2xlYW5zIHVwIHNvbWUgZGVhZCBjb2Rl IGluIHRoZQorICAgICAgICBTREsgYW5kIG1ha2VzIGl0IGVhc2llciB0byByZWFzb24gYWJvdXQg aG93IGhlYWRlcnMgd2lsbCBiZSB1bmlmZGVmJ2QuCisKKyAgICAgICAgRklYTUU6IE5lZWRzIG1v cmUgdGVzdGluZyBieSBsb29raW5nIGF0IFNESyBkaWZmcyBvZiB0aGlzIGNoYW5nZSB2cy4gdHJ1 bmsuCisKKyAgICAgICAgKiBTY3JpcHRzL3Bvc3Rwcm9jZXNzLWhlYWRlci1ydWxlOiBSZW1vdmUg bmFtZS1iYXNlZCBzcGVjaWFsIGNhc2VzIGZvciB1bmlmZGVmIG9wdGlvbnMuCisgICAgICAgICog U2hhcmVkL0FQSS9Db2NvYS9XZWJLaXRMZWdhY3kuaDogSW5zdGVhZCBvZiBjaGVja2luZyB3aGV0 aGVyIFdlYktpdExlZ2FjeSBjYW4gYmUgaW1wb3J0ZWQsCisgICAgICAgIHdyaXRlIFVTRV9BUFBM RV9JTlRFUk5BTF9TREsgc28gdGhhdCB1bmlmZGVmIGNhbiByZW1vdmUgaXQgaW4gcHVibGljIHBy b2R1Y3Rpb24gYnVpbGRzLgorCiAyMDIyLTAzLTIyICBFbGxpb3R0IFdpbGxpYW1zICA8ZW13QGFw cGxlLmNvbT4KIAogICAgICAgICBbWENCdWlsZF0gV2ViS2l0OiBVc2UgbmF0aXZlIGhlYWRlcnMg KyBidWlsZCBydWxlcyBmb3IgbWlncmF0ZWQgaGVhZGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9TY3JpcHRzL3Bvc3Rwcm9jZXNzLWhlYWRlci1ydWxlIGIvU291cmNlL1dlYktpdC9TY3Jp cHRzL3Bvc3Rwcm9jZXNzLWhlYWRlci1ydWxlCmluZGV4IGNjNmFiYjBhMDYzZGYzZTNhM2JjZDRh ZWYzY2Y3Y2I3OWIyZTFhYTguLjQwZjdmYTIwYWI1NzkwNjk0ZjEyM2M0ODQyZDZkODhkMmY2NWQ4 NTUgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy9wb3N0cHJvY2Vzcy1oZWFkZXIt cnVsZQorKysgYi9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvcG9zdHByb2Nlc3MtaGVhZGVyLXJ1bGUK QEAgLTQ0LDcgKzQ0LDYgQEAgcHJvY2Vzc19kZWZpbml0aW9ucyAiJHtCVUlMVF9QUk9EVUNUU19E SVJ9LyR7REVGSU5JVElPTlNfUEFUSH0iIHx8IHByb2Nlc3NfZGVmaW4KIAogIyBEZXRlcm1pbmUg d2hhdCBwb3N0cHJvY2Vzc29yIHN0ZXBzIHRvIHJ1biBiYXNlZCBvbiBidWlsZCBzZXR0aW5ncyBh bmQgdGhlIGZpbGUgYmVpbmcKICMgcHJvY2Vzc2VkLCB0aGVuIHBpcGUgdG9nZXRoZXIgYWxsIHRo ZSBjb21tYW5kcyB3ZSBuZWVkIGFuZCB3cml0ZSB0aGUgb3V0cHV0IGZpbGUuCi0jIEZJWE1FOiBy ZGFyOi8vOTA3MDQ3MzUgKFJ1biB1bmlmZGVmIG1vcmUgdW5pZm9ybWx5IG9uIGFsbCBXZWJLaXQu ZnJhbWV3b3JrIGhlYWRlcnMpCiAKIGlmIFtbICIke1dLX0ZSQU1FV09SS19IRUFERVJfUE9TVFBS T0NFU1NJTkdfRElTQUJMRUR9IiAhPSAiWUVTIiBdXTsgdGhlbgogICAgIGlmIFtbICIke1dLX1BM QVRGT1JNX05BTUV9IiA9PSAibWFjb3N4IiBdXTsgdGhlbgpAQCAtNzgsNTIgKzc3LDM3IEBAIGlm IFtbICIke1dLX0ZSQU1FV09SS19IRUFERVJfUE9TVFBST0NFU1NJTkdfRElTQUJMRUR9IiAhPSAi WUVTIiBdXTsgdGhlbgogICAgIFNFRF9PUFRJT05TKz0oJHtPVEhFUl9TRURfT1BUSU9OU1sqXX0p CiBmaQogCi1VTklGREVGX09QVElPTlM9KC1CKQorVU5JRkRFRl9PUFRJT05TPSgtQiAtRF9fQVBQ TEVfXyAtVUJVSUxESU5HX0dUS19fIC1VQlVJTERJTkdfV1BFX18gLVVVU0VfU09VUCkKIAotY2Fz ZSAiJHtJTlBVVF9GSUxFX1BBVEh9IiBpbgotKi9XS0Jhc2UuaCkKLSAgICBVTklGREVGX09QVElP TlMrPSgtRF9fQVBQTEVfXyAtVUJVSUxESU5HX0dUS19fIC1VQlVJTERJTkdfV1BFX18gLVVVU0Vf U09VUCkKLSAgICA7OwotKi9XS0ZvdW5kYXRpb24uaCkKLSAgICBpZiBbWyAiJHtXS19GUkFNRVdP UktfSEVBREVSX1BPU1RQUk9DRVNTSU5HX0RJU0FCTEVEfSIgPT0gIllFUyIgXV07IHRoZW4KLSAg ICAgICAgVU5JRkRFRl9PUFRJT05TKz0oLVVXS19GUkFNRVdPUktfSEVBREVSX1BPU1RQUk9DRVNT SU5HX0VOQUJMRUQpCi0gICAgZWxzZQotICAgICAgICBVTklGREVGX09QVElPTlMrPSgtRFdLX0ZS QU1FV09SS19IRUFERVJfUE9TVFBST0NFU1NJTkdfRU5BQkxFRCkKLSAgICBmaQotICAgIDs7Ci0q L1dlYktpdExlZ2FjeS5oKQotICAgIFsgIiR7V0tfUExBVEZPUk1fTkFNRX0iID0gbWFjb3N4IF0K LSAgICBVTklGREVGX09QVElPTlMrPSgtRFRBUkdFVF9PU19JUEhPTkU9JD8pCi0gICAgOzsKLSov V2ViS2l0TGVnYWN5LyopCi0gICAgWyAiJHtVU0VfSU5URVJOQUxfU0RLfSIgIT0gWUVTIF0KLSAg ICBVTklGREVGX09QVElPTlMrPSgtRFVTRV9BUFBMRV9JTlRFUk5BTF9TREs9JD8pCi0gICAgWyAi JHtXS19QTEFURk9STV9OQU1FfSIgPSBtYWNvc3ggXQotICAgIFVOSUZERUZfT1BUSU9OUys9KC1E VEFSR0VUX09TX0lQSE9ORT0kPykKLSAgICBbWyAiJHtXS19QTEFURk9STV9OQU1FfSIgIT0gKnNp bXVsYXRvciogXV0KLSAgICBVTklGREVGX09QVElPTlMrPSgtRFRBUkdFVF9PU19TSU1VTEFUT1I9 JD8pCitpZiBbWyAiJHtXS19GUkFNRVdPUktfSEVBREVSX1BPU1RQUk9DRVNTSU5HX0RJU0FCTEVE fSIgPT0gIllFUyIgXV07IHRoZW4KKyAgICBVTklGREVGX09QVElPTlMrPSgtVVdLX0ZSQU1FV09S S19IRUFERVJfUE9TVFBST0NFU1NJTkdfRU5BQkxFRCkKK2Vsc2UKKyAgICBVTklGREVGX09QVElP TlMrPSgtRFdLX0ZSQU1FV09SS19IRUFERVJfUE9TVFBST0NFU1NJTkdfRU5BQkxFRCkKK2ZpCiAK LSAgICBmb3IgZmVhdHVyZURlZmluZSBpbiAiRU5BQkxFX1RPVUNIX0VWRU5UUyIgIkVOQUJMRV9J T1NfR0VTVFVSRV9FVkVOVFMiCi0gICAgZG8KLSAgICAgICAgIyBXZSBhc3N1bWUgYSBkaXNhYmxl ZCBmZWF0dXJlIGlzIGVpdGhlciB1bmRlZmluZWQgb3IgaGFzIHRoZSBlbXB0eSBzdHJpbmcgYXMg aXRzIHZhbHVlLgotICAgICAgICBldmFsICJpc0ZlYXR1cmVFbmFibGVkPVwkJGZlYXR1cmVEZWZp bmUiCi0gICAgICAgIHRlc3QgLXogJGlzRmVhdHVyZUVuYWJsZWQKLSAgICAgICAgVU5JRkRFRl9P UFRJT05TKz0oLUQkZmVhdHVyZURlZmluZT0kPykKLSAgICBkb25lCitbICIke1VTRV9JTlRFUk5B TF9TREt9IiAhPSBZRVMgXQorVU5JRkRFRl9PUFRJT05TKz0oLURVU0VfQVBQTEVfSU5URVJOQUxf U0RLPSQ/KQorWyAiJHtXS19QTEFURk9STV9OQU1FfSIgPSBtYWNvc3ggXQorVU5JRkRFRl9PUFRJ T05TKz0oLURUQVJHRVRfT1NfSVBIT05FPSQ/KQorW1sgIiR7V0tfUExBVEZPUk1fTkFNRX0iICE9 ICpzaW11bGF0b3IqIF1dCitVTklGREVGX09QVElPTlMrPSgtRFRBUkdFVF9PU19TSU1VTEFUT1I9 JD8pCisKK2ZvciBmZWF0dXJlRGVmaW5lIGluICJFTkFCTEVfVE9VQ0hfRVZFTlRTIiAiRU5BQkxF X0lPU19HRVNUVVJFX0VWRU5UUyIKK2RvCisgICAgIyBXZSBhc3N1bWUgYSBkaXNhYmxlZCBmZWF0 dXJlIGlzIGVpdGhlciB1bmRlZmluZWQgb3IgaGFzIHRoZSBlbXB0eSBzdHJpbmcgYXMgaXRzIHZh bHVlLgorICAgIGV2YWwgImlzRmVhdHVyZUVuYWJsZWQ9XCQkZmVhdHVyZURlZmluZSIKKyAgICB0 ZXN0IC16ICRpc0ZlYXR1cmVFbmFibGVkCisgICAgVU5JRkRFRl9PUFRJT05TKz0oLUQkZmVhdHVy ZURlZmluZT0kPykKK2RvbmUKIAorY2FzZSAiJHtJTlBVVF9GSUxFX1BBVEh9IiBpbgorKi9XZWJL aXRMZWdhY3kvKikKICAgICBTRURfT1BUSU9OUys9KC1lICJzL1w8V2ViS2l0TGVnYWN5L1w8V2Vi S2l0LyIpCiAgICAgaWYgW1sgIiR7U09VUkNFX0ZJTEV9IiAhPSAqL1dlYktpdEF2YWlsYWJpbGl0 eS5oIF1dICYmIFsgJHtXS19QTEFURk9STV9OQU1FfSAhPSBtYWNvc3ggXTsgdGhlbgogICAgICAg ICBTRURfT1BUSU9OUys9KC1lICJzLyAqV0VCS0lUXygoQ0xBU1NffEVOVU1fKT8oQVZBSUxBQkxF fERFUFJFQ0FURUQpKV9NQUNcKFteKV0rXCkvL2ciKQogICAgIGZpCiAgICAgOzsKICovV2ViQ29y ZS8qKQotICAgIFsgIiR7VVNFX0lOVEVSTkFMX1NES30iICE9IFlFUyBdCi0gICAgVU5JRkRFRl9P UFRJT05TKz0oLURVU0VfQVBQTEVfSU5URVJOQUxfU0RLPSQ/KQotICAgIFsgIiR7V0tfUExBVEZP Uk1fTkFNRX0iID0gbWFjb3N4IF0KLSAgICBVTklGREVGX09QVElPTlMrPSgtRFRBUkdFVF9PU19J UEhPTkU9JD8pCi0gICAgW1sgIiR7V0tfUExBVEZPUk1fTkFNRX0iICE9ICpzaW11bGF0b3IqIF1d Ci0gICAgVU5JRkRFRl9PUFRJT05TKz0oLURUQVJHRVRfT1NfU0lNVUxBVE9SPSQ/KQotCiAgICAg Zm9yIGZlYXR1cmVEZWZpbmUgaW4gIkVOQUJMRV9UT1VDSF9FVkVOVFMiICJFTkFCTEVfSU9TX0dF U1RVUkVfRVZFTlRTIgogICAgIGRvCiAgICAgICAgICMgV2UgYXNzdW1lIGEgZGlzYWJsZWQgZmVh dHVyZSBpcyBlaXRoZXIgdW5kZWZpbmVkIG9yIGhhcyB0aGUgZW1wdHkgc3RyaW5nIGFzIGl0cyB2 YWx1ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9Db2NvYS9XZWJLaXRM ZWdhY3kuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9Db2NvYS9XZWJLaXRMZWdhY3kuaApp bmRleCA5NTM2YjAxOTFkNDc5NDRhN2FiNTZkNTNiZWE4MGY1Y2NlNDQxMDdkLi41NjFlYzQ2NTBi ZmQ2MjJiMTliZThlMzY2N2MzMDIyMTgxZDc0ODZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9BUEkvQ29jb2EvV2ViS2l0TGVnYWN5LmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFy ZWQvQVBJL0NvY29hL1dlYktpdExlZ2FjeS5oCkBAIC0yNiw3ICsyNiw3IEBACiAgKiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgogICovCiAjaWYgVEFSR0VUX09TX0lQSE9ORQotI2lmIGRlZmluZWQoX19oYXNfaW5jbHVkZSkg JiYgX19oYXNfaW5jbHVkZSg8V2ViS2l0TGVnYWN5L1dlYktpdC5oPikKKyNpZiBkZWZpbmVkKFVT RV9BUFBMRV9JTlRFUk5BTF9TREspICYmIFVTRV9BUFBMRV9JTlRFUk5BTF9TREsKICNpbXBvcnQg PFdlYktpdExlZ2FjeS9XZWJLaXQuaD4KICNlbmRpZgogI2Vsc2UK