238306 2022-03-23 20:34:07 -0700 [LFC][IFC] Remove slow codepath matching arithmetics in FontCascade::widthForSimpleText 2022-03-30 16:56:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=238581 InRadar P2 Normal --- 1 zalan zalan bfulgham ews-watchlist koivisto mmaxfield Morningstar simon.fraser webkit-bug-importer zalan oldest_to_newest 1854555 0 zalan 2022-03-23 20:34:07 -0700 ssia 1854556 1 455600 zalan 2022-03-23 20:37:37 -0700 Created attachment 455600 Patch 1854663 2 455600 koivisto 2022-03-24 06:34:20 -0700 Comment on attachment 455600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455600&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:323 > - float afterWidth = 0; > + auto width = 0.f; good job! 1854812 3 ews-feeder 2022-03-24 12:40:25 -0700 Committed r291811 (248838@main): <https://commits.webkit.org/248838@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455600. 1854813 4 webkit-bug-importer 2022-03-24 12:41:17 -0700 <rdar://problem/90784805> 455600 2022-03-23 20:37:37 -0700 2022-03-24 12:40:28 -0700 Patch bug-238306-20220323203736.patch text/plain 3296 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTUyYzM5M2U5N2U5ZjY4 MzE0Mzg2Y2YwNGVlNTliZGRiMTBmZjM2Yi4uZGFiODM4N2E1NWVjZGZlZjE5ODc2Y2NkN2MxYzA1 ZGMxNmRjZWM1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAzLTIzICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIFJlbW92ZSBz bG93IGNvZGVwYXRoIG1hdGNoaW5nIGFyaXRobWV0aWNzIGluIEZvbnRDYXNjYWRlOjp3aWR0aEZv clNpbXBsZVRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzODMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEJ5IG5vdyBpZiB3ZSBtZWFzdXJlIHNvbWUgdGV4dCB1c2luZyB0aGUgZmFzdCBjb2RlcGF0 aCwgd2UgdXN1YWxseSBzdGF5IG9uIHRoaXMgY29kZXBhdGggZm9yIHRoZSByZXN0CisgICAgICAg IG9mIHRoZSBsYXlvdXQgKGkuZS4gcHJlZmVycmVkIHdpZHRoIGNvbXB1dGF0aW9uIHVzZXMgdGhl IHNhbWUgZmFzdCBjb2RlcGF0aCwgYW5kIHdlIGFsc28gZG9uJ3QgZHluYW1pY2FsbHkgc3dpdGNo IGJldHdlZW4gbW9kZXJuIGFuZCBsZWdhY3kpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvRm9udENhc2NhZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhc2NhZGU6OndpZHRo Rm9yU2ltcGxlVGV4dCBjb25zdCk6CisKIDIwMjItMDMtMjMgIEFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIERldmlydHVhbGl6ZSBSZW5kZXJUZXh0Ojp3aWR0aApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhc2NhZGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhc2NhZGUuY3BwCmluZGV4 IDg1MTgwYWQxMDlmZDgxOGU5YmIxNTg4Y2U5NjJhYjQ2MzA4MTZhMDkuLjFiZGJmMWI2NDVkYzll ZGFkNmI2M2NmZjRiZjFjNzI2ZGJlZjg5N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9Gb250Q2FzY2FkZS5jcHAKQEAgLTMxMiwzMCArMzEyLDIyIEBAIGZsb2F0 IEZvbnRDYXNjYWRlOjp3aWR0aEZvclNpbXBsZVRleHQoU3RyaW5nVmlldyB0ZXh0LCBUZXh0RGly ZWN0aW9uIHRleHREaXJlY3RpCiAgICAgICAgIHJldHVybiAqY2FjaGVFbnRyeTsKIAogICAgIEds eXBoQnVmZmVyIGdseXBoQnVmZmVyOwotICAgIGZsb2F0IGJlZm9yZVdpZHRoID0gMDsKICAgICBh dXRvJiBmb250ID0gcHJpbWFyeUZvbnQoKTsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg dGV4dC5sZW5ndGgoKTsgKytpKSB7CisgICAgQVNTRVJUKCFmb250LnN5bnRoZXRpY0JvbGRPZmZz ZXQoKSk7IC8vIFRoaXMgZnVuY3Rpb24gc2hvdWxkIG9ubHkgYmUgY2FsbGVkIHdoZW4gUmVuZGVy VGV4dDo6Y29tcHV0ZUNhblVzZVNpbXBsaWZpZWRUZXh0TWVhc3VyaW5nKCkgcmV0dXJucyB0cnVl LCBhbmQgdGhhdCBmdW5jdGlvbiByZXF1aXJlcyBubyBzeW50aGV0aWMgYm9sZC4KKyAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IHRleHQubGVuZ3RoKCk7ICsraSkgewogICAgICAgICBhdXRvIGds eXBoID0gZ2x5cGhEYXRhRm9yQ2hhcmFjdGVyKHRleHRbaV0sIGZhbHNlKS5nbHlwaDsKLSAgICAg ICAgQVNTRVJUKCFmb250LnN5bnRoZXRpY0JvbGRPZmZzZXQoKSk7IC8vIFRoaXMgZnVuY3Rpb24g c2hvdWxkIG9ubHkgYmUgY2FsbGVkIHdoZW4gUmVuZGVyVGV4dDo6Y29tcHV0ZUNhblVzZVNpbXBs aWZpZWRUZXh0TWVhc3VyaW5nKCkgcmV0dXJucyB0cnVlLCBhbmQgdGhhdCBmdW5jdGlvbiByZXF1 aXJlcyBubyBzeW50aGV0aWMgYm9sZC4KLSAgICAgICAgYXV0byBnbHlwaFdpZHRoID0gZm9udC53 aWR0aEZvckdseXBoKGdseXBoKTsKLSAgICAgICAgYmVmb3JlV2lkdGggKz0gZ2x5cGhXaWR0aDsK LSAgICAgICAgZ2x5cGhCdWZmZXIuYWRkKGdseXBoLCBmb250LCBnbHlwaFdpZHRoLCBpKTsKKyAg ICAgICAgZ2x5cGhCdWZmZXIuYWRkKGdseXBoLCBmb250LCBmb250LndpZHRoRm9yR2x5cGgoZ2x5 cGgpLCBpKTsKICAgICB9CiAKICAgICBhdXRvIGluaXRpYWxBZHZhbmNlID0gZm9udC5hcHBseVRy YW5zZm9ybXMoZ2x5cGhCdWZmZXIsIDAsIDAsIGVuYWJsZUtlcm5pbmcoKSwgcmVxdWlyZXNTaGFw aW5nKCksIGZvbnREZXNjcmlwdGlvbigpLmNvbXB1dGVkTG9jYWxlKCksIHRleHQsIHRleHREaXJl Y3Rpb24pOwotICAgIC8vIFRoaXMgaXMgbmVlZGVkIG9ubHkgdG8gbWF0Y2ggdGhlIHJlc3VsdCBv ZiB0aGUgc2xvdyBwYXRoLgotICAgIC8vIFNhbWUgZ2x5cGggd2lkdGhzIGJ1dCBkaWZmZXJlbnQg ZmxvYXRpbmcgcG9pbnQgYXJpdGhtZXRpYyBjYW4gcHJvZHVjZSBkaWZmZXJlbnQgcnVuIHdpZHRo LgotICAgIGZsb2F0IGFmdGVyV2lkdGggPSAwOworICAgIGF1dG8gd2lkdGggPSAwLmY7CiAgICAg Zm9yIChzaXplX3QgaSA9IDA7IGkgPCBnbHlwaEJ1ZmZlci5zaXplKCk7ICsraSkKLSAgICAgICAg YWZ0ZXJXaWR0aCArPSBXZWJDb3JlOjp3aWR0aChnbHlwaEJ1ZmZlci5hZHZhbmNlQXQoaSkpOwot ICAgIGF1dG8gYWRkaXRpb25hbEFkdmFuY2UgPSBhZnRlcldpZHRoIC0gYmVmb3JlV2lkdGg7Ci0K LSAgICBhdXRvIGZpbmFsV2lkdGggPSBiZWZvcmVXaWR0aCArIGFkZGl0aW9uYWxBZHZhbmNlOwot ICAgIGZpbmFsV2lkdGggKz0gV2ViQ29yZTo6d2lkdGgoaW5pdGlhbEFkdmFuY2UpOworICAgICAg ICB3aWR0aCArPSBXZWJDb3JlOjp3aWR0aChnbHlwaEJ1ZmZlci5hZHZhbmNlQXQoaSkpOworICAg IHdpZHRoICs9IFdlYkNvcmU6OndpZHRoKGluaXRpYWxBZHZhbmNlKTsKIAogICAgIGlmIChjYWNo ZUVudHJ5KQotICAgICAgICAqY2FjaGVFbnRyeSA9IGZpbmFsV2lkdGg7Ci0gICAgcmV0dXJuIGZp bmFsV2lkdGg7CisgICAgICAgICpjYWNoZUVudHJ5ID0gd2lkdGg7CisgICAgcmV0dXJuIHdpZHRo OwogfQogCiBHbHlwaERhdGEgRm9udENhc2NhZGU6OmdseXBoRGF0YUZvckNoYXJhY3RlcihVQ2hh cjMyIGMsIGJvb2wgbWlycm9yLCBGb250VmFyaWFudCB2YXJpYW50KSBjb25zdAo=