238278 2022-03-23 12:10:18 -0700 [GPU Process] [GraphicsContextState 4/] Ensure DisplayList::Recorder and its base class are initialized with the same GraphicsContextState 2022-03-28 15:13:02 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=238466 InRadar P2 Normal --- 237728 1 sabouhallawa sabouhallawa bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1854325 0 sabouhallawa 2022-03-23 12:10:18 -0700 When a glyph run is redisplayed, we tend to cache its drawing for perf gain. We create a DisplayList::RecorderImpl, pass it the current GraphicsContextState and ask it to drawGlyphs(). We then cache the recorded DisplayList. DisplayList::RecorderImpl passes the initial GraphicsContextState to its base class DisplayList::Recorder which pushes it on its stack. The problem is DisplayList::Recorder does not pass this initial GraphicsContextState to its base class which is GraphicsContext. So DisplayList::Recorder ends up having the initial state but the GraphicsContext ends up having the default state. DisplayList::Recorder::drawGlyphs() calls DrawGlyphsRecorder::drawGlyphs() which stores the original fillBrush, strokeBrush and dropShadow. It uses these original values to restore the m_owner when it finishes. The m_owner in this case is of type DisplayList::RecorderImpl. The problem is DrawGlyphsRecorder::drawGlyphs() stores the values in the state of the GraphicsContext which are the default. So in some cases we may restore the default state to the drawing GraphicsContext. For example let's assume the initial GraphicsContextState in the drawing GraphicsContext has fillColor = 'green': 1. DisplayList::RecorderImpl will pass the initial state to DisplayList::Recorder. So the state of its DisplayList::Recorder will have fillColor = 'green' but its GraphicsContext will have fillColor = 'black' 2. DrawGlyphsRecorder::drawGlyphs() will store fillColor = 'black' before recording. 3. DrawGlyphsRecorder::drawGlyphs() will restore fillColor = 'black' to DisplayList::Recorder. So a DisplayList item will be recorded to set the fillColor back to 'black'. 4. When replaying back the glyph DisplayList, the drawing GraphicsContext has fillColor = 'black. 1854326 1 sabouhallawa 2022-03-23 12:11:19 -0700 rdar://84602660 1854327 2 455537 sabouhallawa 2022-03-23 12:17:14 -0700 Created attachment 455537 Patch 1854451 3 ews-feeder 2022-03-23 15:52:19 -0700 Committed r291771 (?): <https://commits.webkit.org/r291771> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455537. 455537 2022-03-23 12:17:14 -0700 2022-03-23 15:52:22 -0700 Patch bug-238278-20220323121713.patch text/plain 4126 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzAxODFlMmFkNTE2NDE3 Yzk5ZTA4MzgwMTUwYWU1NjRkZWIzNWRkZC4uNDY2NWE0NmVkNGZhNzg0YjRmMzAxZWQ1MzQ5YTlj M2UyNTk5MWRmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIyLTAzLTIzICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g RW5zdXJlIERpc3BsYXlMaXN0OjpSZWNvcmRlciBhbmQgaXRzIGJhc2UgY2xhc3MgYXJlIGluaXRp YWxpemVkIHdpdGggdGhlIHNhbWUgR3JhcGhpY3NDb250ZXh0U3RhdGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODI3OAorICAgICAgICByZGFyOi8v ODQ2MDI2NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBEaXNwbGF5TGlzdDo6UmVjb3JkZXJJbXBsIHBhc3NlcyB0aGUgaW5pdGlhbCBHcmFwaGljc0Nv bnRleHRTdGF0ZSB0byBpdHMKKyAgICAgICAgYmFzZSBjbGFzcyBEaXNwbGF5TGlzdDo6UmVjb3Jk ZXIgd2hpY2ggcHVzaGVzIGl0IG9uIGl0cyBzdGFjay4gQnV0IAorICAgICAgICBEaXNwbGF5TGlz dDo6UmVjb3JkZXIgZG9lcyBub3QgcGFzcyB0aGlzIGluaXRpYWwgR3JhcGhpY3NDb250ZXh0U3Rh dGUgdG8KKyAgICAgICAgaXRzIGJhc2UgY2xhc3Mgd2hpY2ggaXMgR3JhcGhpY3NDb250ZXh0LiBT byBEaXNwbGF5TGlzdDo6UmVjb3JkZXIgZW5kcyB1cAorICAgICAgICBoYXZpbmcgdGhlIGluaXRp YWwgc3RhdGUgYnV0IHRoZSBHcmFwaGljc0NvbnRleHQgZW5kcyB1cCBoYXZpbmcgdGhlIGRlZmF1 bHQKKyAgICAgICAgc3RhdGUuCisKKyAgICAgICAgRGlzcGxheUxpc3Q6OlJlY29yZGVyOjpkcmF3 R2x5cGhzKCkgY2FsbHMgRHJhd0dseXBoc1JlY29yZGVyOjpkcmF3R2x5cGhzKCkKKyAgICAgICAg d2hpY2ggc3RvcmVzIHRoZSBvcmlnaW5hbCBmaWxsQnJ1c2gsIHN0cm9rZUJydXNoIGFuZCBkcm9w U2hhZG93LiBJdCB1c2VzCisgICAgICAgIHRoZXNlIG9yaWdpbmFsIHZhbHVlcyB0byByZXN0b3Jl IHRoZSBvd25lciBHcmFwaGljc0NvbnRleHQgd2hlbiBpdCBmaW5pc2hlcy4KKyAgICAgICAgVGhl IHByb2JsZW0gaXMgRHJhd0dseXBoc1JlY29yZGVyOjpkcmF3R2x5cGhzKCkgc3RvcmVzIHRoZSB2 YWx1ZXMgaW4gdGhlCisgICAgICAgIHN0YXRlIG9mIHRoZSBHcmFwaGljc0NvbnRleHQgd2hpY2gg YXJlIHRoZSBkZWZhdWx0LiBTbyBpbiBzb21lIGNhc2VzIHdlCisgICAgICAgIG1heSByZXN0b3Jl IHRoZSBkZWZhdWx0IHN0YXRlIHRvIHRoZSBkcmF3aW5nIEdyYXBoaWNzQ29udGV4dC4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OkdyYXBoaWNzQ29udGV4dCk6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0Lmg6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0UmVjb3JkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RGlzcGxheUxpc3Q6OlJlY29yZGVyOjpSZWNvcmRlcik6CisKIDIwMjItMDMtMjIgIFNh aWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVSBQcm9jZXNz XSBNYWtlIEdyYXBoaWNzQ29udGV4dFN0YXRlIGEgY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwCmluZGV4IGFjMzNmM2Qz MTIzZmM1ODE0NGQ3YmJiOTdkN2FkZDYxMzc1YzM5MTMuLjI3NTFhYzA4OTkxMmU3NmVmZWQ1MWE1 OTMyMzcyYmM2ZjA3MmFiMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcApAQCAtNDgsNiArNDgsMTEgQEAgR3JhcGhpY3ND b250ZXh0OjpHcmFwaGljc0NvbnRleHQoY29uc3QgR3JhcGhpY3NDb250ZXh0U3RhdGU6OkNoYW5n ZUZsYWdzJiBjaGFuZ2UKIHsKIH0KIAorR3JhcGhpY3NDb250ZXh0OjpHcmFwaGljc0NvbnRleHQo Y29uc3QgR3JhcGhpY3NDb250ZXh0U3RhdGUmIHN0YXRlKQorICAgIDogbV9zdGF0ZShzdGF0ZSkK K3sKK30KKwogR3JhcGhpY3NDb250ZXh0Ojp+R3JhcGhpY3NDb250ZXh0KCkKIHsKICAgICBBU1NF UlQobV9zdGFjay5pc0VtcHR5KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAppbmRleCBlZDBmZWZjNTVhODMxMzFkMTcwOWY3ZDdk NGRhNDFkZDQ5ZTNkYzQxLi5kMzQ0ZDU5ZmI0MTFmNGYxYTZiZDQwNGI4OGJmY2U5MjVjZTQ3M2E4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0Nv bnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0Nv bnRleHQuaApAQCAtNjYsNiArNjYsNyBAQCBjbGFzcyBHcmFwaGljc0NvbnRleHQgewogICAgIFdU Rl9NQUtFX05PTkNPUFlBQkxFKEdyYXBoaWNzQ29udGV4dCk7IFdURl9NQUtFX0ZBU1RfQUxMT0NB VEVEOwogcHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JUIEdyYXBoaWNzQ29udGV4dChjb25zdCBH cmFwaGljc0NvbnRleHRTdGF0ZTo6Q2hhbmdlRmxhZ3MmID0geyB9LCBJbnRlcnBvbGF0aW9uUXVh bGl0eSA9IEludGVycG9sYXRpb25RdWFsaXR5OjpEZWZhdWx0KTsKKyAgICBXRUJDT1JFX0VYUE9S VCBHcmFwaGljc0NvbnRleHQoY29uc3QgR3JhcGhpY3NDb250ZXh0U3RhdGUmKTsKICAgICBXRUJD T1JFX0VYUE9SVCB2aXJ0dWFsIH5HcmFwaGljc0NvbnRleHQoKTsKIAogICAgIHZpcnR1YWwgYm9v bCBoYXNQbGF0Zm9ybUNvbnRleHQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlM aXN0UmVjb3JkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxh eWxpc3RzL0Rpc3BsYXlMaXN0UmVjb3JkZXIuY3BwCmluZGV4IDM0ZjZmMjEzZDNhN2JlNDljNzI1 YTNjYjRkYjVjMmEzYWY3Mzk4NTguLmY4NjU5NmMwY2U0MjQxZmZiNmQxNzQ0MTRhYTIyNDE5YjM5 ZjFkMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3Bs YXlsaXN0cy9EaXNwbGF5TGlzdFJlY29yZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RSZWNvcmRlci5jcHAKQEAgLTQz LDcgKzQzLDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogbmFtZXNwYWNlIERpc3BsYXlMaXN0IHsK IAogUmVjb3JkZXI6OlJlY29yZGVyKGNvbnN0IEdyYXBoaWNzQ29udGV4dFN0YXRlJiBzdGF0ZSwg Y29uc3QgRmxvYXRSZWN0JiBpbml0aWFsQ2xpcCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBpbml0 aWFsQ1RNLCBEcmF3R2x5cGhzUmVjb3JkZXI6OkRlY29uc3RydWN0RHJhd0dseXBocyBkZWNvbnN0 cnVjdERyYXdHbHlwaHMpCi0gICAgOiBtX2RyYXdHbHlwaHNSZWNvcmRlcigqdGhpcywgZGVjb25z dHJ1Y3REcmF3R2x5cGhzKQorICAgIDogR3JhcGhpY3NDb250ZXh0KHN0YXRlKQorICAgICwgbV9k cmF3R2x5cGhzUmVjb3JkZXIoKnRoaXMsIGRlY29uc3RydWN0RHJhd0dseXBocykKIHsKICAgICBt X3N0YXRlU3RhY2suYXBwZW5kKHsgc3RhdGUsIGluaXRpYWxDVE0sIGluaXRpYWxDVE0ubWFwUmVj dChpbml0aWFsQ2xpcCkgfSk7CiB9Cg==