23826 2009-02-07 16:04:05 -0800 Potential bug with before/after rule while moving element from one document to another 2009-02-12 12:32:16 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix webkit-unassigned oldest_to_newest 108854 0 jchaffraix 2009-02-07 16:04:05 -0800 As part of http://trac.webkit.org/changeset/40005, setUsesBeforeAfterRules was added as part of the element construction instead of as part of the insertion for 2 elements. Moving such an element from a document to another could lead to the before/after rules not been enabled on the new document. 109448 1 27590 jchaffraix 2009-02-12 01:15:23 -0800 Created attachment 27590 Proposed change: move toggle into insertedIntoDocument 109491 2 27590 darin 2009-02-12 09:45:53 -0800 Comment on attachment 27590 Proposed change: move toggle into insertedIntoDocument r=me 109536 3 jchaffraix 2009-02-12 12:32:16 -0800 Landed in r40921. 27590 2009-02-12 01:15:23 -0800 2009-02-12 09:45:53 -0800 Proposed change: move toggle into insertedIntoDocument bug23826-beforeAfterRule.diff text/plain 6111 jchaffraix SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDg3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDItMTEgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4 QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQnVnIDIzODI2OiBQb3RlbnRpYWwgYnVnIHdpdGggYmVmb3JlL2FmdGVyIHJ1bGUgd2hp bGUgbW92aW5nIGVsZW1lbnQgZnJvbSBvbmUgZG9jdW1lbnQgdG8gYW5vdGhlcgorCisgICAgICAg IE1vdmVkIHRoZSBkb2N1bWVudCBiZWZvcmUvYWZ0ZXIgdG9nZ2xlIGZyb20gdGhlIGNvbnN0cnVj dG9yIHRvIGluc2VydGVkSW50b0RvY3VtZW50LgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzLWdl bmVyYXRlZC1jb250ZW50L2JlZm9yZUFmdGVyLWludGVyZG9jdW1lbnQuaHRtbAorCisgICAgICAg ICogaHRtbC9IVE1MUXVvdGVFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxRdW90 ZUVsZW1lbnQ6OkhUTUxRdW90ZUVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFF1b3Rl RWxlbWVudDo6aW5zZXJ0ZWRJbnRvRG9jdW1lbnQpOgorICAgICAgICAqIGh0bWwvSFRNTFF1b3Rl RWxlbWVudC5oOgorCiAyMDA5LTAyLTExICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlcgpJbmRleDogV2ViQ29yZS9odG1s L0hUTUxRdW90ZUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MUXVv dGVFbGVtZW50LmNwcAkocmV2aXNpb24gNDA4NjYpCisrKyBXZWJDb3JlL2h0bWwvSFRNTFF1b3Rl RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzLDkgKzMzLDEzIEBAIEhUTUxRdW90ZUVs ZW1lbnQ6OkhUTUxRdW90ZUVsZW1lbnQoY29uc3QKICAgICA6IEhUTUxFbGVtZW50KHRhZ05hbWUs IGRvYykKIHsKICAgICBBU1NFUlQoaGFzVGFnTmFtZShxVGFnKSk7Ci0gICAgLy8gRklYTUU6IFRo aXMgc2hvdWxkIGdvIGludG8gaW5zZXJ0ZWRJbnRvRG9jdW1lbnQgYXMgYSBxdW90ZSBlbGVtZW50 IGNvdWxkCi0gICAgLy8gYmUgbW92ZWQgZnJvbSBvbmUgZG9jdW1lbnQgdG8gYW5vdGhlci4KLSAg ICBkb2MtPnNldFVzZXNCZWZvcmVBZnRlclJ1bGVzKHRydWUpOworfQorCit2b2lkIEhUTUxRdW90 ZUVsZW1lbnQ6Omluc2VydGVkSW50b0RvY3VtZW50KCkKK3sKKyAgICBkb2N1bWVudCgpLT5zZXRV c2VzQmVmb3JlQWZ0ZXJSdWxlcyh0cnVlKTsKKworICAgIEhUTUxFbGVtZW50OjppbnNlcnRlZElu dG9Eb2N1bWVudCgpOwogfQogCiBTdHJpbmcgSFRNTFF1b3RlRWxlbWVudDo6Y2l0ZSgpIGNvbnN0 CkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTFF1b3RlRWxlbWVudC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvaHRtbC9IVE1MUXVvdGVFbGVtZW50LmgJKHJldmlzaW9uIDQwODY2KQorKysgV2ViQ29y ZS9odG1sL0hUTUxRdW90ZUVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsOCBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCBIVE1MVGFnU3RhdHVzIGVuZFRhZ1JlcXVpcmVtZW50KCkg Y29uc3QgeyByZXR1cm4gVGFnU3RhdHVzUmVxdWlyZWQ7IH0KICAgICB2aXJ0dWFsIGludCB0YWdQ cmlvcml0eSgpIGNvbnN0IHsgcmV0dXJuIDE7IH0KIAorICAgIHZpcnR1YWwgdm9pZCBpbnNlcnRl ZEludG9Eb2N1bWVudCgpOworCiAgICAgU3RyaW5nIGNpdGUoKSBjb25zdDsKICAgICB2b2lkIHNl dENpdGUoY29uc3QgU3RyaW5nJik7CiB9OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDA4NzApCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAw OS0wMi0xMSAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMjM4MjY6IFBv dGVudGlhbCBidWcgd2l0aCBiZWZvcmUvYWZ0ZXIgcnVsZSB3aGlsZSBtb3ZpbmcgZWxlbWVudCBm cm9tIG9uZSBkb2N1bWVudCB0byBhbm90aGVyCisKKyAgICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0 ZWQtY29udGVudC9iZWZvcmVBZnRlci1pbnRlcmRvY3VtZW50Lmh0bWw6IEFkZGVkLgorICAgICAg ICAqIHBsYXRmb3JtL21hYy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9iZWZvcmVBZnRlci1p bnRlcmRvY3VtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMDktMDItMTAgIE9saXZlciBI dW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRl cnNvbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2JlZm9y ZUFmdGVyLWludGVyZG9jdW1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9iZWZvcmVBZnRlci1pbnRlcmRvY3VtZW50Lmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9iZWZv cmVBZnRlci1pbnRlcmRvY3VtZW50Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTkgQEAK KzxodG1sPgorPGJvZHk+Cis8cD4gQnVnIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzgyNiI+IDIzODI2IDwvYT46IFBvdGVudGlhbCBidWcgd2l0aCBi ZWZvcmUvYWZ0ZXIgcnVsZSB3aGlsZSBtb3ZpbmcgZWxlbWVudCBmcm9tIG9uZSBkb2N1bWVudCB0 byBhbm90aGVyIDwvcD4KKzxwPiBUaGlzIHRlc3QgdGhhdCBtb3ZpbmcgYSBxdW90ZSBlbGVtZW50 IHNldHMgdGhlIGJlZm9yZSAvIGFmdGVyIGZsYWcgaW4gdGhlIGZpbmFsIGRvY3VtZW50LiA8L3A+ Cis8c2NyaXB0PgorICAgIGZ1bmN0aW9uIHRlc3QoaWZyYW1lKQorICAgIHsKKyAgICAgICAgdmFy IG90aGVyRG9jdW1lbnQgPSBpZnJhbWUuY29udGVudERvY3VtZW50OworICAgICAgICB2YXIgcXVv dGVFbGVtZW50ID0gb3RoZXJEb2N1bWVudC5jcmVhdGVFbGVtZW50KCJxIik7CisgICAgICAgIHF1 b3RlRWxlbWVudC5hcHBlbmRDaGlsZChvdGhlckRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJRdW90 ZXMgc2hvdWxkIHN1cnJvdW5kIikpOworICAgICAgICBxdW90ZUVsZW1lbnQuYXBwZW5kQ2hpbGQo b3RoZXJEb2N1bWVudC5jcmVhdGVFbGVtZW50KCJwIikpOworICAgICAgICBxdW90ZUVsZW1lbnQu YXBwZW5kQ2hpbGQob3RoZXJEb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgidGhpcyB0ZXh0LiIpKTsK KyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5hcHBlbmRDaGlsZChx dW90ZUVsZW1lbnQpOworICAgIH0KKzwvc2NyaXB0PgorPGRpdiBpZD0iY29uc29sZSI+IDwvZGl2 PgorPGlmcmFtZSBzcmM9ImFib3V0OmJsYW5rIiBpZD0iaWZyYW1lIiBvbmxvYWQ9InRlc3QodGhp cykiIHN0eWxlPSJkaXNwbGF5OiBub25lIj4gPC9pZnJhbWU+Cis8L2JvZHk+Cis8L2h0bWw+Cklu ZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQv YmVmb3JlQWZ0ZXItaW50ZXJkb2N1bWVudC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2JlZm9yZUFm dGVyLWludGVyZG9jdW1lbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2JlZm9yZUFmdGVyLWlu dGVyZG9jdW1lbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMzIEBACits YXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgw MHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7SFRNTH0g YXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6 ZSA3ODR4NTg0CisgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMCkgc2l6ZSA3ODR4MTgKKyAg ICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMzF4MTgKKyAgICAgICAgICB0 ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAzMTogIkJ1ZyAiCisgICAgICAgIFJlbmRlcklubGluZSB7 QX0gYXQgKDAsMCkgc2l6ZSA0NHgxOCBbY29sb3I9IzAwMDBFRV0KKyAgICAgICAgICBSZW5kZXJU ZXh0IHsjdGV4dH0gYXQgKDMxLDApIHNpemUgNDR4MTgKKyAgICAgICAgICAgIHRleHQgcnVuIGF0 ICgzMSwwKSB3aWR0aCA0NDogIjIzODI2ICIKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICg3NSwwKSBzaXplIDU2NXgxOAorICAgICAgICAgIHRleHQgcnVuIGF0ICg3NSwwKSB3aWR0aCA1 NjU6ICI6IFBvdGVudGlhbCBidWcgd2l0aCBiZWZvcmUvYWZ0ZXIgcnVsZSB3aGlsZSBtb3Zpbmcg ZWxlbWVudCBmcm9tIG9uZSBkb2N1bWVudCB0byBhbm90aGVyIgorICAgICAgUmVuZGVyQmxvY2sg e1B9IGF0ICgwLDM0KSBzaXplIDc4NHgxOAorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQg KDAsMCkgc2l6ZSA1Mzh4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA1Mzg6 ICJUaGlzIHRlc3QgdGhhdCBtb3ZpbmcgYSBxdW90ZSBlbGVtZW50IHNldHMgdGhlIGJlZm9yZSAv IGFmdGVyIGZsYWcgaW4gdGhlIGZpbmFsIGRvY3VtZW50LiIKKyAgICAgIFJlbmRlckJsb2NrIHtE SVZ9IGF0ICgwLDY4KSBzaXplIDc4NHg1MgorICAgICAgICBSZW5kZXJCbG9jayAoYW5vbnltb3Vz KSBhdCAoMCwwKSBzaXplIDc4NHgxOAorICAgICAgICAgIFJlbmRlcklubGluZSB7UX0gYXQgKDAs MCkgc2l6ZSAxNTh4MTgKKyAgICAgICAgICAgIFJlbmRlcklubGluZSAoZ2VuZXJhdGVkKSBhdCAo MCwwKSBzaXplIDd4MTgKKyAgICAgICAgICAgICAgUmVuZGVyVGV4dCBhdCAoMCwwKSBzaXplIDd4 MTgKKyAgICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA3OiAiXCIiCisgICAg ICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDcsMCkgc2l6ZSAxNTF4MTgKKyAgICAgICAg ICAgICAgdGV4dCBydW4gYXQgKDcsMCkgd2lkdGggMTUxOiAiUXVvdGVzIHNob3VsZCBzdXJyb3Vu ZCIKKyAgICAgICAgUmVuZGVyQmxvY2sgKGFub255bW91cykgYXQgKDAsMzQpIHNpemUgNzg0eDAK KyAgICAgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMCkgc2l6ZSA3ODR4MAorICAgICAgICBS ZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoMCwzNCkgc2l6ZSA3ODR4MTgKKyAgICAgICAgICBS ZW5kZXJJbmxpbmUge1F9IGF0ICgwLDApIHNpemUgNjB4MTgKKyAgICAgICAgICAgIFJlbmRlclRl eHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDUzeDE4CisgICAgICAgICAgICAgIHRleHQgcnVuIGF0 ICgwLDApIHdpZHRoIDUzOiAidGhpcyB0ZXh0LiIKKyAgICAgICAgICAgIFJlbmRlcklubGluZSAo Z2VuZXJhdGVkKSBhdCAoMCwwKSBzaXplIDd4MTgKKyAgICAgICAgICAgICAgUmVuZGVyVGV4dCBh dCAoNTMsMCkgc2l6ZSA3eDE4CisgICAgICAgICAgICAgICAgdGV4dCBydW4gYXQgKDUzLDApIHdp ZHRoIDc6ICJcIiIK