238259 2022-03-23 07:21:39 -0700 [Nicosia] Images in webkit.org/blog/ don't show up with threaded rendering 2022-05-06 00:44:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 alicem magomez bugs-noreply cgarcia johnfactotum1 magomez mcatanzaro webkit-bug-importer oldest_to_newest 1854160 0 alicem 2022-03-23 07:21:39 -0700 For example with https://webkit.org/blog/12445/new-webkit-features-in-safari-15-4/ With GTK3 or WEBKIT_NICOSIA_PAINTING_THREADS=0 it works fine. 1857173 1 johnfactotum1 2022-03-31 23:36:02 -0700 Seems to be caused by `filter: brightness(1)` on the `.preserve-color` class. In fact, all elements with any CSS filter applied seem to be invisible. For example, on https://developer.mozilla.org/en-US/docs/Web/CSS/filter. Almost all of the examples show up blank. The exceptions are the two "SVG equivalents" of `drop-shadow()`, which do show up but apparently without any filter effect. With GTK 3 or WEBKIT_NICOSIA_PAINTING_THREADS=0 everything works as expected. 1866845 2 458874 magomez 2022-05-05 08:23:43 -0700 Created attachment 458874 Patch 1867125 3 ews-feeder 2022-05-06 00:44:36 -0700 Committed r293883 (250341@main): <https://commits.webkit.org/250341@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458874. 458874 2022-05-05 08:23:43 -0700 2022-05-06 00:44:38 -0700 Patch bug-238259-20220505172342.patch text/plain 5202 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzODI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWFjYjcxZmI2YmZmN2Y4 ZDUyZTE0NmY5NGJlNTI3ZTk4ZjM5Y2NlZS4uNzc2NmM5NjBlMWQyNmIxOTNlODM2YTBkOTg1MDVl ZjkxNThjZjY5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTA1LTA1ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW05pY29zaWFdIEltYWdl cyBpbiB3ZWJraXQub3JnL2Jsb2cvIGRvbid0IHNob3cgdXAgd2l0aCB0aHJlYWRlZCByZW5kZXJp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODI1 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxl bWVudCBOaWNvc2lhOjpDYWlyb09wZXJhdGlvblJlY29yZGVyOjpkcmF3RmlsdGVyZWRJbWFnZUJ1 ZmZlcigpLCB3aGljaCBpcyByZXF1aXJlZAorICAgICAgICB0byByZW5kZXIgaW1hZ2VzIHRoYXQg aGF2ZSBDU1MgZmlsdGVycyBhcHBsaWVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv bmljb3NpYS9jYWlyby9OaWNvc2lhQ2Fpcm9PcGVyYXRpb25SZWNvcmRlci5jcHA6CisgICAgICAg IChOaWNvc2lhOjpDYWlyb09wZXJhdGlvblJlY29yZGVyOjpkcmF3RmlsdGVyZWRJbWFnZUJ1ZmZl cik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9jYWlyby9OaWNvc2lhQ2Fp cm9PcGVyYXRpb25SZWNvcmRlci5oOgorCiAyMDIyLTA1LTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICByZXBsYWNlVHJhY2sgd2l0aCBkaWZmZXJlbnQgY29u c3RyYWludHMgc3RvcHMgc2VuZGluZyBwYWNrZXRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9uaWNvc2lhL2NhaXJvL05pY29zaWFDYWlyb09wZXJhdGlvblJl Y29yZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL25pY29zaWEvY2Fp cm8vTmljb3NpYUNhaXJvT3BlcmF0aW9uUmVjb3JkZXIuY3BwCmluZGV4IGMyMWNkMGU0ZDUyN2Ez Y2MxMjAyYmY2ZmNmN2VkMjFhZmY5M2Q1ZjAuLmNiMDhhN2YwZWJlYTQyMDY4ZWUxNDdjMDA2NWY0 Y2E5MWE5MzQ1MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L25pY29zaWEvY2Fpcm8vTmljb3NpYUNhaXJvT3BlcmF0aW9uUmVjb3JkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL25pY29zaWEvY2Fpcm8vTmljb3NpYUNhaXJv T3BlcmF0aW9uUmVjb3JkZXIuY3BwCkBAIC0zMCw2ICszMCw4IEBACiAjaW5jbHVkZSAiTmljb3Np YUNhaXJvT3BlcmF0aW9uUmVjb3JkZXIuaCIKIAogI2luY2x1ZGUgIkNhaXJvT3BlcmF0aW9ucy5o IgorI2luY2x1ZGUgIkZpbHRlci5oIgorI2luY2x1ZGUgIkZpbHRlclJlc3VsdHMuaCIKICNpbmNs dWRlICJGbG9hdFJvdW5kZWRSZWN0LmgiCiAjaW5jbHVkZSAiR3JhZGllbnQuaCIKICNpbmNsdWRl ICJJbWFnZUJ1ZmZlci5oIgpAQCAtNTQzLDYgKzU0NSw0NCBAQCB2b2lkIENhaXJvT3BlcmF0aW9u UmVjb3JkZXI6OmRyYXdJbWFnZUJ1ZmZlcihJbWFnZUJ1ZmZlciYsIGNvbnN0IEZsb2F0UmVjdCYs IGNvbgogICAgIC8vIEZJWE1FOiBOb3QgaW1wbGVtZW50ZWQuCiB9CiAKK3ZvaWQgQ2Fpcm9PcGVy YXRpb25SZWNvcmRlcjo6ZHJhd0ZpbHRlcmVkSW1hZ2VCdWZmZXIoSW1hZ2VCdWZmZXIqIHNyY0lt YWdlLCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsIEZpbHRlciYgZmlsdGVyLCBGaWx0ZXJSZXN1 bHRzJiByZXN1bHRzKQoreworICAgIHN0cnVjdCBEcmF3RmlsdGVyZWRJbWFnZUJ1ZmZlciBmaW5h bCA6IFBhaW50aW5nT3BlcmF0aW9uLCBPcGVyYXRpb25EYXRhPFJlZlB0cjxjYWlyb19zdXJmYWNl X3Q+LCBGbG9hdFJlY3QsIEZsb2F0UmVjdCwgRmxvYXRTaXplLCBJbWFnZVBhaW50aW5nT3B0aW9u cywgZmxvYXQsIENhaXJvOjpTaGFkb3dTdGF0ZT4geworICAgICAgICB2aXJ0dWFsIH5EcmF3Rmls dGVyZWRJbWFnZUJ1ZmZlcigpID0gZGVmYXVsdDsKKworICAgICAgICB2b2lkIGV4ZWN1dGUoUGFp bnRpbmdPcGVyYXRpb25SZXBsYXkmIHJlcGxheWVyKSBvdmVycmlkZQorICAgICAgICB7CisgICAg ICAgICAgICBDYWlybzo6c2NhbGUoY29udGV4dEZvclJlcGxheShyZXBsYXllciksIHsgMSAvIGFy ZzwzPigpLndpZHRoKCksIDEgLyBhcmc8Mz4oKS5oZWlnaHQoKSB9KTsKKyAgICAgICAgICAgIENh aXJvOjpkcmF3UGxhdGZvcm1JbWFnZShjb250ZXh0Rm9yUmVwbGF5KHJlcGxheWVyKSwgYXJnPDA+ KCkuZ2V0KCksIGFyZzwxPigpLCBhcmc8Mj4oKSwgYXJnPDQ+KCksIGFyZzw1PigpLCBhcmc8Nj4o KSk7CisgICAgICAgICAgICBDYWlybzo6c2NhbGUoY29udGV4dEZvclJlcGxheShyZXBsYXllciks IGFyZzwzPigpKTsKKyAgICAgICAgfQorCisgICAgICAgIHZvaWQgZHVtcChUZXh0U3RyZWFtJiB0 cykgb3ZlcnJpZGUKKyAgICAgICAgeworICAgICAgICAgICAgdHMgPDwgaW5kZW50IDw8ICJEcmF3 RmlsdGVyZWRJbWFnZUJ1ZmZlcjw+XG4iOworICAgICAgICB9CisgICAgfTsKKworICAgIGF1dG8g cmVzdWx0ID0gZmlsdGVyLmFwcGx5KHNyY0ltYWdlLCBzcmNSZWN0LCByZXN1bHRzKTsKKyAgICBp ZiAoIXJlc3VsdCkKKyAgICAgICAgcmV0dXJuOworCisgICAgYXV0byBpbWFnZUJ1ZmZlciA9IHJl c3VsdC0+aW1hZ2VCdWZmZXIoKTsKKyAgICBpZiAoIWltYWdlQnVmZmVyKQorICAgICAgICByZXR1 cm47CisKKyAgICBSZWZQdHI8SW1hZ2U+IGltYWdlID0gaW1hZ2VCdWZmZXItPmNvcHlJbWFnZShE b250Q29weUJhY2tpbmdTdG9yZSk7CisgICAgaWYgKCFpbWFnZSkKKyAgICAgICAgcmV0dXJuOwor CisgICAgYXV0byBuYXRpdmVJbWFnZSA9IGltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFt ZSgpOworICAgIGlmICghbmF0aXZlSW1hZ2UpCisgICAgICAgIHJldHVybjsKKworICAgIGF1dG8m IHN0YXRlID0gdGhpcy0+c3RhdGUoKTsKKyAgICBhcHBlbmQoY3JlYXRlQ29tbWFuZDxEcmF3Rmls dGVyZWRJbWFnZUJ1ZmZlcj4obmF0aXZlSW1hZ2UtPnBsYXRmb3JtSW1hZ2UoKSwgRmxvYXRSZWN0 KHJlc3VsdC0+YWJzb2x1dGVJbWFnZVJlY3QoKSksIEZsb2F0UmVjdCh7IH0gLCBpbWFnZUJ1ZmZl ci0+bG9naWNhbFNpemUoKSksIGZpbHRlci5maWx0ZXJTY2FsZSgpLCBJbWFnZVBhaW50aW5nT3B0 aW9ucyhzdGF0ZS5pbWFnZUludGVycG9sYXRpb25RdWFsaXR5KCkpLCBzdGF0ZS5hbHBoYSgpLCBD YWlybzo6U2hhZG93U3RhdGUoc3RhdGUpKSk7Cit9CisKIHZvaWQgQ2Fpcm9PcGVyYXRpb25SZWNv cmRlcjo6ZHJhd05hdGl2ZUltYWdlKE5hdGl2ZUltYWdlJiBuYXRpdmVJbWFnZSwgY29uc3QgRmxv YXRTaXplJiBpbWFnZVNpemUsIGNvbnN0IEZsb2F0UmVjdCYgZGVzdFJlY3QsIGNvbnN0IEZsb2F0 UmVjdCYgc3JjUmVjdCwgY29uc3QgSW1hZ2VQYWludGluZ09wdGlvbnMmIG9wdGlvbnMpCiB7CiAg ICAgc3RydWN0IERyYXdOYXRpdmVJbWFnZSBmaW5hbCA6IFBhaW50aW5nT3BlcmF0aW9uLCBPcGVy YXRpb25EYXRhPFJlZlB0cjxjYWlyb19zdXJmYWNlX3Q+LCBGbG9hdFJlY3QsIEZsb2F0UmVjdCwg SW1hZ2VQYWludGluZ09wdGlvbnMsIGZsb2F0LCBDYWlybzo6U2hhZG93U3RhdGU+IHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL25pY29zaWEvY2Fpcm8vTmlj b3NpYUNhaXJvT3BlcmF0aW9uUmVjb3JkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL25pY29zaWEvY2Fpcm8vTmljb3NpYUNhaXJvT3BlcmF0aW9uUmVjb3JkZXIuaAppbmRl eCBiOTUyODYzMTM0MzMwMDJmYWU3MmJkZTQ3ODBkMzI1NjhkYzU4MWNlLi5kNjUyN2M0N2Q2MTk2 Nzg1ZGNiMWIzOGQ4M2ZlYzY0MjFkMTM2NmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9uaWNvc2lhL2NhaXJvL05pY29zaWFDYWlyb09wZXJhdGlvblJlY29y ZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS9jYWly by9OaWNvc2lhQ2Fpcm9PcGVyYXRpb25SZWNvcmRlci5oCkBAIC02NSw2ICs2NSw3IEBAIHByaXZh dGU6CiAgICAgdm9pZCBkcmF3R2x5cGhzKGNvbnN0IFdlYkNvcmU6OkZvbnQmLCBjb25zdCBXZWJD b3JlOjpHbHlwaEJ1ZmZlckdseXBoKiwgY29uc3QgV2ViQ29yZTo6R2x5cGhCdWZmZXJBZHZhbmNl KiwgdW5zaWduZWQgbnVtR2x5cGhzLCBjb25zdCBXZWJDb3JlOjpGbG9hdFBvaW50JiwgV2ViQ29y ZTo6Rm9udFNtb290aGluZ01vZGUpIG92ZXJyaWRlOwogCiAgICAgdm9pZCBkcmF3SW1hZ2VCdWZm ZXIoV2ViQ29yZTo6SW1hZ2VCdWZmZXImLCBjb25zdCBXZWJDb3JlOjpGbG9hdFJlY3QmIGRlc3Rp bmF0aW9uLCBjb25zdCBXZWJDb3JlOjpGbG9hdFJlY3QmIHNvdXJjZSwgY29uc3QgV2ViQ29yZTo6 SW1hZ2VQYWludGluZ09wdGlvbnMmKSBvdmVycmlkZTsKKyAgICB2b2lkIGRyYXdGaWx0ZXJlZElt YWdlQnVmZmVyKFdlYkNvcmU6OkltYWdlQnVmZmVyKiwgY29uc3QgV2ViQ29yZTo6RmxvYXRSZWN0 JiwgV2ViQ29yZTo6RmlsdGVyJiwgV2ViQ29yZTo6RmlsdGVyUmVzdWx0cyYpIG92ZXJyaWRlOwog ICAgIHZvaWQgZHJhd05hdGl2ZUltYWdlKFdlYkNvcmU6Ok5hdGl2ZUltYWdlJiwgY29uc3QgV2Vi Q29yZTo6RmxvYXRTaXplJiwgY29uc3QgV2ViQ29yZTo6RmxvYXRSZWN0JiwgY29uc3QgV2ViQ29y ZTo6RmxvYXRSZWN0JiwgY29uc3QgV2ViQ29yZTo6SW1hZ2VQYWludGluZ09wdGlvbnMmKSBvdmVy cmlkZTsKICAgICB2b2lkIGRyYXdQYXR0ZXJuKFdlYkNvcmU6Ok5hdGl2ZUltYWdlJiwgY29uc3Qg V2ViQ29yZTo6RmxvYXRSZWN0JiwgY29uc3QgV2ViQ29yZTo6RmxvYXRSZWN0JiwgY29uc3QgV2Vi Q29yZTo6QWZmaW5lVHJhbnNmb3JtJiwgY29uc3QgV2ViQ29yZTo6RmxvYXRQb2ludCYsIGNvbnN0 IFdlYkNvcmU6OkZsb2F0U2l6ZSYsIGNvbnN0IFdlYkNvcmU6OkltYWdlUGFpbnRpbmdPcHRpb25z Jikgb3ZlcnJpZGU7CiAK