238239 2022-03-22 16:29:30 -0700 REGRESSION (r287807): WEBGL_multi_draw validation rejecting valid arguments 2022-05-26 15:03:24 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220753 https://bugs.webkit.org/show_bug.cgi?id=238303 InRadar P2 Normal --- 222812 238240 1 kbr kkinnunen bfulgham cdumez changseok darin dino esprehn+autocc ews-watchlist gyuyoung.kim kbr kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1853988 0 kbr 2022-03-22 16:29:30 -0700 A change was made to the validation code for WEBGL_multi_draw in Bug 234966 which was incorrect. Unfortunately, it causes about half of the tests in conformance/extensions/webgl-multi-draw.html to fail, and breaks customer applications, as reported on https://groups.google.com/g/webgl-dev-list . 1854010 1 455455 kbr 2022-03-22 16:51:55 -0700 Created attachment 455455 Patch 1854013 2 kbr 2022-03-22 16:56:24 -0700 Kimmo / Brent / Darin: please review. Thanks. Confirmed by running: https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-multi-draw.html locally that this fixes the test. 1854123 3 455455 darin 2022-03-23 05:36:33 -0700 Comment on attachment 455455 Patch This seems too complicated to me. Couldn’t this also be solved by removing the incorrect type cast of size - drawCount to GCGLuint? 1854124 4 455455 darin 2022-03-23 05:38:02 -0700 Comment on attachment 455455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455455&action=review > Source/WebCore/html/canvas/WebGLMultiDraw.cpp:-137 > - if (offset >= static_cast<GCGLuint>(size - drawcount)) { The bug seems to be that this can chop a large integer to a smaller one. Can we just change this to not do that rather than adding more code? 1854125 5 455455 darin 2022-03-23 05:40:08 -0700 Comment on attachment 455455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455455&action=review >> Source/WebCore/html/canvas/WebGLMultiDraw.cpp:-137 >> - if (offset >= static_cast<GCGLuint>(size - drawcount)) { > > The bug seems to be that this can chop a large integer to a smaller one. Can we just change this to not do that rather than adding more code? Or is the real problem that this is used >= rather than >? I’d like to understand what the actual problem was before weighing in on the solution. 1854127 6 darin 2022-03-23 05:41:29 -0700 Your post about this says there are “gaps in WebGL testing in WebKit” but this patch does not include any new WebGL tests. 1854128 7 darin 2022-03-23 05:43:22 -0700 Webkit policy requires adding a new test case when fixing a bug so we do need to add a test case here. 1854129 8 darin 2022-03-23 05:44:19 -0700 We can turn https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-multi-draw.html into a test case perhaps? 1854130 9 darin 2022-03-23 05:45:04 -0700 Is there something that prevents us from using these Kronos test cases as part of the Webkit test suite? 1854131 10 webkit-bug-importer 2022-03-23 05:47:41 -0700 <rdar://problem/90694727> 1854132 11 webkit-bug-importer 2022-03-23 05:48:51 -0700 <rdar://problem/90694765> 1854133 12 darin 2022-03-23 05:49:35 -0700 I see now, by to 20753 is the reason we had this untested. Is there something we can do to resolve that so that we can at least run some of that test? 1854136 13 darin 2022-03-23 06:04:59 -0700 Besides the disabled test leaving us vulnerable, my suggestion for a cleaner way to write the range check in the first place is probably what led to the mistake. I understand if others would like to take Ken‘s patch as is. I would, however, like to understand what was wrong with the original and I think that could lead to a more elegant fix. However I will not insist on this; urgent, I think, to have this fixed one way or another. 1854156 14 455495 kkinnunen 2022-03-23 07:14:43 -0700 Created attachment 455495 alternative impl 1854157 15 455496 kkinnunen 2022-03-23 07:16:48 -0700 Created attachment 455496 alternative impl 1854159 16 kkinnunen 2022-03-23 07:19:42 -0700 *** Bug 237418 has been marked as a duplicate of this bug. *** 1854165 17 455496 darin 2022-03-23 07:46:35 -0700 Comment on attachment 455496 alternative impl Yes, I like this better. i’m gonna say r=me on this one, assuming we make sure tests really are all passing 1854299 18 455532 kbr 2022-03-23 11:35:56 -0700 Created attachment 455532 Patch 1854302 19 kbr 2022-03-23 11:38:25 -0700 Darin and Kimmo, thanks for your review and for pointing out the alternative implementation (and my unclear description of what was wrong). Anyway, here is Kimmo's patch with his authorship attributed in the ChangeLog, and the tests marked Slow in TestExpectations as they take a while to run. If the EWS is green I'll CQ this later today. 1854533 20 kbr 2022-03-23 18:34:00 -0700 The http/wpt/webrtc/getUserMedia-processSwapping.html failure on mac-AS-debug-wk2 is unrelated; filed Bug 238303 about it. Notably, webgl-multi-draw.html passed in that run in both the WebGL 1.0.x and 2.0.y conformance tests: https://ews-build.webkit.org/#/builders/60/builds/27223 1854535 21 kbr 2022-03-23 18:35:11 -0700 Kimmo, could you take over this patch from me and try to land it during your workday? In particular, to see if the other EWS bots pass. 1854653 22 ews-feeder 2022-03-24 05:45:35 -0700 Committed r291791 (248819@main): <https://commits.webkit.org/248819@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455532. 1872160 23 bfulgham 2022-05-26 15:03:24 -0700 This fix shipped with Safari 15.5 (all platforms). 455455 2022-03-22 16:51:55 -0700 2022-03-23 11:35:50 -0700 Patch bug-238239-20220322165154.patch text/plain 2249 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTgyMTlmZmRjODM1ZDcw ODdlMDQyYTE3N2NiYzVhMzkwYjg3MzlhOS4uZDk4YWZkZDc1ZWQxMGE3MDAwNDQwZmJiYzUwZWZm MjNhMjI5NzlkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIyLTAzLTIyICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEluY29ycmVjdCBjaGFu Z2UgdG8gV0VCR0xfbXVsdGlfZHJhdyB2YWxpZGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzgyMzkKKworICAgICAgICBBZGp1c3QgdGhlIG5l dywgc3RyaWN0ZXIgdmFsaWRhdGlvbiB0byBiZSBjb3JyZWN0LiBWZXJpZmllZAorICAgICAgICBs b2NhbGx5IHRoYXQgdGhlIHRlc3QgY29uZm9ybWFuY2UvZXh0ZW5zaW9ucy93ZWJnbC1tdWx0aS1k cmF3Lmh0bWwKKyAgICAgICAgcGFzc2VzIGFnYWluIHdpdGggdGhpcyB1cGRhdGUuCisKKyAgICAg ICAgQ292ZXJlZCBieSBleGlzdGluZyBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0cy4gQnVnIDIzODI0 MCBjb3ZlcnMKKyAgICAgICAgcnVubmluZyB0aGVzZSB0ZXN0cyBvbiB0aGUgRVdTIGFuZCBDUS4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwv Y2FudmFzL1dlYkdMTXVsdGlEcmF3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMTXVsdGlE cmF3Ojp2YWxpZGF0ZU9mZnNldCk6CisKIDIwMjItMDMtMjIgIEplciBOb2JsZSAgPGplci5ub2Js ZUBhcHBsZS5jb20+CiAKICAgICAgICAgWW91VHViZS5jb20gLSBDbGlja2luZyBhbnl3aGVyZSBv biB0aGUgcHJvZ3Jlc3MgYmFyIHBhdXNlcyB0aGUgdmlkZW8KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMTXVsdGlEcmF3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMTXVsdGlEcmF3LmNwcAppbmRleCBmMWNjNTZjOWRmYjE4ODRiOGI4ZGVh YTJlZWZlNTgyN2Y5MmZlZTljLi40NDUyZTZkNzE2OTczM2ZkZDQyMGM4NmJmZThmYzMxNDVkYzM1 MTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTE11bHRpRHJh dy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xNdWx0aURyYXcuY3Bw CkBAIC0xMzQsNyArMTM0LDE4IEBAIGJvb2wgV2ViR0xNdWx0aURyYXc6OnZhbGlkYXRlT2Zmc2V0 KGNvbnN0IGNoYXIqIGZ1bmN0aW9uTmFtZSwgY29uc3QgY2hhciogb3V0T2ZCCiAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICB9CiAKLSAgICBpZiAob2Zmc2V0ID49IHN0YXRpY19jYXN0PEdDR0x1 aW50PihzaXplIC0gZHJhd2NvdW50KSkgeworICAgIGlmIChvZmZzZXQgPj0gc3RhdGljX2Nhc3Q8 R0NHTHVpbnQ+KHNpemUpKSB7CisgICAgICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdMRXJyb3Io R3JhcGhpY3NDb250ZXh0R0w6OklOVkFMSURfT1BFUkFUSU9OLCBmdW5jdGlvbk5hbWUsIG91dE9m Qm91bmRzRGVzY3JpcHRpb24pOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCisgICAg Q2hlY2tlZDxHQ0dMc2l6ZWksIFJlY29yZE92ZXJmbG93PiBjaGVja2VkT2Zmc2V0UGx1c0RyYXdj b3VudCA9IENoZWNrZWQ8R0NHTHVpbnQ+KG9mZnNldCkgKyBDaGVja2VkPEdDR0xzaXplaT4oZHJh d2NvdW50KTsKKyAgICBpZiAoY2hlY2tlZE9mZnNldFBsdXNEcmF3Y291bnQuaGFzT3ZlcmZsb3dl ZCgpKSB7CisgICAgICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3NDb250 ZXh0R0w6OklOVkFMSURfT1BFUkFUSU9OLCBmdW5jdGlvbk5hbWUsICJvZmZzZXQgKyBkcmF3Y291 bnQgaXMgb3V0IG9mIGJvdW5kcyIpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCisg ICAgaWYgKGNoZWNrZWRPZmZzZXRQbHVzRHJhd2NvdW50LnZhbHVlKCkgPiBzaXplKSB7CiAgICAg ICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3NDb250ZXh0R0w6OklOVkFM SURfT1BFUkFUSU9OLCBmdW5jdGlvbk5hbWUsIG91dE9mQm91bmRzRGVzY3JpcHRpb24pOwogICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQo= 455495 2022-03-23 07:14:43 -0700 2022-03-23 07:18:51 -0700 alternative impl bug-238239-20220323161442.patch text/plain 3299 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA2NzQ5NjcyYTQyNmYz Y2NkODUyOWFlYWVmMWRmZmU3ZmI5MjgzYy4uNjUzMjBmMjFjMGZlOTE4MGU4NmQ2NTY0NmYxNmNk ZTVkMTg1YmJlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTIzICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjI4NzgwNyk6IFdFQkdMX211bHRpX2RyYXcgdmFsaWRhdGlvbiByZWplY3RpbmcgdmFsaWQgYXJn dW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MzgyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggb2ZmLWJ5LW9uZSBlcnJvciBjYXVzaW5nIGZ1bGwgYnVmZmVyIG11bHRpZHJhd3MgdG8gYmUK KyAgICAgICAgbWFya2VkIGFzIGludmFsaWQuCisKKyAgICAgICAgRW5hYmxlIHRoZSBuZXdlciBX ZWJHTCBjb25mb3JtYW5jZSB0ZXN0cyB0aGF0IHRlc3QgdGhpcy4KKworICAgICAgICAqIGh0bWwv Y2FudmFzL1dlYkdMTXVsdGlEcmF3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMTXVsdGlE cmF3Ojp2YWxpZGF0ZU9mZnNldCk6CisKIDIwMjItMDMtMDkgIFJ1c3NlbGwgRXBzdGVpbiAgPHJl cHN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGVycnktcGljayByMjkwNTE1LiByZGFyOi8v cHJvYmxlbS84OTM3NjQ4NApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xNdWx0aURyYXcuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xNdWx0 aURyYXcuY3BwCmluZGV4IDY0YjE1ZDVmZjg2MTNjZmQ3ODRjN2UzMWQwMjJkNTNiZDYxM2NlZmUu LjY3ZWY1OTA1OTc2NmRkZDAzNWQ4ZTlmNTU3ZDIyY2VkNzI1YjIzMTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMTXVsdGlEcmF3LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTE11bHRpRHJhdy5jcHAKQEAgLTEzNSw3ICsxMzUsNyBA QCBib29sIFdlYkdMTXVsdGlEcmF3Ojp2YWxpZGF0ZU9mZnNldChjb25zdCBjaGFyKiBmdW5jdGlv bk5hbWUsIGNvbnN0IGNoYXIqIG91dE9mQgogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQog Ci0gICAgaWYgKG9mZnNldCA+PSBzdGF0aWNfY2FzdDxHQ0dMdWludD4oc2l6ZSAtIGRyYXdjb3Vu dCkpIHsKKyAgICBpZiAob2Zmc2V0ID4gc3RhdGljX2Nhc3Q8R0NHTHVpbnQ+KHNpemUgLSBkcmF3 Y291bnQpKSB7CiAgICAgICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3ND b250ZXh0R0w6OklOVkFMSURfT1BFUkFUSU9OLCBmdW5jdGlvbk5hbWUsIG91dE9mQm91bmRzRGVz Y3JpcHRpb24pOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI2OTlhMDMw ZDA4OGRlNjE1OGEwMmIyOWU2NTdiMjA3NTFhYTNmMDUuLjBkNTVlYjFjYTM1YmQwNGJjYTkxYTA5 ZGM2ZGY2ZDI1NGI4YjFhZjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMy0yMyAgS2lt bW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyODc4MDcpOiBXRUJHTF9tdWx0aV9kcmF3IHZhbGlkYXRpb24gcmVqZWN0aW5nIHZhbGlkIGFy Z3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjM4MjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RW5hYmxlIHRoZSBuZXdlciBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0cyB0aGF0IHRlc3QgdGhpcy4K KworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjItMDMtMDkgIFJ1c3NlbGwgRXBz dGVpbiAgPHJlcHN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGVycnktcGljayByMjkwNTE1 LiByZGFyOi8vcHJvYmxlbS84OTM3NjQ4NApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4 cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYmFmMTllNzU1 N2U1ODU5MmMwZTMxNzA2MWQ4ODZmNzA0NTg0YzE3My4uMWE3ZmFkZjJkYTQyMTU3M2FmZjFmZDEx Y2NhZTc3Yjc5NjhlMzJmMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0zNjU1LDkgKzM2NTUsMTEg QEAgd2ViZ2wvMi4wLnkvY29uZm9ybWFuY2UvY2FudmFzL3RvLWRhdGEtdXJsLXRlc3QuaHRtbCBb IFBhc3MgXQogd2ViZ2wvMi4wLnkvY29uZm9ybWFuY2UvbWlzYy9pbnZhbGlkLXBhc3NlZC1wYXJh bXMuaHRtbCBbIFBhc3MgXQogd2ViZ2wvMi4wLnkvY29uZm9ybWFuY2UvZ2xzbC9idWdzL2NoYXJh Y3Rlci1zZXQuaHRtbCBbIFBhc3MgXQogd2ViZ2wvMi4wLnkvY29uZm9ybWFuY2UvZ2xzbC9taXNj L2ZyYWdjb2xvci1mcmFnZGF0YS1pbnZhcmlhbnQuaHRtbCBbIFBhc3MgXQord2ViZ2wvMi4wLnkv Y29uZm9ybWFuY2UvZXh0ZW5zaW9ucy93ZWJnbC1tdWx0aS1kcmF3Lmh0bWwgWyBQYXNzIF0KIHdl YmdsLzIuMC55L2NvbmZvcm1hbmNlMi9jb250ZXh0L2NvbnN0YW50cy1hbmQtcHJvcGVydGllcy0y Lmh0bWwgWyBQYXNzIF0KIHdlYmdsLzIuMC55L2NvbmZvcm1hbmNlMi92ZXJ0ZXhfYXJyYXlzL3Zl cnRleC1hcnJheS1vYmplY3QuaHRtbCBbIFBhc3MgXQogd2ViZ2wvMS4wLngvY29uZm9ybWFuY2Uv ZXh0ZW5zaW9ucy9vZXMtdmVydGV4LWFycmF5LW9iamVjdC5odG1sIFsgUGFzcyBdCit3ZWJnbC8x LjAueC9jb25mb3JtYW5jZS9leHRlbnNpb25zL3dlYmdsLW11bHRpLWRyYXcuaHRtbCBbIFBhc3Mg XQogCiAjIEV4cGxpY2l0bHkgdHVybiBvbiBjb25mb3JtYW5jZSB0ZXN0IHVudGlsIGFsbCBvZiB3 ZWJnbC8yLjAueSBpcyBlbmFibGVkCiB3ZWJnbC8yLjAueS9jb25mb3JtYW5jZS9leHRlbnNpb25z L3dlYmdsLWNvbXByZXNzZWQtdGV4dHVyZS1zM3RjLXNyZ2IuaHRtbCBbIFBhc3MgXQo= 455496 2022-03-23 07:16:48 -0700 2022-03-23 11:35:53 -0700 alternative impl bug-238239-20220323161647.patch text/plain 3513 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA2NzQ5NjcyYTQyNmYz Y2NkODUyOWFlYWVmMWRmZmU3ZmI5MjgzYy4uNjUzMjBmMjFjMGZlOTE4MGU4NmQ2NTY0NmYxNmNk ZTVkMTg1YmJlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTIzICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjI4NzgwNyk6IFdFQkdMX211bHRpX2RyYXcgdmFsaWRhdGlvbiByZWplY3RpbmcgdmFsaWQgYXJn dW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MzgyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggb2ZmLWJ5LW9uZSBlcnJvciBjYXVzaW5nIGZ1bGwgYnVmZmVyIG11bHRpZHJhd3MgdG8gYmUK KyAgICAgICAgbWFya2VkIGFzIGludmFsaWQuCisKKyAgICAgICAgRW5hYmxlIHRoZSBuZXdlciBX ZWJHTCBjb25mb3JtYW5jZSB0ZXN0cyB0aGF0IHRlc3QgdGhpcy4KKworICAgICAgICAqIGh0bWwv Y2FudmFzL1dlYkdMTXVsdGlEcmF3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMTXVsdGlE cmF3Ojp2YWxpZGF0ZU9mZnNldCk6CisKIDIwMjItMDMtMDkgIFJ1c3NlbGwgRXBzdGVpbiAgPHJl cHN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGVycnktcGljayByMjkwNTE1LiByZGFyOi8v cHJvYmxlbS84OTM3NjQ4NApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xNdWx0aURyYXcuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xNdWx0 aURyYXcuY3BwCmluZGV4IDY0YjE1ZDVmZjg2MTNjZmQ3ODRjN2UzMWQwMjJkNTNiZDYxM2NlZmUu LjY3ZWY1OTA1OTc2NmRkZDAzNWQ4ZTlmNTU3ZDIyY2VkNzI1YjIzMTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMTXVsdGlEcmF3LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTE11bHRpRHJhdy5jcHAKQEAgLTEzNSw3ICsxMzUsNyBA QCBib29sIFdlYkdMTXVsdGlEcmF3Ojp2YWxpZGF0ZU9mZnNldChjb25zdCBjaGFyKiBmdW5jdGlv bk5hbWUsIGNvbnN0IGNoYXIqIG91dE9mQgogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQog Ci0gICAgaWYgKG9mZnNldCA+PSBzdGF0aWNfY2FzdDxHQ0dMdWludD4oc2l6ZSAtIGRyYXdjb3Vu dCkpIHsKKyAgICBpZiAob2Zmc2V0ID4gc3RhdGljX2Nhc3Q8R0NHTHVpbnQ+KHNpemUgLSBkcmF3 Y291bnQpKSB7CiAgICAgICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3ND b250ZXh0R0w6OklOVkFMSURfT1BFUkFUSU9OLCBmdW5jdGlvbk5hbWUsIG91dE9mQm91bmRzRGVz Y3JpcHRpb24pOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI2OTlhMDMw ZDA4OGRlNjE1OGEwMmIyOWU2NTdiMjA3NTFhYTNmMDUuLjBkNTVlYjFjYTM1YmQwNGJjYTkxYTA5 ZGM2ZGY2ZDI1NGI4YjFhZjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMy0yMyAgS2lt bW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyODc4MDcpOiBXRUJHTF9tdWx0aV9kcmF3IHZhbGlkYXRpb24gcmVqZWN0aW5nIHZhbGlkIGFy Z3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjM4MjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RW5hYmxlIHRoZSBuZXdlciBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0cyB0aGF0IHRlc3QgdGhpcy4K KworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjItMDMtMDkgIFJ1c3NlbGwgRXBz dGVpbiAgPHJlcHN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGVycnktcGljayByMjkwNTE1 LiByZGFyOi8vcHJvYmxlbS84OTM3NjQ4NApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4 cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYmFmMTllNzU1 N2U1ODU5MmMwZTMxNzA2MWQ4ODZmNzA0NTg0YzE3My4uMzFmMTI4NzI5MTlhZmZmZjcwZTc0ZDI0 MGM0MGFhYmI0NDUwNDMxZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0zNjQ1LDYgKzM2NDUsNyBA QCB3ZWJnbC8xLjAueC9jb25mb3JtYW5jZS9taXNjL2ludmFsaWQtcGFzc2VkLXBhcmFtcy5odG1s IFsgUGFzcyBdCiB3ZWJnbC8xLjAueC9jb25mb3JtYW5jZS9nbHNsL2J1Z3MvY2hhcmFjdGVyLXNl dC5odG1sIFsgUGFzcyBdCiB3ZWJnbC8xLjAueC9jb25mb3JtYW5jZS9nbHNsL21pc2MvZnJhZ2Nv bG9yLWZyYWdkYXRhLWludmFyaWFudC5odG1sIFsgUGFzcyBdCiB3ZWJnbC8xLjAueC9jb25mb3Jt YW5jZS9jb250ZXh0L2NvbnN0YW50cy1hbmQtcHJvcGVydGllcy5odG1sIFsgUGFzcyBdCit3ZWJn bC8xLjAueC9jb25mb3JtYW5jZS9leHRlbnNpb25zL3dlYmdsLW11bHRpLWRyYXcuaHRtbCBbIFBh c3MgXQogCiAKICMgV2ViR0wgY29uZm9ybWFuY2UgdGVzdCBzdWl0ZSAyLjAuMSBpcyBza2lwcGVk IHVudGlsIDIuMC4wIGlzIHJldGlyZWQuCkBAIC0zNjU1LDYgKzM2NTYsNyBAQCB3ZWJnbC8yLjAu eS9jb25mb3JtYW5jZS9jYW52YXMvdG8tZGF0YS11cmwtdGVzdC5odG1sIFsgUGFzcyBdCiB3ZWJn bC8yLjAueS9jb25mb3JtYW5jZS9taXNjL2ludmFsaWQtcGFzc2VkLXBhcmFtcy5odG1sIFsgUGFz cyBdCiB3ZWJnbC8yLjAueS9jb25mb3JtYW5jZS9nbHNsL2J1Z3MvY2hhcmFjdGVyLXNldC5odG1s IFsgUGFzcyBdCiB3ZWJnbC8yLjAueS9jb25mb3JtYW5jZS9nbHNsL21pc2MvZnJhZ2NvbG9yLWZy YWdkYXRhLWludmFyaWFudC5odG1sIFsgUGFzcyBdCit3ZWJnbC8yLjAueS9jb25mb3JtYW5jZS9l eHRlbnNpb25zL3dlYmdsLW11bHRpLWRyYXcuaHRtbCBbIFBhc3MgXQogd2ViZ2wvMi4wLnkvY29u Zm9ybWFuY2UyL2NvbnRleHQvY29uc3RhbnRzLWFuZC1wcm9wZXJ0aWVzLTIuaHRtbCBbIFBhc3Mg XQogd2ViZ2wvMi4wLnkvY29uZm9ybWFuY2UyL3ZlcnRleF9hcnJheXMvdmVydGV4LWFycmF5LW9i amVjdC5odG1sIFsgUGFzcyBdCiB3ZWJnbC8xLjAueC9jb25mb3JtYW5jZS9leHRlbnNpb25zL29l cy12ZXJ0ZXgtYXJyYXktb2JqZWN0Lmh0bWwgWyBQYXNzIF0K 455532 2022-03-23 11:35:56 -0700 2022-03-24 05:45:37 -0700 Patch bug-238239-20220323113555.patch text/plain 3604 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGYzOGJmMmE1MDhiOWY2 MDQ0OTRhODA2NjAxYzE3OGE3MWE1NjVlZC4uZGNmZjRmYTVjOTMwMzA5ZThkNzc2Y2JiOTc3NzJi MDJhZDkyNmU5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTIzICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjI4NzgwNyk6IFdFQkdMX211bHRpX2RyYXcgdmFsaWRhdGlvbiByZWplY3RpbmcgdmFsaWQgYXJn dW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MzgyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBGaXgg b2ZmLWJ5LW9uZSBlcnJvciBjYXVzaW5nIGZ1bGwgYnVmZmVyIG11bHRpZHJhd3MgdG8gYmUKKyAg ICAgICAgbWFya2VkIGFzIGludmFsaWQuCisKKyAgICAgICAgRW5hYmxlIHRoZSBuZXdlciBXZWJH TCBjb25mb3JtYW5jZSB0ZXN0cyB0aGF0IHRlc3QgdGhpcy4KKworICAgICAgICAqIGh0bWwvY2Fu dmFzL1dlYkdMTXVsdGlEcmF3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMTXVsdGlEcmF3 Ojp2YWxpZGF0ZU9mZnNldCk6CisKIDIwMjItMDMtMjMgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51 bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBBZnRlciBsb3NpbmcgY29udGV4dCBkdWUgdG8gdG9v IG1hbnkgY29udGV4dHMsIGdldEVycm9yKCkgZG9lcyBub3QgcmV0dXJuIENPTlRFWFRfTE9TVF9X RUJHTApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xNdWx0aURy YXcuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xNdWx0aURyYXcuY3BwCmlu ZGV4IGYxY2M1NmM5ZGZiMTg4NGI4YjhkZWFhMmVlZmU1ODI3ZjkyZmVlOWMuLjk0ZGZjYzQ3YTQ2 MTI3MmQ5YWFlYTJjY2IzNDVkYzM3NzM3YjdhMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMTXVsdGlEcmF3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTE11bHRpRHJhdy5jcHAKQEAgLTEzNCw3ICsxMzQsNyBAQCBib29sIFdlYkdM TXVsdGlEcmF3Ojp2YWxpZGF0ZU9mZnNldChjb25zdCBjaGFyKiBmdW5jdGlvbk5hbWUsIGNvbnN0 IGNoYXIqIG91dE9mQgogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgaWYgKG9m ZnNldCA+PSBzdGF0aWNfY2FzdDxHQ0dMdWludD4oc2l6ZSAtIGRyYXdjb3VudCkpIHsKKyAgICBp ZiAob2Zmc2V0ID4gc3RhdGljX2Nhc3Q8R0NHTHVpbnQ+KHNpemUgLSBkcmF3Y291bnQpKSB7CiAg ICAgICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3NDb250ZXh0R0w6OklO VkFMSURfT1BFUkFUSU9OLCBmdW5jdGlvbk5hbWUsIG91dE9mQm91bmRzRGVzY3JpcHRpb24pOwog ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVjZjdkMjBiN2Y0YzgzYjNiY2Nj ODExMTZlOGIyYzE5MDE1NjVhNjguLmQzMmI4YWRlMjkzN2ViZjhkYjYxODgyMDE3ZmQwYjA3YzJm OTY0MTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMi0wMy0yMyAgS2ltbW8gS2lubnVuZW4g IDxra2lubnVuZW5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyODc4MDcpOiBX RUJHTF9tdWx0aV9kcmF3IHZhbGlkYXRpb24gcmVqZWN0aW5nIHZhbGlkIGFyZ3VtZW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4MjM5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgRW5hYmxlIHRoZSBuZXdl ciBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0cyB0aGF0IHRlc3QgdGhpcywgbWFya2VkCisgICAgICAg IFNsb3cgYXMgdGhleSB0YWtlIGEgd2hpbGUgdG8gcnVuLgorCisgICAgICAgICogVGVzdEV4cGVj dGF0aW9uczoKKwogMjAyMi0wMy0yMyAgTWF0dGVvIEZsb3JlcyAgPG1hdHRlb19mbG9yZXNAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjkxNzIxLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBl Y3RhdGlvbnMKaW5kZXggZTRiYWY4YWZmYjQ0NzY2NzliNTgzNmMwYzg2NGRhYjljZGY4YjA3OS4u Zjg5MDdmYzRhNjlhMzlhZGMwNjRmNjFiMmI4MjBmYWM2Y2JkZjgzOCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRp b25zCkBAIC0zNjQ3LDYgKzM2NDcsNyBAQCB3ZWJnbC8xLjAueC9jb25mb3JtYW5jZS9taXNjL2lu dmFsaWQtcGFzc2VkLXBhcmFtcy5odG1sIFsgUGFzcyBdCiB3ZWJnbC8xLjAueC9jb25mb3JtYW5j ZS9nbHNsL2J1Z3MvY2hhcmFjdGVyLXNldC5odG1sIFsgUGFzcyBdCiB3ZWJnbC8xLjAueC9jb25m b3JtYW5jZS9nbHNsL21pc2MvZnJhZ2NvbG9yLWZyYWdkYXRhLWludmFyaWFudC5odG1sIFsgUGFz cyBdCiB3ZWJnbC8xLjAueC9jb25mb3JtYW5jZS9jb250ZXh0L2NvbnN0YW50cy1hbmQtcHJvcGVy dGllcy5odG1sIFsgUGFzcyBdCit3ZWJnbC8xLjAueC9jb25mb3JtYW5jZS9leHRlbnNpb25zL3dl YmdsLW11bHRpLWRyYXcuaHRtbCBbIFBhc3MgU2xvdyBdCiAKIAogIyBXZWJHTCBjb25mb3JtYW5j ZSB0ZXN0IHN1aXRlIDIuMC4xIGlzIHNraXBwZWQgdW50aWwgMi4wLjAgaXMgcmV0aXJlZC4KQEAg LTM2NTcsNiArMzY1OCw3IEBAIHdlYmdsLzIuMC55L2NvbmZvcm1hbmNlL2NhbnZhcy90by1kYXRh LXVybC10ZXN0Lmh0bWwgWyBQYXNzIF0KIHdlYmdsLzIuMC55L2NvbmZvcm1hbmNlL21pc2MvaW52 YWxpZC1wYXNzZWQtcGFyYW1zLmh0bWwgWyBQYXNzIF0KIHdlYmdsLzIuMC55L2NvbmZvcm1hbmNl L2dsc2wvYnVncy9jaGFyYWN0ZXItc2V0Lmh0bWwgWyBQYXNzIF0KIHdlYmdsLzIuMC55L2NvbmZv cm1hbmNlL2dsc2wvbWlzYy9mcmFnY29sb3ItZnJhZ2RhdGEtaW52YXJpYW50Lmh0bWwgWyBQYXNz IF0KK3dlYmdsLzIuMC55L2NvbmZvcm1hbmNlL2V4dGVuc2lvbnMvd2ViZ2wtbXVsdGktZHJhdy5o dG1sIFsgUGFzcyBTbG93IF0KIHdlYmdsLzIuMC55L2NvbmZvcm1hbmNlMi9jb250ZXh0L2NvbnN0 YW50cy1hbmQtcHJvcGVydGllcy0yLmh0bWwgWyBQYXNzIF0KIHdlYmdsLzIuMC55L2NvbmZvcm1h bmNlMi92ZXJ0ZXhfYXJyYXlzL3ZlcnRleC1hcnJheS1vYmplY3QuaHRtbCBbIFBhc3MgXQogd2Vi Z2wvMS4wLngvY29uZm9ybWFuY2UvZXh0ZW5zaW9ucy9vZXMtdmVydGV4LWFycmF5LW9iamVjdC5o dG1sIFsgUGFzcyBdCg==