23823 2009-02-07 08:36:17 -0800 [Gtk] Running automake fails with current automake/libtool 2009-02-12 20:55:17 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 calvin.walton webkit-unassigned oldest_to_newest 108834 0 calvin.walton 2009-02-07 08:36:17 -0800 With current versions of autotools, creating the build system fails with the following messages: autoreconf-2.63: running: automake --add-missing --copy --no-force /usr/share/automake-1.10/am/depend2.am: am__fastdepCXX does not appear in AM_CONDITIONAL /usr/share/automake-1.10/am/depend2.am: The usual way to define `am__fastdepCXX' is to add `AC_PROG_CXX' /usr/share/automake-1.10/am/depend2.am: to `configure.ac' and run `aclocal' and `autoconf' again. GNUmakefile.am: C++ source seen but `CXX' is undefined GNUmakefile.am: The usual way to define `CXX' is to add `AC_PROG_CXX' GNUmakefile.am: to `configure.ac' and run `autoconf' again. autoreconf-2.63: automake failed with exit status: 1 (autoconf 2.63, automake 1.10.2, libtool 2.2.6) The fix is quite simple, as suggested by the error - simply use the AC_PROG_CXX macro in configure.ac. (This will not affect older autotools versions, as the macro has been around for a long time - it is simply no longer automatically included). 108835 1 27450 calvin.walton 2009-02-07 08:43:37 -0800 Created attachment 27450 Patch adding AC_PROG_CXX macro to configure.ac I've created a patch adding a check for AC_PROG_CXX to the configure.ac file. I've tried to follow the committing guidelines as close as possible, please let me know if I got anything wrong! 108907 2 zecke 2009-02-08 11:57:43 -0800 Please use the prepare-ChaneLog utility and upload a new patch. 109008 3 27450 zecke 2009-02-09 12:34:54 -0800 Comment on attachment 27450 Patch adding AC_PROG_CXX macro to configure.ac Please see http://webkit.org/coding/contributing.html for future patches. Your manual creation of the ChangeLog is creating more work for me. 109012 4 zecke 2009-02-09 12:49:11 -0800 Landed in r40790. 109085 5 calvin.walton 2009-02-09 19:50:54 -0800 Ah, sorry about that; I was about to redo the patch using the proper tools, but it seems you beat me to it. 109598 6 gustavo 2009-02-12 17:20:08 -0800 This change is bogus, I believe. WebKit's configure.ac already calls the AC_PROG_CXX macro through WEBKIT_INIT, which is defined in its webkit.m4, and protects the call so that CXXFLAGS is not modified incorrectly. With this change debugging symbols are being added because the first AC_PROG_CXX is not protected to not allow CXXFLAGS modification. This caused: https://bugs.webkit.org/show_bug.cgi?id=23939 We need a better way to shut up automake1.10, although my (Debian) automake 1.10 did not complain about AC_PROG_CXX missing when I removed the call added by this change. 109610 7 calvin.walton 2009-02-12 20:55:17 -0800 Hmm. I investigated a little more, and found that this only happened on one of my two computers (both of which are supposed to have the same build system tool versions). I suspect deeper problems with the one computer specifically now, and it looks like the original code was correct - the comment on bug #23939 says that this macro is already called, with debug compiler flag protection. It would probably be best to revert this change, fixing bug #23939 at the same time. Sorry about that :/ 27450 2009-02-07 08:43:37 -0800 2009-02-09 12:34:54 -0800 Patch adding AC_PROG_CXX macro to configure.ac 0001--Gtk-Fix-build-with-recent-autotools.patch text/plain 1465 calvin.walton RnJvbSA4NDFjMjYxYzI0MzIzMDA3YjFlZjBjYTNhMGVlNzk0NjI0NjQ1NTg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYWx2aW4gV2FsdG9uIDxjYWx2aW4ud2FsdG9uQGdtYWlsLmNv bT4KRGF0ZTogU2F0LCA3IEZlYiAyMDA5IDExOjIyOjM3IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0g W0d0a10gRml4IGJ1aWxkIHdpdGggcmVjZW50IGF1dG90b29scwoKQ3VycmVudCB2ZXJzaW9ucyBv ZiBhdXRvbWFrZS9saWJ0b29sIGRvbid0IGFzc3VtZSB5b3Ugd2FudCBDKysgZW5hYmxlZApieSBk ZWZhdWx0IGFueSBtb3JlLCBzbyBleHBsaWNpdGx5IGNoZWNrIGZvciBhIEMrKyBjb21waWxlci4K CiogY29uZmlndXJlLmFjOiBBZGQgQUNfUFJPR19DWFggbWFjcm8KLS0tCiBDaGFuZ2VMb2cgICAg fCAgICA5ICsrKysrKysrKwogY29uZmlndXJlLmFjIHwgICAgMyArKysKIDIgZmlsZXMgY2hhbmdl ZCwgMTIgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9DaGFuZ2VM b2cgYi9DaGFuZ2VMb2cKaW5kZXggNmFlOTlkMi4uYTRkODYxOCAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDA5LTAyLTA3ICBDYWx2aW4g V2FsdG9uICA8Y2FsdmluLndhbHRvbkBnbWFpbC5jb20+CisKKwlbR3RrXSBGaXggYnVpbGQgd2l0 aCByZWNlbnQgYXV0b3Rvb2xzCisKKwlDdXJyZW50IHZlcnNpb25zIG9mIGF1dG9tYWtlL2xpYnRv b2wgZG9uJ3QgYXNzdW1lIHlvdSB3YW50IEMrKyBlbmFibGVkCisJYnkgZGVmYXVsdCBhbnkgbW9y ZSwgc28gZXhwbGljaXRseSBjaGVjayBmb3IgYSBDKysgY29tcGlsZXIuCisKKyAgICAgICAgKiBj b25maWd1cmUuYWM6IEFkZCBBQ19QUk9HX0NYWCBtYWNybworCiAyMDA5LTAyLTAyICBDaHJpc3Rp YW4gRHl3YW4gIDxjaHJpc3RpYW5AdHdvdG9hc3RzLmRlPgogCiAgICAgICAgIFJ1YmJlci1zdGFt cGVkIGJ5IEhvbGdlciBGcmV5dGhlci4KZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZp Z3VyZS5hYwppbmRleCAwOGQ5OGI2Li5jN2VkOTg4IDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMK KysrIGIvY29uZmlndXJlLmFjCkBAIC0yNyw2ICsyNyw5IEBAIGRubCAjIHNlZSBodHRwOi8vd3d3 LmdudS5vcmcvc29mdHdhcmUvbGlidG9vbC9tYW51YWwuaHRtbCNWZXJzaW9uaW5nCiBMSUJXRUJL SVRHVEtfVkVSU0lPTj0xOjA6MAogQUNfU1VCU1QoW0xJQldFQktJVEdUS19WRVJTSU9OXSkKIAor IyBSZWNlbnQgbGlidG9vbCthdXRvbWFrZSBkb24ndCBhc3N1bWUgeW91IHdhbnQgQysrLCBleHBs aWNpdGx5IGVuYWJsZSBpdAorQUNfUFJPR19DWFgKKwogQU1fSU5JVF9BVVRPTUFLRShbZm9yZWln biBzdWJkaXItb2JqZWN0cyB0YXItdXN0YXJdKQogCiAjIGhvc3QgY2hlY2tpbmcgLSBpbnNwaXJl ZCBieSB0aGUgR1RLKyBjb25maWd1cmUuaW4KLS0gCjEuNi4xLjIKCg==