238221 2022-03-22 13:05:01 -0700 Add URL::stringWithoutFragmentIdentifier() overload which returns a String instead of a StringView 2022-03-22 20:02:54 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=236069 InRadar P2 Normal --- 1 cdumez cdumez achristensen benjamin cmarcelo darin ews-watchlist ggaren webkit-bug-importer oldest_to_newest 1853865 0 cdumez 2022-03-22 13:05:01 -0700 Add URL::stringWithoutFragmentIdentifier() overload which returns a String instead of a StringView. 1853868 1 455419 cdumez 2022-03-22 13:06:14 -0700 Created attachment 455419 Patch 1853993 2 455419 ggaren 2022-03-22 16:37:10 -0700 Comment on attachment 455419 Patch r=me 1854031 3 ews-feeder 2022-03-22 17:59:55 -0700 Committed r291730 (248762@main): <https://commits.webkit.org/248762@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455419. 1854032 4 webkit-bug-importer 2022-03-22 18:00:21 -0700 <rdar://problem/90670425> 1854045 5 achristensen 2022-03-22 20:01:48 -0700 What motivated this change? 1854046 6 cdumez 2022-03-22 20:02:54 -0700 (In reply to Alex Christensen from comment #5) > What motivated this change? Review feedback from Darin here: https://bugs.webkit.org/show_bug.cgi?id=236069#c11 455419 2022-03-22 13:06:14 -0700 2022-03-22 17:59:58 -0700 Patch bug-238221-20220322130613.patch text/plain 7086 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ2M2E2ZmMwZWMzZjk0YmE4NzdmMzY4 NWI1OTNiOTRhNjRiZGI1MjUuLjQ0ZWIxZWU5YzA1NGMwMDRkMTdmOTA5NWJlNmFmOTBhYmJlYjM3 YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjItMDMtMjIgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgVVJMOjpzdHJpbmdXaXRob3V0RnJhZ21lbnRJZGVu dGlmaWVyKCkgb3ZlcmxvYWQgd2hpY2ggcmV0dXJucyBhIFN0cmluZyBpbnN0ZWFkIG9mIGEgU3Ry aW5nVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjM4MjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB3dGYvVVJMLmNwcDoKKyAgICAgICAgKFdURjo6VVJMOjp2aWV3V2l0aG91dFF1ZXJ5T3JGcmFn bWVudElkZW50aWZpZXIgY29uc3QpOgorICAgICAgICAoV1RGOjpVUkw6OnZpZXdXaXRob3V0RnJh Z21lbnRJZGVudGlmaWVyIGNvbnN0KToKKyAgICAgICAgKFdURjo6VVJMOjpzdHJpbmdXaXRob3V0 RnJhZ21lbnRJZGVudGlmaWVyIGNvbnN0KToKKyAgICAgICAgKFdURjo6ZXF1YWxJZ25vcmluZ0Zy YWdtZW50SWRlbnRpZmllcik6CisgICAgICAgIChXVEY6OlVSTDo6c3RyaW5nV2l0aG91dFF1ZXJ5 T3JGcmFnbWVudElkZW50aWZpZXIgY29uc3QpOiBEZWxldGVkLgorICAgICAgICAqIHd0Zi9VUkwu aDoKKwogMjAyMi0wMy0yMiAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgRW5hYmxlIGNvbnRlbnQgZmlsdGVyaW5nIGluIHRoZSBOZXR3b3JrIHByb2Nlc3MK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzcyM2NiMjQ3NDZiNzg3ZmRmMjRlMTdkMTJlNzU4ODhmMWQ1ZWRjLi40 ZTQxMmVkNmE4Y2NjYTllYWY5NDUwNzhmZjA2NzkwMzFhZGVkNjAwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMjItMDMtMjIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K KworICAgICAgICBBZGQgVVJMOjpzdHJpbmdXaXRob3V0RnJhZ21lbnRJZGVudGlmaWVyKCkgb3Zl cmxvYWQgd2hpY2ggcmV0dXJucyBhIFN0cmluZyBpbnN0ZWFkIG9mIGEgU3RyaW5nVmlldworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4MjIxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0hpc3Rv cnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeTo6c3RhdGVPYmplY3RBZGRlZCk6Cisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9CbG9iUmVnaXN0cnlJbXBsLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkJsb2JSZWdpc3RyeUltcGw6OmdldEJsb2JEYXRhRnJvbVVSTCBjb25zdCk6Cisg ICAgICAgIChXZWJDb3JlOjpCbG9iUmVnaXN0cnlJbXBsOjpyZWdpc3RlckJsb2JVUkxIYW5kbGUp OgorICAgICAgICAoV2ViQ29yZTo6QmxvYlJlZ2lzdHJ5SW1wbDo6dW5yZWdpc3RlckJsb2JVUkxI YW5kbGUpOgorICAgICAgICAoV2ViQ29yZTo6YmxvYlVSTFdpdGhvdXRGcmFnbWVudCk6IERlbGV0 ZWQuCisKIDIwMjItMDMtMjIgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjkxNTQ2LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvVVJMLmNwcCBiL1NvdXJjZS9XVEYvd3RmL1VSTC5jcHAKaW5kZXggNDgw ZmVjNjQ0MjZiMDg2YTg1ZmMwZDE4YzI5ZTc4MTk3ZTRmZDQ3Yi4uMDJiMDdlNWEyZWMwOTJkNzZm MWM2OGY5Mzk4NmY5ZTNlMDE1MGYyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVVJMLmNw cAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9VUkwuY3BwCkBAIC03MDgsNyArNzA4LDcgQEAgdm9pZCBV Ukw6OnNldFBhdGgoU3RyaW5nVmlldyBwYXRoKQogICAgICkpOwogfQogCi1TdHJpbmdWaWV3IFVS TDo6c3RyaW5nV2l0aG91dFF1ZXJ5T3JGcmFnbWVudElkZW50aWZpZXIoKSBjb25zdAorU3RyaW5n VmlldyBVUkw6OnZpZXdXaXRob3V0UXVlcnlPckZyYWdtZW50SWRlbnRpZmllcigpIGNvbnN0CiB7 CiAgICAgaWYgKCFtX2lzVmFsaWQpCiAgICAgICAgIHJldHVybiBtX3N0cmluZzsKQEAgLTcxNiw3 ICs3MTYsNyBAQCBTdHJpbmdWaWV3IFVSTDo6c3RyaW5nV2l0aG91dFF1ZXJ5T3JGcmFnbWVudElk ZW50aWZpZXIoKSBjb25zdAogICAgIHJldHVybiBTdHJpbmdWaWV3KG1fc3RyaW5nKS5sZWZ0KHBh dGhFbmQoKSk7CiB9CiAKLVN0cmluZ1ZpZXcgVVJMOjpzdHJpbmdXaXRob3V0RnJhZ21lbnRJZGVu dGlmaWVyKCkgY29uc3QKK1N0cmluZ1ZpZXcgVVJMOjp2aWV3V2l0aG91dEZyYWdtZW50SWRlbnRp ZmllcigpIGNvbnN0CiB7CiAgICAgaWYgKCFtX2lzVmFsaWQpCiAgICAgICAgIHJldHVybiBtX3N0 cmluZzsKQEAgLTcyNCw5ICs3MjQsMTcgQEAgU3RyaW5nVmlldyBVUkw6OnN0cmluZ1dpdGhvdXRG cmFnbWVudElkZW50aWZpZXIoKSBjb25zdAogICAgIHJldHVybiBTdHJpbmdWaWV3KG1fc3RyaW5n KS5sZWZ0KG1fcXVlcnlFbmQpOwogfQogCitTdHJpbmcgVVJMOjpzdHJpbmdXaXRob3V0RnJhZ21l bnRJZGVudGlmaWVyKCkgY29uc3QKK3sKKyAgICBpZiAoIW1faXNWYWxpZCkKKyAgICAgICAgcmV0 dXJuIG1fc3RyaW5nOworCisgICAgcmV0dXJuIG1fc3RyaW5nLmxlZnQobV9xdWVyeUVuZCk7Cit9 CisKIGJvb2wgZXF1YWxJZ25vcmluZ0ZyYWdtZW50SWRlbnRpZmllcihjb25zdCBVUkwmIGEsIGNv bnN0IFVSTCYgYikKIHsKLSAgICByZXR1cm4gYS5zdHJpbmdXaXRob3V0RnJhZ21lbnRJZGVudGlm aWVyKCkgPT0gYi5zdHJpbmdXaXRob3V0RnJhZ21lbnRJZGVudGlmaWVyKCk7CisgICAgcmV0dXJu IGEudmlld1dpdGhvdXRGcmFnbWVudElkZW50aWZpZXIoKSA9PSBiLnZpZXdXaXRob3V0RnJhZ21l bnRJZGVudGlmaWVyKCk7CiB9CiAKIGJvb2wgcHJvdG9jb2xIb3N0QW5kUG9ydEFyZUVxdWFsKGNv bnN0IFVSTCYgYSwgY29uc3QgVVJMJiBiKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVVJM LmggYi9Tb3VyY2UvV1RGL3d0Zi9VUkwuaAppbmRleCAyNzliMzVlMDdkMTAzNjI5MGI1YTcxYjU1 MzhkMGZhN2ZmMTRmMzhjLi5iODcwZjIzMTVhZjc0MWMzMjllOGVmMjdlOTI3YmU5Mzg0MzFjNDlj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9VUkwuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9V UkwuaApAQCAtMTE3LDggKzExNyw5IEBAIHB1YmxpYzoKIAogICAgIFdURl9FWFBPUlRfUFJJVkFU RSBTdHJpbmdWaWV3IHF1ZXJ5V2l0aExlYWRpbmdRdWVzdGlvbk1hcmsoKSBjb25zdDsKICAgICBX VEZfRVhQT1JUX1BSSVZBVEUgU3RyaW5nVmlldyBmcmFnbWVudElkZW50aWZpZXJXaXRoTGVhZGlu Z051bWJlclNpZ24oKSBjb25zdDsKLSAgICBXVEZfRVhQT1JUX1BSSVZBVEUgU3RyaW5nVmlldyBz dHJpbmdXaXRob3V0UXVlcnlPckZyYWdtZW50SWRlbnRpZmllcigpIGNvbnN0OwotICAgIFdURl9F WFBPUlRfUFJJVkFURSBTdHJpbmdWaWV3IHN0cmluZ1dpdGhvdXRGcmFnbWVudElkZW50aWZpZXIo KSBjb25zdDsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgU3RyaW5nVmlldyB2aWV3V2l0aG91dFF1 ZXJ5T3JGcmFnbWVudElkZW50aWZpZXIoKSBjb25zdDsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUg U3RyaW5nVmlldyB2aWV3V2l0aG91dEZyYWdtZW50SWRlbnRpZmllcigpIGNvbnN0OworICAgIFdU Rl9FWFBPUlRfUFJJVkFURSBTdHJpbmcgc3RyaW5nV2l0aG91dEZyYWdtZW50SWRlbnRpZmllcigp IGNvbnN0OwogCiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBwcm90b2NvbEhvc3RBbmRQ b3J0KCkgY29uc3Q7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBob3N0QW5kUG9ydCgp IGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9IaXN0b3J5LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5jcHAKaW5kZXggZDc4YTdjNGZlZDhmM2Q1MjIyY2M5 ZWZmZTQxMmY0M2U0ODc1NDQyOC4uYTc4MmMzYmU1MWNhMTEzYTUyNDgyYzVhMTA1ODNjOGZhNjQ3 MjRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9IaXN0b3J5LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0hpc3RvcnkuY3BwCkBAIC0yMDgsNyArMjA4LDcgQEAgRXhjZXB0 aW9uT3I8dm9pZD4gSGlzdG9yeTo6c3RhdGVPYmplY3RBZGRlZChSZWZQdHI8U2VyaWFsaXplZFNj cmlwdFZhbHVlPiYmIGRhdGEKICAgICAvLyBXZSBhbGxvdyBzYW5kYm94ZWQgZG9jdW1lbnRzLCAn ZGF0YTonLydmaWxlOicgVVJMcywgZXRjLiB0byB1c2UgJ3B1c2hTdGF0ZScvJ3JlcGxhY2VTdGF0 ZScgdG8gbW9kaWZ5IHRoZSBVUkwgcXVlcnkgYW5kIGZyYWdtZW50cy4KICAgICAvLyBTZWUgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzAyOCBmb3IgdGhlIGNvbXBh dGliaWxpdHkgY29uY2VybnMuCiAgICAgYm9vbCBhbGxvd1NhbmRib3hFeGNlcHRpb24gPSAoZG9j dW1lbnRTZWN1cml0eU9yaWdpbi5pc0xvY2FsKCkgfHwgZG9jdW1lbnRTZWN1cml0eU9yaWdpbi5p c1VuaXF1ZSgpKQotICAgICAgICAmJiBkb2N1bWVudFVSTC5zdHJpbmdXaXRob3V0UXVlcnlPckZy YWdtZW50SWRlbnRpZmllcigpID09IGZ1bGxVUkwuc3RyaW5nV2l0aG91dFF1ZXJ5T3JGcmFnbWVu dElkZW50aWZpZXIoKTsKKyAgICAgICAgJiYgZG9jdW1lbnRVUkwudmlld1dpdGhvdXRRdWVyeU9y RnJhZ21lbnRJZGVudGlmaWVyKCkgPT0gZnVsbFVSTC52aWV3V2l0aG91dFF1ZXJ5T3JGcmFnbWVu dElkZW50aWZpZXIoKTsKIAogICAgIGlmICghYWxsb3dTYW5kYm94RXhjZXB0aW9uICYmICFkb2N1 bWVudFNlY3VyaXR5T3JpZ2luLmNhblJlcXVlc3QoZnVsbFVSTCkgJiYgKGZ1bGxVUkwucGF0aCgp ICE9IGRvY3VtZW50VVJMLnBhdGgoKSB8fCBmdWxsVVJMLnF1ZXJ5KCkgIT0gZG9jdW1lbnRVUkwu cXVlcnkoKSkpCiAgICAgICAgIHJldHVybiBjcmVhdGVCbG9ja2VkVVJMU2VjdXJpdHlFcnJvcldp dGhNZXNzYWdlU3VmZml4KCJQYXRocyBhbmQgZnJhZ21lbnRzIG11c3QgbWF0Y2ggZm9yIGEgc2Fu ZGJveGVkIGRvY3VtZW50LiIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9CbG9iUmVnaXN0cnlJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvQmxvYlJlZ2lzdHJ5SW1wbC5jcHAKaW5kZXggM2I0ZTM3MDlmYTYxYjc1NmM4MjhlMzg4 YjZlNWQ1MDg3ZmE1N2Y3NS4uMzUxNTFiYTY2ZjNiMmM0ZWZhMWY2OWY2NmM0MjU0YzI4NGQ0ZDUw YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9CbG9iUmVnaXN0 cnlJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Jsb2JSZWdp c3RyeUltcGwuY3BwCkBAIC01MCwxMSArNTAsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK LXN0YXRpYyBTdHJpbmcgYmxvYlVSTFdpdGhvdXRGcmFnbWVudChjb25zdCBVUkwmIHVybCkKLXsK LSAgICByZXR1cm4gdXJsLmhhc0ZyYWdtZW50SWRlbnRpZmllcigpID8gdXJsLnN0cmluZ1dpdGhv dXRGcmFnbWVudElkZW50aWZpZXIoKS50b1N0cmluZygpIDogdXJsLnN0cmluZygpOwotfQotCiBC bG9iUmVnaXN0cnlJbXBsOjp+QmxvYlJlZ2lzdHJ5SW1wbCgpID0gZGVmYXVsdDsKIAogc3RhdGlj IFJlZjxSZXNvdXJjZUhhbmRsZT4gY3JlYXRlQmxvYlJlc291cmNlSGFuZGxlKGNvbnN0IFJlc291 cmNlUmVxdWVzdCYgcmVxdWVzdCwgUmVzb3VyY2VIYW5kbGVDbGllbnQqIGNsaWVudCkKQEAgLTIz NSw3ICsyMzAsNyBAQCBCbG9iRGF0YSogQmxvYlJlZ2lzdHJ5SW1wbDo6Z2V0QmxvYkRhdGFGcm9t VVJMKGNvbnN0IFVSTCYgdXJsKSBjb25zdAogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7 CiAgICAgaWYgKHVybC5oYXNGcmFnbWVudElkZW50aWZpZXIoKSkKLSAgICAgICAgcmV0dXJuIG1f YmxvYnMuZ2V0KHVybC5zdHJpbmdXaXRob3V0RnJhZ21lbnRJZGVudGlmaWVyKCkudG9TdHJpbmdX aXRob3V0Q29weWluZygpKTsKKyAgICAgICAgcmV0dXJuIG1fYmxvYnMuZ2V0KHVybC52aWV3V2l0 aG91dEZyYWdtZW50SWRlbnRpZmllcigpLnRvU3RyaW5nV2l0aG91dENvcHlpbmcoKSk7CiAgICAg cmV0dXJuIG1fYmxvYnMuZ2V0KHVybC5zdHJpbmcoKSk7CiB9CiAKQEAgLTM4MCwxNCArMzc1LDE0 IEBAIHZvaWQgQmxvYlJlZ2lzdHJ5SW1wbDo6YWRkQmxvYkRhdGEoY29uc3QgU3RyaW5nJiB1cmws IFJlZlB0cjxCbG9iRGF0YT4mJiBibG9iRGF0CiAKIHZvaWQgQmxvYlJlZ2lzdHJ5SW1wbDo6cmVn aXN0ZXJCbG9iVVJMSGFuZGxlKGNvbnN0IFVSTCYgdXJsKQogewotICAgIGF1dG8gdXJsS2V5ID0g YmxvYlVSTFdpdGhvdXRGcmFnbWVudCh1cmwpOworICAgIGF1dG8gdXJsS2V5ID0gdXJsLnN0cmlu Z1dpdGhvdXRGcmFnbWVudElkZW50aWZpZXIoKTsKICAgICBpZiAobV9ibG9icy5jb250YWlucyh1 cmxLZXkpKQogICAgICAgICBtX2Jsb2JSZWZlcmVuY2VzLmFkZCh1cmxLZXkpOwogfQogCiB2b2lk IEJsb2JSZWdpc3RyeUltcGw6OnVucmVnaXN0ZXJCbG9iVVJMSGFuZGxlKGNvbnN0IFVSTCYgdXJs KQogewotICAgIGF1dG8gdXJsS2V5ID0gYmxvYlVSTFdpdGhvdXRGcmFnbWVudCh1cmwpOworICAg IGF1dG8gdXJsS2V5ID0gdXJsLnN0cmluZ1dpdGhvdXRGcmFnbWVudElkZW50aWZpZXIoKTsKICAg ICBpZiAobV9ibG9iUmVmZXJlbmNlcy5yZW1vdmUodXJsS2V5KSkKICAgICAgICAgbV9ibG9icy5y ZW1vdmUodXJsS2V5KTsKIH0K