238145 2022-03-21 09:24:07 -0700 REGRESSION(r291055): Invalid test expectations 2022-03-22 16:50:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 237227 1 commit-queue commit-queue ap Morningstar pvollan webkit-bug-importer oldest_to_newest 1853215 0 commit-queue 2022-03-21 09:24:07 -0700 https://commits.webkit.org/r291055 introduced a regression: Invalid test expectations This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1853216 1 455252 commit-queue 2022-03-21 09:24:11 -0700 Created attachment 455252 REVERT of r291055 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1853406 2 ews-feeder 2022-03-21 16:37:31 -0700 Committed r291587 (248682@main): <https://commits.webkit.org/248682@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455252. 1853408 3 webkit-bug-importer 2022-03-21 16:38:22 -0700 <rdar://problem/90600590> 1853527 4 ap 2022-03-21 22:16:38 -0700 r291055 both added TestExpectations and added Matteo to contributors.json (ugh). So the revert reverted both changes. 1854008 5 Morningstar 2022-03-22 16:50:03 -0700 (In reply to Alexey Proskuryakov from comment #4) > r291055 both added TestExpectations and added Matteo to contributors.json > (ugh). > > So the revert reverted both changes. My first commit. Lesson obviously learned. 455252 2022-03-21 09:24:11 -0700 2022-03-21 16:37:32 -0700 REVERT of r291055 bug-238145-20220321092411.patch text/plain 3518 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNTU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmE2MzgxMDdhZjBiZGU2OWUyZjZm OGUxMWRiZmVlODA4NmFkMmUxNi4uMTVhMTRlNDY5OWMwODQ2ZGVjNThlYmE1MTU5MWRjYzY2NDI1 YzEwOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAzLTIxICBDb21taXQgUXVldWUgIDxj b21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcg cjI5MTA1NS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzODE0NQorCisgICAgICAgIEludmFsaWQgdGVzdCBleHBlY3RhdGlvbnMKKworICAgICAgICBS ZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIltpT1NdIEhhcmQgbGluayBBVlBpY3R1cmVJ blBpY3R1cmVDb250cm9sbGVyIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjM3MjI3CisgICAgICAgIGh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnL3Iy OTEwNTUKKwogMjAyMi0wMy0yMSAgWmlyYW4gU3VuICA8enN1bkBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtzZWxlY3Rpb25dIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpzdWJ0cmVlSGFzQ2hh bmdlZCgpIHNob3VsZG4ndCBiZSBjYWxsZWQgaW4gc2V0UmFuZ2VUZXh0CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9pcGFkL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9pcGFkL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNWU1MjIzY2UxZmMzYzViZjE3ZTQw OTc4NTk5M2VlMDI2YmJiNTk2Ny4uZjA5ZWI5MjY5ZTlmZjY1MTA2YmE1YjU3YzhjMDQ1ZTI4NDZi MDg5MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaXBhZC9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lwYWQvVGVzdEV4cGVjdGF0aW9ucwpAQCAt OTYsMTggKzk2LDYgQEAgd2Via2l0Lm9yZy9iLzIwMzI2NCBlZGl0aW5nL3Bhc3RlYm9hcmQvc21h cnQtcGFzdGUtcGFyYWdyYXBoLTAwMS5odG1sIFsgUGFzcyBdCiAKIHdlYmtpdC5vcmcvYi8yMzE2 MzUgWyBSZWxlYXNlIF0gZWRpdGluZy9zZWxlY3Rpb24vaW9zL3Njcm9sbC10by1yZXZlYWwtc2Vs ZWN0aW9uLXdoZW4tc2hvd2luZy1zb2Z0d2FyZS1rZXlib2FyZC5odG1sIFsgVGltZW91dCBdCiAK LSN3ZWJraXQub3JnL2IvMjM3MjI3IFRoZXNlIDEwIHBpY3R1cmUgaW4gcGljdHVyZSB0ZXN0cyBh cmUgZmFpbGluZyBvbiBpUGFkCi1tZWRpYS9waWN0dXJlLWluLXBpY3R1cmUvcGljdHVyZS1pbi1w aWN0dXJlLWFwaS1jc3Mtc2VsZWN0b3IuaHRtbCBbIFRpbWVvdXQgXQotbWVkaWEvcGljdHVyZS1p bi1waWN0dXJlL3BpY3R1cmUtaW4tcGljdHVyZS1hcGktZW50ZXItcGlwLTEuaHRtbCBbIEZhaWx1 cmUgXQotbWVkaWEvcGljdHVyZS1pbi1waWN0dXJlL3BpY3R1cmUtaW4tcGljdHVyZS1hcGktZW50 ZXItcGlwLTIuaHRtbCBbIEZhaWx1cmUgXQotbWVkaWEvcGljdHVyZS1pbi1waWN0dXJlL3BpY3R1 cmUtaW4tcGljdHVyZS1hcGktZW50ZXItcGlwLTMuaHRtbCBbIEZhaWx1cmUgXQotbWVkaWEvcGlj dHVyZS1pbi1waWN0dXJlL3BpY3R1cmUtaW4tcGljdHVyZS1hcGktZW50ZXItcGlwLTQuaHRtbCBb IEZhaWx1cmUgXQotbWVkaWEvcGljdHVyZS1pbi1waWN0dXJlL3BpY3R1cmUtaW4tcGljdHVyZS1h cGktZXZlbnRzLmh0bWwgWyBUaW1lb3V0IF0KLW1lZGlhL3BpY3R1cmUtaW4tcGljdHVyZS9waWN0 dXJlLWluLXBpY3R1cmUtYXBpLWV4aXQtcGlwLTEuaHRtbCBbIFRpbWVvdXQgXQotbWVkaWEvcGlj dHVyZS1pbi1waWN0dXJlL3BpY3R1cmUtaW4tcGljdHVyZS1hcGktcGlwLXdpbmRvdy5odG1sIFsg RmFpbHVyZSBdCi1tZWRpYS9waWN0dXJlLWluLXBpY3R1cmUvcGljdHVyZS1pbi1waWN0dXJlLXdp bmRvdy1hc3BlY3QtcmF0aW8uaHRtbCBbIEZhaWx1cmUgXQotcGxhdGZvcm0vaXBhZC9tZWRpYS9t b2Rlcm4tbWVkaWEtY29udHJvbHMvcGlwLXN1cHBvcnQvcGlwLXN1cHBvcnQtZW5hYmxlZC5odG1s IFsgRmFpbHVyZSBdCi0KIG1lZGlhL3BpY3R1cmUtaW4tcGljdHVyZSBbIFBhc3MgXQogbWVkaWEv cmVtb3ZlLXZpZGVvLWVsZW1lbnQtaW4tcGlwLWZyb20tZG9jdW1lbnQuaHRtbCBbIFBhc3MgXQog CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMWNkYTFhYzM2YTg2OWZl OGI0ZDNiMDI4OGNkOWEzZTIyNzJiYTQ1OS4uZGU4OTQyZDhmOWI4ZjRkY2RmYWMyNzFhZTNjMzIz OGFlYzYxZGIzNiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDIyLTAzLTIxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KKworICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI5MTA1NS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODE0NQorCisgICAgICAg IEludmFsaWQgdGVzdCBleHBlY3RhdGlvbnMKKworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6 CisKKyAgICAgICAgIltpT1NdIEhhcmQgbGluayBBVlBpY3R1cmVJblBpY3R1cmVDb250cm9sbGVy IgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3MjI3 CisgICAgICAgIGh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnL3IyOTEwNTUKKwogMjAyMi0wMy0x OCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dT dHJlYW1lcl0gTWlncmF0ZSBnc3QtZnVsbCBzdXBwb3J0IHRvIDEuMjAKZGlmZiAtLWdpdCBhL21l dGFkYXRhL2NvbnRyaWJ1dG9ycy5qc29uIGIvbWV0YWRhdGEvY29udHJpYnV0b3JzLmpzb24KaW5k ZXggNzc2Mzg5ZmY5MGYyN2E1MzBlYWIwNTlhYTk5NDFlMmFjN2NhYjc3ZS4uOGY4YmYxNjA0YWRi NWEzODhiODk3MjczY2Q1OThkNzQ1NGUwZDg4YiAxMDA2NDQKLS0tIGEvbWV0YWRhdGEvY29udHJp YnV0b3JzLmpzb24KKysrIGIvbWV0YWRhdGEvY29udHJpYnV0b3JzLmpzb24KQEAgLTQ3MzUsMTcg KzQ3MzUsNiBAQAogICAgICAgICAgIm1taXJtYW4iCiAgICAgICBdCiAgICB9LAotICAgewotICAg ICAgImVtYWlscyIgOiBbCi0gICAgICAgICAiTWF0dGVvX2Zsb3Jlc0BhcHBsZS5jb20iCi0gICAg ICBdLAotICAgICAgImdpdGh1YiIgOiAiU21hY2t0ZW8iLAotICAgICAgIm5hbWUiIDogIk1hdHRl byBGbG9yZXMiLAotICAgICAgIm5pY2tzIiA6IFsKLSAgICAgICAgICJNYXR0ZW9GIgotICAgICAg XSwKLSAgICAgICJzdGF0dXMiIDogImNvbW1pdHRlciIKLSAgIH0sCiAgICB7CiAgICAgICAiZW1h aWxzIiA6IFsKICAgICAgICAgICJtdnVqb3ZpY0BhZG9iZS5jb20iLAo=