238074 2022-03-18 07:28:32 -0700 Optimize AtomHTMLToken::initializeAttributes() 2022-03-18 17:21:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen changseok darin esprehn+autocc ews-watchlist ggaren gyuyoung.kim webkit-bug-importer ysuzuki oldest_to_newest 1852706 0 cdumez 2022-03-18 07:28:32 -0700 Optimize AtomHTMLToken::initializeAttributes(). 1852709 1 455093 cdumez 2022-03-18 07:30:47 -0700 Created attachment 455093 Patch 1852725 2 455093 ggaren 2022-03-18 08:42:47 -0700 Comment on attachment 455093 Patch R=me 1852757 3 455093 ggaren 2022-03-18 10:14:24 -0700 Comment on attachment 455093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455093&action=review > Source/WebCore/html/parser/AtomHTMLToken.h:207 > + HashSet<AtomString> addedAttributes; Maybe reserveInitialCapacity(size) here, like we do for m_attributes? 1852758 4 455107 cdumez 2022-03-18 10:17:11 -0700 Created attachment 455107 Patch 1852902 5 ews-feeder 2022-03-18 17:20:40 -0700 Committed r291508 (248615@main): <https://commits.webkit.org/248615@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455107. 1852903 6 webkit-bug-importer 2022-03-18 17:21:18 -0700 <rdar://problem/90511727> 455093 2022-03-18 07:30:47 -0700 2022-03-18 10:17:08 -0700 Patch bug-238074-20220318073046.patch text/plain 2082 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTgxYjU3MjNlOTllYTZm Yjg1NjViZGUwZDkzMzkyNjliMzQyNzU1Ni4uMmI4Y2ZkODAwNzkyY2RiZmY5ZDE0NjIxZjI5NGJh MWUzYmMwOGEwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAzLTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgT3B0aW1pemUgQXRvbUhUTUxU b2tlbjo6aW5pdGlhbGl6ZUF0dHJpYnV0ZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4MDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlIGEgSGFzaFNldCB0byBmaW5kIGR1cGxpY2F0ZSBhdHRy aWJ1dGVzIGluc3RlYWQgb2YgZG9pbmcgYSBsaW5lYXIgc2VhcmNoLgorICAgICAgICBUaGlzIGlz IGEgY29uZmlybWVkIDEuMiUgcHJvZ3Jlc3Npb24gb24gU3BlZWRvbWV0ZXIgb24gaU1hYzIwLDEg dmlhIEEvQiBib3RzLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvQXRvbUhUTUxUb2tlbi5oOgor ICAgICAgICAoV2ViQ29yZTo6QXRvbUhUTUxUb2tlbjo6aW5pdGlhbGl6ZUF0dHJpYnV0ZXMpOgor CiAyMDIyLTAzLTE4ICBBbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb SUZDXVtJbnRlZ3JhdGlvbl0gUmVuYW1lIElubGluZUl0ZXJhdG9yOjpMaW5lOjpjbG9zZXN0UnVu KiB0byBjbG9zZXN0Qm94Rm9yKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvQXRvbUhUTUxUb2tlbi5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQXRvbUhUTUxU b2tlbi5oCmluZGV4IDZjNDI5ZDJhNjVkNjcyNzNjOTI0YjIxYmU2MGVhOGQ2N2RiOGNlZmEuLjgy MTU4NTU5M2VjYmEyMDliMjBiYjM5MmFhZDQ0ODJhNGJhZDkyMjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0F0b21IVE1MVG9rZW4uaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3BhcnNlci9BdG9tSFRNTFRva2VuLmgKQEAgLTIwNCw2ICsyMDQsNyBAQCBpbmxpbmUg dm9pZCBBdG9tSFRNTFRva2VuOjppbml0aWFsaXplQXR0cmlidXRlcyhjb25zdCBIVE1MVG9rZW46 OkF0dHJpYnV0ZUxpc3QmCiAgICAgaWYgKCFzaXplKQogICAgICAgICByZXR1cm47CiAKKyAgICBI YXNoU2V0PEF0b21TdHJpbmc+IGFkZGVkQXR0cmlidXRlczsKICAgICBtX2F0dHJpYnV0ZXMucmVz ZXJ2ZUluaXRpYWxDYXBhY2l0eShzaXplKTsKICAgICBmb3IgKGF1dG8mIGF0dHJpYnV0ZSA6IGF0 dHJpYnV0ZXMpIHsKICAgICAgICAgaWYgKGF0dHJpYnV0ZS5uYW1lLmlzRW1wdHkoKSkKQEAgLTIx MSw4ICsyMTIsNyBAQCBpbmxpbmUgdm9pZCBBdG9tSFRNTFRva2VuOjppbml0aWFsaXplQXR0cmli dXRlcyhjb25zdCBIVE1MVG9rZW46OkF0dHJpYnV0ZUxpc3QmCiAKICAgICAgICAgYXV0byBxdWFs aWZpZWROYW1lID0gSFRNTE5hbWVDYWNoZTo6bWFrZUF0dHJpYnV0ZVF1YWxpZmllZE5hbWUoYXR0 cmlidXRlLm5hbWUpOwogCi0gICAgICAgIC8vIEZJWE1FOiBUaGlzIGlzIE5eMiBmb3IgdGhlIG51 bWJlciBvZiBhdHRyaWJ1dGVzLgotICAgICAgICBpZiAoIWhhc0F0dHJpYnV0ZShtX2F0dHJpYnV0 ZXMsIHF1YWxpZmllZE5hbWUubG9jYWxOYW1lKCkpKQorICAgICAgICBpZiAoYWRkZWRBdHRyaWJ1 dGVzLmFkZChxdWFsaWZpZWROYW1lLmxvY2FsTmFtZSgpKS5pc05ld0VudHJ5KQogICAgICAgICAg ICAgbV9hdHRyaWJ1dGVzLnVuY2hlY2tlZEFwcGVuZChBdHRyaWJ1dGUoV1RGTW92ZShxdWFsaWZp ZWROYW1lKSwgSFRNTE5hbWVDYWNoZTo6bWFrZUF0dHJpYnV0ZVZhbHVlKGF0dHJpYnV0ZS52YWx1 ZSkpKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgbV9oYXNEdXBsaWNhdGVBdHRyaWJ1dGUg PSBIYXNEdXBsaWNhdGVBdHRyaWJ1dGU6OlllczsK 455107 2022-03-18 10:17:11 -0700 2022-03-18 17:20:43 -0700 Patch bug-238074-20220318101710.patch text/plain 2122 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDcwMTQyYmVlMjZjMzc4 Zjg5Njc4ZmU0NzM4YzMwZmNiOGNiMWE2OS4uYTQ5MTViMmQ0YjBlODNlZmViN2I3MTU4NjE0MWVi Y2VkMGQzODI2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAzLTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgT3B0aW1pemUgQXRvbUhUTUxU b2tlbjo6aW5pdGlhbGl6ZUF0dHJpYnV0ZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4MDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZy ZXkgR2FyZW4uCisKKyAgICAgICAgVXNlIGEgSGFzaFNldCB0byBmaW5kIGR1cGxpY2F0ZSBhdHRy aWJ1dGVzIGluc3RlYWQgb2YgZG9pbmcgYSBsaW5lYXIgc2VhcmNoLgorICAgICAgICBUaGlzIGlz IGEgY29uZmlybWVkIDEuMiUgcHJvZ3Jlc3Npb24gb24gU3BlZWRvbWV0ZXIgb24gaU1hYzIwLDEg dmlhIEEvQiBib3RzLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvQXRvbUhUTUxUb2tlbi5oOgor ICAgICAgICAoV2ViQ29yZTo6QXRvbUhUTUxUb2tlbjo6aW5pdGlhbGl6ZUF0dHJpYnV0ZXMpOgor CiAyMDIyLTAzLTE4ICBFbnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gQWRkIHN0b3AgcG9zaXRpb24gdG8gdGhlIHJhbmdl IHJlcXVlc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0F0b21IVE1M VG9rZW4uaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0F0b21IVE1MVG9rZW4uaAppbmRl eCA2YzQyOWQyYTY1ZDY3MjczYzkyNGIyMWJlNjBlYThkNjdkYjhjZWZhLi42MjZkYjkyZDkyYWFk NGU1ZmQzNDRhZTNhOWIxMzI4NjM5NmM4ZDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9BdG9tSFRNTFRva2VuLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvQXRvbUhUTUxUb2tlbi5oCkBAIC0yMDQsNiArMjA0LDggQEAgaW5saW5lIHZvaWQgQXRvbUhU TUxUb2tlbjo6aW5pdGlhbGl6ZUF0dHJpYnV0ZXMoY29uc3QgSFRNTFRva2VuOjpBdHRyaWJ1dGVM aXN0JgogICAgIGlmICghc2l6ZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgSGFzaFNldDxBdG9t U3RyaW5nPiBhZGRlZEF0dHJpYnV0ZXM7CisgICAgYWRkZWRBdHRyaWJ1dGVzLnJlc2VydmVJbml0 aWFsQ2FwYWNpdHkoc2l6ZSk7CiAgICAgbV9hdHRyaWJ1dGVzLnJlc2VydmVJbml0aWFsQ2FwYWNp dHkoc2l6ZSk7CiAgICAgZm9yIChhdXRvJiBhdHRyaWJ1dGUgOiBhdHRyaWJ1dGVzKSB7CiAgICAg ICAgIGlmIChhdHRyaWJ1dGUubmFtZS5pc0VtcHR5KCkpCkBAIC0yMTEsOCArMjEzLDcgQEAgaW5s aW5lIHZvaWQgQXRvbUhUTUxUb2tlbjo6aW5pdGlhbGl6ZUF0dHJpYnV0ZXMoY29uc3QgSFRNTFRv a2VuOjpBdHRyaWJ1dGVMaXN0JgogCiAgICAgICAgIGF1dG8gcXVhbGlmaWVkTmFtZSA9IEhUTUxO YW1lQ2FjaGU6Om1ha2VBdHRyaWJ1dGVRdWFsaWZpZWROYW1lKGF0dHJpYnV0ZS5uYW1lKTsKIAot ICAgICAgICAvLyBGSVhNRTogVGhpcyBpcyBOXjIgZm9yIHRoZSBudW1iZXIgb2YgYXR0cmlidXRl cy4KLSAgICAgICAgaWYgKCFoYXNBdHRyaWJ1dGUobV9hdHRyaWJ1dGVzLCBxdWFsaWZpZWROYW1l LmxvY2FsTmFtZSgpKSkKKyAgICAgICAgaWYgKGFkZGVkQXR0cmlidXRlcy5hZGQocXVhbGlmaWVk TmFtZS5sb2NhbE5hbWUoKSkuaXNOZXdFbnRyeSkKICAgICAgICAgICAgIG1fYXR0cmlidXRlcy51 bmNoZWNrZWRBcHBlbmQoQXR0cmlidXRlKFdURk1vdmUocXVhbGlmaWVkTmFtZSksIEhUTUxOYW1l Q2FjaGU6Om1ha2VBdHRyaWJ1dGVWYWx1ZShhdHRyaWJ1dGUudmFsdWUpKSk7CiAgICAgICAgIGVs c2UKICAgICAgICAgICAgIG1faGFzRHVwbGljYXRlQXR0cmlidXRlID0gSGFzRHVwbGljYXRlQXR0 cmlidXRlOjpZZXM7Cg==