23803 2009-02-06 15:38:58 -0800 fix 'off-by-1' error in Chromium font fallback 2009-03-03 10:22:30 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Minor --- 1 jshin jshin dglazkov eric oldest_to_newest 108743 0 jshin 2009-02-06 15:38:58 -0800 There's an 'off-by-1' error in platform/graphics/chromium/FontCacheChromium.cpp. As a result, when only the last font in the list of fallback fonts covers a character, the character is regarded as not covered by any font and is rendered as an empty box. 108745 1 27426 jshin 2009-02-06 15:39:49 -0800 Created attachment 27426 a test case With code2000 font installed, all 3 lines should be rendered identically. 108750 2 27429 jshin 2009-02-06 15:56:06 -0800 Created attachment 27429 1-liner patch (with a comment) 110850 3 27429 eric 2009-02-24 16:05:27 -0800 Comment on attachment 27429 1-liner patch (with a comment) OK. In the future, you don't need to make me the requestee. WebKit doesn't tend to target reviews to specific people unless you know that they are the only person who could review your change. In this case, I'm not the only person who could review this change. Making me the requestee is likely to just slow down the process. 112033 4 dglazkov 2009-03-03 10:22:30 -0800 Landed as http://trac.webkit.org/changeset/41392. 27426 2009-02-06 15:39:49 -0800 2009-02-06 15:39:49 -0800 a test case canadian.html text/html 271 jshin PGh0bWw+CiAgPGhlYWQ+CiAgICA8dGl0bGU+VW5pZmllZCBDYW5hZGlhbiBTeWxsYWJsZXM8L3Rp dGxlPgogIDwvaGVhZD4KICA8Ym9keT4KICAgIDx1bD4KICAgICAgPGxpPiYjeDE0MDE7JiN4MTQw Mjs8L2xpPgogICAgICA8bGkgc3R5bGU9ImZvbnQtZmFtaWx5OiBhcmlhbCI+JiN4MTQwMTsmI3gx NDAyOzwvbGk+CiAgICAgIDxsaSBzdHlsZT0iZm9udC1mYW1pbHk6IGNvZGUyMDAwIj4mI3gxNDAx OyYjeDE0MDI7PC9saT4KICAgIDwvdWw+CiAgPC9ib2R5Pgo8L2h0bWw+Cg== 27429 2009-02-06 15:56:06 -0800 2009-02-24 16:05:27 -0800 1-liner patch (with a comment) 23803.patch.1 text/plain 1598 jshin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDczNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDItMDYgIEp1bmdzaGlrIFNoaW4gPGpzaGluQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4MDMKKyAgICAgICAgRml4 IGFuICdvZmYtYnktMScgZXJyb3IgaW4gQ2hyb21pdW1XaW4ncyBmb250IGZhbGxiYWNrLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlQ2hyb21pdW1XaW4u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpnZXRGb250RGF0YUZvckNoYXJhY3Rl cnMpOgorCiAyMDA5LTAyLTA2ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUNocm9taXVtV2luLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUNocm9t aXVtV2luLmNwcAkocmV2aXNpb24gNDA3MjApCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0ZvbnRDYWNoZUNocm9taXVtV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzk0 LDcgKzM5NCwxMiBAQCBjb25zdCBTaW1wbGVGb250RGF0YSogRm9udENhY2hlOjpnZXRGb250CiAg ICAgICAgIGZhbWlseSA9IHBhblVuaUZvbnRzW2ldOyAKICAgICAgICAgZGF0YSA9IGdldENhY2hl ZEZvbnRQbGF0Zm9ybURhdGEoZm9udC5mb250RGVzY3JpcHRpb24oKSwgQXRvbWljU3RyaW5nKGZh bWlseSwgd2NzbGVuKGZhbWlseSkpKTsKICAgICB9Ci0gICAgaWYgKGkgPCBudW1Gb250cykgLy8g d2UgZm91bmQgdGhlIGZvbnQgdGhhdCBjb3ZlcnMgdGhpcyBjaGFyYWN0ZXIgIQorICAgIC8vIFdo ZW4gaS10aCBmb250ICgwLWJhc2UpIGluIHxwYW5VbmlGb250c3wgY29udGFpbnMgYSBjaGFyYWN0 ZXIgYW5kCisgICAgLy8gd2UgZ2V0IG91dCBvZiB0aGUgbG9vcCwgfGl8IHdpbGwgYmUgfGkgKyAx fC4gVGhhdCBpcywgaWYgb25seSB0aGUKKyAgICAvLyBsYXN0IGZvbnQgaW4gdGhlIGFycmF5IGNv dmVycyB0aGUgY2hhcmFjdGVyLCB8aXwgd2lsbCBiZSBudW1Gb250cy4KKyAgICAvLyBTbywgd2Ug aGF2ZSB0byB1c2UgJzw9IiByYXRoZXIgdGhhbiAnPCcgdG8gc2VlIGlmIHdlIGZvdW5kIGEgZm9u dAorICAgIC8vIGNvdmVyaW5nIHRoZSBjaGFyYWN0ZXIuCisgICAgaWYgKGkgPD0gbnVtRm9udHMp IAogICAgICAgIHJldHVybiBnZXRDYWNoZWRGb250RGF0YShkYXRhKTsKIAogICAgIHJldHVybiAw Owo=