238028 2022-03-17 10:54:26 -0700 [GStreamer] Add stop position to the range request 2022-03-18 09:47:19 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eocanha eocanha adam pnormand webkit-bug-importer oldest_to_newest 1852375 0 eocanha 2022-03-17 10:54:26 -0700 Currently, the range requests performed by WebKitWebSourceGStreamer indicate a range start position but not a range stop one, even though it's set in the internal members->stopPosition attribute. 1852389 1 454997 eocanha 2022-03-17 11:29:24 -0700 Created attachment 454997 Patch 1852395 2 454997 pnormand 2022-03-17 11:48:34 -0700 Comment on attachment 454997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454997&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:680 > + formatedRange.reset(g_strdup_printf("bytes=%" G_GUINT64_FORMAT "-%" G_GUINT64_FORMAT, members->requestedPosition, (members->stopPosition > 0) ? members->stopPosition - 1 : 0)); The wrapping parentheses are not needed. 1852476 3 adam 2022-03-17 13:59:30 -0700 Is this a regression of this: https://bugs.webkit.org/show_bug.cgi?id=236401 ? We have a customer that's having an issue playing videos within an embedded WebView in FileMaker Pro on macOS 12.3. While this bug appears to have been fixed in Safari proper, it looks like it's still broken in embedded WebViews. If this isn't related, let me know and I'll file a new bug. 1852492 4 pnormand 2022-03-17 14:35:25 -0700 The GStreamer backend is not used by the mac ports, so I doubt this patch will solve your issues. 1852688 5 455090 eocanha 2022-03-18 05:46:00 -0700 Created attachment 455090 Patch 1852721 6 ews-feeder 2022-03-18 08:35:17 -0700 Found 2 new test failures: imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-cross-origin.sub.any.worker.html, imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-redirect-to-cross-origin.sub.any.worker.html 1852747 7 ews-feeder 2022-03-18 09:46:58 -0700 Committed r291487 (248601@main): <https://commits.webkit.org/248601@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455090. 1852748 8 webkit-bug-importer 2022-03-18 09:47:19 -0700 <rdar://problem/90490318> 454997 2022-03-17 11:29:24 -0700 2022-03-18 05:45:55 -0700 Patch bug-238028-20220317192922.patch text/plain 2890 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQ1YzI0YjM3MjU2MjVh YjI0YjJlZTJmZWRhMDljMDdjMmY4NGVkOS4uNzI2NzU0ZWQ0YTQ0MjBhNDFmNmI0MmQwNGI3OTA5 MmU4NGJkYTJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIyLTAzLTE3ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gQWRkIHN0b3AgcG9zaXRpb24gdG8gdGhlIHJhbmdlIHJlcXVlc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODAyOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhlIHJh bmdlIHJlcXVlc3RzIHBlcmZvcm1lZCBieSBXZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIgaW5kaWNh dGUgYSByYW5nZQorICAgICAgICBzdGFydCBwb3NpdGlvbiBidXQgbm90IGEgcmFuZ2Ugc3RvcCBv bmUsIGV2ZW4gdGhvdWdoIGl0J3Mgc2V0IGluIHRoZSBpbnRlcm5hbAorICAgICAgICBtZW1iZXJz LT5zdG9wUG9zaXRpb24gYXR0cmlidXRlLgorCisgICAgICAgIFRoaXMgbWF5IG5vdCBiZSBhIHBy b2JsZW0gd2hlbiBXZWJLaXRXZWJTcmMgaXMgdXNlZCBhcyBhIHNvdXJjZSBmb3IgdGhlIHdob2xl IHZpZGVvLAorICAgICAgICBidXQgY2VydGFpbmx5IGlzIHdoZW4gaXQncyB1c2VkIGFzIGFuIGVt YmVkZGVkIHNvdXJjZSBpbnNpZGUgYWRhcHRpdmUgZGVtdXgKKyAgICAgICAgKHJlcGxhY2luZyBT b3VwSHR0cFNyYykuIEl0IGNhdXNlcyBkZWNvZGluZyBlcnJvcnMgaW4gc29tZSBNUEVHLURBU0gg c3RyZWFtcy4KKyAgICAgICAgU2VlOiBodHRwczovL2dpdGh1Yi5jb20vV2ViUGxhdGZvcm1Gb3JF bWJlZGRlZC9XUEVXZWJLaXQvaXNzdWVzLzgxMworCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgYXV0 aG9yZWQgYnkgRXVnZW5lIE11dGF2Y2hpIDxJZXZnZW5fTXV0YXZjaGlAY29tY2FzdC5jb20+Cisg ICAgICAgIFNlZTogaHR0cHM6Ly9naXRodWIuY29tL1dlYlBsYXRmb3JtRm9yRW1iZWRkZWQvV1BF V2ViS2l0L3B1bGwvODE0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDogQXBwbHkgc3RvcFBvc2l0aW9uIHRvIHRoZSBy YW5nZSByZXF1ZXN0IHdoZW4gaXQncyB2YWxpZC4KKwogMjAyMi0wMy0xNSAgQW50b2luZSBRdWlu dCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICBEaWFsb2cgZWxlbWVudCBvbmx5IGFu aW1hdGVzIG9uY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAK aW5kZXggNTNiMzdjYjNjMDU0NmQ2NWI2OTBjNjM2MGZlMTFiZTcwZmQ0Zjg3My4uZmUzNmQwYmE0 MzYyNjMwOWY3MjQyODQ3ZWZkNzMyNzRiYjZlYjRjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktp dFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTY3NCw4ICs2NzQsMTIgQEAgc3RhdGljIHZvaWQg d2ViS2l0V2ViU3JjTWFrZVJlcXVlc3QoV2ViS2l0V2ViU3JjKiBzcmMsIERhdGFNdXRleExvY2tl cjxXZWJLaXRXZWIKICAgICAgICAgfHwgIWdfYXNjaWlfc3RyY2FzZWNtcCgidHJhaWxlcnMuYXBw bGUuY29tIiwgdXJsLmhvc3QoKS51dGY4KCkuZGF0YSgpKSkKICAgICAgICAgcmVxdWVzdC5zZXRI VFRQVXNlckFnZW50KCJRdWlja3RpbWUvNy42LjYiKTsKIAotICAgIGlmIChtZW1iZXJzLT5yZXF1 ZXN0ZWRQb3NpdGlvbikgewotICAgICAgICBHVW5pcXVlUHRyPGNoYXI+IGZvcm1hdGVkUmFuZ2Uo Z19zdHJkdXBfcHJpbnRmKCJieXRlcz0lIiBHX0dVSU5UNjRfRk9STUFUICItIiwgbWVtYmVycy0+ cmVxdWVzdGVkUG9zaXRpb24pKTsKKyAgICBpZiAobWVtYmVycy0+cmVxdWVzdGVkUG9zaXRpb24g fHwgbWVtYmVycy0+c3RvcFBvc2l0aW9uICE9IFVJTlQ2NF9NQVgpIHsKKyAgICAgICAgR1VuaXF1 ZVB0cjxjaGFyPiBmb3JtYXRlZFJhbmdlOworICAgICAgICBpZiAobWVtYmVycy0+c3RvcFBvc2l0 aW9uICE9IFVJTlQ2NF9NQVgpCisgICAgICAgICAgICBmb3JtYXRlZFJhbmdlLnJlc2V0KGdfc3Ry ZHVwX3ByaW50ZigiYnl0ZXM9JSIgR19HVUlOVDY0X0ZPUk1BVCAiLSUiIEdfR1VJTlQ2NF9GT1JN QVQsIG1lbWJlcnMtPnJlcXVlc3RlZFBvc2l0aW9uLCAobWVtYmVycy0+c3RvcFBvc2l0aW9uID4g MCkgPyBtZW1iZXJzLT5zdG9wUG9zaXRpb24gLSAxIDogMCkpOworICAgICAgICBlbHNlCisgICAg ICAgICAgICBmb3JtYXRlZFJhbmdlLnJlc2V0KGdfc3RyZHVwX3ByaW50ZigiYnl0ZXM9JSIgR19H VUlOVDY0X0ZPUk1BVCAiLSIsIG1lbWJlcnMtPnJlcXVlc3RlZFBvc2l0aW9uKSk7CiAgICAgICAg IEdTVF9ERUJVR19PQkpFQ1Qoc3JjLCAiUmFuZ2UgcmVxdWVzdDogJXMiLCBmb3JtYXRlZFJhbmdl LmdldCgpKTsKICAgICAgICAgcmVxdWVzdC5zZXRIVFRQSGVhZGVyRmllbGQoSFRUUEhlYWRlck5h bWU6OlJhbmdlLCBmb3JtYXRlZFJhbmdlLmdldCgpKTsKICAgICB9Cg== 455090 2022-03-18 05:46:00 -0700 2022-03-18 09:47:00 -0700 Patch bug-238028-20220318134559.patch text/plain 2888 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQ1YzI0YjM3MjU2MjVh YjI0YjJlZTJmZWRhMDljMDdjMmY4NGVkOS4uNjBmMWUzYjA2MmY4ZjhlNTlhN2ZjMWMxYzAxM2M1 OTRmMjk5NWI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIyLTAzLTE4ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gQWRkIHN0b3AgcG9zaXRpb24gdG8gdGhlIHJhbmdlIHJlcXVlc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODAyOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhlIHJh bmdlIHJlcXVlc3RzIHBlcmZvcm1lZCBieSBXZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIgaW5kaWNh dGUgYSByYW5nZQorICAgICAgICBzdGFydCBwb3NpdGlvbiBidXQgbm90IGEgcmFuZ2Ugc3RvcCBv bmUsIGV2ZW4gdGhvdWdoIGl0J3Mgc2V0IGluIHRoZSBpbnRlcm5hbAorICAgICAgICBtZW1iZXJz LT5zdG9wUG9zaXRpb24gYXR0cmlidXRlLgorCisgICAgICAgIFRoaXMgbWF5IG5vdCBiZSBhIHBy b2JsZW0gd2hlbiBXZWJLaXRXZWJTcmMgaXMgdXNlZCBhcyBhIHNvdXJjZSBmb3IgdGhlIHdob2xl IHZpZGVvLAorICAgICAgICBidXQgY2VydGFpbmx5IGlzIHdoZW4gaXQncyB1c2VkIGFzIGFuIGVt YmVkZGVkIHNvdXJjZSBpbnNpZGUgYWRhcHRpdmUgZGVtdXgKKyAgICAgICAgKHJlcGxhY2luZyBT b3VwSHR0cFNyYykuIEl0IGNhdXNlcyBkZWNvZGluZyBlcnJvcnMgaW4gc29tZSBNUEVHLURBU0gg c3RyZWFtcy4KKyAgICAgICAgU2VlOiBodHRwczovL2dpdGh1Yi5jb20vV2ViUGxhdGZvcm1Gb3JF bWJlZGRlZC9XUEVXZWJLaXQvaXNzdWVzLzgxMworCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgYXV0 aG9yZWQgYnkgRXVnZW5lIE11dGF2Y2hpIDxJZXZnZW5fTXV0YXZjaGlAY29tY2FzdC5jb20+Cisg ICAgICAgIFNlZTogaHR0cHM6Ly9naXRodWIuY29tL1dlYlBsYXRmb3JtRm9yRW1iZWRkZWQvV1BF V2ViS2l0L3B1bGwvODE0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDogQXBwbHkgc3RvcFBvc2l0aW9uIHRvIHRoZSBy YW5nZSByZXF1ZXN0IHdoZW4gaXQncyB2YWxpZC4KKwogMjAyMi0wMy0xNSAgQW50b2luZSBRdWlu dCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICBEaWFsb2cgZWxlbWVudCBvbmx5IGFu aW1hdGVzIG9uY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAK aW5kZXggNTNiMzdjYjNjMDU0NmQ2NWI2OTBjNjM2MGZlMTFiZTcwZmQ0Zjg3My4uNzU0YjNmZjQ4 MzkwZDVmZjMzNmQ5MDlhYzU1YzA2NTg5N2RkMmQ4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktp dFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTY3NCw4ICs2NzQsMTIgQEAgc3RhdGljIHZvaWQg d2ViS2l0V2ViU3JjTWFrZVJlcXVlc3QoV2ViS2l0V2ViU3JjKiBzcmMsIERhdGFNdXRleExvY2tl cjxXZWJLaXRXZWIKICAgICAgICAgfHwgIWdfYXNjaWlfc3RyY2FzZWNtcCgidHJhaWxlcnMuYXBw bGUuY29tIiwgdXJsLmhvc3QoKS51dGY4KCkuZGF0YSgpKSkKICAgICAgICAgcmVxdWVzdC5zZXRI VFRQVXNlckFnZW50KCJRdWlja3RpbWUvNy42LjYiKTsKIAotICAgIGlmIChtZW1iZXJzLT5yZXF1 ZXN0ZWRQb3NpdGlvbikgewotICAgICAgICBHVW5pcXVlUHRyPGNoYXI+IGZvcm1hdGVkUmFuZ2Uo Z19zdHJkdXBfcHJpbnRmKCJieXRlcz0lIiBHX0dVSU5UNjRfRk9STUFUICItIiwgbWVtYmVycy0+ cmVxdWVzdGVkUG9zaXRpb24pKTsKKyAgICBpZiAobWVtYmVycy0+cmVxdWVzdGVkUG9zaXRpb24g fHwgbWVtYmVycy0+c3RvcFBvc2l0aW9uICE9IFVJTlQ2NF9NQVgpIHsKKyAgICAgICAgR1VuaXF1 ZVB0cjxjaGFyPiBmb3JtYXRlZFJhbmdlOworICAgICAgICBpZiAobWVtYmVycy0+c3RvcFBvc2l0 aW9uICE9IFVJTlQ2NF9NQVgpCisgICAgICAgICAgICBmb3JtYXRlZFJhbmdlLnJlc2V0KGdfc3Ry ZHVwX3ByaW50ZigiYnl0ZXM9JSIgR19HVUlOVDY0X0ZPUk1BVCAiLSUiIEdfR1VJTlQ2NF9GT1JN QVQsIG1lbWJlcnMtPnJlcXVlc3RlZFBvc2l0aW9uLCBtZW1iZXJzLT5zdG9wUG9zaXRpb24gPiAw ID8gbWVtYmVycy0+c3RvcFBvc2l0aW9uIC0gMSA6IDApKTsKKyAgICAgICAgZWxzZQorICAgICAg ICAgICAgZm9ybWF0ZWRSYW5nZS5yZXNldChnX3N0cmR1cF9wcmludGYoImJ5dGVzPSUiIEdfR1VJ TlQ2NF9GT1JNQVQgIi0iLCBtZW1iZXJzLT5yZXF1ZXN0ZWRQb3NpdGlvbikpOwogICAgICAgICBH U1RfREVCVUdfT0JKRUNUKHNyYywgIlJhbmdlIHJlcXVlc3Q6ICVzIiwgZm9ybWF0ZWRSYW5nZS5n ZXQoKSk7CiAgICAgICAgIHJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1l OjpSYW5nZSwgZm9ybWF0ZWRSYW5nZS5nZXQoKSk7CiAgICAgfQo=