237978 2022-03-16 13:13:26 -0700 [Cocoa] Minor AVVideoCaptureSource cleanup 2022-03-16 16:02:25 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=231621 InRadar P2 Normal --- 1 eric.carlson eric.carlson ews-watchlist glenn hta jer.noble peng.liu6 philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1851955 0 eric.carlson 2022-03-16 13:13:26 -0700 Minor AVVideoCaptureSource cleanup 1851957 1 webkit-bug-importer 2022-03-16 13:13:36 -0700 <rdar://problem/90388332> 1851960 2 454887 eric.carlson 2022-03-16 13:22:09 -0700 Created attachment 454887 Patch 1851970 3 454887 peng.liu6 2022-03-16 13:53:06 -0700 Comment on attachment 454887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454887&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:429 > + m_session = adoptNS([PAL::allocAVCaptureSessionInstance() init]); Looks like this change is not intended? 1851973 4 454887 eric.carlson 2022-03-16 14:03:34 -0700 Comment on attachment 454887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454887&action=review >> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:429 >> + m_session = adoptNS([PAL::allocAVCaptureSessionInstance() init]); > > Looks like this change is not intended? It is, it is needed to line up with the `else` above the `#else`. 1852036 5 ews-feeder 2022-03-16 16:02:20 -0700 Committed r291374 (248506@main): <https://commits.webkit.org/248506@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454887. 454887 2022-03-16 13:22:09 -0700 2022-03-16 16:02:22 -0700 Patch bug-237978-20220316132208.patch text/plain 2245 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTYxYzkxNGQ3NWIzNDQ1 M2VkMjI3NWQ3MjU2NTY0YTEwYWE0MTEyNS4uYTVhOGYyYTU1MzAwOTUyZjc2MDNiNGNmOGM2ZGYy ZTMxYjBmMzk1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTE2ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gTWlu b3IgQVZWaWRlb0NhcHR1cmVTb3VyY2UgY2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3OTc4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85 MDM4ODMzMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3Jt L21lZGlhc3RyZWFtL21hYy9BVlZpZGVvQ2FwdHVyZVNvdXJjZS5tbToKKyAgICAgICAgKFdlYkNv cmU6OkFWVmlkZW9DYXB0dXJlU291cmNlOjpzZXR1cFNlc3Npb24pOiBVc2UgYGluc3RhbmNlc1Jl c3BvbmRUb1NlbGVjdG9yOmAKKyAgICAgICAgaW5zdGVhZCBvZiBgcmVzcG9uZHNUb1NlbGVjdG9y OmAgc28gd2UgZG9uJ3QgaGF2ZSB0byBhbGxvY2F0ZSBhbiBBVkNhcHR1cmVTZXNzaW9uCisgICAg ICAgIGp1c3QgdG8gZmluZCBvdXQgaG93IHRvIGluaXRpYWxpemUgaXQuCisKIDIwMjItMDMtMTQg IEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW21vZGVsXSA8 bW9kZWwgaW50ZXJhY3RpdmU+IGRvZXNuJ3QgYWxsb3cgbW9kZWwgdG8gYmUgcm90YXRlZCBvbiBp T1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9B VlZpZGVvQ2FwdHVyZVNvdXJjZS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL21hYy9BVlZpZGVvQ2FwdHVyZVNvdXJjZS5tbQppbmRleCA3MDdjYjY1YzY4MTg1YWRjNzU0 N2E0ZWNiZjM3ZGE1YTdmYjIwODcxLi5hMGZmNzRiZGQ1YmUwNjA4ZTEwNWIwYzAxNDRiYTQwNjll NGE0YWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9t YWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tCkBAIC00MjIsMTMgKzQyMiwx MyBAQCBib29sIEFWVmlkZW9DYXB0dXJlU291cmNlOjpzZXR1cFNlc3Npb24oKQogCiAjaWYgRU5B QkxFKEFQUF9QUklWQUNZX1JFUE9SVCkKICAgICBhdXRvIGlkZW50aXR5ID0gUmVhbHRpbWVNZWRp YVNvdXJjZUNlbnRlcjo6c2luZ2xldG9uKCkuaWRlbnRpdHkoKTsKLSAgICBpZiAoaWRlbnRpdHkg JiYgW1BBTDo6YWxsb2NBVkNhcHR1cmVTZXNzaW9uSW5zdGFuY2UoKSByZXNwb25kc1RvU2VsZWN0 b3I6QHNlbGVjdG9yKGluaXRXaXRoQXNzdW1lZElkZW50aXR5OildKQorICAgIGlmIChpZGVudGl0 eSAmJiBbUEFMOjpnZXRBVkNhcHR1cmVTZXNzaW9uQ2xhc3MoKSBpbnN0YW5jZXNSZXNwb25kVG9T ZWxlY3RvcjpAc2VsZWN0b3IoaW5pdFdpdGhBc3N1bWVkSWRlbnRpdHk6KV0pCiAgICAgICAgIG1f c2Vzc2lvbiA9IGFkb3B0TlMoW1BBTDo6YWxsb2NBVkNhcHR1cmVTZXNzaW9uSW5zdGFuY2UoKSBp bml0V2l0aEFzc3VtZWRJZGVudGl0eTppZGVudGl0eS5nZXQoKV0pOwogICAgIGVsc2UKLSAgICAg ICAgbV9zZXNzaW9uID0gYWRvcHROUyhbUEFMOjphbGxvY0FWQ2FwdHVyZVNlc3Npb25JbnN0YW5j ZSgpIGluaXRdKTsKICNlbHNlCi0gICAgbV9zZXNzaW9uID0gYWRvcHROUyhbUEFMOjphbGxvY0FW Q2FwdHVyZVNlc3Npb25JbnN0YW5jZSgpIGluaXRdKTsKKyAgICAgICAgbV9zZXNzaW9uID0gYWRv cHROUyhbUEFMOjphbGxvY0FWQ2FwdHVyZVNlc3Npb25JbnN0YW5jZSgpIGluaXRdKTsKICNlbmRp ZgorCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICAgICBQQUw6OkFWQ2FwdHVyZVNlc3Npb25T ZXRBdXRob3JpemVkVG9Vc2VDYW1lcmFJbk11bHRpcGxlRm9yZWdyb3VuZEFwcExheW91dChtX3Nl c3Npb24uZ2V0KCkpOwogI2VuZGlmCg==