237931 2022-03-15 16:14:19 -0700 Remove unused directory local variable in pas_enumerate_segregated_heaps. 2022-03-15 20:53:17 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ggaren webkit-bug-importer oldest_to_newest 1851556 0 mark.lam 2022-03-15 16:14:19 -0700 Also remove the call to pas_unwrap_local_view_cache_node(). It doesn't add any value. The only thing of substance that it does is a PAS_ASSERT that turns out to be redundant because pas_enumerate_segregated_heaps() already asserts the same thing before calling pas_unwrap_local_view_cache_node(). 1851564 1 454769 mark.lam 2022-03-15 16:19:26 -0700 Created attachment 454769 proposed patch. 1851566 2 454769 ggaren 2022-03-15 16:25:26 -0700 Comment on attachment 454769 proposed patch. r=me 1851626 3 454769 mark.lam 2022-03-15 19:59:26 -0700 Comment on attachment 454769 proposed patch. Thanks for the review. 1851634 4 ews-feeder 2022-03-15 20:52:13 -0700 Committed r291328 (248467@main): <https://commits.webkit.org/248467@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454769. 1851635 5 webkit-bug-importer 2022-03-15 20:53:17 -0700 <rdar://problem/90348452> 454769 2022-03-15 16:19:26 -0700 2022-03-15 20:52:14 -0700 proposed patch. bug-237931.patch text/plain 1875 mark.lam SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5MTMxOSkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTE1ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIGRpcmVjdG9y eSBsb2NhbCB2YXJpYWJsZSBpbiBwYXNfZW51bWVyYXRlX3NlZ3JlZ2F0ZWRfaGVhcHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc5MzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvIHJlbW92ZSB0 aGUgY2FsbCB0byBwYXNfdW53cmFwX2xvY2FsX3ZpZXdfY2FjaGVfbm9kZSgpLiAgSXQgZG9lc24n dCBhZGQgYW55CisgICAgICAgIHZhbHVlLiAgVGhlIG9ubHkgdGhpbmcgb2Ygc3Vic3RhbmNlIHRo YXQgaXQgZG9lcyBpcyBhIFBBU19BU1NFUlQgdGhhdCB0dXJucyBvdXQgdG8KKyAgICAgICAgYmUg cmVkdW5kYW50IGJlY2F1c2UgcGFzX2VudW1lcmF0ZV9zZWdyZWdhdGVkX2hlYXBzKCkgYWxyZWFk eSBhc3NlcnRzIHRoZSBzYW1lCisgICAgICAgIHRoaW5nIGJlZm9yZSBjYWxsaW5nIHBhc191bndy YXBfbG9jYWxfdmlld19jYWNoZV9ub2RlKCkuCisKKyAgICAgICAgKiBsaWJwYXMvc3JjL2xpYnBh cy9wYXNfZW51bWVyYXRlX3NlZ3JlZ2F0ZWRfaGVhcHMuYzoKKyAgICAgICAgKHBhc19lbnVtZXJh dGVfc2VncmVnYXRlZF9oZWFwcyk6CisKIDIwMjItMDMtMTQgIEVsbGlvdHQgV2lsbGlhbXMgIDxl bXdAYXBwbGUuY29tPgogCiAgICAgICAgIGJtYWxsb2MueGNvZGVwcm9qOiBSZW1vdmUgZHVwbGlj YXRlIGZpbGUgcmVmZXJlbmNlCkluZGV4OiBTb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBh cy9wYXNfZW51bWVyYXRlX3NlZ3JlZ2F0ZWRfaGVhcHMuYwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv Ym1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfZW51bWVyYXRlX3NlZ3JlZ2F0ZWRfaGVhcHMu YwkocmV2aXNpb24gMjkxMzExKQorKysgU291cmNlL2JtYWxsb2MvbGlicGFzL3NyYy9saWJwYXMv cGFzX2VudW1lcmF0ZV9zZWdyZWdhdGVkX2hlYXBzLmMJKHdvcmtpbmcgY29weSkKQEAgLTcyOCwx MiArNzI4LDcgQEAgYm9vbCBwYXNfZW51bWVyYXRlX3NlZ3JlZ2F0ZWRfaGVhcHMocGFzXwogICAg ICAgICAgICAgICAgICAgICBhbGxvY2F0b3JfaW5kZXggPSByZWR1bmRhbnRfbm9kZS0+YWxsb2Nh dG9yX2luZGV4OwogICAgICAgICAgICAgICAgICAgICBoYXNfYWxsb2NhdG9yID0gdHJ1ZTsKICAg ICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgICAgICBwYXNfc2VncmVnYXRl ZF9zaXplX2RpcmVjdG9yeSogZGlyZWN0b3J5OwotICAgICAgICAgICAgICAgICAgICAKICAgICAg ICAgICAgICAgICAgICAgUEFTX0FTU0VSVF9XSVRIX0RFVEFJTChwYXNfaXNfd3JhcHBlZF9sb2Nh bF92aWV3X2NhY2hlX25vZGUobGF5b3V0X25vZGUpKTsKLQotICAgICAgICAgICAgICAgICAgICBk aXJlY3RvcnkgPSBwYXNfdW53cmFwX2xvY2FsX3ZpZXdfY2FjaGVfbm9kZShsYXlvdXRfbm9kZSk7 Ci0KICAgICAgICAgICAgICAgICAgICAgYWxsb2NhdG9yX2luZGV4ID0gMDsKICAgICAgICAgICAg ICAgICAgICAgaGFzX2FsbG9jYXRvciA9IGZhbHNlOwogICAgICAgICAgICAgICAgIH0K