237922 2022-03-15 14:47:18 -0700 REGRESSION (r291191): [iOS] ASSERTION FAILED: m_contentsBufferHandle in WebKit::RemoteLayerBackingStore::paintContents() 2022-03-15 23:08:42 -0700 1 1 1 Unclassified WebKit WebKit Process Model WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jenner simon.fraser ggaren simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1851510 0 jenner 2022-03-15 14:47:18 -0700 We're seeing the following assertion on quite a few WebGL tests here: https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r291304%20(1950)/results.html ASSERTION FAILED: m_contentsBufferHandle /Volumes/Data/worker/ios-simulator-15-debug/build/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm(355) : void WebKit::RemoteLayerBackingStore::paintContents() 1 0x6b2606769 WTFCrash 2 0x694cfbfeb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x6959c727d WebKit::RemoteLayerBackingStore::paintContents() 4 0x695a1e5d7 WebKit::RemoteLayerBackingStoreCollection::paintReachableBackingStoreContents() 5 0x69662609f WebKit::RemoteLayerTreeContext::buildTransaction(WebKit::RemoteLayerTreeTransaction&, WebCore::PlatformCALayer&) 6 0x69529a499 WebKit::RemoteLayerTreeDrawingArea::updateRendering() 7 0x6952a3a0e decltype(*(std::__1::forward<WebKit::RemoteLayerTreeDrawingArea*&>(fp0)).*fp()) std::__1::__invoke<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*&, void>(void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*&) 8 0x6952a398d std::__1::__bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<>, __is_valid_bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, 0ul, std::__1::tuple<> >(void (WebKit::RemoteLayerTreeDrawingArea::*&)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) 9 0x6952a3940 std::__1::__bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<>, __is_valid_bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*>::operator()<>() 10 0x6952a38d9 WTF::Detail::CallableWrapper<std::__1::__bind<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*>, void>::call() 11 0x694d55fc2 WTF::Function<void ()>::operator()() const 12 0x69529f259 WebCore::Timer::fired() 13 0x6de73bfa6 WebCore::ThreadTimers::sharedTimerFiredInternal() 14 0x6de7468c1 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const 15 0x6de746859 WTF::Detail::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, void>::call() 16 0x6da01e232 WTF::Function<void ()>::operator()() const 17 0x6de6d87e1 WebCore::MainThreadSharedTimer::fired() 18 0x6de7d0276 WebCore::timerFired(__CFRunLoopTimer*, void*) 19 0x7fff2036a6c6 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 20 0x7fff2036a1c2 __CFRunLoopDoTimer 21 0x7fff20369781 __CFRunLoopDoTimers 22 0x7fff20363dc0 __CFRunLoopRun 23 0x7fff20363103 CFRunLoopRunSpecific 24 0x7fff2081941c -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 25 0x7fff20819638 -[NSRunLoop(NSRunLoop) run] 26 0x7fff2006705f _xpc_objc_main 27 0x7fff20069050 xpc_main 28 0x6959c4f3a WebKit::XPCServiceMain(int, char const**) 29 0x697985ecb WKXPCServiceMain 30 0x101e65d12 main 31 0x680001e1e com.apple.WebKit.WebContent.Development terminated (pid 139) because the process crashed 1851512 1 webkit-bug-importer 2022-03-15 14:47:36 -0700 <rdar://problem/90331880> 1851535 2 simon.fraser 2022-03-15 15:23:36 -0700 Regressed between r291190 and r291201 1851537 3 simon.fraser 2022-03-15 15:26:24 -0700 https://trac.webkit.org/log/webkit/trunk?mode=follow_copy&rev=291201&stop_rev=291190 so probably https://trac.webkit.org/changeset/291191/webkit/trunk 1851633 4 simon.fraser 2022-03-15 20:48:01 -0700 Just a bad assertion. 1851636 5 454792 simon.fraser 2022-03-15 20:56:44 -0700 Created attachment 454792 Patch 1851641 6 454794 simon.fraser 2022-03-15 21:17:54 -0700 Created attachment 454794 Patch 1851644 7 454794 ggaren 2022-03-15 21:31:27 -0700 Comment on attachment 454794 Patch r=me 1851662 8 ews-feeder 2022-03-15 23:08:38 -0700 Committed r291333 (248472@main): <https://commits.webkit.org/248472@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454794. 454792 2022-03-15 20:56:44 -0700 2022-03-15 21:17:52 -0700 Patch bug-237922-20220315205643.patch text/plain 1948 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5Y2MzYzRmZTY5ZThiY2U1 ZTAxYzg5YWY0ZDA3Yzc1YWM4MGMzZTYuLmFjY2Q5MDQxMjgwMGQ4NDI5NTMzN2E1YmNmYWMyZGUz Y2U1OTRmOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjItMDMtMTUgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI5 MTE5MSk6IFtpT1NdIEFTU0VSVElPTiBGQUlMRUQ6IG1fY29udGVudHNCdWZmZXJIYW5kbGUgaW4g V2ViS2l0OjpSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6cGFpbnRDb250ZW50cygpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc5MjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYXNzZXJ0aW9uIGFk ZGVkIGluIHIyOTExOTEgaXMgaW5jb3JyZWN0LiBXaXRoIHRoYXQgY2hhbmdlLCB3ZSBlbmQgdXAg Y2FsbGluZworICAgICAgICBSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6cGFpbnRDb250ZW50cygp IG9uIFdlYkdMIGxheWVycyAod2hpY2ggdXNlIGRlbGVnYXRlZCBkaXNwbGF5KQorICAgICAgICB3 aGVuIHdlIHVzZWQgdG8ganVzdCBlYXJseSByZXR1cm4gZnJvbSBkaXNwbGF5KCkuIFNvIGl0J3Mg T0sgZm9yIG1fZnJvbnRCdWZmZXIuaW1hZ2VCdWZmZXIKKyAgICAgICAgdG8gYmUgbnVsbCBvbiB0 aGVzZSBsYXllcnMuCisKKyAgICAgICAgKiBTaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxh eWVyQmFja2luZ1N0b3JlLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllckJhY2tpbmdT dG9yZTo6cGFpbnRDb250ZW50cyk6CisKIDIwMjItMDMtMTQgIEFudG9pbmUgUXVpbnQgIDxncmFv dXRzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW21vZGVsXSA8bW9kZWwgaW50ZXJhY3RpdmU+IGRv ZXNuJ3QgYWxsb3cgbW9kZWwgdG8gYmUgcm90YXRlZCBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllckJhY2tpbmdTdG9yZS5t bSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllckJhY2tp bmdTdG9yZS5tbQppbmRleCBkMTUwZTExYTAyNzUyMzFkNzc1ZGEzMGU3MDM1YjU2MmRhZTAwYjdj Li4xYTMwNzI0NmJlZTA0MzEzNzRmMmM1MTU5ZTdmYTEyZjM2Yjk3OGI4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1NoYXJlZC9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJCYWNraW5nU3Rv cmUubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxh eWVyQmFja2luZ1N0b3JlLm1tCkBAIC0zNzcsMTAgKzM3Nyw4IEBAIHZvaWQgUmVtb3RlTGF5ZXJC YWNraW5nU3RvcmU6OnBhaW50Q29udGVudHMoKQogewogICAgIExPR19XSVRIX1NUUkVBTShSZW1v dGVSZW5kZXJpbmdCdWZmZXJWb2xhdGlsaXR5LCBzdHJlYW0gPDwgIlJlbW90ZUxheWVyQmFja2lu Z1N0b3JlICIgPDwgbV9sYXllci0+bGF5ZXJJRCgpIDw8ICIgcGFpbnRDb250ZW50cygpIC0gaGFz IGRpcnR5IHJlZ2lvbiAiIDw8ICFoYXNFbXB0eURpcnR5UmVnaW9uKCkpOwogCi0gICAgaWYgKCFt X2Zyb250QnVmZmVyLmltYWdlQnVmZmVyKSB7Ci0gICAgICAgIEFTU0VSVChtX2NvbnRlbnRzQnVm ZmVySGFuZGxlKTsKKyAgICBpZiAoIW1fZnJvbnRCdWZmZXIuaW1hZ2VCdWZmZXIpCiAgICAgICAg IHJldHVybjsKLSAgICB9CiAKICAgICBpZiAoaGFzRW1wdHlEaXJ0eVJlZ2lvbigpKQogICAgICAg ICByZXR1cm47Cg== 454794 2022-03-15 21:17:54 -0700 2022-03-15 23:08:41 -0700 Patch bug-237922-20220315211753.patch text/plain 1883 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJmOWU3NjQzMDI0NzhmOWUw Nzk5NTNlNjg4Yzc2NTFhZmNlMTdmMmQuLjQzODk1ZjcwZjhkZmQ3NDEyYmQ4YjRmYjM2NDdmNTVm ZTMwODY4Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjItMDMtMTUgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI5 MTE5MSk6IFtpT1NdIEFTU0VSVElPTiBGQUlMRUQ6IG1fY29udGVudHNCdWZmZXJIYW5kbGUgaW4g V2ViS2l0OjpSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6cGFpbnRDb250ZW50cygpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc5MjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYXNzZXJ0aW9uIGFk ZGVkIGluIHIyOTExOTEgaXMgaW5jb3JyZWN0LiBXaXRoIHRoYXQgY2hhbmdlLCB3ZSBlbmQgdXAg Y2FsbGluZworICAgICAgICBSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6cGFpbnRDb250ZW50cygp IG9uIFdlYkdMIGxheWVycyAod2hpY2ggdXNlIGRlbGVnYXRlZCBkaXNwbGF5KQorICAgICAgICB3 aGVuIHdlIHVzZWQgdG8ganVzdCBlYXJseSByZXR1cm4gZnJvbSBkaXNwbGF5KCkuIFNvIGl0J3Mg T0sgZm9yIG1fZnJvbnRCdWZmZXIuaW1hZ2VCdWZmZXIKKyAgICAgICAgdG8gYmUgbnVsbCBvbiB0 aGVzZSBsYXllcnMuCisKKyAgICAgICAgKiBTaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxh eWVyQmFja2luZ1N0b3JlLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllckJhY2tpbmdT dG9yZTo6cGFpbnRDb250ZW50cyk6CisKIDIwMjItMDMtMTUgIEVyaWMgQ2FybHNvbiAgPGVyaWMu Y2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVmlkZW8gcG9zdGVyIGRpc2FwcGVhcnMgcHJl bWF0dXJlbHkgb24gcGxheSwgbGVhdmluZyB0cmFuc3BhcmVudCB2aWRlbyBlbGVtZW50LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxheWVy QmFja2luZ1N0b3JlLm1tIGIvU291cmNlL1dlYktpdC9TaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1Jl bW90ZUxheWVyQmFja2luZ1N0b3JlLm1tCmluZGV4IGFmZDkwMTg2Y2E1NDEyYTVkYWI5NzRhNzlm NGY4NzY2MGM3ZWFjM2MuLjUxMDI0YzQzNWU2ZmViYWJmNTgyZTM1MmM3ODUyYzQ3MzZjNmNkMWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVM YXllckJhY2tpbmdTdG9yZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9SZW1vdGVMYXll clRyZWUvUmVtb3RlTGF5ZXJCYWNraW5nU3RvcmUubW0KQEAgLTM1MSwxMCArMzUxLDggQEAgU3dh cEJ1ZmZlcnNEaXNwbGF5UmVxdWlyZW1lbnQgUmVtb3RlTGF5ZXJCYWNraW5nU3RvcmU6OnByZXBh cmVCdWZmZXJzKGJvb2wgaGFzRW0KIAogdm9pZCBSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6cGFp bnRDb250ZW50cygpCiB7Ci0gICAgaWYgKCFtX2Zyb250QnVmZmVyLmltYWdlQnVmZmVyKSB7Ci0g ICAgICAgIEFTU0VSVChtX2NvbnRlbnRzQnVmZmVySGFuZGxlKTsKKyAgICBpZiAoIW1fZnJvbnRC dWZmZXIuaW1hZ2VCdWZmZXIpCiAgICAgICAgIHJldHVybjsKLSAgICB9CiAKICAgICBpZiAobV9k aXJ0eVJlZ2lvbi5pc0VtcHR5KCkgfHwgbV9zaXplLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJu Owo=