23788 2009-02-06 06:34:52 -0800 call style()->isOriginalDisplayInlineType() on RenderBox 2009-02-07 18:12:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zalan webkit-unassigned oldest_to_newest 108632 0 zalan 2009-02-06 06:34:52 -0800 call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject. Same as in RenderBlock::skipTrailingWhitespace(); The change in RenderBlock::skipTrailingWhitespace() was introduced by http://trac.webkit.org/changeset/40679 and probably was missed in RenderBlock::skipLeadingWhitespace(). 108633 1 27396 zalan 2009-02-06 06:37:31 -0800 Created attachment 27396 isOriginalDisplayInlineType() call 108819 2 27396 rwlbuis 2009-02-07 06:43:21 -0800 Comment on attachment 27396 isOriginalDisplayInlineType() call > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 40718) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,13 @@ > +2009-02-06 Zalan Bujtas <zbujtas@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + > + https://bugs.webkit.org/show_bug.cgi?id=23788 > + call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject. > + > + * rendering/bidi.cpp: > + (WebCore::RenderBlock::skipLeadingWhitespace): > + > 2009-02-06 Simon Hausmann <simon.hausmann@nokia.com> > > Reviewed by Tor Arne Vestbø. > Index: WebCore/rendering/bidi.cpp > =================================================================== > --- WebCore/rendering/bidi.cpp (revision 40717) > +++ WebCore/rendering/bidi.cpp (working copy) > @@ -1480,7 +1480,7 @@ int RenderBlock::skipLeadingWhitespace(I > > RenderBox* box = toRenderBox(object); > if (box->style()->hasStaticX()) { > - if (object->style()->isOriginalDisplayInlineType()) > + if (box->style()->isOriginalDisplayInlineType()) > box->layer()->setStaticX(style()->direction() == LTR ? leftOffset(height(), firstLine) : width() - rightOffset(height(), firstLine)); > else > box->layer()->setStaticX(style()->direction() == LTR ? borderLeft() + paddingLeft() : borderRight() + paddingRight()); AFAICS the end result is the same, but indeed confusing to use object here. r = me 108857 3 bfulgham 2009-02-07 18:12:21 -0800 Applied in http://trac.webkit.org/changeset/40766. 27396 2009-02-06 06:37:31 -0800 2009-02-07 06:43:21 -0800 isOriginalDisplayInlineType() call bidi.patch text/plain 1440 zalan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDcxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDItMDYgIFphbGFuIEJ1anRhcyAgPHpidWp0YXNAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzg4CisgICAg ICAgIGNhbGwgc3R5bGUoKS0+aXNPcmlnaW5hbERpc3BsYXlJbmxpbmVUeXBlKCkgb24gUmVuZGVy Qm94IGluc3RlYWQgb2YgUmVuZGVyT2JqZWN0LiAKKyAgICAgICAgCisgICAgICAgICogcmVuZGVy aW5nL2JpZGkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OnNraXBMZWFkaW5n V2hpdGVzcGFjZSk6CisKIDIwMDktMDItMDYgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21h bm5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCklu ZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9iaWRpLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Jl bmRlcmluZy9iaWRpLmNwcAkocmV2aXNpb24gNDA3MTcpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9i aWRpLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ4MCw3ICsxNDgwLDcgQEAgaW50IFJlbmRlckJs b2NrOjpza2lwTGVhZGluZ1doaXRlc3BhY2UoSQogICAgIAogICAgICAgICAgICAgUmVuZGVyQm94 KiBib3ggPSB0b1JlbmRlckJveChvYmplY3QpOwogICAgICAgICAgICAgaWYgKGJveC0+c3R5bGUo KS0+aGFzU3RhdGljWCgpKSB7Ci0gICAgICAgICAgICAgICAgaWYgKG9iamVjdC0+c3R5bGUoKS0+ aXNPcmlnaW5hbERpc3BsYXlJbmxpbmVUeXBlKCkpCisgICAgICAgICAgICAgICAgaWYgKGJveC0+ c3R5bGUoKS0+aXNPcmlnaW5hbERpc3BsYXlJbmxpbmVUeXBlKCkpCiAgICAgICAgICAgICAgICAg ICAgIGJveC0+bGF5ZXIoKS0+c2V0U3RhdGljWChzdHlsZSgpLT5kaXJlY3Rpb24oKSA9PSBMVFIg PyBsZWZ0T2Zmc2V0KGhlaWdodCgpLCBmaXJzdExpbmUpIDogd2lkdGgoKSAtIHJpZ2h0T2Zmc2V0 KGhlaWdodCgpLCBmaXJzdExpbmUpKTsKICAgICAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAg ICAgICAgICAgIGJveC0+bGF5ZXIoKS0+c2V0U3RhdGljWChzdHlsZSgpLT5kaXJlY3Rpb24oKSA9 PSBMVFIgPyBib3JkZXJMZWZ0KCkgKyBwYWRkaW5nTGVmdCgpIDogYm9yZGVyUmlnaHQoKSArIHBh ZGRpbmdSaWdodCgpKTsK