<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>237869</bug_id>
          
          <creation_ts>2022-03-14 20:01:38 -0700</creation_ts>
          <short_desc>[WebGPU] Implement queue submission methods according to the spec</short_desc>
          <delta_ts>2022-03-16 19:30:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGPU</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>237864</dependson>
          <blocked>237583</blocked>
    
    <blocked>237870</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Myles C. Maxfield">mmaxfield</assigned_to>
          <cc>dino</cc>
    
    <cc>djg</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1851126</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-03-14 20:01:38 -0700</bug_when>
    <thetext>.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1851128</commentid>
    <comment_count>1</comment_count>
      <attachid>454655</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-03-14 20:13:22 -0700</bug_when>
    <thetext>Created attachment 454655
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1851129</commentid>
    <comment_count>2</comment_count>
      <attachid>454656</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-03-14 20:14:41 -0700</bug_when>
    <thetext>Created attachment 454656
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1851251</commentid>
    <comment_count>3</comment_count>
      <attachid>454656</attachid>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2022-03-15 06:10:24 -0700</bug_when>
    <thetext>Comment on attachment 454656
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454656&amp;action=review

&gt; Source/WebGPU/WebGPU/Queue.h:73
&gt; +    using OnSubmittedWorkDoneCallbacks = Vector&lt;WTF::Function&lt;void(WGPUQueueWorkDoneStatus)&gt;&gt;;

completion handler aspect comes back also here.
so later on, you perhaps should switch the onsubmitted api signature to use completion handler, as the. intention is to express &quot;this function is valid only for one call&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1851982</commentid>
    <comment_count>4</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-03-16 14:20:11 -0700</bug_when>
    <thetext>Committed r291366 (248498@trunk): &lt;https://commits.webkit.org/248498@trunk&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1851983</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-03-16 14:21:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/90391949&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1852108</commentid>
    <comment_count>6</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-03-16 19:30:33 -0700</bug_when>
    <thetext>Committed r291382 (248513@trunk): &lt;https://commits.webkit.org/248513@trunk&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454655</attachid>
            <date>2022-03-14 20:13:22 -0700</date>
            <delta_ts>2022-03-14 20:14:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch.diff</filename>
            <type>text/plain</type>
            <size>6582</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">Y29tbWl0IGEyYjc2YzZiNDI1MmM2ODExYTk3YmEzNjU2ZTlhYzQ1MjNjMjYwODEKQXV0aG9yOiBN
eWxlcyBDLiBNYXhmaWVsZCA8bW1heGZpZWxkQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gTWFyIDE0
IDIwOjEyOjM5IDIwMjIgLTA3MDAKCiAgICBQYXJ0IDQKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
R1BVL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJHUFUvQ2hhbmdlTG9nCmluZGV4IDRhOTU2OGUxZWVi
ZC4uMDFmMGQ2NTc0MjAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BVL0NoYW5nZUxvZworKysg
Yi9Tb3VyY2UvV2ViR1BVL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIyLTAzLTE0ICBN
eWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkdQ
VV0gSW1wbGVtZW50IHF1ZXVlIHN1Ym1pc3Npb24gbWV0aG9kcyBhY2NvcmRpbmcgdG8gdGhlIHNw
ZWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzg2
OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdyB0
aGF0IHdlIGNhbiBlbnF1ZXVlIHRhc2tzIHRvIHRoZSBtYWluIHRocmVhZCAoaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzg1MikKKyAgICAgICAgd2UgY2FuIG5vdyBp
bXBsZW1lbnQgUXVldWU6Om9uU3VibWl0dGVkV29ya0RvbmUoKSBhbmQgUXVldWU6OnN1Ym1pdCgp
LiBUaGUgd2F5IGl0IHdvcmtzIGlzIHByZXR0eQorICAgICAgICBzaW1wbGUgLSB0aGVyZSdzIGEg
Y291bnQgb2YgdGhlIG51bWJlciBvZiBzdWJtaXR0ZWQgY29tbWFuZCBidWZmZXJzIChtX3N1Ym1p
dHRlZENvbW1hbmRCdWZmZXJDb3VudCkKKyAgICAgICAgYW5kIHRoZSBudW1iZXIgb2YgY29tcGxl
dGVkIGNvbW1hbmQgYnVmZmVycyAobV9jb21wbGV0ZWRDb21tYW5kQnVmZmVyQ291bnQpLiBXaGVu
IHRoZSB0d28gdmFsdWVzCisgICAgICAgIGFyZSBlcXVhbCwgdGhlIHF1ZXVlIGlzIGlkbGUsIGFu
ZCB0aGUgb25TdWJtaXR0ZWRXb3JrRG9uZSgpIHdvcmsgc2hvdWxkIGhhcHBlbiB0aGUgbmV4dCB0
aW1lIHRoZQorICAgICAgICBydW5sb29wIHR1cm5zLiBPdGhlcndpc2UsIHdlIHN0aWNrIHRoZSB3
b3JrIGluIGEgSGFzaE1hcCwga2V5ZWQgYnkgdGhlIHZhbHVlIHRoYXQKKyAgICAgICAgbV9jb21w
bGV0ZWRDb21tYW5kQnVmZmVyQ291bnQgd2lsbCBoYXZlIHRvIGJlY29tZSBhdCB0aGUgcG9pbnQg
dGhpcyBjYWxsYmFjayBzaG91bGQgcnVuLgorCisgICAgICAgICogV2ViR1BVL1F1ZXVlLmg6Cisg
ICAgICAgIChXZWJHUFU6OlF1ZXVlOjpjb21tYW5kUXVldWUgY29uc3QpOgorICAgICAgICAqIFdl
YkdQVS9RdWV1ZS5tbToKKyAgICAgICAgKFdlYkdQVTo6UXVldWU6Om9uU3VibWl0dGVkV29ya0Rv
bmUpOgorICAgICAgICAoV2ViR1BVOjpRdWV1ZTo6dmFsaWRhdGVTdWJtaXQgY29uc3QpOgorICAg
ICAgICAoV2ViR1BVOjpRdWV1ZTo6c3VibWl0KToKKyAgICAgICAgKiBXZWJHUFUvVGV4dHVyZVZp
ZXcubW06CisKIDIwMjItMDMtMTQgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxl
LmNvbT4KIAogICAgICAgICBbV2ViR1BVXSBDcmVhdGUgYSBwYXRoIG9mIFJlZjw+cyBiZXR3ZWVu
IEluc3RhbmNlIGFuZCBRdWV1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkdQVS9XZWJHUFUvUXVl
dWUuaCBiL1NvdXJjZS9XZWJHUFUvV2ViR1BVL1F1ZXVlLmgKaW5kZXggMzVhNTI1NDRmYThmLi5m
NWNmMzE2NzY5MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJHUFUvV2ViR1BVL1F1ZXVlLmgKKysr
IGIvU291cmNlL1dlYkdQVS9XZWJHUFUvUXVldWUuaApAQCAtMjgsNiArMjgsNyBAQAogI2ltcG9y
dCAiSW5zdGFuY2UuaCIKICNpbXBvcnQgPHd0Zi9GYXN0TWFsbG9jLmg+CiAjaW1wb3J0IDx3dGYv
RnVuY3Rpb24uaD4KKyNpbXBvcnQgPHd0Zi9IYXNoTWFwLmg+CiAjaW1wb3J0IDx3dGYvUmVmLmg+
CiAjaW1wb3J0IDx3dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQuaD4KICNpbXBvcnQgPHd0Zi9WZWN0
b3IuaD4KQEAgLTU0LDE0ICs1NSwyMyBAQCBwdWJsaWM6CiAgICAgdm9pZCB3cml0ZVRleHR1cmUo
Y29uc3QgV0dQVUltYWdlQ29weVRleHR1cmUmIGRlc3RpbmF0aW9uLCBjb25zdCB2b2lkKiBkYXRh
LCBzaXplX3QgZGF0YVNpemUsIGNvbnN0IFdHUFVUZXh0dXJlRGF0YUxheW91dCYsIGNvbnN0IFdH
UFVFeHRlbnQzRCYgd3JpdGVTaXplKTsKICAgICB2b2lkIHNldExhYmVsKGNvbnN0IGNoYXIqKTsK
IAorICAgIGlkPE1UTENvbW1hbmRRdWV1ZT4gY29tbWFuZFF1ZXVlKCkgY29uc3QgeyByZXR1cm4g
bV9jb21tYW5kUXVldWU7IH0KKwogcHJpdmF0ZToKICAgICBRdWV1ZShpZDxNVExDb21tYW5kUXVl
dWU+LCBEZXZpY2UmKTsKIAorICAgIGJvb2wgdmFsaWRhdGVTdWJtaXQoKSBjb25zdDsKKwogICAg
IC8vIFRoaXMgY2FuIGJlIGNhbGxlZCBvbiBhIGJhY2tncm91bmQgdGhyZWFkLgogICAgIHZvaWQg
c2NoZWR1bGVXb3JrKEluc3RhbmNlOjpXb3JrSXRlbSYmKTsKIAogICAgIGlkPE1UTENvbW1hbmRR
dWV1ZT4gbV9jb21tYW5kUXVldWUgeyBuaWwgfTsKICAgICBEZXZpY2UmIG1fZGV2aWNlOyAvLyBU
aGUgb25seSBraW5kIG9mIHF1ZXVlcyB0aGF0IGV4aXN0IHJpZ2h0IG5vdyBhcmUgZGVmYXVsdCBx
dWV1ZXMsIHdoaWNoIGFyZSBvd25lZCBieSBEZXZpY2VzLgorCisgICAgdWludDY0X3QgbV9zdWJt
aXR0ZWRDb21tYW5kQnVmZmVyQ291bnQgeyAwIH07CisgICAgdWludDY0X3QgbV9jb21wbGV0ZWRD
b21tYW5kQnVmZmVyQ291bnQgeyAwIH07CisgICAgdXNpbmcgT25TdWJtaXR0ZWRXb3JrRG9uZUNh
bGxiYWNrcyA9IFZlY3RvcjxXVEY6OkZ1bmN0aW9uPHZvaWQoV0dQVVF1ZXVlV29ya0RvbmVTdGF0
dXMpPj47CisgICAgSGFzaE1hcDx1aW50NjRfdCwgT25TdWJtaXR0ZWRXb3JrRG9uZUNhbGxiYWNr
cz4gbV9vblN1Ym1pdHRlZFdvcmtEb25lQ2FsbGJhY2tzOwogfTsKIAogfSAvLyBuYW1lc3BhY2Ug
V2ViR1BVCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9RdWV1ZS5tbSBiL1NvdXJj
ZS9XZWJHUFUvV2ViR1BVL1F1ZXVlLm1tCmluZGV4IGQzNjc5NTIxYzdiMy4uYTgyNzEyODM0NmJi
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9RdWV1ZS5tbQorKysgYi9Tb3VyY2Uv
V2ViR1BVL1dlYkdQVS9RdWV1ZS5tbQpAQCAtNDAsMTUgKzQwLDYxIEBAIFF1ZXVlOjpRdWV1ZShp
ZDxNVExDb21tYW5kUXVldWU+IGNvbW1hbmRRdWV1ZSwgRGV2aWNlJiBkZXZpY2UpCiAKIFF1ZXVl
Ojp+UXVldWUoKSA9IGRlZmF1bHQ7CiAKLXZvaWQgUXVldWU6Om9uU3VibWl0dGVkV29ya0RvbmUo
dWludDY0X3Qgc2lnbmFsVmFsdWUsIFdURjo6RnVuY3Rpb248dm9pZChXR1BVUXVldWVXb3JrRG9u
ZVN0YXR1cyk+JiYgY2FsbGJhY2spCit2b2lkIFF1ZXVlOjpvblN1Ym1pdHRlZFdvcmtEb25lKHVp
bnQ2NF90LCBXVEY6OkZ1bmN0aW9uPHZvaWQoV0dQVVF1ZXVlV29ya0RvbmVTdGF0dXMpPiYmIGNh
bGxiYWNrKQogewotICAgIFVOVVNFRF9QQVJBTShzaWduYWxWYWx1ZSk7Ci0gICAgVU5VU0VEX1BB
UkFNKGNhbGxiYWNrKTsKKyAgICBBU1NFUlQobV9zdWJtaXR0ZWRDb21tYW5kQnVmZmVyQ291bnQg
Pj0gbV9jb21wbGV0ZWRDb21tYW5kQnVmZmVyQ291bnQpOworCisgICAgaWYgKG1fc3VibWl0dGVk
Q29tbWFuZEJ1ZmZlckNvdW50ID09IG1fY29tcGxldGVkQ29tbWFuZEJ1ZmZlckNvdW50KSB7Cisg
ICAgICAgIHNjaGVkdWxlV29yayhbY2FsbGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKV0geworICAg
ICAgICAgICAgY2FsbGJhY2soV0dQVVF1ZXVlV29ya0RvbmVTdGF0dXNfU3VjY2Vzcyk7CisgICAg
ICAgIH0pOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgYXV0byYgY2FsbGJhY2tzID0g
bV9vblN1Ym1pdHRlZFdvcmtEb25lQ2FsbGJhY2tzLmFkZChtX3N1Ym1pdHRlZENvbW1hbmRCdWZm
ZXJDb3VudCwgT25TdWJtaXR0ZWRXb3JrRG9uZUNhbGxiYWNrcygpKS5pdGVyYXRvci0+dmFsdWU7
CisgICAgY2FsbGJhY2tzLmFwcGVuZChXVEZNb3ZlKGNhbGxiYWNrKSk7Cit9CisKK2Jvb2wgUXVl
dWU6OnZhbGlkYXRlU3VibWl0KCkgY29uc3QKK3sKKyAgICAvLyBGSVhNRTogIkV2ZXJ5IHt7R1BV
Q29tbWFuZEJ1ZmZlcn19IGluIHxjb21tYW5kQnVmZmVyc3wgaXMgWyR2YWxpZCB0byB1c2Ugd2l0
aCRdIHx0aGlzfC4iCisKKyAgICAvLyBGSVhNRTogIkV2ZXJ5IEdQVUJ1ZmZlciByZWZlcmVuY2Vk
IGluIGFueSBlbGVtZW50IG9mIGNvbW1hbmRCdWZmZXJzIGlzIGluIHRoZSAidW5tYXBwZWQiIGJ1
ZmZlciBzdGF0ZS4iCisKKyAgICAvLyBGSVhNRTogIkV2ZXJ5IEdQVVF1ZXJ5U2V0IHJlZmVyZW5j
ZWQgaW4gYSBjb21tYW5kIGluIGFueSBlbGVtZW50IG9mIGNvbW1hbmRCdWZmZXJzIGlzIGluIHRo
ZSBhdmFpbGFibGUgc3RhdGUuIgorICAgIC8vIEZJWE1FOiAiRm9yIG9jY2x1c2lvbiBxdWVyaWVz
LCBvY2NsdXNpb25RdWVyeVNldCBpbiBiZWdpblJlbmRlclBhc3MoKSBkb2VzIG5vdCBjb25zdGl0
dXRlIGEgcmVmZXJlbmNlLCB3aGlsZSBiZWdpbk9jY2x1c2lvblF1ZXJ5KCkgZG9lcy4iCisKKyAg
ICAvLyBUaGVyZSdzIG9ubHkgb25lIHF1ZXVlIHJpZ2h0IG5vdywgc28gdGhlcmUgaXMgbm8gbmVl
ZCB0byBtYWtlIHN1cmUgdGhhdCB0aGUgY29tbWFuZCBidWZmZXJzIGFyZSBiZWluZyBzdWJtaXR0
ZWQgdG8gdGhlIGNvcnJlY3QgcXVldWUuCisKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogdm9pZCBR
dWV1ZTo6c3VibWl0KFZlY3RvcjxzdGQ6OnJlZmVyZW5jZV93cmFwcGVyPGNvbnN0IENvbW1hbmRC
dWZmZXI+PiYmIGNvbW1hbmRzKQogewotICAgIFVOVVNFRF9QQVJBTShjb21tYW5kcyk7CisgICAg
Ly8gaHR0cHM6Ly9ncHV3ZWIuZ2l0aHViLmlvL2dwdXdlYi8jZG9tLWdwdXF1ZXVlLXN1Ym1pdAor
CisgICAgLy8gIklmIGFueSBvZiB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlIHVuc2F0aXNm
aWVkIgorICAgIGlmICghdmFsaWRhdGVTdWJtaXQoKSkgeworICAgICAgICAvLyBGSVhNRTogImdl
bmVyYXRlIGEgdmFsaWRhdGlvbiBlcnJvciBhbmQgc3RvcC4iCisgICAgICAgIHJldHVybjsKKyAg
ICB9CisKKyAgICAvLyAiRm9yIGVhY2ggY29tbWFuZEJ1ZmZlciBpbiBjb21tYW5kQnVmZmVyczoi
CisgICAgZm9yIChhdXRvIGNvbW1hbmRCdWZmZXIgOiBjb21tYW5kcykgeworICAgICAgICBBU1NF
UlQoY29tbWFuZEJ1ZmZlci5nZXQoKS5jb21tYW5kQnVmZmVyKCkuY29tbWFuZFF1ZXVlID09IG1f
Y29tbWFuZFF1ZXVlKTsgLy8KKyAgICAgICAgW2NvbW1hbmRCdWZmZXIuZ2V0KCkuY29tbWFuZEJ1
ZmZlcigpIGFkZENvbXBsZXRlZEhhbmRsZXI6W3Byb3RlY3RlZFRoaXMgPSBSZWYgeyAqdGhpcyB9
XSAoaWQ8TVRMQ29tbWFuZEJ1ZmZlcj4pIHsKKyAgICAgICAgICAgIHByb3RlY3RlZFRoaXMtPnNj
aGVkdWxlV29yayhbcHJvdGVjdGVkVGhpcyA9IHByb3RlY3RlZFRoaXMuY29weVJlZigpXSgpIHsK
KyAgICAgICAgICAgICAgICArKyhwcm90ZWN0ZWRUaGlzLT5tX2NvbXBsZXRlZENvbW1hbmRCdWZm
ZXJDb3VudCk7CisgICAgICAgICAgICAgICAgZm9yIChhdXRvJiBjYWxsYmFjayA6IHByb3RlY3Rl
ZFRoaXMtPm1fb25TdWJtaXR0ZWRXb3JrRG9uZUNhbGxiYWNrcy50YWtlKHByb3RlY3RlZFRoaXMt
Pm1fY29tcGxldGVkQ29tbWFuZEJ1ZmZlckNvdW50KSkKKyAgICAgICAgICAgICAgICAgICAgY2Fs
bGJhY2soV0dQVVF1ZXVlV29ya0RvbmVTdGF0dXNfU3VjY2Vzcyk7CisgICAgICAgICAgICB9KTsK
KyAgICAgICAgfV07CisKKyAgICAgICAgLy8gIkV4ZWN1dGUgZWFjaCBjb21tYW5kIGluIGNvbW1h
bmRCdWZmZXIuW1tjb21tYW5kX2xpc3RdXS4iCisgICAgICAgIFtjb21tYW5kQnVmZmVyLmdldCgp
LmNvbW1hbmRCdWZmZXIoKSBjb21taXRdOworICAgIH0KKworICAgIG1fc3VibWl0dGVkQ29tbWFu
ZEJ1ZmZlckNvdW50ICs9IGNvbW1hbmRzLnNpemUoKTsKIH0KIAogdm9pZCBRdWV1ZTo6d3JpdGVC
dWZmZXIoY29uc3QgQnVmZmVyJiBidWZmZXIsIHVpbnQ2NF90IGJ1ZmZlck9mZnNldCwgY29uc3Qg
dm9pZCogZGF0YSwgc2l6ZV90IHNpemUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViR1BVL1dlYkdQ
VS9UZXh0dXJlVmlldy5tbSBiL1NvdXJjZS9XZWJHUFUvV2ViR1BVL1RleHR1cmVWaWV3Lm1tCmlu
ZGV4IDU4M2E0MDY4Y2U0MC4uZDZkY2NiZDVhOGIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BV
L1dlYkdQVS9UZXh0dXJlVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9UZXh0dXJl
Vmlldy5tbQpAQCAtNDAsNyArNDAsNyBAQCB2b2lkIFRleHR1cmVWaWV3OjpzZXRMYWJlbChjb25z
dCBjaGFyKiBsYWJlbCkKICAgICBtX3RleHR1cmUubGFiZWwgPSBbTlNTdHJpbmcgc3RyaW5nV2l0
aENTdHJpbmc6bGFiZWwgZW5jb2Rpbmc6TlNVVEY4U3RyaW5nRW5jb2RpbmddOwogfQogCi19Cit9
IC8vIG5hbWVzcGFjZSBXZWJHUFUKIAogdm9pZCB3Z3B1VGV4dHVyZVZpZXdSZWxlYXNlKFdHUFVU
ZXh0dXJlVmlldyB0ZXh0dXJlVmlldykKIHsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>454656</attachid>
            <date>2022-03-14 20:14:41 -0700</date>
            <delta_ts>2022-03-15 06:10:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch.diff</filename>
            <type>text/plain</type>
            <size>6658</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">Y29tbWl0IDkxM2M2MTA4YWViOTkyMDFkMTU2NDdjMzFjMjhiNzNmMmVjYTc2OTQKQXV0aG9yOiBN
eWxlcyBDLiBNYXhmaWVsZCA8bW1heGZpZWxkQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gTWFyIDE0
IDIwOjEyOjM5IDIwMjIgLTA3MDAKCiAgICBQYXJ0IDQKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
R1BVL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJHUFUvQ2hhbmdlTG9nCmluZGV4IDRhOTU2OGUxZWVi
ZC4uMDFmMGQ2NTc0MjAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BVL0NoYW5nZUxvZworKysg
Yi9Tb3VyY2UvV2ViR1BVL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIyLTAzLTE0ICBN
eWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkdQ
VV0gSW1wbGVtZW50IHF1ZXVlIHN1Ym1pc3Npb24gbWV0aG9kcyBhY2NvcmRpbmcgdG8gdGhlIHNw
ZWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzg2
OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdyB0
aGF0IHdlIGNhbiBlbnF1ZXVlIHRhc2tzIHRvIHRoZSBtYWluIHRocmVhZCAoaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNzg1MikKKyAgICAgICAgd2UgY2FuIG5vdyBp
bXBsZW1lbnQgUXVldWU6Om9uU3VibWl0dGVkV29ya0RvbmUoKSBhbmQgUXVldWU6OnN1Ym1pdCgp
LiBUaGUgd2F5IGl0IHdvcmtzIGlzIHByZXR0eQorICAgICAgICBzaW1wbGUgLSB0aGVyZSdzIGEg
Y291bnQgb2YgdGhlIG51bWJlciBvZiBzdWJtaXR0ZWQgY29tbWFuZCBidWZmZXJzIChtX3N1Ym1p
dHRlZENvbW1hbmRCdWZmZXJDb3VudCkKKyAgICAgICAgYW5kIHRoZSBudW1iZXIgb2YgY29tcGxl
dGVkIGNvbW1hbmQgYnVmZmVycyAobV9jb21wbGV0ZWRDb21tYW5kQnVmZmVyQ291bnQpLiBXaGVu
IHRoZSB0d28gdmFsdWVzCisgICAgICAgIGFyZSBlcXVhbCwgdGhlIHF1ZXVlIGlzIGlkbGUsIGFu
ZCB0aGUgb25TdWJtaXR0ZWRXb3JrRG9uZSgpIHdvcmsgc2hvdWxkIGhhcHBlbiB0aGUgbmV4dCB0
aW1lIHRoZQorICAgICAgICBydW5sb29wIHR1cm5zLiBPdGhlcndpc2UsIHdlIHN0aWNrIHRoZSB3
b3JrIGluIGEgSGFzaE1hcCwga2V5ZWQgYnkgdGhlIHZhbHVlIHRoYXQKKyAgICAgICAgbV9jb21w
bGV0ZWRDb21tYW5kQnVmZmVyQ291bnQgd2lsbCBoYXZlIHRvIGJlY29tZSBhdCB0aGUgcG9pbnQg
dGhpcyBjYWxsYmFjayBzaG91bGQgcnVuLgorCisgICAgICAgICogV2ViR1BVL1F1ZXVlLmg6Cisg
ICAgICAgIChXZWJHUFU6OlF1ZXVlOjpjb21tYW5kUXVldWUgY29uc3QpOgorICAgICAgICAqIFdl
YkdQVS9RdWV1ZS5tbToKKyAgICAgICAgKFdlYkdQVTo6UXVldWU6Om9uU3VibWl0dGVkV29ya0Rv
bmUpOgorICAgICAgICAoV2ViR1BVOjpRdWV1ZTo6dmFsaWRhdGVTdWJtaXQgY29uc3QpOgorICAg
ICAgICAoV2ViR1BVOjpRdWV1ZTo6c3VibWl0KToKKyAgICAgICAgKiBXZWJHUFUvVGV4dHVyZVZp
ZXcubW06CisKIDIwMjItMDMtMTQgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxl
LmNvbT4KIAogICAgICAgICBbV2ViR1BVXSBDcmVhdGUgYSBwYXRoIG9mIFJlZjw+cyBiZXR3ZWVu
IEluc3RhbmNlIGFuZCBRdWV1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkdQVS9XZWJHUFUvUXVl
dWUuaCBiL1NvdXJjZS9XZWJHUFUvV2ViR1BVL1F1ZXVlLmgKaW5kZXggMzVhNTI1NDRmYThmLi5m
NWNmMzE2NzY5MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJHUFUvV2ViR1BVL1F1ZXVlLmgKKysr
IGIvU291cmNlL1dlYkdQVS9XZWJHUFUvUXVldWUuaApAQCAtMjgsNiArMjgsNyBAQAogI2ltcG9y
dCAiSW5zdGFuY2UuaCIKICNpbXBvcnQgPHd0Zi9GYXN0TWFsbG9jLmg+CiAjaW1wb3J0IDx3dGYv
RnVuY3Rpb24uaD4KKyNpbXBvcnQgPHd0Zi9IYXNoTWFwLmg+CiAjaW1wb3J0IDx3dGYvUmVmLmg+
CiAjaW1wb3J0IDx3dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQuaD4KICNpbXBvcnQgPHd0Zi9WZWN0
b3IuaD4KQEAgLTU0LDE0ICs1NSwyMyBAQCBwdWJsaWM6CiAgICAgdm9pZCB3cml0ZVRleHR1cmUo
Y29uc3QgV0dQVUltYWdlQ29weVRleHR1cmUmIGRlc3RpbmF0aW9uLCBjb25zdCB2b2lkKiBkYXRh
LCBzaXplX3QgZGF0YVNpemUsIGNvbnN0IFdHUFVUZXh0dXJlRGF0YUxheW91dCYsIGNvbnN0IFdH
UFVFeHRlbnQzRCYgd3JpdGVTaXplKTsKICAgICB2b2lkIHNldExhYmVsKGNvbnN0IGNoYXIqKTsK
IAorICAgIGlkPE1UTENvbW1hbmRRdWV1ZT4gY29tbWFuZFF1ZXVlKCkgY29uc3QgeyByZXR1cm4g
bV9jb21tYW5kUXVldWU7IH0KKwogcHJpdmF0ZToKICAgICBRdWV1ZShpZDxNVExDb21tYW5kUXVl
dWU+LCBEZXZpY2UmKTsKIAorICAgIGJvb2wgdmFsaWRhdGVTdWJtaXQoKSBjb25zdDsKKwogICAg
IC8vIFRoaXMgY2FuIGJlIGNhbGxlZCBvbiBhIGJhY2tncm91bmQgdGhyZWFkLgogICAgIHZvaWQg
c2NoZWR1bGVXb3JrKEluc3RhbmNlOjpXb3JrSXRlbSYmKTsKIAogICAgIGlkPE1UTENvbW1hbmRR
dWV1ZT4gbV9jb21tYW5kUXVldWUgeyBuaWwgfTsKICAgICBEZXZpY2UmIG1fZGV2aWNlOyAvLyBU
aGUgb25seSBraW5kIG9mIHF1ZXVlcyB0aGF0IGV4aXN0IHJpZ2h0IG5vdyBhcmUgZGVmYXVsdCBx
dWV1ZXMsIHdoaWNoIGFyZSBvd25lZCBieSBEZXZpY2VzLgorCisgICAgdWludDY0X3QgbV9zdWJt
aXR0ZWRDb21tYW5kQnVmZmVyQ291bnQgeyAwIH07CisgICAgdWludDY0X3QgbV9jb21wbGV0ZWRD
b21tYW5kQnVmZmVyQ291bnQgeyAwIH07CisgICAgdXNpbmcgT25TdWJtaXR0ZWRXb3JrRG9uZUNh
bGxiYWNrcyA9IFZlY3RvcjxXVEY6OkZ1bmN0aW9uPHZvaWQoV0dQVVF1ZXVlV29ya0RvbmVTdGF0
dXMpPj47CisgICAgSGFzaE1hcDx1aW50NjRfdCwgT25TdWJtaXR0ZWRXb3JrRG9uZUNhbGxiYWNr
cz4gbV9vblN1Ym1pdHRlZFdvcmtEb25lQ2FsbGJhY2tzOwogfTsKIAogfSAvLyBuYW1lc3BhY2Ug
V2ViR1BVCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9RdWV1ZS5tbSBiL1NvdXJj
ZS9XZWJHUFUvV2ViR1BVL1F1ZXVlLm1tCmluZGV4IGQzNjc5NTIxYzdiMy4uYWRhMDRkN2NkMzE0
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9RdWV1ZS5tbQorKysgYi9Tb3VyY2Uv
V2ViR1BVL1dlYkdQVS9RdWV1ZS5tbQpAQCAtNDAsMTUgKzQwLDYzIEBAIFF1ZXVlOjpRdWV1ZShp
ZDxNVExDb21tYW5kUXVldWU+IGNvbW1hbmRRdWV1ZSwgRGV2aWNlJiBkZXZpY2UpCiAKIFF1ZXVl
Ojp+UXVldWUoKSA9IGRlZmF1bHQ7CiAKLXZvaWQgUXVldWU6Om9uU3VibWl0dGVkV29ya0RvbmUo
dWludDY0X3Qgc2lnbmFsVmFsdWUsIFdURjo6RnVuY3Rpb248dm9pZChXR1BVUXVldWVXb3JrRG9u
ZVN0YXR1cyk+JiYgY2FsbGJhY2spCit2b2lkIFF1ZXVlOjpvblN1Ym1pdHRlZFdvcmtEb25lKHVp
bnQ2NF90LCBXVEY6OkZ1bmN0aW9uPHZvaWQoV0dQVVF1ZXVlV29ya0RvbmVTdGF0dXMpPiYmIGNh
bGxiYWNrKQogewotICAgIFVOVVNFRF9QQVJBTShzaWduYWxWYWx1ZSk7Ci0gICAgVU5VU0VEX1BB
UkFNKGNhbGxiYWNrKTsKKyAgICAvLyBodHRwczovL2dwdXdlYi5naXRodWIuaW8vZ3B1d2ViLyNk
b20tZ3B1cXVldWUtb25zdWJtaXR0ZWR3b3JrZG9uZQorCisgICAgQVNTRVJUKG1fc3VibWl0dGVk
Q29tbWFuZEJ1ZmZlckNvdW50ID49IG1fY29tcGxldGVkQ29tbWFuZEJ1ZmZlckNvdW50KTsKKwor
ICAgIGlmIChtX3N1Ym1pdHRlZENvbW1hbmRCdWZmZXJDb3VudCA9PSBtX2NvbXBsZXRlZENvbW1h
bmRCdWZmZXJDb3VudCkgeworICAgICAgICBzY2hlZHVsZVdvcmsoW2NhbGxiYWNrID0gV1RGTW92
ZShjYWxsYmFjayldIHsKKyAgICAgICAgICAgIGNhbGxiYWNrKFdHUFVRdWV1ZVdvcmtEb25lU3Rh
dHVzX1N1Y2Nlc3MpOworICAgICAgICB9KTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAg
IGF1dG8mIGNhbGxiYWNrcyA9IG1fb25TdWJtaXR0ZWRXb3JrRG9uZUNhbGxiYWNrcy5hZGQobV9z
dWJtaXR0ZWRDb21tYW5kQnVmZmVyQ291bnQsIE9uU3VibWl0dGVkV29ya0RvbmVDYWxsYmFja3Mo
KSkuaXRlcmF0b3ItPnZhbHVlOworICAgIGNhbGxiYWNrcy5hcHBlbmQoV1RGTW92ZShjYWxsYmFj
aykpOworfQorCitib29sIFF1ZXVlOjp2YWxpZGF0ZVN1Ym1pdCgpIGNvbnN0Cit7CisgICAgLy8g
RklYTUU6ICJFdmVyeSB7e0dQVUNvbW1hbmRCdWZmZXJ9fSBpbiB8Y29tbWFuZEJ1ZmZlcnN8IGlz
IFskdmFsaWQgdG8gdXNlIHdpdGgkXSB8dGhpc3wuIgorCisgICAgLy8gRklYTUU6ICJFdmVyeSBH
UFVCdWZmZXIgcmVmZXJlbmNlZCBpbiBhbnkgZWxlbWVudCBvZiBjb21tYW5kQnVmZmVycyBpcyBp
biB0aGUgInVubWFwcGVkIiBidWZmZXIgc3RhdGUuIgorCisgICAgLy8gRklYTUU6ICJFdmVyeSBH
UFVRdWVyeVNldCByZWZlcmVuY2VkIGluIGEgY29tbWFuZCBpbiBhbnkgZWxlbWVudCBvZiBjb21t
YW5kQnVmZmVycyBpcyBpbiB0aGUgYXZhaWxhYmxlIHN0YXRlLiIKKyAgICAvLyBGSVhNRTogIkZv
ciBvY2NsdXNpb24gcXVlcmllcywgb2NjbHVzaW9uUXVlcnlTZXQgaW4gYmVnaW5SZW5kZXJQYXNz
KCkgZG9lcyBub3QgY29uc3RpdHV0ZSBhIHJlZmVyZW5jZSwgd2hpbGUgYmVnaW5PY2NsdXNpb25R
dWVyeSgpIGRvZXMuIgorCisgICAgLy8gVGhlcmUncyBvbmx5IG9uZSBxdWV1ZSByaWdodCBub3cs
IHNvIHRoZXJlIGlzIG5vIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgdGhlIGNvbW1hbmQgYnVmZmVy
cyBhcmUgYmVpbmcgc3VibWl0dGVkIHRvIHRoZSBjb3JyZWN0IHF1ZXVlLgorCisgICAgcmV0dXJu
IHRydWU7CiB9CiAKIHZvaWQgUXVldWU6OnN1Ym1pdChWZWN0b3I8c3RkOjpyZWZlcmVuY2Vfd3Jh
cHBlcjxjb25zdCBDb21tYW5kQnVmZmVyPj4mJiBjb21tYW5kcykKIHsKLSAgICBVTlVTRURfUEFS
QU0oY29tbWFuZHMpOworICAgIC8vIGh0dHBzOi8vZ3B1d2ViLmdpdGh1Yi5pby9ncHV3ZWIvI2Rv
bS1ncHVxdWV1ZS1zdWJtaXQKKworICAgIC8vICJJZiBhbnkgb2YgdGhlIGZvbGxvd2luZyBjb25k
aXRpb25zIGFyZSB1bnNhdGlzZmllZCIKKyAgICBpZiAoIXZhbGlkYXRlU3VibWl0KCkpIHsKKyAg
ICAgICAgLy8gRklYTUU6ICJnZW5lcmF0ZSBhIHZhbGlkYXRpb24gZXJyb3IgYW5kIHN0b3AuIgor
ICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgLy8gIkZvciBlYWNoIGNvbW1hbmRCdWZmZXIg
aW4gY29tbWFuZEJ1ZmZlcnM6IgorICAgIGZvciAoYXV0byBjb21tYW5kQnVmZmVyIDogY29tbWFu
ZHMpIHsKKyAgICAgICAgQVNTRVJUKGNvbW1hbmRCdWZmZXIuZ2V0KCkuY29tbWFuZEJ1ZmZlcigp
LmNvbW1hbmRRdWV1ZSA9PSBtX2NvbW1hbmRRdWV1ZSk7IC8vCisgICAgICAgIFtjb21tYW5kQnVm
ZmVyLmdldCgpLmNvbW1hbmRCdWZmZXIoKSBhZGRDb21wbGV0ZWRIYW5kbGVyOltwcm90ZWN0ZWRU
aGlzID0gUmVmIHsgKnRoaXMgfV0gKGlkPE1UTENvbW1hbmRCdWZmZXI+KSB7CisgICAgICAgICAg
ICBwcm90ZWN0ZWRUaGlzLT5zY2hlZHVsZVdvcmsoW3Byb3RlY3RlZFRoaXMgPSBwcm90ZWN0ZWRU
aGlzLmNvcHlSZWYoKV0oKSB7CisgICAgICAgICAgICAgICAgKysocHJvdGVjdGVkVGhpcy0+bV9j
b21wbGV0ZWRDb21tYW5kQnVmZmVyQ291bnQpOworICAgICAgICAgICAgICAgIGZvciAoYXV0byYg
Y2FsbGJhY2sgOiBwcm90ZWN0ZWRUaGlzLT5tX29uU3VibWl0dGVkV29ya0RvbmVDYWxsYmFja3Mu
dGFrZShwcm90ZWN0ZWRUaGlzLT5tX2NvbXBsZXRlZENvbW1hbmRCdWZmZXJDb3VudCkpCisgICAg
ICAgICAgICAgICAgICAgIGNhbGxiYWNrKFdHUFVRdWV1ZVdvcmtEb25lU3RhdHVzX1N1Y2Nlc3Mp
OworICAgICAgICAgICAgfSk7CisgICAgICAgIH1dOworCisgICAgICAgIC8vICJFeGVjdXRlIGVh
Y2ggY29tbWFuZCBpbiBjb21tYW5kQnVmZmVyLltbY29tbWFuZF9saXN0XV0uIgorICAgICAgICBb
Y29tbWFuZEJ1ZmZlci5nZXQoKS5jb21tYW5kQnVmZmVyKCkgY29tbWl0XTsKKyAgICB9CisKKyAg
ICBtX3N1Ym1pdHRlZENvbW1hbmRCdWZmZXJDb3VudCArPSBjb21tYW5kcy5zaXplKCk7CiB9CiAK
IHZvaWQgUXVldWU6OndyaXRlQnVmZmVyKGNvbnN0IEJ1ZmZlciYgYnVmZmVyLCB1aW50NjRfdCBi
dWZmZXJPZmZzZXQsIGNvbnN0IHZvaWQqIGRhdGEsIHNpemVfdCBzaXplKQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkdQVS9XZWJHUFUvVGV4dHVyZVZpZXcubW0gYi9Tb3VyY2UvV2ViR1BVL1dlYkdQ
VS9UZXh0dXJlVmlldy5tbQppbmRleCA1ODNhNDA2OGNlNDAuLmQ2ZGNjYmQ1YThiMiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkdQVS9XZWJHUFUvVGV4dHVyZVZpZXcubW0KKysrIGIvU291cmNlL1dl
YkdQVS9XZWJHUFUvVGV4dHVyZVZpZXcubW0KQEAgLTQwLDcgKzQwLDcgQEAgdm9pZCBUZXh0dXJl
Vmlldzo6c2V0TGFiZWwoY29uc3QgY2hhciogbGFiZWwpCiAgICAgbV90ZXh0dXJlLmxhYmVsID0g
W05TU3RyaW5nIHN0cmluZ1dpdGhDU3RyaW5nOmxhYmVsIGVuY29kaW5nOk5TVVRGOFN0cmluZ0Vu
Y29kaW5nXTsKIH0KIAotfQorfSAvLyBuYW1lc3BhY2UgV2ViR1BVCiAKIHZvaWQgd2dwdVRleHR1
cmVWaWV3UmVsZWFzZShXR1BVVGV4dHVyZVZpZXcgdGV4dHVyZVZpZXcpCiB7Cg==
</data>
<flag name="review"
          id="482373"
          type_id="1"
          status="+"
          setter="kkinnunen"
    />
          </attachment>
      

    </bug>

</bugzilla>