237856 2022-03-14 16:02:30 -0700 [WebAuthn] Mock UI interactions whenever virtual authenticators are in use. 2022-03-15 16:25:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pascoe pascoe bfulgham webkit-bug-importer oldest_to_newest 1851055 0 pascoe 2022-03-14 16:02:30 -0700 Which UI option to choose is unspecified. The convention is to select the first assertion / creation option. 1851056 1 webkit-bug-importer 2022-03-14 16:02:39 -0700 <rdar://problem/90274854> 1851122 2 454652 pascoe 2022-03-14 19:39:55 -0700 Created attachment 454652 Patch 1851555 3 454652 bfulgham 2022-03-15 16:14:19 -0700 Comment on attachment 454652 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454652&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h:-100 > - void decidePolicyForLocalAuthenticator(CompletionHandler<void(LocalAuthenticatorPolicy)>&&) final; It might be enough to just remove 'final' on these two methods, and not make them public. > Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:43 > + void runPanel(); void runPanel() override; This can also be 'private', since it is an override of the parent class method. 1851565 4 ews-feeder 2022-03-15 16:25:04 -0700 Committed r291321 (248460@main): <https://commits.webkit.org/248460@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454652. 454652 2022-03-14 19:39:55 -0700 2022-03-15 16:25:07 -0700 Patch bug-237856-20220314193954.patch text/plain 5815 pascoe U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYwYTJjYjBjN2MxNmE0NTA5 NmVkMzIzYzEyZTQ0OGJhN2VlZjJkNTcuLjMyODlhODEyZmE0MzMzYzM4NjQ3ZWQwYjljODczMmI4 Njg4ZWMxNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjItMDMtMTQgIEogUGFzY29l ICA8al9wYXNjb2VAYXBwbGUuY29tPgorCisgICAgICAgIFtXZWJBdXRobl0gTW9jayBVSSBpbnRl cmFjdGlvbnMgd2hlbmV2ZXIgdmlydHVhbCBhdXRoZW50aWNhdG9ycyBhcmUgaW4gdXNlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3ODU2CisgICAg ICAgIHJkYXI6Ly9wcm9ibGVtLzkwMjc0ODU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGVzdGVkIGJ5IHdwdCdzIHdlYmF1dGhuIHRlc3RzLgorCisg ICAgICAgICogVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0b3JNYW5hZ2Vy Lmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL1ZpcnR1YWwvVmlydHVh bEF1dGhlbnRpY2F0b3JNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6VmlydHVhbEF1dGhl bnRpY2F0b3JNYW5hZ2VyOjpydW5QYW5lbCk6CisgICAgICAgIChXZWJLaXQ6OlZpcnR1YWxBdXRo ZW50aWNhdG9yTWFuYWdlcjo6c2VsZWN0QXNzZXJ0aW9uUmVzcG9uc2UpOgorICAgICAgICAoV2Vi S2l0OjpWaXJ0dWFsQXV0aGVudGljYXRvck1hbmFnZXI6OmRlY2lkZVBvbGljeUZvckxvY2FsQXV0 aGVudGljYXRvcik6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL1ZpcnR1 YWwvVmlydHVhbEF1dGhlbnRpY2F0b3JNYW5hZ2VyLmg6CisKIDIwMjItMDMtMTQgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW01haWwgQ29tcG9zZV0g U3BlbGxpbmcgYW5kIGdyYW1tYXIgY29udGV4dCBtZW51IGl0ZW1zIG5lZWQgY3VzdG9tIGlkZW50 aWZpZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi QXV0aGVudGljYXRpb24vQXV0aGVudGljYXRvck1hbmFnZXIuaAppbmRleCA4NjRiMzM3OGIzNDc2 NjVlZTVmNzk0OGE3ZmQ0ZDM2NDE2NTUxOWU0Li41OWUyYTFmN2E1YTAxODRmZDA0OWVhOTYyN2Qz NTNjNDYyODViZjkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRo ZW50aWNhdGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0b3JNYW5hZ2VyLmgKQEAgLTgwLDYg KzgwLDEyIEBAIHByb3RlY3RlZDoKICAgICB2b2lkIGNsZWFyU3RhdGUoKTsKICAgICB2b2lkIGlu dm9rZVBlbmRpbmdDb21wbGV0aW9uSGFuZGxlcihSZXNwb25kJiYpOwogCisgICAgdm9pZCBkZWNp ZGVQb2xpY3lGb3JMb2NhbEF1dGhlbnRpY2F0b3IoQ29tcGxldGlvbkhhbmRsZXI8dm9pZChMb2Nh bEF1dGhlbnRpY2F0b3JQb2xpY3kpPiYmKTsKKyAgICBUcmFuc3BvcnRTZXQgZ2V0VHJhbnNwb3J0 cygpIGNvbnN0OworICAgIHZpcnR1YWwgdm9pZCBydW5QYW5lbCgpOworICAgIHZvaWQgc2VsZWN0 QXNzZXJ0aW9uUmVzcG9uc2UoVmVjdG9yPFJlZjxXZWJDb3JlOjpBdXRoZW50aWNhdG9yQXNzZXJ0 aW9uUmVzcG9uc2U+PiYmLCBXZWJBdXRoZW50aWNhdGlvblNvdXJjZSwgQ29tcGxldGlvbkhhbmRs ZXI8dm9pZChXZWJDb3JlOjpBdXRoZW50aWNhdG9yQXNzZXJ0aW9uUmVzcG9uc2UqKT4mJik7Cisg ICAgdm9pZCBzdGFydERpc2NvdmVyeShjb25zdCBUcmFuc3BvcnRTZXQmKTsKKwogcHJpdmF0ZToK ICAgICBlbnVtIGNsYXNzIE1vZGUgewogICAgICAgICBDb21wYXRpYmxlLApAQCAtOTYsOCArMTAy LDYgQEAgcHJpdmF0ZToKICAgICB2b2lkIGRvd25ncmFkZShBdXRoZW50aWNhdG9yKiBpZCwgUmVm PEF1dGhlbnRpY2F0b3I+JiYgZG93bmdyYWRlZEF1dGhlbnRpY2F0b3IpIGZpbmFsOwogICAgIHZv aWQgYXV0aGVudGljYXRvclN0YXR1c1VwZGF0ZWQoV2ViQXV0aGVudGljYXRpb25TdGF0dXMpIGZp bmFsOwogICAgIHZvaWQgcmVxdWVzdFBpbih1aW50NjRfdCByZXRyaWVzLCBDb21wbGV0aW9uSGFu ZGxlcjx2b2lkKGNvbnN0IFdURjo6U3RyaW5nJik+JiYpIGZpbmFsOwotICAgIHZvaWQgc2VsZWN0 QXNzZXJ0aW9uUmVzcG9uc2UoVmVjdG9yPFJlZjxXZWJDb3JlOjpBdXRoZW50aWNhdG9yQXNzZXJ0 aW9uUmVzcG9uc2U+PiYmLCBXZWJBdXRoZW50aWNhdGlvblNvdXJjZSwgQ29tcGxldGlvbkhhbmRs ZXI8dm9pZChXZWJDb3JlOjpBdXRoZW50aWNhdG9yQXNzZXJ0aW9uUmVzcG9uc2UqKT4mJikgZmlu YWw7Ci0gICAgdm9pZCBkZWNpZGVQb2xpY3lGb3JMb2NhbEF1dGhlbnRpY2F0b3IoQ29tcGxldGlv bkhhbmRsZXI8dm9pZChMb2NhbEF1dGhlbnRpY2F0b3JQb2xpY3kpPiYmKSBmaW5hbDsKICAgICB2 b2lkIHJlcXVlc3RMQUNvbnRleHRGb3JVc2VyVmVyaWZpY2F0aW9uKENvbXBsZXRpb25IYW5kbGVy PHZvaWQoTEFDb250ZXh0ICopPiYmKSBmaW5hbDsKICAgICB2b2lkIGNhbmNlbFJlcXVlc3QoKSBm aW5hbDsKIApAQCAtMTA4LDEzICsxMTIsMTAgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQg ZmlsdGVyVHJhbnNwb3J0cyhUcmFuc3BvcnRTZXQmKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQg cnVuUHJlc2VudGVySW50ZXJuYWwoY29uc3QgVHJhbnNwb3J0U2V0Jik7CiAKLSAgICB2b2lkIHN0 YXJ0RGlzY292ZXJ5KGNvbnN0IFRyYW5zcG9ydFNldCYpOwogICAgIHZvaWQgaW5pdFRpbWVPdXRU aW1lcigpOwogICAgIHZvaWQgdGltZU91dFRpbWVyRmlyZWQoKTsKLSAgICB2b2lkIHJ1blBhbmVs KCk7CiAgICAgdm9pZCBydW5QcmVzZW50ZXIoKTsKICAgICB2b2lkIHJlc3RhcnREaXNjb3Zlcnko KTsKLSAgICBUcmFuc3BvcnRTZXQgZ2V0VHJhbnNwb3J0cygpIGNvbnN0OwogICAgIHZvaWQgZGlz cGF0Y2hQYW5lbENsaWVudENhbGwoRnVuY3Rpb248dm9pZChjb25zdCBBUEk6OldlYkF1dGhlbnRp Y2F0aW9uUGFuZWwmKT4mJikgY29uc3Q7CiAKICAgICAvLyBSZXF1ZXN0OiBXZSBvbmx5IGFsbG93 IG9uZSByZXF1ZXN0IHBlciB0aW1lLiBBIG5ldyByZXF1ZXN0IHdpbGwgY2FuY2VsIGFueSBwZW5k aW5nIG9uZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50 aWNhdGlvbi9WaXJ0dWFsL1ZpcnR1YWxBdXRoZW50aWNhdG9yTWFuYWdlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9WaXJ0dWFsL1ZpcnR1YWxBdXRoZW50 aWNhdG9yTWFuYWdlci5jcHAKaW5kZXggZDY2MTVhN2Q4OTU4NGIyMzM3NDEzODJjMDE5YjI5Mzlh ZDI4NGFmMy4uM2FmYjBjZTJmMzU2YzVmNTViODYzZWQwMjIyMDVmMjFmZGMxMDZlNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vVmlydHVhbC9W aXJ0dWFsQXV0aGVudGljYXRvck1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYkF1dGhlbnRpY2F0aW9uL1ZpcnR1YWwvVmlydHVhbEF1dGhlbnRpY2F0b3JNYW5hZ2Vy LmNwcApAQCAtNjMsNiArNjMsMjcgQEAgVW5pcXVlUmVmPEF1dGhlbnRpY2F0b3JUcmFuc3BvcnRT ZXJ2aWNlPiBWaXJ0dWFsQXV0aGVudGljYXRvck1hbmFnZXI6OmNyZWF0ZVNlcnYKICAgICByZXR1 cm4gVmlydHVhbFNlcnZpY2U6OmNyZWF0ZVZpcnR1YWwodHJhbnNwb3J0LCBvYnNlcnZlciwgY29u Zmlncyk7CiB9CiAKK3ZvaWQgVmlydHVhbEF1dGhlbnRpY2F0b3JNYW5hZ2VyOjpydW5QYW5lbCgp Cit7CisgICAgYXV0byB0cmFuc3BvcnRzID0gZ2V0VHJhbnNwb3J0cygpOworICAgIGlmICh0cmFu c3BvcnRzLmlzRW1wdHkoKSkgeworICAgICAgICBjYW5jZWwoKTsKKyAgICAgICAgcmV0dXJuOwor ICAgIH0KKworICAgIHN0YXJ0RGlzY292ZXJ5KHRyYW5zcG9ydHMpOworfQorCit2b2lkIFZpcnR1 YWxBdXRoZW50aWNhdG9yTWFuYWdlcjo6c2VsZWN0QXNzZXJ0aW9uUmVzcG9uc2UoVmVjdG9yPFJl ZjxXZWJDb3JlOjpBdXRoZW50aWNhdG9yQXNzZXJ0aW9uUmVzcG9uc2U+PiYmIHJlc3BvbnNlcywg V2ViQXV0aGVudGljYXRpb25Tb3VyY2Ugc291cmNlLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKFdl YkNvcmU6OkF1dGhlbnRpY2F0b3JBc3NlcnRpb25SZXNwb25zZSopPiYmIGNvbXBsZXRpb25IYW5k bGVyKQoreworICAgIGNvbXBsZXRpb25IYW5kbGVyKHJlc3BvbnNlc1swXS5wdHIoKSk7Cit9CisK K3ZvaWQgVmlydHVhbEF1dGhlbnRpY2F0b3JNYW5hZ2VyOjpkZWNpZGVQb2xpY3lGb3JMb2NhbEF1 dGhlbnRpY2F0b3IoQ29tcGxldGlvbkhhbmRsZXI8dm9pZChMb2NhbEF1dGhlbnRpY2F0b3JQb2xp Y3kpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQoreworICAgIGNvbXBsZXRpb25IYW5kbGVyKExvY2Fs QXV0aGVudGljYXRvclBvbGljeTo6QWxsb3cpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK IAogI2VuZGlmIC8vIEVOQUJMRShXRUJfQVVUSE4pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9WaXJ0dWFsL1ZpcnR1YWxBdXRoZW50aWNhdG9y TWFuYWdlci5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vVmly dHVhbC9WaXJ0dWFsQXV0aGVudGljYXRvck1hbmFnZXIuaAppbmRleCA2Mjk0NWRjMWY3YjZkNDgw NjExNWFkYjU0MjRmMzU5NTUxYzFiNmQyLi5mNWZjNWY5NWUyYzBiMzA3YzcyMzY2OWEwNWM2YjBh ZWFlMDBhOTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50 aWNhdGlvbi9WaXJ0dWFsL1ZpcnR1YWxBdXRoZW50aWNhdG9yTWFuYWdlci5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL1ZpcnR1YWwvVmlydHVhbEF1dGhl bnRpY2F0b3JNYW5hZ2VyLmgKQEAgLTQwLDYgKzQwLDkgQEAgcHVibGljOgogICAgIGJvb2wgcmVt b3ZlQXV0aGVudGljYXRvcihjb25zdCBTdHJpbmcmIC8qYXV0aGVudGljYXRvcklkKi8pOwogCiAg ICAgYm9vbCBpc1ZpcnR1YWwoKSBjb25zdCBmaW5hbCB7IHJldHVybiB0cnVlOyB9CisgICAgdm9p ZCBydW5QYW5lbCgpOworICAgIHZvaWQgc2VsZWN0QXNzZXJ0aW9uUmVzcG9uc2UoVmVjdG9yPFJl ZjxXZWJDb3JlOjpBdXRoZW50aWNhdG9yQXNzZXJ0aW9uUmVzcG9uc2U+PiYmLCBXZWJBdXRoZW50 aWNhdGlvblNvdXJjZSwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChXZWJDb3JlOjpBdXRoZW50aWNh dG9yQXNzZXJ0aW9uUmVzcG9uc2UqKT4mJik7CisgICAgdm9pZCBkZWNpZGVQb2xpY3lGb3JMb2Nh bEF1dGhlbnRpY2F0b3IoQ29tcGxldGlvbkhhbmRsZXI8dm9pZChMb2NhbEF1dGhlbnRpY2F0b3JQ b2xpY3kpPiYmKTsKIAogcHJpdmF0ZToKICAgICBVbmlxdWVSZWY8QXV0aGVudGljYXRvclRyYW5z cG9ydFNlcnZpY2U+IGNyZWF0ZVNlcnZpY2UoV2ViQ29yZTo6QXV0aGVudGljYXRvclRyYW5zcG9y dCwgQXV0aGVudGljYXRvclRyYW5zcG9ydFNlcnZpY2U6Ok9ic2VydmVyJikgY29uc3QgZmluYWw7 Cg==