237801 2022-03-11 16:56:54 -0800 AX: Move addChildren, addChild, insertChild, canHaveChildren, setNeedsToUpdateChildren, setNeedsToUpdateSubtree, clearChildren, and needsToUpdateChildren out of AXCoreObject interface 2022-03-14 10:36:02 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1850653 0 tyler_w 2022-03-11 16:56:54 -0800 All of these methods are ASSERT_NOT_REACHED no-ops for AXIsolatedObjects, so we should move these virtual methods to AccessibilityObject instead. 1850654 1 webkit-bug-importer 2022-03-11 16:57:07 -0800 <rdar://problem/90188014> 1850657 2 454524 tyler_w 2022-03-11 17:06:41 -0800 Created attachment 454524 Patch 1850866 3 andresg_22 2022-03-14 07:06:40 -0700 (In reply to Tyler Wilcock from comment #2) > Created attachment 454524 [details] > Patch --- a/Source/WebCore/accessibility/AccessibilityObject.h +++ a/Source/WebCore/accessibility/AccessibilityObject.h + enum class DescendIfIgnored : uint8_t { + No, + Yes + }; Can we make this a one-liner? I.e.: enum class DescendIfIgnored : uint8_t { No, Yes }; 1850874 4 454592 tyler_w 2022-03-14 08:27:01 -0700 Created attachment 454592 Patch 1850932 5 ews-feeder 2022-03-14 10:35:56 -0700 Committed r291237 (248392@main): <https://commits.webkit.org/248392@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454592. 454524 2022-03-11 17:06:41 -0800 2022-03-14 08:26:58 -0700 Patch bug-237801-20220311190640.patch text/plain 7369 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM3NjI3YTk1ZDkyNTBi ZTQzNzBkMTZkMTQ4NGQzMDBiMWRmYmI2Yy4uMzUyNmQ1MGYwZTljZTRkZDM1NWZhMjM1ZjVjZDli ZWE0MjNmOGI2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIyLTAzLTExICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE1vdmUgYWRkQ2hp bGRyZW4sIGFkZENoaWxkLCBpbnNlcnRDaGlsZCwgY2FuSGF2ZUNoaWxkcmVuLCBzZXROZWVkc1Rv VXBkYXRlQ2hpbGRyZW4sIHNldE5lZWRzVG9VcGRhdGVTdWJ0cmVlLCBjbGVhckNoaWxkcmVuLCBh bmQgbmVlZHNUb1VwZGF0ZUNoaWxkcmVuIG91dCBvZiBBWENvcmVPYmplY3QgaW50ZXJmYWNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc4MDEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwgb2YgdGhl c2UgdmlydHVhbCBtZXRob2RzIGFyZSBBU1NFUlRfTk9UX1JFQUNIRUQgbm8tb3BzIGZvciBBWElz b2xhdGVkT2JqZWN0cywKKyAgICAgICAgc28gdGhpcyBwYXRjaCBtb3ZlcyB0aGVtIHRvIEFjY2Vz c2liaWxpdHlPYmplY3QuaCBpbnN0ZWFkLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0 OjphZGRDaGlsZHJlbik6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0Ojpj YW5IYXZlQ2hpbGRyZW4gY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9i amVjdDo6c2V0TmVlZHNUb1VwZGF0ZUNoaWxkcmVuKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vz c2liaWxpdHlPYmplY3Q6OnNldE5lZWRzVG9VcGRhdGVTdWJ0cmVlKToKKyAgICAgICAgKFdlYkNv cmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6Om5lZWRzVG9VcGRhdGVDaGlsZHJlbiBjb25zdCk6Cisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0SW50ZXJmYWNlLmg6Cisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2JqZWN0OjphZGRDaGlsZHJlbik6IERlbGV0 ZWQuCisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2JqZWN0OjphZGRDaGlsZCk6IERlbGV0 ZWQuCisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2JqZWN0OjppbnNlcnRDaGlsZCk6IERl bGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2JqZWN0OjpjYW5IYXZlQ2hpbGRy ZW4gY29uc3QpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6 c2V0TmVlZHNUb1VwZGF0ZUNoaWxkcmVuKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkFY SXNvbGF0ZWRPYmplY3Q6OnNldE5lZWRzVG9VcGRhdGVTdWJ0cmVlKTogRGVsZXRlZC4KKyAgICAg ICAgKFdlYkNvcmU6OkFYSXNvbGF0ZWRPYmplY3Q6OmNsZWFyQ2hpbGRyZW4pOiBEZWxldGVkLgor ICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6bmVlZHNUb1VwZGF0ZUNoaWxkcmVu IGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9B WElzb2xhdGVkT2JqZWN0Lmg6CisKIDIwMjItMDMtMDMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgbmFzYS5nb3YgcGFnZSB3aXRoIGZpeGVkIGJhY2tn cm91bmRzIHBhaW50cyBpbmNvcnJlY3RseSBvbiBzY3JvbGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgKaW5kZXggYjlhOGI5YzA5N2Rh NGVlOGU4ZWU3OWM3MzBkOWYzZTA0NmU0ODJlYy4uNTgyYjI0ZWQ4Yzg5N2RjNTkzNmJkMzFmY2Rj MDNkNDA5ZjY4ODUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5T2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5T2JqZWN0LmgKQEAgLTUxMywxNiArNTEzLDE5IEBAIHB1YmxpYzoKIAogICAg IHZpcnR1YWwgdm9pZCB1cGRhdGVBY2Nlc3NpYmlsaXR5Um9sZSgpIHsgfQogICAgIGNvbnN0IEFj Y2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciYgY2hpbGRyZW4oYm9vbCB1cGRhdGVDaGlsZHJlbklm TmVlZGVkID0gdHJ1ZSkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBhZGRDaGlsZHJlbigpIG92ZXJyaWRl IHsgfQotICAgIHZvaWQgYWRkQ2hpbGQoQVhDb3JlT2JqZWN0KiwgRGVzY2VuZElmSWdub3JlZCA9 IERlc2NlbmRJZklnbm9yZWQ6Olllcykgb3ZlcnJpZGU7Ci0gICAgdm9pZCBpbnNlcnRDaGlsZChB WENvcmVPYmplY3QqLCB1bnNpZ25lZCwgRGVzY2VuZElmSWdub3JlZCA9IERlc2NlbmRJZklnbm9y ZWQ6Olllcykgb3ZlcnJpZGU7Ci0KLSAgICBib29sIGNhbkhhdmVDaGlsZHJlbigpIGNvbnN0IG92 ZXJyaWRlIHsgcmV0dXJuIHRydWU7IH0KKyAgICBlbnVtIGNsYXNzIERlc2NlbmRJZklnbm9yZWQg OiB1aW50OF90IHsKKyAgICAgICAgTm8sCisgICAgICAgIFllcworICAgIH07CisgICAgdmlydHVh bCB2b2lkIGFkZENoaWxkKEFYQ29yZU9iamVjdCosIERlc2NlbmRJZklnbm9yZWQgPSBEZXNjZW5k SWZJZ25vcmVkOjpZZXMpOworICAgIHZpcnR1YWwgdm9pZCBhZGRDaGlsZHJlbigpIHsgfQorICAg IHZpcnR1YWwgdm9pZCBpbnNlcnRDaGlsZChBWENvcmVPYmplY3QqLCB1bnNpZ25lZCwgRGVzY2Vu ZElmSWdub3JlZCA9IERlc2NlbmRJZklnbm9yZWQ6Olllcyk7CisgICAgdmlydHVhbCBib29sIGNh bkhhdmVDaGlsZHJlbigpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KICAgICB2b2lkIHVwZGF0ZUNo aWxkcmVuSWZOZWNlc3NhcnkoKSBvdmVycmlkZTsKLSAgICB2b2lkIHNldE5lZWRzVG9VcGRhdGVD aGlsZHJlbigpIG92ZXJyaWRlIHsgfQotICAgIHZvaWQgc2V0TmVlZHNUb1VwZGF0ZVN1YnRyZWUo KSBvdmVycmlkZSB7IH0KLSAgICB2b2lkIGNsZWFyQ2hpbGRyZW4oKSBvdmVycmlkZTsKLSAgICBi b29sIG5lZWRzVG9VcGRhdGVDaGlsZHJlbigpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIGZhbHNl OyB9CisgICAgdmlydHVhbCB2b2lkIHNldE5lZWRzVG9VcGRhdGVDaGlsZHJlbigpIHsgfQorICAg IHZpcnR1YWwgdm9pZCBzZXROZWVkc1RvVXBkYXRlU3VidHJlZSgpIHsgfQorICAgIHZpcnR1YWwg dm9pZCBjbGVhckNoaWxkcmVuKCk7CisgICAgdmlydHVhbCBib29sIG5lZWRzVG9VcGRhdGVDaGls ZHJlbigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAjaWYgUExBVEZPUk0oQ09DT0EpCiAgICAg dm9pZCBkZXRhY2hGcm9tUGFyZW50KCkgb3ZlcnJpZGU7CiAjZWxzZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0SW50ZXJmYWNlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3RJbnRlcmZh Y2UuaAppbmRleCAyMDRiMmI5MWEyNTJiMDA2MjU2ZjhjNjIxNjcyZGUxZWZjNDM4YzFiLi4wZDBl NjA3MzJkN2ZjNTdkNDNhYjgwYzU1ZmZhOTNjYmNjNDM2MGI5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3RJbnRlcmZhY2UuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3RJbnRlcmZh Y2UuaApAQCAtMTI2NiwyMiArMTI2Niw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGVj cmVtZW50KCkgPSAwOwogCiAgICAgdmlydHVhbCBjb25zdCBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5W ZWN0b3ImIGNoaWxkcmVuKGJvb2wgdXBkYXRlQ2hpbGRyZW5JZk5lZWRlZCA9IHRydWUpID0gMDsK LQotICAgIGVudW0gY2xhc3MgRGVzY2VuZElmSWdub3JlZCA6IHVpbnQ4X3QgewotICAgICAgICBO bywKLSAgICAgICAgWWVzCi0gICAgfTsKLSAgICB2aXJ0dWFsIHZvaWQgYWRkQ2hpbGRyZW4oKSA9 IDA7Ci0gICAgdmlydHVhbCB2b2lkIGFkZENoaWxkKEFYQ29yZU9iamVjdCosIERlc2NlbmRJZkln bm9yZWQgPSBEZXNjZW5kSWZJZ25vcmVkOjpZZXMpID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQgaW5z ZXJ0Q2hpbGQoQVhDb3JlT2JqZWN0KiwgdW5zaWduZWQsIERlc2NlbmRJZklnbm9yZWQgPSBEZXNj ZW5kSWZJZ25vcmVkOjpZZXMpID0gMDsKICAgICBWZWN0b3I8QVhJRD4gY2hpbGRyZW5JRHMoYm9v bCB1cGRhdGVDaGlsZHJlbklmTmVjZXNzYXJ5ID0gdHJ1ZSk7Ci0KLSAgICB2aXJ0dWFsIGJvb2wg Y2FuSGF2ZUNoaWxkcmVuKCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVDaGls ZHJlbklmTmVjZXNzYXJ5KCkgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBzZXROZWVkc1RvVXBkYXRl Q2hpbGRyZW4oKSA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIHNldE5lZWRzVG9VcGRhdGVTdWJ0cmVl KCkgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBjbGVhckNoaWxkcmVuKCkgPSAwOwotICAgIHZpcnR1 YWwgYm9vbCBuZWVkc1RvVXBkYXRlQ2hpbGRyZW4oKSBjb25zdCA9IDA7CiAgICAgdmlydHVhbCB2 b2lkIGRldGFjaEZyb21QYXJlbnQoKSA9IDA7CiAgICAgdmlydHVhbCBib29sIGlzRGV0YWNoZWRG cm9tUGFyZW50KCkgPSAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuY3BwCmluZGV4IGI3MzYw MzU2YTIxZTgyMDExMWQ1N2IxZGIwODQxYjY3NzBiN2I1NWEuLjc0YjViZDk2MTc0ZGVjNTQ3MzIy MDk5MTRjMGE4NDEyMjJjMDY1NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuY3BwCkBAIC0y MjE5LDQ4ICsyMjE5LDYgQEAgU2Nyb2xsVmlldyogQVhJc29sYXRlZE9iamVjdDo6c2Nyb2xsVmll d0FuY2VzdG9yKCkgY29uc3QKICAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAotdm9pZCBBWElzb2xh dGVkT2JqZWN0OjphZGRDaGlsZHJlbigpCi17Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci19 Ci0KLXZvaWQgQVhJc29sYXRlZE9iamVjdDo6YWRkQ2hpbGQoQVhDb3JlT2JqZWN0KiwgRGVzY2Vu ZElmSWdub3JlZCkKLXsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLX0KLQotdm9pZCBBWElz b2xhdGVkT2JqZWN0OjppbnNlcnRDaGlsZChBWENvcmVPYmplY3QqLCB1bnNpZ25lZCwgRGVzY2Vu ZElmSWdub3JlZCkKLXsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLX0KLQotYm9vbCBBWElz b2xhdGVkT2JqZWN0OjpjYW5IYXZlQ2hpbGRyZW4oKSBjb25zdAotewotICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOwotICAgIHJldHVybiBmYWxzZTsKLX0KLQotdm9pZCBBWElzb2xhdGVkT2JqZWN0 OjpzZXROZWVkc1RvVXBkYXRlQ2hpbGRyZW4oKQotewotICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwotfQotCi12b2lkIEFYSXNvbGF0ZWRPYmplY3Q6OnNldE5lZWRzVG9VcGRhdGVTdWJ0cmVlKCkK LXsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLX0KLQotdm9pZCBBWElzb2xhdGVkT2JqZWN0 OjpjbGVhckNoaWxkcmVuKCkKLXsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLX0KLQotYm9v bCBBWElzb2xhdGVkT2JqZWN0OjpuZWVkc1RvVXBkYXRlQ2hpbGRyZW4oKSBjb25zdAotewotICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgIHJldHVybiBmYWxzZTsKLX0KLQogYm9vbCBBWElz b2xhdGVkT2JqZWN0OjpzaG91bGRGb2N1c0FjdGl2ZURlc2NlbmRhbnQoKSBjb25zdAogewogICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oCmluZGV4IDBlNDFh OTAwOTM5NTA4Y2JiZGRjMzU1MTkyMzFiZTQwZTU3ZmQ1YmYuLmRlYjZkY2FlMWNlN2JiYjgxODRk ZmExNDZjNDJhZjIyOTQ5M2Y2MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmgKQEAgLTYxMiwx NCArNjEyLDYgQEAgcHJpdmF0ZToKICAgICBEb2N1bWVudCogdG9wRG9jdW1lbnQoKSBjb25zdCBv dmVycmlkZTsKICAgICBTY3JvbGxWaWV3KiBzY3JvbGxWaWV3KCkgY29uc3Qgb3ZlcnJpZGU7CiAg ICAgU2Nyb2xsVmlldyogc2Nyb2xsVmlld0FuY2VzdG9yKCkgY29uc3Qgb3ZlcnJpZGU7Ci0gICAg dm9pZCBhZGRDaGlsZHJlbigpIG92ZXJyaWRlOwotICAgIHZvaWQgYWRkQ2hpbGQoQVhDb3JlT2Jq ZWN0KiwgRGVzY2VuZElmSWdub3JlZCA9IERlc2NlbmRJZklnbm9yZWQ6Olllcykgb3ZlcnJpZGU7 Ci0gICAgdm9pZCBpbnNlcnRDaGlsZChBWENvcmVPYmplY3QqLCB1bnNpZ25lZCwgRGVzY2VuZElm SWdub3JlZCA9IERlc2NlbmRJZklnbm9yZWQ6Olllcykgb3ZlcnJpZGU7Ci0gICAgYm9vbCBjYW5I YXZlQ2hpbGRyZW4oKSBjb25zdCBvdmVycmlkZTsKLSAgICB2b2lkIHNldE5lZWRzVG9VcGRhdGVD aGlsZHJlbigpIG92ZXJyaWRlOwotICAgIHZvaWQgc2V0TmVlZHNUb1VwZGF0ZVN1YnRyZWUoKSBv dmVycmlkZTsKLSAgICB2b2lkIGNsZWFyQ2hpbGRyZW4oKSBvdmVycmlkZTsKLSAgICBib29sIG5l ZWRzVG9VcGRhdGVDaGlsZHJlbigpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZvaWQgZGV0YWNoRnJv bVBhcmVudCgpIG92ZXJyaWRlOwogICAgIGJvb2wgc2hvdWxkRm9jdXNBY3RpdmVEZXNjZW5kYW50 KCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgQVhDb3JlT2JqZWN0KiBhY3RpdmVEZXNjZW5kYW50KCkg Y29uc3Qgb3ZlcnJpZGU7Cg== 454592 2022-03-14 08:27:01 -0700 2022-03-14 10:36:00 -0700 Patch bug-237801-20220314102700.patch text/plain 7347 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwNzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM3NjI3YTk1ZDkyNTBi ZTQzNzBkMTZkMTQ4NGQzMDBiMWRmYmI2Yy4uNGJjNTA2NWI2ODNlYTVmMTViZGI4ZGRhZDMzZDRk ZDMxZDkyMDZlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIyLTAzLTExICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE1vdmUgYWRkQ2hp bGRyZW4sIGFkZENoaWxkLCBpbnNlcnRDaGlsZCwgY2FuSGF2ZUNoaWxkcmVuLCBzZXROZWVkc1Rv VXBkYXRlQ2hpbGRyZW4sIHNldE5lZWRzVG9VcGRhdGVTdWJ0cmVlLCBjbGVhckNoaWxkcmVuLCBh bmQgbmVlZHNUb1VwZGF0ZUNoaWxkcmVuIG91dCBvZiBBWENvcmVPYmplY3QgaW50ZXJmYWNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc4MDEKKwor ICAgICAgICBSZXZpZXdlZCBieSBBbmRyZXMgR29uemFsZXouCisKKyAgICAgICAgQWxsIG9mIHRo ZXNlIHZpcnR1YWwgbWV0aG9kcyBhcmUgQVNTRVJUX05PVF9SRUFDSEVEIG5vLW9wcyBmb3IgQVhJ c29sYXRlZE9iamVjdHMsCisgICAgICAgIHNvIHRoaXMgcGF0Y2ggbW92ZXMgdGhlbSB0byBBY2Nl c3NpYmlsaXR5T2JqZWN0LmggaW5zdGVhZC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eU9iamVjdC5oOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVj dDo6YWRkQ2hpbGRyZW4pOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdDo6 Y2FuSGF2ZUNoaWxkcmVuIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlP YmplY3Q6OnNldE5lZWRzVG9VcGRhdGVDaGlsZHJlbik6CisgICAgICAgIChXZWJDb3JlOjpBY2Nl c3NpYmlsaXR5T2JqZWN0OjpzZXROZWVkc1RvVXBkYXRlU3VidHJlZSk6CisgICAgICAgIChXZWJD b3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0OjpuZWVkc1RvVXBkYXRlQ2hpbGRyZW4gY29uc3QpOgor ICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdEludGVyZmFjZS5oOgor ICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6YWRkQ2hpbGRyZW4pOiBEZWxl dGVkLgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6YWRkQ2hpbGQpOiBEZWxl dGVkLgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6aW5zZXJ0Q2hpbGQpOiBE ZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6Y2FuSGF2ZUNoaWxk cmVuIGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkFYSXNvbGF0ZWRPYmplY3Q6 OnNldE5lZWRzVG9VcGRhdGVDaGlsZHJlbik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpB WElzb2xhdGVkT2JqZWN0OjpzZXROZWVkc1RvVXBkYXRlU3VidHJlZSk6IERlbGV0ZWQuCisgICAg ICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2JqZWN0OjpjbGVhckNoaWxkcmVuKTogRGVsZXRlZC4K KyAgICAgICAgKFdlYkNvcmU6OkFYSXNvbGF0ZWRPYmplY3Q6Om5lZWRzVG9VcGRhdGVDaGlsZHJl biBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUv QVhJc29sYXRlZE9iamVjdC5oOgorCiAyMDIyLTAzLTAzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIG5hc2EuZ292IHBhZ2Ugd2l0aCBmaXhlZCBiYWNr Z3JvdW5kcyBwYWludHMgaW5jb3JyZWN0bHkgb24gc2Nyb2xsCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaCBiL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCmluZGV4IGI5YThiOWMwOTdk YTRlZThlOGVlNzljNzMwZDlmM2UwNDZlNDgyZWMuLjA3MGMyMjBlMjJiMWM2NWY5MzY4ZTBlNzE0 ZjJjYjVjOWEzODBjNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU9iamVjdC5oCkBAIC01MTMsMTYgKzUxMywxNiBAQCBwdWJsaWM6CiAKICAg ICB2aXJ0dWFsIHZvaWQgdXBkYXRlQWNjZXNzaWJpbGl0eVJvbGUoKSB7IH0KICAgICBjb25zdCBB Y2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIGNoaWxkcmVuKGJvb2wgdXBkYXRlQ2hpbGRyZW5J Zk5lZWRlZCA9IHRydWUpIG92ZXJyaWRlOwotICAgIHZvaWQgYWRkQ2hpbGRyZW4oKSBvdmVycmlk ZSB7IH0KLSAgICB2b2lkIGFkZENoaWxkKEFYQ29yZU9iamVjdCosIERlc2NlbmRJZklnbm9yZWQg PSBEZXNjZW5kSWZJZ25vcmVkOjpZZXMpIG92ZXJyaWRlOwotICAgIHZvaWQgaW5zZXJ0Q2hpbGQo QVhDb3JlT2JqZWN0KiwgdW5zaWduZWQsIERlc2NlbmRJZklnbm9yZWQgPSBEZXNjZW5kSWZJZ25v cmVkOjpZZXMpIG92ZXJyaWRlOwotCi0gICAgYm9vbCBjYW5IYXZlQ2hpbGRyZW4oKSBjb25zdCBv dmVycmlkZSB7IHJldHVybiB0cnVlOyB9CisgICAgdmlydHVhbCB2b2lkIGFkZENoaWxkcmVuKCkg eyB9CisgICAgZW51bSBjbGFzcyBEZXNjZW5kSWZJZ25vcmVkIDogdWludDhfdCB7IE5vLCBZZXMg fTsKKyAgICB2aXJ0dWFsIHZvaWQgYWRkQ2hpbGQoQVhDb3JlT2JqZWN0KiwgRGVzY2VuZElmSWdu b3JlZCA9IERlc2NlbmRJZklnbm9yZWQ6Olllcyk7CisgICAgdmlydHVhbCB2b2lkIGluc2VydENo aWxkKEFYQ29yZU9iamVjdCosIHVuc2lnbmVkLCBEZXNjZW5kSWZJZ25vcmVkID0gRGVzY2VuZElm SWdub3JlZDo6WWVzKTsKKyAgICB2aXJ0dWFsIGJvb2wgY2FuSGF2ZUNoaWxkcmVuKCkgY29uc3Qg eyByZXR1cm4gdHJ1ZTsgfQogICAgIHZvaWQgdXBkYXRlQ2hpbGRyZW5JZk5lY2Vzc2FyeSgpIG92 ZXJyaWRlOwotICAgIHZvaWQgc2V0TmVlZHNUb1VwZGF0ZUNoaWxkcmVuKCkgb3ZlcnJpZGUgeyB9 Ci0gICAgdm9pZCBzZXROZWVkc1RvVXBkYXRlU3VidHJlZSgpIG92ZXJyaWRlIHsgfQotICAgIHZv aWQgY2xlYXJDaGlsZHJlbigpIG92ZXJyaWRlOwotICAgIGJvb2wgbmVlZHNUb1VwZGF0ZUNoaWxk cmVuKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gZmFsc2U7IH0KKyAgICB2aXJ0dWFsIHZvaWQg c2V0TmVlZHNUb1VwZGF0ZUNoaWxkcmVuKCkgeyB9CisgICAgdmlydHVhbCB2b2lkIHNldE5lZWRz VG9VcGRhdGVTdWJ0cmVlKCkgeyB9CisgICAgdmlydHVhbCB2b2lkIGNsZWFyQ2hpbGRyZW4oKTsK KyAgICB2aXJ0dWFsIGJvb2wgbmVlZHNUb1VwZGF0ZUNoaWxkcmVuKCkgY29uc3QgeyByZXR1cm4g ZmFsc2U7IH0KICNpZiBQTEFURk9STShDT0NPQSkKICAgICB2b2lkIGRldGFjaEZyb21QYXJlbnQo KSBvdmVycmlkZTsKICNlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlPYmplY3RJbnRlcmZhY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdEludGVyZmFjZS5oCmluZGV4IDIwNGIyYjkxYTI1 MmIwMDYyNTZmOGM2MjE2NzJkZTFlZmM0MzhjMWIuLjBkMGU2MDczMmQ3ZmM1N2Q0M2FiODBjNTVm ZmE5M2NiY2M0MzYwYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU9iamVjdEludGVyZmFjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdEludGVyZmFjZS5oCkBAIC0xMjY2LDIyICsxMjY2 LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkZWNyZW1lbnQoKSA9IDA7CiAKICAgICB2 aXJ0dWFsIGNvbnN0IEFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciYgY2hpbGRyZW4oYm9vbCB1 cGRhdGVDaGlsZHJlbklmTmVlZGVkID0gdHJ1ZSkgPSAwOwotCi0gICAgZW51bSBjbGFzcyBEZXNj ZW5kSWZJZ25vcmVkIDogdWludDhfdCB7Ci0gICAgICAgIE5vLAotICAgICAgICBZZXMKLSAgICB9 OwotICAgIHZpcnR1YWwgdm9pZCBhZGRDaGlsZHJlbigpID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQg YWRkQ2hpbGQoQVhDb3JlT2JqZWN0KiwgRGVzY2VuZElmSWdub3JlZCA9IERlc2NlbmRJZklnbm9y ZWQ6OlllcykgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBpbnNlcnRDaGlsZChBWENvcmVPYmplY3Qq LCB1bnNpZ25lZCwgRGVzY2VuZElmSWdub3JlZCA9IERlc2NlbmRJZklnbm9yZWQ6OlllcykgPSAw OwogICAgIFZlY3RvcjxBWElEPiBjaGlsZHJlbklEcyhib29sIHVwZGF0ZUNoaWxkcmVuSWZOZWNl c3NhcnkgPSB0cnVlKTsKLQotICAgIHZpcnR1YWwgYm9vbCBjYW5IYXZlQ2hpbGRyZW4oKSBjb25z dCA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUNoaWxkcmVuSWZOZWNlc3NhcnkoKSA9IDA7 Ci0gICAgdmlydHVhbCB2b2lkIHNldE5lZWRzVG9VcGRhdGVDaGlsZHJlbigpID0gMDsKLSAgICB2 aXJ0dWFsIHZvaWQgc2V0TmVlZHNUb1VwZGF0ZVN1YnRyZWUoKSA9IDA7Ci0gICAgdmlydHVhbCB2 b2lkIGNsZWFyQ2hpbGRyZW4oKSA9IDA7Ci0gICAgdmlydHVhbCBib29sIG5lZWRzVG9VcGRhdGVD aGlsZHJlbigpIGNvbnN0ID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoRnJvbVBhcmVudCgp ID0gMDsKICAgICB2aXJ0dWFsIGJvb2wgaXNEZXRhY2hlZEZyb21QYXJlbnQoKSA9IDA7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNv bGF0ZWRPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRy ZWUvQVhJc29sYXRlZE9iamVjdC5jcHAKaW5kZXggYjczNjAzNTZhMjFlODIwMTExZDU3YjFkYjA4 NDFiNjc3MGI3YjU1YS4uNzRiNWJkOTYxNzRkZWM1NDczMjIwOTkxNGMwYTg0MTIyMmMwNjU2ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJ c29sYXRlZE9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29s YXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAKQEAgLTIyMTksNDggKzIyMTksNiBAQCBTY3Jv bGxWaWV3KiBBWElzb2xhdGVkT2JqZWN0OjpzY3JvbGxWaWV3QW5jZXN0b3IoKSBjb25zdAogICAg IHJldHVybiBudWxscHRyOwogfQogCi12b2lkIEFYSXNvbGF0ZWRPYmplY3Q6OmFkZENoaWxkcmVu KCkKLXsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLX0KLQotdm9pZCBBWElzb2xhdGVkT2Jq ZWN0OjphZGRDaGlsZChBWENvcmVPYmplY3QqLCBEZXNjZW5kSWZJZ25vcmVkKQotewotICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOwotfQotCi12b2lkIEFYSXNvbGF0ZWRPYmplY3Q6Omluc2VydENo aWxkKEFYQ29yZU9iamVjdCosIHVuc2lnbmVkLCBEZXNjZW5kSWZJZ25vcmVkKQotewotICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOwotfQotCi1ib29sIEFYSXNvbGF0ZWRPYmplY3Q6OmNhbkhhdmVD aGlsZHJlbigpIGNvbnN0Ci17Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJu IGZhbHNlOwotfQotCi12b2lkIEFYSXNvbGF0ZWRPYmplY3Q6OnNldE5lZWRzVG9VcGRhdGVDaGls ZHJlbigpCi17Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci19Ci0KLXZvaWQgQVhJc29sYXRl ZE9iamVjdDo6c2V0TmVlZHNUb1VwZGF0ZVN1YnRyZWUoKQotewotICAgIEFTU0VSVF9OT1RfUkVB Q0hFRCgpOwotfQotCi12b2lkIEFYSXNvbGF0ZWRPYmplY3Q6OmNsZWFyQ2hpbGRyZW4oKQotewot ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotfQotCi1ib29sIEFYSXNvbGF0ZWRPYmplY3Q6Om5l ZWRzVG9VcGRhdGVDaGlsZHJlbigpIGNvbnN0Ci17Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 Ci0gICAgcmV0dXJuIGZhbHNlOwotfQotCiBib29sIEFYSXNvbGF0ZWRPYmplY3Q6OnNob3VsZEZv Y3VzQWN0aXZlRGVzY2VuZGFudCgpIGNvbnN0CiB7CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9B WElzb2xhdGVkT2JqZWN0LmggYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVk dHJlZS9BWElzb2xhdGVkT2JqZWN0LmgKaW5kZXggMGU0MWE5MDA5Mzk1MDhjYmJkZGMzNTUxOTIz MWJlNDBlNTdmZDViZi4uZGViNmRjYWUxY2U3YmJiODE4NGRmYTE0NmM0MmFmMjI5NDkzZjYwMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJ c29sYXRlZE9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0 ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaApAQCAtNjEyLDE0ICs2MTIsNiBAQCBwcml2YXRlOgog ICAgIERvY3VtZW50KiB0b3BEb2N1bWVudCgpIGNvbnN0IG92ZXJyaWRlOwogICAgIFNjcm9sbFZp ZXcqIHNjcm9sbFZpZXcoKSBjb25zdCBvdmVycmlkZTsKICAgICBTY3JvbGxWaWV3KiBzY3JvbGxW aWV3QW5jZXN0b3IoKSBjb25zdCBvdmVycmlkZTsKLSAgICB2b2lkIGFkZENoaWxkcmVuKCkgb3Zl cnJpZGU7Ci0gICAgdm9pZCBhZGRDaGlsZChBWENvcmVPYmplY3QqLCBEZXNjZW5kSWZJZ25vcmVk ID0gRGVzY2VuZElmSWdub3JlZDo6WWVzKSBvdmVycmlkZTsKLSAgICB2b2lkIGluc2VydENoaWxk KEFYQ29yZU9iamVjdCosIHVuc2lnbmVkLCBEZXNjZW5kSWZJZ25vcmVkID0gRGVzY2VuZElmSWdu b3JlZDo6WWVzKSBvdmVycmlkZTsKLSAgICBib29sIGNhbkhhdmVDaGlsZHJlbigpIGNvbnN0IG92 ZXJyaWRlOwotICAgIHZvaWQgc2V0TmVlZHNUb1VwZGF0ZUNoaWxkcmVuKCkgb3ZlcnJpZGU7Ci0g ICAgdm9pZCBzZXROZWVkc1RvVXBkYXRlU3VidHJlZSgpIG92ZXJyaWRlOwotICAgIHZvaWQgY2xl YXJDaGlsZHJlbigpIG92ZXJyaWRlOwotICAgIGJvb2wgbmVlZHNUb1VwZGF0ZUNoaWxkcmVuKCkg Y29uc3Qgb3ZlcnJpZGU7CiAgICAgdm9pZCBkZXRhY2hGcm9tUGFyZW50KCkgb3ZlcnJpZGU7CiAg ICAgYm9vbCBzaG91bGRGb2N1c0FjdGl2ZURlc2NlbmRhbnQoKSBjb25zdCBvdmVycmlkZTsKICAg ICBBWENvcmVPYmplY3QqIGFjdGl2ZURlc2NlbmRhbnQoKSBjb25zdCBvdmVycmlkZTsK