237788 2022-03-11 10:49:47 -0800 [IFC][Integration] previousLinePosition/nextLinePosition should use Line::lineBoxHeight 2022-03-12 11:12:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1850568 0 zalan 2022-03-11 10:49:47 -0800 to check for empty lines 1850570 1 454498 zalan 2022-03-11 10:55:06 -0800 Created attachment 454498 Patch 1850697 2 ews-feeder 2022-03-12 11:11:27 -0800 Committed r291208 (248363@main): <https://commits.webkit.org/248363@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454498. 1850698 3 webkit-bug-importer 2022-03-12 11:12:18 -0800 <rdar://problem/90204421> 454498 2022-03-11 10:55:06 -0800 2022-03-12 11:11:28 -0800 Patch bug-237788-20220311105505.patch text/plain 5707 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFkMGU1ZGQ0MTBlODZm YzYxOTE5ZWI2ZTIwY2JlN2MzNTMyOTE4MS4uZmNlZDYwMWU1NmY4YjViYjY0M2RlN2U2M2M2ZWMy NTIzYWM1OTZiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIyLTAzLTExICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbSUZDXVtJbnRlZ3JhdGlvbl0g cHJldmlvdXNMaW5lUG9zaXRpb24vbmV4dExpbmVQb3NpdGlvbiBzaG91bGQgdXNlIExpbmU6Omxp bmVCb3hIZWlnaHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzNzc4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIExpbmU6OmxpbmVCb3hIZWlnaHQoKSBzaG91bGQgYmUgc3VmZmljaWVudCBmb3IgY2hlY2tp bmcgaWYgdGhlIGxpbmUgaXMgZW1wdHkgZm9yIFZpc3VhbFBvc2l0aW9uLgorCisgICAgICAgICog ZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJldmlvdXNMaW5l UG9zaXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6bmV4dExpbmVQb3NpdGlvbik6CisgICAgICAg ICogbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0ZXJhdG9yTGluZS5oOgorICAgICAgICAoV2Vi Q29yZTo6SW5saW5lSXRlcmF0b3I6OkxpbmU6OmxpbmVCb3hIZWlnaHQgY29uc3QpOgorICAgICAg ICAoV2ViQ29yZTo6SW5saW5lSXRlcmF0b3I6OkxpbmU6OmxvZ2ljYWxIZWlnaHQgY29uc3QpOiBE ZWxldGVkLgorICAgICAgICAqIGxheW91dC9pbnRlZ3JhdGlvbi9JbmxpbmVJdGVyYXRvckxpbmVM ZWdhY3lQYXRoLmg6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVJdGVyYXRvcjo6TGluZUl0ZXJh dG9yTGVnYWN5UGF0aDo6Y29udGVudExvZ2ljYWxSaWdodCBjb25zdCk6CisgICAgICAgIChXZWJD b3JlOjpJbmxpbmVJdGVyYXRvcjo6TGluZUl0ZXJhdG9yTGVnYWN5UGF0aDo6bG9naWNhbEhlaWdo dCBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgICogbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0 ZXJhdG9yTGluZU1vZGVyblBhdGguaDoKKyAgICAgICAgKFdlYkNvcmU6OklubGluZUl0ZXJhdG9y OjpMaW5lSXRlcmF0b3JNb2Rlcm5QYXRoOjpjb250ZW50TG9naWNhbFJpZ2h0IGNvbnN0KToKKyAg ICAgICAgKFdlYkNvcmU6OklubGluZUl0ZXJhdG9yOjpMaW5lSXRlcmF0b3JNb2Rlcm5QYXRoOjps b2dpY2FsSGVpZ2h0IGNvbnN0KTogRGVsZXRlZC4KKwogMjAyMi0wMy0xMSAgQWxhbiBCdWp0YXMg IDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0lGQ11bSW50ZWdyYXRpb25dIFJlbmRlckJs b2NrRmxvdzo6ZmluZENsb3Nlc3RUZXh0QXRBYnNvbHV0ZVBvaW50IHNob3VsZCB1c2Ugcm9vdCBp bmxpbmUgYm94IGl0ZXJhdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zp c2libGVVbml0cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVVbml0cy5jcHAK aW5kZXggMjRlMjg3MDQyYTAxODhiZDgxNWM5ZjE0NjhiMGQ2NDg1M2FhYWU0Yi4uZmI4NjlkMTc5 MTM3NzMwOTdhMzA0Nzg4Njc5YzlhY2E4ODk0NGRhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv VmlzaWJsZVVuaXRzLmNwcApAQCAtOTczLDcgKzk3Myw3IEBAIFZpc2libGVQb3NpdGlvbiBwcmV2 aW91c0xpbmVQb3NpdGlvbihjb25zdCBWaXNpYmxlUG9zaXRpb24mIHZpc2libGVQb3NpdGlvbiwg aW50CiAgICAgICAgIGxpbmUgPSBydW4tPmxpbmUoKS0+cHJldmlvdXMoKTsKICAgICAgICAgLy8g V2Ugd2FudCB0byBza2lwIHplcm8gaGVpZ2h0IGJveGVzLgogICAgICAgICAvLyBUaGlzIGNvdWxk IGhhcHBlbiBpbiBjYXNlIGl0IGlzIGEgTGVnYWN5Um9vdElubGluZUJveCB3aXRoIHRyYWlsaW5n IGZsb2F0cy4KLSAgICAgICAgaWYgKCFsaW5lIHx8ICFsaW5lLT5sb2dpY2FsSGVpZ2h0KCkgfHwg IWxpbmUtPmZpcnN0TGVhZkJveCgpKQorICAgICAgICBpZiAoIWxpbmUgfHwgIWxpbmUtPmxpbmVC b3hIZWlnaHQoKSB8fCAhbGluZS0+Zmlyc3RMZWFmQm94KCkpCiAgICAgICAgICAgICBsaW5lID0g eyB9OwogICAgIH0KIApAQCAtMTAyNiw3ICsxMDI2LDcgQEAgVmlzaWJsZVBvc2l0aW9uIG5leHRM aW5lUG9zaXRpb24oY29uc3QgVmlzaWJsZVBvc2l0aW9uJiB2aXNpYmxlUG9zaXRpb24sIGludCBs aW4KICAgICAgICAgbGluZSA9IHJ1bi0+bGluZSgpLT5uZXh0KCk7CiAgICAgICAgIC8vIFdlIHdh bnQgdG8gc2tpcCB6ZXJvIGhlaWdodCBib3hlcy4KICAgICAgICAgLy8gVGhpcyBjb3VsZCBoYXBw ZW4gaW4gY2FzZSBpdCBpcyBhIExlZ2FjeVJvb3RJbmxpbmVCb3ggd2l0aCB0cmFpbGluZyBmbG9h dHMuCi0gICAgICAgIGlmICghbGluZSB8fCAhbGluZS0+bG9naWNhbEhlaWdodCgpIHx8ICFsaW5l LT5maXJzdExlYWZCb3goKSkKKyAgICAgICAgaWYgKCFsaW5lIHx8ICFsaW5lLT5saW5lQm94SGVp Z2h0KCkgfHwgIWxpbmUtPmZpcnN0TGVhZkJveCgpKQogICAgICAgICAgICAgbGluZSA9IHsgfTsK ICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9J bmxpbmVJdGVyYXRvckxpbmUuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9J bmxpbmVJdGVyYXRvckxpbmUuaAppbmRleCA3MGEwYjgwMWNlODY3NjYzYTA2OTBlMjY1ODg5OGE4 ZWExNzI2Y2Y2Li41MWNjODk2YjZlMmQwOGU3MjNkNjA3MmUxZmUyOWI3NDkwNjcyMjQ4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vSW5saW5lSXRlcmF0b3JM aW5lLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0ZXJh dG9yTGluZS5oCkBAIC02MCw2ICs2MCw3IEBAIHB1YmxpYzoKICAgICBMYXlvdXRVbml0IHNlbGVj dGlvbkhlaWdodEFkanVzdGVkRm9yUHJlY2VkaW5nQmxvY2soKSBjb25zdDsKICAgICBMYXlvdXRV bml0IGxpbmVCb3hUb3AoKSBjb25zdDsKICAgICBMYXlvdXRVbml0IGxpbmVCb3hCb3R0b20oKSBj b25zdDsKKyAgICBMYXlvdXRVbml0IGxpbmVCb3hIZWlnaHQoKSBjb25zdCB7IHJldHVybiBsaW5l Qm94Qm90dG9tKCkgLSBsaW5lQm94VG9wKCk7IH0KIAogICAgIExheW91dFJlY3Qgc2VsZWN0aW9u UmVjdCgpIGNvbnN0OwogICAgIFJlbmRlck9iamVjdDo6SGlnaGxpZ2h0U3RhdGUgc2VsZWN0aW9u U3RhdGUoKSBjb25zdDsKQEAgLTY3LDcgKzY4LDYgQEAgcHVibGljOgogICAgIGZsb2F0IGNvbnRl bnRMb2dpY2FsTGVmdCgpIGNvbnN0OwogICAgIGZsb2F0IGNvbnRlbnRMb2dpY2FsUmlnaHQoKSBj b25zdDsKICAgICBmbG9hdCBjb250ZW50TG9naWNhbFdpZHRoKCkgY29uc3Q7Ci0gICAgZmxvYXQg bG9naWNhbEhlaWdodCgpIGNvbnN0OwogCiAgICAgaW50IGJsb2NrRGlyZWN0aW9uUG9pbnRJbkxp bmUoKSBjb25zdDsKIApAQCAtMjE0LDEzICsyMTQsNiBAQCBpbmxpbmUgZmxvYXQgTGluZTo6Y29u dGVudExvZ2ljYWxXaWR0aCgpIGNvbnN0CiAgICAgcmV0dXJuIGNvbnRlbnRMb2dpY2FsUmlnaHQo KSAtIGNvbnRlbnRMb2dpY2FsTGVmdCgpOwogfQogCi1pbmxpbmUgZmxvYXQgTGluZTo6bG9naWNh bEhlaWdodCgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIFdURjo6c3dpdGNoT24obV9wYXRoVmFyaWFu dCwgW10oY29uc3QgYXV0byYgcGF0aCkgewotICAgICAgICByZXR1cm4gcGF0aC5sb2dpY2FsSGVp Z2h0KCk7Ci0gICAgfSk7Ci19Ci0KIGlubGluZSBib29sIExpbmU6OmlzSG9yaXpvbnRhbCgpIGNv bnN0CiB7CiAgICAgcmV0dXJuIFdURjo6c3dpdGNoT24obV9wYXRoVmFyaWFudCwgW10oY29uc3Qg YXV0byYgcGF0aCkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0 aW9uL0lubGluZUl0ZXJhdG9yTGluZUxlZ2FjeVBhdGguaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbnRlZ3JhdGlvbi9JbmxpbmVJdGVyYXRvckxpbmVMZWdhY3lQYXRoLmgKaW5kZXggNzEzYTdh YjI0ZWEzYzc3ZmVjY2NjNzZhMTExNzkxNDg4MGNkNzAwZi4uMGUxNmFlM2ZlNGE0NWUwOGRlYWU3 MzFlOWM0OWE2N2Y4ZDE5YzZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu dGVncmF0aW9uL0lubGluZUl0ZXJhdG9yTGluZUxlZ2FjeVBhdGguaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW50ZWdyYXRpb24vSW5saW5lSXRlcmF0b3JMaW5lTGVnYWN5UGF0aC5oCkBA IC01Myw3ICs1Myw2IEBAIHB1YmxpYzoKIAogICAgIGZsb2F0IGNvbnRlbnRMb2dpY2FsTGVmdCgp IGNvbnN0IHsgcmV0dXJuIG1fcm9vdElubGluZUJveC0+bG9naWNhbExlZnQoKTsgfQogICAgIGZs b2F0IGNvbnRlbnRMb2dpY2FsUmlnaHQoKSBjb25zdCB7IHJldHVybiBtX3Jvb3RJbmxpbmVCb3gt PmxvZ2ljYWxSaWdodCgpOyB9Ci0gICAgZmxvYXQgbG9naWNhbEhlaWdodCgpIGNvbnN0IHsgcmV0 dXJuIG1fcm9vdElubGluZUJveC0+bG9naWNhbEhlaWdodCgpOyB9CiAgICAgYm9vbCBpc0hvcml6 b250YWwoKSBjb25zdCB7IHJldHVybiBtX3Jvb3RJbmxpbmVCb3gtPmlzSG9yaXpvbnRhbCgpOyB9 CiAgICAgRm9udEJhc2VsaW5lIGJhc2VsaW5lVHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fcm9vdElu bGluZUJveC0+YmFzZWxpbmVUeXBlKCk7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0ZXJhdG9yTGluZU1vZGVyblBhdGguaCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9JbmxpbmVJdGVyYXRvckxpbmVNb2Rlcm5QYXRo LmgKaW5kZXggYTVmMjY1N2U3ZjQ4NDE4ZDMwOGVjYjMyODM3MjBiYTEyOWY2NzFkZi4uMzQxODY5 NGM0NjkxOTI3N2VlNDIyYmI0NmZhMTgyNTQ5NzQyNjczNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0ZXJhdG9yTGluZU1vZGVyblBhdGguaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vSW5saW5lSXRlcmF0b3JMaW5l TW9kZXJuUGF0aC5oCkBAIC02NCw3ICs2NCw2IEBAIHB1YmxpYzoKIAogICAgIGZsb2F0IGNvbnRl bnRMb2dpY2FsTGVmdCgpIGNvbnN0IHsgcmV0dXJuIGxpbmUoKS5saW5lQm94TGVmdCgpICsgbGlu ZSgpLmNvbnRlbnRMb2dpY2FsT2Zmc2V0KCk7IH0KICAgICBmbG9hdCBjb250ZW50TG9naWNhbFJp Z2h0KCkgY29uc3QgeyByZXR1cm4gY29udGVudExvZ2ljYWxMZWZ0KCkgKyBsaW5lKCkuY29udGVu dExvZ2ljYWxXaWR0aCgpOyB9Ci0gICAgZmxvYXQgbG9naWNhbEhlaWdodCgpIGNvbnN0IHsgcmV0 dXJuIGxpbmVCb3hCb3R0b20oKSAtIGxpbmVCb3hUb3AoKTsgfQogICAgIGJvb2wgaXNIb3Jpem9u dGFsKCkgY29uc3QgeyByZXR1cm4gbGluZSgpLmlzSG9yaXpvbnRhbCgpOyB9CiAgICAgRm9udEJh c2VsaW5lIGJhc2VsaW5lVHlwZSgpIGNvbnN0IHsgcmV0dXJuIGxpbmUoKS5iYXNlbGluZVR5cGUo KTsgfQogCg==