237751 2022-03-10 18:14:19 -0800 Unreviewed, non-unified build fix after 248294@main 2022-03-10 19:24:15 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=237497 InRadar P2 Normal --- 1 lmoura lmoura webkit-bug-importer zalan oldest_to_newest 1850343 0 lmoura 2022-03-10 18:14:19 -0800 Unreviewed, non-unified build fix after 248294@main 1850344 1 454435 lmoura 2022-03-10 18:15:25 -0800 Created attachment 454435 [fast-cq] Patch 1850345 2 lmoura 2022-03-10 18:16:25 -0800 /app/webkit/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp: In member function ‘void WebCore::LayoutIntegration::LineLayout::updateListItemDimensions(const WebCore::RenderListItem&)’: /app/webkit/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:160:31: error: cannot convert ‘const WebCore::RenderListItem’ to ‘const WebCore::RenderBox&’ 160 | updateLayoutBoxDimensions(listItem); | ^~~~~~~~ | | | const WebCore::RenderListItem In file included from /app/webkit/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:27: /app/webkit/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.h:135:36: note: initializing argument 1 of ‘void WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions(const WebCore ::RenderBox&)’ 135 | void updateLayoutBoxDimensions(const RenderBox&); | ^~~~~~~~~~~~~~~~ 1850349 3 zalan 2022-03-10 18:50:37 -0800 Sorry about that (and thank you for fixing it). 1850351 4 ews-feeder 2022-03-10 19:23:14 -0800 Committed r291143 (248303@main): <https://commits.webkit.org/248303@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454435. 1850352 5 webkit-bug-importer 2022-03-10 19:24:15 -0800 <rdar://problem/90138290> 454435 2022-03-10 18:15:25 -0800 2022-03-10 19:23:15 -0800 [fast-cq] Patch bug-237751-20220311021524.patch text/plain 1257 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY5YjI0MWQyMTRiYzhk MmM1ZjNkZDZlZjFjMWZmN2FjN2Q4ZWY0MC4uNzliZDAyZDMwOWZmODNkZDQ1M2YxOGE2OWZhMDQ3 ZDAyNGE2YTllZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDIyLTAzLTEwICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIG5vbi11 bmlmaWVkIGJ1aWxkIGZpeCBhZnRlciAyNDgyOTRAbWFpbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3NzUxCisKKyAgICAgICAgKiBsYXlvdXQvaW50 ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcDogQWRkIG1pc3NpbmcKKyAg ICAgICAgaW5jbHVkZS4KKwogMjAyMi0wMy0xMCAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlh LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBub24tdW5pZmllZCBidWlsZCBmaXggYWZ0ZXIg MjQ4MjYwQG1haW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlv bi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKaW5kZXggYjUyM2Q4 YmM2Y2ZkNzRlYjRiNjUwOGVkNDA5NzI5ZDcwNzNlYmFmNS4uNWY2NjVhMzMxOWIzOWY4NzVlOWZi MjA4OGM3ODFlNDYyYzNjZTQ4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu dGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAK QEAgLTU0LDYgKzU0LDcgQEAKICNpbmNsdWRlICJSZW5kZXJJbmxpbmUuaCIKICNpbmNsdWRlICJS ZW5kZXJMaW5lQnJlYWsuaCIKICNpbmNsdWRlICJSZW5kZXJMaXN0Qm94LmgiCisjaW5jbHVkZSAi UmVuZGVyTGlzdEl0ZW0uaCIKICNpbmNsdWRlICJSZW5kZXJMaXN0TWFya2VyLmgiCiAjaW5jbHVk ZSAiUmVuZGVyU2xpZGVyLmgiCiAjaW5jbHVkZSAiUmVuZGVyVGV4dENvbnRyb2xNdWx0aUxpbmUu aCIK