237734 2022-03-10 14:45:05 -0800 Abandoned memory in NetworkStorageManager::m_temporaryBlobPathsByConnection 2022-03-10 21:42:16 -0800 1 1 1 Unclassified WebKit Website Storage WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu cdumez sihui_liu webkit-bug-importer oldest_to_newest 1850251 0 sihui_liu 2022-03-10 14:45:05 -0800 ... 1850253 1 454404 sihui_liu 2022-03-10 14:47:43 -0800 Created attachment 454404 Patch 1850254 2 454404 cdumez 2022-03-10 14:50:58 -0800 Comment on attachment 454404 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454404&action=review > Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:214 > + protectedThis->m_temporaryBlobPathsByConnection.remove(connection); Can't we do this before the work queue dispatch(), instead of re-dispatching to the main thread here? 1850257 3 sihui_liu 2022-03-10 14:53:50 -0800 (In reply to Chris Dumez from comment #2) > Comment on attachment 454404 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454404&action=review > > > Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:214 > > + protectedThis->m_temporaryBlobPathsByConnection.remove(connection); > > Can't we do this before the work queue dispatch(), instead of re-dispatching > to the main thread here? This technically should be removed after we notify storage thread; and we need to dispatch to the main thread to deter NetworkStorageManager anyways 1850367 4 ews-feeder 2022-03-10 21:41:00 -0800 Committed r291145 (248305@main): <https://commits.webkit.org/248305@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454404. 1850368 5 webkit-bug-importer 2022-03-10 21:42:16 -0800 <rdar://problem/90142912> 454404 2022-03-10 14:47:43 -0800 2022-03-10 21:41:02 -0800 Patch bug-237734-20220310144742.patch text/plain 1678 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxMTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGViZDA1MjE3OTRlM2QzOTlk YTljNWQ2OGYzODkyOGE1N2FmMTI2NzMuLmM5ZTE3YzdlZDQ5MzkwNmMzMjRiYTY2YTQ1ZjNhMjEz ZWY3YThjYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDMtMTAgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQWJhbmRvbmVkIG1lbW9yeSBpbiBO ZXR3b3JrU3RvcmFnZU1hbmFnZXI6Om1fdGVtcG9yYXJ5QmxvYlBhdGhzQnlDb25uZWN0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc3MzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgaXRl bXMgZnJvbSBtX3RlbXBvcmFyeUJsb2JQYXRoc0J5Q29ubmVjdGlvbiB3aGVuIGNvbm5lY3Rpb24g aXMgY2xvc2VkLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvc3RvcmFnZS9OZXR3b3JrU3Rv cmFnZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrU3RvcmFnZU1hbmFnZXI6 OnN0b3BSZWNlaXZpbmdNZXNzYWdlRnJvbUNvbm5lY3Rpb24pOgorCiAyMDIyLTAzLTEwICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWFTYW1wbGVDdXJz b3Igc2hvdWxkIGl0ZXJhdGUgb3ZlciB0aGUgc2FtcGxlcyBjb250YWluZWQgaW4gdGhlIE1lZGlh U2FtcGxlc0Jsb2NrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3N0 b3JhZ2UvTmV0d29ya1N0b3JhZ2VNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3Mvc3RvcmFnZS9OZXR3b3JrU3RvcmFnZU1hbmFnZXIuY3BwCmluZGV4IGRkODRlM2NkYjlm YTNiMDQyMzkzMTgwN2IxMTMwY2E3ZmFjZGM4NmMuLmZhMWUzOGIxMzhlNDg0MzAxY2Q2MzE2NDE3 OWNiNzQ4M2Y4ZDIxNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv c3RvcmFnZS9OZXR3b3JrU3RvcmFnZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3Mvc3RvcmFnZS9OZXR3b3JrU3RvcmFnZU1hbmFnZXIuY3BwCkBAIC0yMTAsNyAr MjEwLDkgQEAgdm9pZCBOZXR3b3JrU3RvcmFnZU1hbmFnZXI6OnN0b3BSZWNlaXZpbmdNZXNzYWdl RnJvbUNvbm5lY3Rpb24oSVBDOjpDb25uZWN0aW9uJgogICAgICAgICAgICAgcmV0dXJuICFtYW5h Z2VyLT5pc0FjdGl2ZSgpOwogICAgICAgICB9KTsKIAotICAgICAgICBSdW5Mb29wOjptYWluKCku ZGlzcGF0Y2goW3Byb3RlY3RlZFRoaXMgPSBXVEZNb3ZlKHByb3RlY3RlZFRoaXMpXSB7IH0pOwor ICAgICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3Byb3RlY3RlZFRoaXMgPSBXVEZNb3Zl KHByb3RlY3RlZFRoaXMpLCBjb25uZWN0aW9uXSB7CisgICAgICAgICAgICBwcm90ZWN0ZWRUaGlz LT5tX3RlbXBvcmFyeUJsb2JQYXRoc0J5Q29ubmVjdGlvbi5yZW1vdmUoY29ubmVjdGlvbik7Cisg ICAgICAgIH0pOwogICAgIH0pOwogfQogCg==