237698 2022-03-09 21:40:03 -0800 Fix WebContent jetsam that occurs when selecting text in a large e-mail 2022-03-11 09:40:56 -0800 1 1 1 Unclassified WebKit Scrolling WebKit Local Build iPhone / iPad iOS 15 RESOLVED FIXED InRadar P2 Normal --- 1 nham nham nham simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1849963 0 nham 2022-03-09 21:40:03 -0800 WebContent often jetsams when selecting text in a large e-mail in MobileMail. 1849964 1 nham 2022-03-09 21:40:31 -0800 rdar://88549631 1849965 2 454314 nham 2022-03-09 21:41:20 -0800 Created attachment 454314 Patch 1849966 3 454314 simon.fraser 2022-03-09 21:50:39 -0800 Comment on attachment 454314 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454314&action=review > Source/WebCore/page/FrameView.cpp:2735 > +#if PLATFORM(IOS_FAMILY) > + tiledBacking->prepopulateRect(FloatRect(position, exposedContentRect().size())); > +#else > + auto rect = FloatRect(position, visibleContentRect().size()); > + if (auto exposedRect = viewExposedRect()) { > + exposedRect->setLocation(position); > + rect.intersect(*exposedRect); > + } > + tiledBacking->prepopulateRect(rect); > +#endif I generally prefer the #ifdef to just surround the argument computation, so there's only one line that calls tiledBacking->prepopulateRect(). Are you sure you want to change the macOS behavior at this time? 1849967 4 nham 2022-03-09 21:54:45 -0800 It's probably better to leave the macOS path alone since content rects work differently on that platform and we don't have evidence of this bug on macOS. I'll submit a newer version of the patch. 1849968 5 454315 nham 2022-03-09 21:59:05 -0800 Created attachment 454315 Patch 1850542 6 ews-feeder 2022-03-11 09:40:53 -0800 Committed r291175 (248335@main): <https://commits.webkit.org/248335@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454315. 454314 2022-03-09 21:41:20 -0800 2022-03-09 22:01:02 -0800 Patch bug-237698-20220309214119.patch text/plain 3313 nham U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ViYjFiZTQ5OWFiNTI2 MDQ1M2Q5ZDkzODA1MWZjODhiMjA2ZDlmZi4uZjMyYTM5YWJmMDY3NTkzNjVlNzBkMWY1NGQ4ZWRj OGRmNWU2NDg5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDIyLTAzLTA5ICBCZW4g TmhhbSAgPG5oYW1AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBXZWJDb250ZW50IGpldHNhbSB0 aGF0IG9jY3VycyB3aGVuIHNlbGVjdGluZyB0ZXh0IGluIGEgbGFyZ2UgZS1tYWlsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc2OTgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHNlbGVjdGluZyB0 ZXh0IGluIGEgbGFyZ2UgZS1tYWlsIGluIE1vYmlsZU1haWwsIHdlIG9mdGVuIGpldHNhbS4gVGhp cyBpcyBkdWUgdG8gdGhpcworICAgICAgICBjaGFpbiBvZiBldmVudHM6CisKKyAgICAgICAgIDEu IElmIHRoZSBzZWxlY3Rpb24gZXh0ZW5kcyBlbm91Z2ggdG8gc3RhcnQgY2F1c2luZyB0aGUgY29u dGVudCB0byBwYW4gKHdoaWNoIGlzIGVhc3kKKyAgICAgICAgICAgIHRvIGRvIHdoZW4gem9vbWVk IGluIG9uIHRoZSBtYWlsIGNvbnRlbnQpLCB0aGVuIEF1dG9zY3JvbGxDb250cm9sbGVyIGVuZHMg dXAgY2hhbmdpbmcKKyAgICAgICAgICAgIHRoZSBzY3JvbGwgcG9zaXRpb24gb2YgdGhlIEZyYW1l VmlldyB0byBwZXJmb3JtIHRoZSBwYW4uCisgICAgICAgICAyLiBGcmFtZVZpZXc6OnJlcXVlc3RT Y3JvbGxQb3NpdGlvblVwZGF0ZSB0cmllcyB0byBwcmVwb3B1bGF0ZSB0aWxlcyBhcm91bmQgdGhl IGVuZHBvaW50CisgICAgICAgICAgICBvZiB0aGUgcGFuIGJ5IGNhbGxpbmcgVGlsZUNvbnRyb2xs ZXI6OnByZXBvcHVsYXRlUmVjdCB3aXRoIHZpc2libGVDb250ZW50UmVjdCdzIHNpemUuCisKKyAg ICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCBNb2JpbGVNYWlsIHJlc2l6ZXMgdGhlaXIgd2ViIHZp ZXcgKGFuZCB0aGVyZWZvcmUgRnJhbWVWaWV3KSB0byBtYXRjaAorICAgICAgICB0aGUgc2l6ZSBv ZiB0aGUgY29udGVudC4gVGhpcyBjYXVzZXMgRnJhbWVWaWV3J3MgdmlzaWJsZUNvbnRlbnRSZWN0 IHRvIGJlIHZlcnkgbGFyZ2UgKD4xMDBrCisgICAgICAgIHB0cyBoaWdoIGZvciBzb21lIGVtYWls cykuIEFzIGEgcmVzdWx0LCB3ZSBlbmQgdXAgcHJlcG9wdWxhdGluZyBldmVyeSBzaW5nbGUgdGls ZSBpbiB0aGUKKyAgICAgICAgZW1haWwsIGNhdXNpbmcgYSBodWdlIHNwaWtlIGluIElPU3VyZmFj ZSBtZW1vcnkgdXNhZ2UgdGhhdCBsZWFkcyB0byBhIGpldHNhbS4KKworICAgICAgICBUbyBmaXgg dGhpcywgd2UgbWFrZSBGcmFtZVZpZXc6OnJlcXVlc3RTY3JvbGxQb3NpdGlvblVwZGF0ZSBhY3Qg bW9yZSBsaWtlCisgICAgICAgIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dmlzaWJsZVJlY3RGb3JM YXllckZsdXNoaW5nLiBJbiBwYXJ0aWN1bGFyLCBvbiBpT1MsIHdlIG5vdyB1c2UKKyAgICAgICAg ZXhwb3NlZENvbnRlbnRSZWN0IGluc3RlYWQgb2YgdmlzaWJsZUNvbnRlbnRSZWN0LiBTaW5jZSBl eHBvc2VkQ29udGVudFJlY3QgaXMgZGVyaXZlZCBmcm9tCisgICAgICAgIGNvbnRlbnRPZmZzZXQv Y29udGVudFNpemUgb2YgdGhlIHNjcm9sbCB2aWV3IGluIHRoZSBVSVByb2Nlc3MsIGl0J3MgbW9y ZSBjb3JyZWN0IGFuZCBpcyBtdWNoCisgICAgICAgIHNtYWxsZXIgdGhhbiB2aXNpYmxlQ29udGVu dFJlY3QgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpyZXF1ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUpOgor CiAyMDIyLTAzLTA0ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAK ICAgICAgICAgW2lPU10gQm9va3MgQVNTRVJUcyB1cG9uIG9wZW5pbmcgYSBib29rIHdpdGggYSBk ZWJ1ZyBidWlsZCBvZiBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCAzYjk5 NTU4OWQxODU2ZjdjMzM3ZmEwMGQ0ZWRjNTJhYmJlOTM0MTE1Li5mMjU5Y2M3YzVkNTUzNTdiZDk5 MGMyYTU5NzdmYTdkMzNkNWU1ZjcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0y NzIyLDggKzI3MjIsMTggQEAgYm9vbCBGcmFtZVZpZXc6OnJlcXVlc3RTY3JvbGxQb3NpdGlvblVw ZGF0ZShjb25zdCBTY3JvbGxQb3NpdGlvbiYgcG9zaXRpb24sIFNjcm8KICAgICBMT0dfV0lUSF9T VFJFQU0oU2Nyb2xsaW5nLCBzdHJlYW0gPDwgIkZyYW1lVmlldzo6cmVxdWVzdFNjcm9sbFBvc2l0 aW9uVXBkYXRlICIgPDwgcG9zaXRpb24pOwogCiAjaWYgRU5BQkxFKEFTWU5DX1NDUk9MTElORykK LSAgICBpZiAoVGlsZWRCYWNraW5nKiB0aWxlZEJhY2tpbmcgPSB0aGlzLT50aWxlZEJhY2tpbmco KSkKLSAgICAgICAgdGlsZWRCYWNraW5nLT5wcmVwb3B1bGF0ZVJlY3QoRmxvYXRSZWN0KHBvc2l0 aW9uLCB2aXNpYmxlQ29udGVudFJlY3QoKS5zaXplKCkpKTsKKyAgICBpZiAoVGlsZWRCYWNraW5n KiB0aWxlZEJhY2tpbmcgPSB0aGlzLT50aWxlZEJhY2tpbmcoKSkgeworI2lmIFBMQVRGT1JNKElP U19GQU1JTFkpCisgICAgICAgIHRpbGVkQmFja2luZy0+cHJlcG9wdWxhdGVSZWN0KEZsb2F0UmVj dChwb3NpdGlvbiwgZXhwb3NlZENvbnRlbnRSZWN0KCkuc2l6ZSgpKSk7CisjZWxzZQorICAgICAg ICBhdXRvIHJlY3QgPSBGbG9hdFJlY3QocG9zaXRpb24sIHZpc2libGVDb250ZW50UmVjdCgpLnNp emUoKSk7CisgICAgICAgIGlmIChhdXRvIGV4cG9zZWRSZWN0ID0gdmlld0V4cG9zZWRSZWN0KCkp IHsKKyAgICAgICAgICAgIGV4cG9zZWRSZWN0LT5zZXRMb2NhdGlvbihwb3NpdGlvbik7CisgICAg ICAgICAgICByZWN0LmludGVyc2VjdCgqZXhwb3NlZFJlY3QpOworICAgICAgICB9CisgICAgICAg IHRpbGVkQmFja2luZy0+cHJlcG9wdWxhdGVSZWN0KHJlY3QpOworI2VuZGlmCisgICAgfQogI2Vu ZGlmCiAKICNpZiBFTkFCTEUoQVNZTkNfU0NST0xMSU5HKSB8fCBVU0UoQ09PUkRJTkFURURfR1JB UEhJQ1MpCg== 454315 2022-03-09 21:59:05 -0800 2022-03-11 09:40:55 -0800 Patch bug-237698-20220309215905.patch text/plain 3138 nham U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ViYjFiZTQ5OWFiNTI2 MDQ1M2Q5ZDkzODA1MWZjODhiMjA2ZDlmZi4uZjMyYTM5YWJmMDY3NTkzNjVlNzBkMWY1NGQ4ZWRj OGRmNWU2NDg5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDIyLTAzLTA5ICBCZW4g TmhhbSAgPG5oYW1AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBXZWJDb250ZW50IGpldHNhbSB0 aGF0IG9jY3VycyB3aGVuIHNlbGVjdGluZyB0ZXh0IGluIGEgbGFyZ2UgZS1tYWlsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzc2OTgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHNlbGVjdGluZyB0 ZXh0IGluIGEgbGFyZ2UgZS1tYWlsIGluIE1vYmlsZU1haWwsIHdlIG9mdGVuIGpldHNhbS4gVGhp cyBpcyBkdWUgdG8gdGhpcworICAgICAgICBjaGFpbiBvZiBldmVudHM6CisKKyAgICAgICAgIDEu IElmIHRoZSBzZWxlY3Rpb24gZXh0ZW5kcyBlbm91Z2ggdG8gc3RhcnQgY2F1c2luZyB0aGUgY29u dGVudCB0byBwYW4gKHdoaWNoIGlzIGVhc3kKKyAgICAgICAgICAgIHRvIGRvIHdoZW4gem9vbWVk IGluIG9uIHRoZSBtYWlsIGNvbnRlbnQpLCB0aGVuIEF1dG9zY3JvbGxDb250cm9sbGVyIGVuZHMg dXAgY2hhbmdpbmcKKyAgICAgICAgICAgIHRoZSBzY3JvbGwgcG9zaXRpb24gb2YgdGhlIEZyYW1l VmlldyB0byBwZXJmb3JtIHRoZSBwYW4uCisgICAgICAgICAyLiBGcmFtZVZpZXc6OnJlcXVlc3RT Y3JvbGxQb3NpdGlvblVwZGF0ZSB0cmllcyB0byBwcmVwb3B1bGF0ZSB0aWxlcyBhcm91bmQgdGhl IGVuZHBvaW50CisgICAgICAgICAgICBvZiB0aGUgcGFuIGJ5IGNhbGxpbmcgVGlsZUNvbnRyb2xs ZXI6OnByZXBvcHVsYXRlUmVjdCB3aXRoIHZpc2libGVDb250ZW50UmVjdCdzIHNpemUuCisKKyAg ICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCBNb2JpbGVNYWlsIHJlc2l6ZXMgdGhlaXIgd2ViIHZp ZXcgKGFuZCB0aGVyZWZvcmUgRnJhbWVWaWV3KSB0byBtYXRjaAorICAgICAgICB0aGUgc2l6ZSBv ZiB0aGUgY29udGVudC4gVGhpcyBjYXVzZXMgRnJhbWVWaWV3J3MgdmlzaWJsZUNvbnRlbnRSZWN0 IHRvIGJlIHZlcnkgbGFyZ2UgKD4xMDBrCisgICAgICAgIHB0cyBoaWdoIGZvciBzb21lIGVtYWls cykuIEFzIGEgcmVzdWx0LCB3ZSBlbmQgdXAgcHJlcG9wdWxhdGluZyBldmVyeSBzaW5nbGUgdGls ZSBpbiB0aGUKKyAgICAgICAgZW1haWwsIGNhdXNpbmcgYSBodWdlIHNwaWtlIGluIElPU3VyZmFj ZSBtZW1vcnkgdXNhZ2UgdGhhdCBsZWFkcyB0byBhIGpldHNhbS4KKworICAgICAgICBUbyBmaXgg dGhpcywgd2UgbWFrZSBGcmFtZVZpZXc6OnJlcXVlc3RTY3JvbGxQb3NpdGlvblVwZGF0ZSBhY3Qg bW9yZSBsaWtlCisgICAgICAgIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dmlzaWJsZVJlY3RGb3JM YXllckZsdXNoaW5nLiBJbiBwYXJ0aWN1bGFyLCBvbiBpT1MsIHdlIG5vdyB1c2UKKyAgICAgICAg ZXhwb3NlZENvbnRlbnRSZWN0IGluc3RlYWQgb2YgdmlzaWJsZUNvbnRlbnRSZWN0LiBTaW5jZSBl eHBvc2VkQ29udGVudFJlY3QgaXMgZGVyaXZlZCBmcm9tCisgICAgICAgIGNvbnRlbnRPZmZzZXQv Y29udGVudFNpemUgb2YgdGhlIHNjcm9sbCB2aWV3IGluIHRoZSBVSVByb2Nlc3MsIGl0J3MgbW9y ZSBjb3JyZWN0IGFuZCBpcyBtdWNoCisgICAgICAgIHNtYWxsZXIgdGhhbiB2aXNpYmxlQ29udGVu dFJlY3QgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpyZXF1ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUpOgor CiAyMDIyLTAzLTA0ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAK ICAgICAgICAgW2lPU10gQm9va3MgQVNTRVJUcyB1cG9uIG9wZW5pbmcgYSBib29rIHdpdGggYSBk ZWJ1ZyBidWlsZCBvZiBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCAzYjk5 NTU4OWQxODU2ZjdjMzM3ZmEwMGQ0ZWRjNTJhYmJlOTM0MTE1Li45ZmY5ZDJlMDQ0ZDAyYjkxYzMy MDdjODQzZWEyYTY3MjBlYzM0ZWE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0y NzIyLDggKzI3MjIsMTQgQEAgYm9vbCBGcmFtZVZpZXc6OnJlcXVlc3RTY3JvbGxQb3NpdGlvblVw ZGF0ZShjb25zdCBTY3JvbGxQb3NpdGlvbiYgcG9zaXRpb24sIFNjcm8KICAgICBMT0dfV0lUSF9T VFJFQU0oU2Nyb2xsaW5nLCBzdHJlYW0gPDwgIkZyYW1lVmlldzo6cmVxdWVzdFNjcm9sbFBvc2l0 aW9uVXBkYXRlICIgPDwgcG9zaXRpb24pOwogCiAjaWYgRU5BQkxFKEFTWU5DX1NDUk9MTElORykK LSAgICBpZiAoVGlsZWRCYWNraW5nKiB0aWxlZEJhY2tpbmcgPSB0aGlzLT50aWxlZEJhY2tpbmco KSkKLSAgICAgICAgdGlsZWRCYWNraW5nLT5wcmVwb3B1bGF0ZVJlY3QoRmxvYXRSZWN0KHBvc2l0 aW9uLCB2aXNpYmxlQ29udGVudFJlY3QoKS5zaXplKCkpKTsKKyAgICBpZiAoVGlsZWRCYWNraW5n KiB0aWxlZEJhY2tpbmcgPSB0aGlzLT50aWxlZEJhY2tpbmcoKSkgeworI2lmIFBMQVRGT1JNKElP U19GQU1JTFkpCisgICAgICAgIGF1dG8gY29udGVudFNpemUgPSBleHBvc2VkQ29udGVudFJlY3Qo KS5zaXplKCk7CisjZWxzZQorICAgICAgICBhdXRvIGNvbnRlbnRTaXplID0gdmlzaWJsZUNvbnRl bnRSZWN0KCkuc2l6ZSgpOworI2VuZGlmCisgICAgICAgIHRpbGVkQmFja2luZy0+cHJlcG9wdWxh dGVSZWN0KEZsb2F0UmVjdChwb3NpdGlvbiwgY29udGVudFNpemUpKTsKKyAgICB9CiAjZW5kaWYK IAogI2lmIEVOQUJMRShBU1lOQ19TQ1JPTExJTkcpIHx8IFVTRShDT09SRElOQVRFRF9HUkFQSElD UykK