237679 2022-03-09 15:03:20 -0800 Web Inspector: Styles Panel: CSS variable completions should be provided even without a query 2022-03-10 04:06:02 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 rcaliman rcaliman ews-watchlist hi inspector-bugzilla-changes pangle webkit-bug-importer oldest_to_newest 1849861 0 rcaliman 2022-03-09 15:03:20 -0800 # Steps to Reproduce: - Ensure "Use fuzzy matching for completion suggestions" is enabled in Settings > Experimental - Inspect https://webkit.org - In the Styles panel, add a new CSS declaration: `color: var(` (notice the missing value for a variable name) # Result No completion suggestions provided. # Expected results In the absence of a query string, a list of all applicable CSS variable names should be provided. This is the behavior for classic prefix autocompletion. It's a regression when using fuzzy matching. 1849863 1 webkit-bug-importer 2022-03-09 15:03:54 -0800 <rdar://problem/90059628> 1849869 2 454291 rcaliman 2022-03-09 15:10:53 -0800 Created attachment 454291 Patch 1.0 1849903 3 454291 pangle 2022-03-09 16:24:27 -0800 Comment on attachment 454291 Patch 1.0 r=me 1850021 4 ews-feeder 2022-03-10 04:05:59 -0800 Committed r291102 (248264@main): <https://commits.webkit.org/248264@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454291. 454291 2022-03-09 15:10:53 -0800 2022-03-10 04:06:01 -0800 Patch 1.0 bug-237679-20220310001052.patch text/plain 1738 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFkMTgzMDdmNzM4MTgzMDYxNmRlMDM4N2IzYjA3 NTU3ZDU4ZDdjZDcuLjMzZWIyNDU1MDk2MzI5M2JiMDUyMjQyMDYzZTQxZDdiYjI1NjU0MzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAzLTA5ICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBTdHlsZXMgUGFuZWw6IENTUyB2YXJpYWJsZSBjb21wbGV0aW9ucyBzaG91bGQgYmUgcHJvdmlk ZWQgZXZlbiB3aXRob3V0IGEgcXVlcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzNzY3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTAwNTk2Mjg+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJu IHRoZSBsaXN0IG9mIGFsbCBhdmFpbGFibGUgY29tcGxldGlvbiBzdWdnZXN0aW9ucyBpZiBgV0ku Q1NTQ29tcGxldGlvbnNgIGlzIGNvbmZpZ3VyZWQgdG8gYWxsb3cgZW1wdHkKKyAgICAgICAgcHJl Zml4IHNlYXJjaC4gVGhpcyB3YXMgYWxyZWFkeSB0aGUgY2FzZSBmb3IgY2xhc3NpYyBhdXRvY29t cGxldGlvbiB3aXRoIHByZWZpeCBtYXRjaGluZywgYnV0IHdhcyBtaXNzaW5nCisgICAgICAgIGZv ciBmdXp6eSBtYXRjaGluZy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0Nv bXBsZXRpb25zLmpzOgorICAgICAgICAoV0kuQ1NTQ29tcGxldGlvbnMucHJvdG90eXBlLmV4ZWN1 dGVRdWVyeSk6CisKIDIwMjItMDMtMDIgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CiAKICAgICAgICAgQ29weSBXZWJLaXQgZnJhbWV3b3JrcyBhbmQgWFBDIHByb2Nlc3NlcyB0 byBTZWNvbmRhcnkgUGF0aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL0NTU0NvbXBsZXRpb25zLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0NvbXBsZXRpb25zLmpzCmluZGV4IGZkMWNhZGQ2MzZk YjJhM2Q5NDg1MTg0NjBkMjUyZGQxMWYyNWRhY2YuLjgzMGM5OWFhYTRmNjZhMWY2NjI1MDQ5YzM3 ZTJjYzFmNzI1YzVhOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9DU1NDb21wbGV0aW9ucy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTQ29tcGxldGlvbnMuanMKQEAgLTE1Miw2ICsxNTIs OSBAQCBXSS5DU1NDb21wbGV0aW9ucyA9IGNsYXNzIENTU0NvbXBsZXRpb25zCiAKICAgICBleGVj dXRlUXVlcnkocXVlcnkpCiAgICAgeworICAgICAgICBpZiAoIXF1ZXJ5KQorICAgICAgICAgICAg cmV0dXJuIHRoaXMuX2FjY2VwdEVtcHR5UHJlZml4ID8gdGhpcy5fdmFsdWVzLnNsaWNlKCkgOiBb XTsKKwogICAgICAgICB0aGlzLl9xdWVyeUNvbnRyb2xsZXIgfHw9IG5ldyBXSS5DU1NRdWVyeUNv bnRyb2xsZXIodGhpcy5fdmFsdWVzKTsKIAogICAgICAgICByZXR1cm4gdGhpcy5fcXVlcnlDb250 cm9sbGVyLmV4ZWN1dGVRdWVyeShxdWVyeSk7Cg==