237668 2022-03-09 10:21:07 -0800 [CMake] Associate platform specific configuration with WinCairo 2022-03-09 12:45:55 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead annulen basuke ews-watchlist gyuyoung.kim ryuan.choi sergio oldest_to_newest 1849743 0 don.olmstead 2022-03-09 10:21:07 -0800 Some is in the root source listing some is under WinCairo check. Just make it all under WinCairo. 1849752 1 454266 don.olmstead 2022-03-09 10:33:12 -0800 Created attachment 454266 Patch 1849758 2 454266 basuke 2022-03-09 10:36:59 -0800 Comment on attachment 454266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review > Source/WebKit/PlatformWin.cmake:-170 > - Is it okay to remove these definitions? 1849761 3 454266 don.olmstead 2022-03-09 10:38:21 -0800 Comment on attachment 454266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review >> Source/WebKit/PlatformWin.cmake:-170 >> - > > Is it okay to remove these definitions? Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon for modern CMake code anyways. 1849762 4 454266 basuke 2022-03-09 10:39:14 -0800 Comment on attachment 454266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review >>> Source/WebKit/PlatformWin.cmake:-170 >>> - >> >> Is it okay to remove these definitions? > > Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon for modern CMake code anyways. Great. 1849806 5 ews-feeder 2022-03-09 12:45:50 -0800 Committed r291061 (248234@main): <https://commits.webkit.org/248234@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454266. 454266 2022-03-09 10:33:12 -0800 2022-03-09 12:45:53 -0800 Patch bug-237668.diff text/plain 3784 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNWUzMTU5NjlhYjYxLi5kOGQ4NGI4ZGM0ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjItMDMtMDkgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNv bT4KKworICAgICAgICBbQ01ha2VdIEFzc29jaWF0ZSBwbGF0Zm9ybSBzcGVjaWZpYyBjb25maWd1 cmF0aW9uIHdpdGggV2luQ2Fpcm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzNzY2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1vdmUgYWxsIGNhaXJvIGFuZCBjdXJsIHBsYXRmb3JtIGNvbmZpZ3VyYXRp b24gdW5kZXIgYSBjaGVjayBmb3IgV2luQ2Fpcm8uIFRoaXMgYXJyYW5nZXMKKyAgICAgICAgcGxh dGZvcm0gY29uZmlnIGluIGEgY29uc2lzdGVudCBtYW5uZXIuCisKKyAgICAgICAgKiBQbGF0Zm9y bVdpbi5jbWFrZToKKwogMjAyMi0wMy0wOSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWpp aUBzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dIEltcHJvdmUgV0NUaWxlZEJhY2tpbmcg YW5kIFRleHR1cmVNYXBwZXJTcGFyc2VCYWNraW5nU3RvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV2luLmNtYWtl CmluZGV4IDM1N2IyYThkNzYxNi4uNjU5MzQ1ZWRlYzEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtV2luLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21h a2UKQEAgLTI1LDggKzI1LDYgQEAgbGlzdChBUFBFTkQgV2ViS2l0X1NPVVJDRVMKIAogICAgIE5l dHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3BwCiAKLSAgICBOZXR3b3Jr UHJvY2Vzcy9jdXJsL05ldHdvcmtQcm9jZXNzTWFpbkN1cmwuY3BwCi0KICAgICBQbGF0Zm9ybS9J UEMvd2luL0F0dGFjaG1lbnRXaW4uY3BwCiAgICAgUGxhdGZvcm0vSVBDL3dpbi9Db25uZWN0aW9u V2luLmNwcAogICAgIFBsYXRmb3JtL0lQQy93aW4vSVBDU2VtYXBob3JlV2luLmNwcApAQCAtMzcs OCArMzUsNiBAQCBsaXN0KEFQUEVORCBXZWJLaXRfU09VUkNFUwogICAgIFBsYXRmb3JtL3dpbi9N b2R1bGVXaW4uY3BwCiAgICAgUGxhdGZvcm0vd2luL1NoYXJlZE1lbW9yeVdpbi5jcHAKIAotICAg IFNoYXJlZC9BUEkvYy9jdXJsL1dLQ2VydGlmaWNhdGVJbmZvQ3VybC5jcHAKLQogICAgIFNoYXJl ZC9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxlTm9uZS5jcHAKIAogICAgIFNo YXJlZC93aW4vQXV4aWxpYXJ5UHJvY2Vzc01haW5XaW4uY3BwCkBAIC01OCw5ICs1NCw2IEBAIGxp c3QoQVBQRU5EIFdlYktpdF9TT1VSQ0VTCiAKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tWaWV3cG9y dEF0dHJpYnV0ZXMuY3BwCiAKLSAgICBVSVByb2Nlc3MvQVBJL0MvY3VybC9XS1Byb3RlY3Rpb25T cGFjZUN1cmwuY3BwCi0gICAgVUlQcm9jZXNzL0FQSS9DL2N1cmwvV0tXZWJzaXRlRGF0YVN0b3Jl UmVmQ3VybC5jcHAKLQogICAgIFVJUHJvY2Vzcy9BUEkvQy93aW4vV0tWaWV3LmNwcAogCiAgICAg VUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvRHJhd2luZ0FyZWFQcm94eUNvb3JkaW5hdGVk R3JhcGhpY3MuY3BwCkBAIC03MCw4ICs2Myw2IEBAIGxpc3QoQVBQRU5EIFdlYktpdF9TT1VSQ0VT CiAKICAgICBVSVByb2Nlc3MvTGF1bmNoZXIvd2luL1Byb2Nlc3NMYXVuY2hlcldpbi5jcHAKIAot ICAgIFVJUHJvY2Vzcy9XZWJzaXRlRGF0YS9jdXJsL1dlYnNpdGVEYXRhU3RvcmVDdXJsLmNwcAot CiAgICAgVUlQcm9jZXNzL1dlYnNpdGVEYXRhL3dpbi9XZWJzaXRlRGF0YVN0b3JlV2luLmNwcAog CiAgICAgVUlQcm9jZXNzL3djL0RyYXdpbmdBcmVhUHJveHlXQy5jcHAKQEAgLTEyNCw4ICsxMTUs NiBAQCBsaXN0KEFQUEVORCBXZWJLaXRfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1dFQktJ VF9ESVJ9L1NoYXJlZC9QbHVnaW5zL3dpbiIKICAgICAiJHtXRUJLSVRfRElSfS9TaGFyZWQvd2Mi CiAgICAgIiR7V0VCS0lUX0RJUn0vU2hhcmVkL3dpbiIKLSAgICAiJHtXRUJLSVRfRElSfS9VSVBy b2Nlc3MvQVBJL0MvY2Fpcm8iCi0gICAgIiR7V0VCS0lUX0RJUn0vVUlQcm9jZXNzL0FQSS9DL2N1 cmwiCiAgICAgIiR7V0VCS0lUX0RJUn0vVUlQcm9jZXNzL0FQSS9DL3dpbiIKICAgICAiJHtXRUJL SVRfRElSfS9VSVByb2Nlc3MvQVBJL2NwcC93aW4iCiAgICAgIiR7V0VCS0lUX0RJUn0vVUlQcm9j ZXNzL0FQSS93aW4iCkBAIC0xNjYsOCArMTU1LDYgQEAgbGlzdChBUFBFTkQgR1BVUHJvY2Vzc19T T1VSQ0VTCiApCiAKIGlmICgke1dURl9QTEFURk9STV9XSU5fQ0FJUk99KQotICAgIGFkZF9kZWZp bml0aW9ucygtRFVTRV9DQUlSTz0xIC1EVVNFX0NVUkw9MSkKLQogICAgIGxpc3QoQVBQRU5EIFdl YktpdF9TT1VSQ0VTCiAgICAgICAgIE5ldHdvcmtQcm9jZXNzL0Nvb2tpZXMvY3VybC9XZWJDb29r aWVNYW5hZ2VyQ3VybC5jcHAKIApAQCAtMTc2LDE2ICsxNjMsMjQgQEAgaWYgKCR7V1RGX1BMQVRG T1JNX1dJTl9DQUlST30pCiAKICAgICAgICAgTmV0d29ya1Byb2Nlc3MvY3VybC9OZXR3b3JrRGF0 YVRhc2tDdXJsLmNwcAogICAgICAgICBOZXR3b3JrUHJvY2Vzcy9jdXJsL05ldHdvcmtQcm9jZXNz Q3VybC5jcHAKKyAgICAgICAgTmV0d29ya1Byb2Nlc3MvY3VybC9OZXR3b3JrUHJvY2Vzc01haW5D dXJsLmNwcAogICAgICAgICBOZXR3b3JrUHJvY2Vzcy9jdXJsL05ldHdvcmtTZXNzaW9uQ3VybC5j cHAKIAogICAgICAgICBTaGFyZWQvQVBJL2MvY2Fpcm8vV0tJbWFnZUNhaXJvLmNwcAogCisgICAg ICAgIFNoYXJlZC9BUEkvYy9jdXJsL1dLQ2VydGlmaWNhdGVJbmZvQ3VybC5jcHAKKwogICAgICAg ICBTaGFyZWQvY2Fpcm8vU2hhcmVhYmxlQml0bWFwQ2Fpcm8uY3BwCiAKICAgICAgICAgU2hhcmVk L2N1cmwvV2ViQ29yZUFyZ3VtZW50Q29kZXJzQ3VybC5jcHAKIAorICAgICAgICBVSVByb2Nlc3Mv QVBJL0MvY3VybC9XS1Byb3RlY3Rpb25TcGFjZUN1cmwuY3BwCisgICAgICAgIFVJUHJvY2Vzcy9B UEkvQy9jdXJsL1dLV2Vic2l0ZURhdGFTdG9yZVJlZkN1cmwuY3BwCisKICAgICAgICAgVUlQcm9j ZXNzL0F1dG9tYXRpb24vY2Fpcm8vV2ViQXV0b21hdGlvblNlc3Npb25DYWlyby5jcHAKIAorICAg ICAgICBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvY3VybC9XZWJzaXRlRGF0YVN0b3JlQ3VybC5jcHAK KwogICAgICAgICBVSVByb2Nlc3MvY2Fpcm8vQmFja2luZ1N0b3JlQ2Fpcm8uY3BwCiAKICAgICAg ICAgV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9jdXJsL1dlYkZyYW1lTmV0d29ya2luZ0NvbnRl eHQuY3BwCkBAIC0xOTMsNiArMTg4LDggQEAgaWYgKCR7V1RGX1BMQVRGT1JNX1dJTl9DQUlST30p CiAKICAgICBsaXN0KEFQUEVORCBXZWJLaXRfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICAgICAi JHtXRUJLSVRfRElSfS9OZXR3b3JrUHJvY2Vzcy9jdXJsIgorICAgICAgICAiJHtXRUJLSVRfRElS fS9VSVByb2Nlc3MvQVBJL0MvY2Fpcm8iCisgICAgICAgICIke1dFQktJVF9ESVJ9L1VJUHJvY2Vz cy9BUEkvQy9jdXJsIgogICAgICAgICAiJHtXRUJLSVRfRElSfS9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L2N1cmwiCiAgICAgKQogCg==